Skip to contentSkip to conversation

dt-bindings: PCI: intel,lgm-pcie: Fix matching on all snps,dw-pcie instances

PATCH In review Rob Herring 2 participants 2 messages Aug 19, 2020 – Aug 20, 2020

Subsystems (4)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: PCI: intel,lgm-pcie: Fix matching on all snps,dw-pcie instances

The intel,lgm-pcie binding is matching on all snps,dw-pcie instances which is wrong. Add a custom 'select' entry to fix this.

Fixes e54ea45a4955 ("dt-bindings: PCI: intel: Add YAML schemas for the PCIe RC controller")
Cc Bjorn Helgaas <[email protected]>
Cc Dilip Kota <[email protected]>

---
I'll take this via the DT tree.

Rob

 Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)
Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml +8 -0
index 64b2c64ca806..a1e2be737eec 100644
@@ -9,6 +9,14 @@ title: PCIe RC controller on Intel Gateway SoCs
 maintainers:
   - Dilip Kota <[email protected]>
 
+select:
+  properties:
+    compatible:
+      contains:
+        const: intel,lgm-pcie
+  required:
+    - compatible
+
 properties:
   compatible:
     items:
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 25 lines · Rob Herring

The intel,lgm-pcie binding is matching on all snps,dw-pcie instances which is wrong. Add a custom 'select' entry to fix this.

Fixes e54ea45a4955 ("dt-bindings: PCI: intel: Add YAML schemas for the PCIe RC controller")
Cc Bjorn Helgaas <[email protected]>
Cc Dilip Kota <[email protected]>

---
I'll take this via the DT tree.

Rob

  Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml | 8 ++++++++
  1 file changed, 8 insertions(+)
Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml +1 -0
index 64b2c64ca806..a1e2be737eec 100644
@@ -9,6 +9,14 @@ title: PCIe RC controller on Intel Gateway SoCs
  maintainers:
    - Dilip Kota <[email protected]>
 
+select:

Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml title: PCIe RC controller on Intel Gateway SoCs · line 22

Quoted 10 lines
Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml +7 -0
+  properties:
+    compatible:
+      contains:
+        const: intel,lgm-pcie
+  required:
+    - compatible
+
  properties:
    compatible:
      items:

Regards,
Dilip