Skip to contentSkip to conversation

Add binding updates and DT files for SC7280 SoC

PATCH Superseded Rajendra Nayak 7 participants 39 messages Feb 12, 2021 – Mar 11, 2021

Subsystems (8)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover Add binding updates and DT files for SC7280 SoC

This series includes a few minor binding updates and base device tree files (to boot to shell) for SC7280 SoC and the IDP board using this SoC.

The series is dependent on a few driver patches to merge first, for gcc, rpmhcc and pinctrl
https://lore.kernel.org/patchwork/project/lkml/list/?series=484517
https://lore.kernel.org/patchwork/project/lkml/list/?series=484489
https://lore.kernel.org/patchwork/patch/1379831/

Maulik Shah (3):
arm64: dts: qcom: sc7280: Add RSC and PDC devices
arm64: dts: qcom: Add reserved memory for fw
arm64: dts: qcom: sc7280: Add cpuidle states

Rajendra Nayak (5):
dt-bindings: arm: qcom: Document SC7280 SoC and board
dt-bindings: firmware: scm: Add SC7280 support
arm64: dts: sc7280: Add basic dts/dtsi files for SC7280 soc
dt-bindings: qcom,pdc: Add compatible for sc7280
arm64: dts: qcom: SC7280: Add rpmhcc clock controller node

Sai Prakash Ranjan (4):
dt-bindings: arm-smmu: Add compatible for SC7280 SoC
arm64: dts: qcom: sc7280: Add device node for APPS SMMU
dt-bindings: watchdog: Add compatible for SC7280 SoC
arm64: dts: qcom: sc7280: Add APSS watchdog node

satya priya (1):
arm64: dts: qcom: sc7280: Add SPMI PMIC arbiter device for SC7280

 Documentation/devicetree/bindings/arm/qcom.yaml    |   6 +
 .../devicetree/bindings/firmware/qcom,scm.txt      |   1 +
 .../bindings/interrupt-controller/qcom,pdc.txt     |   1 +
 .../devicetree/bindings/iommu/arm,smmu.yaml        |   1 +
 .../devicetree/bindings/watchdog/qcom-wdt.yaml     |   1 +
 arch/arm64/boot/dts/qcom/Makefile                  |   1 +
 arch/arm64/boot/dts/qcom/sc7280-idp.dts            |  47 ++
 arch/arm64/boot/dts/qcom/sc7280.dtsi               | 596 +++++++++++++++++++++
 8 files changed, 654 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sc7280-idp.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sc7280.dtsi
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#1 lore raw

PATCH 1/13 dt-bindings: arm: qcom: Document SC7280 SoC and board

Document the SC7280 SoC and the IDP board bindings

---
 Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/qcom.yaml +6 -0
index c97d4a5..f730843 100644
@@ -37,6 +37,7 @@ description: |
         msm8994
         msm8996
         sc7180
+        sc7280
         sdm630
         sdm660
         sdm845
@@ -164,6 +165,11 @@ properties:
 
       - items:
           - enum:
+              - qcom,sc7280-idp
+          - const: qcom,sc7280
+
+      - items:
+          - enum:
               - xiaomi,lavender
           - const: qcom,sdm660
 
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#4 lore raw

PATCH 2/13 dt-bindings: firmware: scm: Add SC7280 support

In reply to Rajendra Nayak

Add compatible for SC7280 SoC

---
 Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/firmware/qcom,scm.txt +1 -0
index 7845643..4871fc5 100644
@@ -20,6 +20,7 @@ Required properties:
  * "qcom,scm-msm8996"
  * "qcom,scm-msm8998"
  * "qcom,scm-sc7180"
+ * "qcom,scm-sc7280"
  * "qcom,scm-sdm845"
  * "qcom,scm-sm8150"
  and:
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#7 lore raw

PATCH 3/13 arm64: dts: sc7280: Add basic dts/dtsi files for SC7280 soc

In reply to Rajendra Nayak

Add initial device tree support for the SC7280 SoC and the IDP boards based on this SoC

---
 arch/arm64/boot/dts/qcom/Makefile       |   1 +
 arch/arm64/boot/dts/qcom/sc7280-idp.dts |  47 +++++
 arch/arm64/boot/dts/qcom/sc7280.dtsi    | 294 ++++++++++++++++++++++++++++++++
 3 files changed, 342 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sc7280-idp.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sc7280.dtsi
arch/arm64/boot/dts/qcom/Makefile +1 -0
index 5113fac..6f16ff6 100644
@@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sc7180-trogdor-lazor-r3-kb.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sc7180-trogdor-lazor-r3-lte.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sc7180-trogdor-r1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sc7180-trogdor-r1-lte.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= sc7280-idp.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sdm630-sony-xperia-ganges-kirin.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sdm630-sony-xperia-nile-discovery.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sdm630-sony-xperia-nile-pioneer.dtb
arch/arm64/boot/dts/qcom/sc7280-idp.dts new file +47 -0

47 lines not on this page · raw message

arch/arm64/boot/dts/qcom/sc7280.dtsi new file +294 -0

294 lines not on this page · raw message

Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#8 lore raw

Re: [PATCH 03/13] arm64: dts: sc7280: Add basic dts/dtsi files for SC7280 soc

I love your patch! Yet something to improve:

Hi Rajendra,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on tip/irq/core iommu/next v5.11-rc7 next-20210211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Rajendra-Nayak/Add-binding-updates-and-DT-files-for-SC7280-SoC/20210212-154029
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/add6aba241bd502fd7c4b201016bd0b7a0d6d314
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Rajendra-Nayak/Add-binding-updates-and-DT-files-for-SC7280-SoC/20210212-154029 git checkout add6aba241bd502fd7c4b201016bd0b7a0d6d314
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

In file included from arch/arm64/boot/dts/qcom/sc7280-idp.dts:10:

>> arch/arm64/boot/dts/qcom/sc7280.dtsi:8:10: fatal error: dt-bindings/clock/qcom,gcc-sc7280.h: No such file or directory
    #include <dt-bindings/clock/qcom,gcc-sc7280.h>
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

compilation terminated.

vim +8 arch/arm64/boot/dts/qcom/sc7280.dtsi

   > 8	#include <dt-bindings/clock/qcom,gcc-sc7280.h>

9 #include <dt-bindings/interrupt-controller/arm-gic.h>
10

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

Reviewed-by on v1 3/13
#9 lore raw

Re: [PATCH 03/13] arm64: dts: sc7280: Add basic dts/dtsi files for SC7280 soc

In reply to Rajendra Nayak

Quoting Rajendra Nayak (2021-02-11 23:28:40)

Quoted 5 lines

Add initial device tree support for the SC7280 SoC and the IDP boards based on this SoC

---

arch/arm64/boot/dts/qcom/sc7280-idp.dts line 3

Quoted 9 lines
arch/arm64/boot/dts/qcom/sc7280-idp.dts new file +3 -0
new file mode 100644
index 0000000..428f863
@@ -0,0 +1,47 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * sc7280 IDP board device tree source

Is it capitalized or not capitalized for SC?

arch/arm64/boot/dts/qcom/sc7280-idp.dts line 13

Quoted 10 lines
arch/arm64/boot/dts/qcom/sc7280-idp.dts new file +10 -0
+ *
+ * Copyright (c) 2021, The Linux Foundation. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "sc7280.dtsi"
+
+/ {
+       model = "Qualcomm Technologies, Inc. SC7280 IDP platform";

Because it is capitalized here.

#10 lore raw

Re: [PATCH 03/13] arm64: dts: sc7280: Add basic dts/dtsi files for SC7280 soc

Quoted 9 lines · Stephen Boyd

Quoting Rajendra Nayak (2021-02-11 23:28:40)

Quoted 5 lines

Add initial device tree support for the SC7280 SoC and the IDP boards based on this SoC

---

Quoted 11 lines

arch/arm64/boot/dts/qcom/sc7280-idp.dts line 3

Quoted 9 lines
arch/arm64/boot/dts/qcom/sc7280-idp.dts new file +3 -0
new file mode 100644
index 0000000..428f863
@@ -0,0 +1,47 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * sc7280 IDP board device tree source

Is it capitalized or not capitalized for SC?

:) I'll be consistent and make it not capitalized everywhere.

Quoted 14 lines

arch/arm64/boot/dts/qcom/sc7280-idp.dts line 13

Quoted 11 lines
arch/arm64/boot/dts/qcom/sc7280-idp.dts new file +10 -0
+ *
+ * Copyright (c) 2021, The Linux Foundation. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "sc7280.dtsi"
+
+/ {
+       model = "Qualcomm Technologies, Inc. SC7280 IDP platform";

Because it is capitalized here.

Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#11 lore raw

PATCH 4/13 dt-bindings: qcom,pdc: Add compatible for sc7280

In reply to Rajendra Nayak

Add the compatible string for sc7180 SoC from Qualcomm

---
 Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt +1 -0
index 1df2939..9345c2e 100644
@@ -19,6 +19,7 @@ Properties:
 	Value type: <string>
 	Definition: Should contain "qcom,<soc>-pdc" and "qcom,pdc"
 		    - "qcom,sc7180-pdc": For SC7180
+		    - "qcom,sc7280-pdc": For SC7280
 		    - "qcom,sdm845-pdc": For SDM845
 
 - reg:
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#13 lore raw

Re: [PATCH 04/13] dt-bindings: qcom,pdc: Add compatible for sc7280

In reply to Rajendra Nayak

Quoting Rajendra Nayak (2021-02-11 23:28:41)

Quoted 5 lines

Add the compatible string for sc7180 SoC from Qualcomm

---
 Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt | 1 +

Is this being YAML-ified at some point?

#14 lore raw

Re: [PATCH 04/13] dt-bindings: qcom,pdc: Add compatible for sc7280

Quoted 8 lines · Stephen Boyd

Quoting Rajendra Nayak (2021-02-11 23:28:41)

Quoted 5 lines

Add the compatible string for sc7180 SoC from Qualcomm

---
  Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt | 1 +

Is this being YAML-ified at some point?

forgot to mention, Maulik already has a patch for it which he plans to post soon.

Quoted 1 line
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#15 lore raw

PATCH 5/13 arm64: dts: qcom: sc7280: Add RSC and PDC devices

In reply to Rajendra Nayak

From: Maulik Shah <[email protected]>

Add PDC interrupt controller along with apps RSC device. Also add reserved memory for command_db.

---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 44 ++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)
arch/arm64/boot/dts/qcom/sc7280.dtsi +44 -0
index 1fe2eba..7848e88 100644
@@ -7,6 +7,7 @@
 
 #include <dt-bindings/clock/qcom,gcc-sc7280.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/soc/qcom,rpmh-rsc.h>
 
 / {
 	interrupt-parent = <&intc>;
@@ -30,6 +31,18 @@
 		};
 	};
 
+	reserved_memory: reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		aop_cmd_db_mem: memory@80860000 {
+			reg = <0x0 0x80860000 0x0 0x20000>;
+			compatible = "qcom,cmd-db";
+			no-map;
+		};
+	};
+
 	cpus {
 		#address-cells = <2>;
 		#size-cells = <0>;
@@ -189,6 +202,19 @@
 			};
 		};
 
+		pdc: interrupt-controller@b220000 {
+			compatible = "qcom,sc7280-pdc", "qcom,pdc";
+			reg = <0 0xb220000 0 0x30000>;
+			qcom,pdc-ranges = <0 480 40>, <40 140 14>, <54 263 1>,
+					  <55 306 4>, <59 312 3>, <62 374 2>,
+					  <64 434 2>, <66 438 3>, <69 86 1>,
+					  <70 520 54>, <124 609 31>, <155 63 1>,
+					  <156 716 12>;
+			#interrupt-cells = <2>;
+			interrupt-parent = <&intc>;
+			interrupt-controller;
+		};
+
 		tlmm: pinctrl@f100000 {
 			compatible = "qcom,sc7280-pinctrl";
 			reg = <0 0xf100000 0 0x1000000>;
@@ -198,6 +224,7 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 			gpio-ranges = <&tlmm 0 0 175>;
+			wakeup-parent = <&pdc>;
 
 			qup_uart5_default: qup-uart5-default {
 				pins = "gpio46", "gpio47";
@@ -282,6 +309,23 @@
 				status = "disabled";
 			};
 		};
+
+		apps_rsc: rsc@18200000 {
+			compatible = "qcom,rpmh-rsc";
+			reg = <0 0x18200000 0 0x10000>,
+			      <0 0x18210000 0 0x10000>,
+			      <0 0x18220000 0 0x10000>;
+			reg-names = "drv-0", "drv-1", "drv-2";
+			interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
+			qcom,tcs-offset = <0xd00>;
+			qcom,drv-id = <2>;
+			qcom,tcs-config = <ACTIVE_TCS  2>,
+					  <SLEEP_TCS   3>,
+					  <WAKE_TCS    3>,
+					  <CONTROL_TCS 1>;
+		};
 	};
 
 	timer {
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#16 lore raw

Re: [PATCH 05/13] arm64: dts: qcom: sc7280: Add RSC and PDC devices

Quoting Rajendra Nayak (2021-02-11 23:28:42)

Quoted 32 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +13 -0
index 1fe2eba..7848e88 100644
@@ -7,6 +7,7 @@
 
 #include <dt-bindings/clock/qcom,gcc-sc7280.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/soc/qcom,rpmh-rsc.h>
 
 / {
        interrupt-parent = <&intc>;
@@ -30,6 +31,18 @@
                };
        };
 
+       reserved_memory: reserved-memory {
+               #address-cells = <2>;
+               #size-cells = <2>;
+               ranges;
+
+               aop_cmd_db_mem: memory@80860000 {
+                       reg = <0x0 0x80860000 0x0 0x20000>;
+                       compatible = "qcom,cmd-db";
+                       no-map;
+               };
+       };
+
        cpus {
                #address-cells = <2>;
                #size-cells = <0>;

arch/arm64/boot/dts/qcom/sc7280.dtsi line 207

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +3 -0
@@ -189,6 +202,19 @@
                        };
                };
 
+               pdc: interrupt-controller@b220000 {
+                       compatible = "qcom,sc7280-pdc", "qcom,pdc";
+                       reg = <0 0xb220000 0 0x30000>;

Can you pad out reg to 8 digits? 0x0b220000

arch/arm64/boot/dts/qcom/sc7280.dtsi line 220

Quoted 13 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +10 -0
+                       qcom,pdc-ranges = <0 480 40>, <40 140 14>, <54 263 1>,
+                                         <55 306 4>, <59 312 3>, <62 374 2>,
+                                         <64 434 2>, <66 438 3>, <69 86 1>,
+                                         <70 520 54>, <124 609 31>, <155 63 1>,
+                                         <156 716 12>;
+                       #interrupt-cells = <2>;
+                       interrupt-parent = <&intc>;
+                       interrupt-controller;
+               };
+
                tlmm: pinctrl@f100000 {
                        compatible = "qcom,sc7280-pinctrl";
                        reg = <0 0xf100000 0 0x1000000>;

The same applies to the previous patch. Sorry for missing that.

Quoted 30 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +18 -0
@@ -198,6 +224,7 @@
                        interrupt-controller;
                        #interrupt-cells = <2>;
                        gpio-ranges = <&tlmm 0 0 175>;
+                       wakeup-parent = <&pdc>;
 
                        qup_uart5_default: qup-uart5-default {
                                pins = "gpio46", "gpio47";
@@ -282,6 +309,23 @@
                                status = "disabled";
                        };
                };
+
+               apps_rsc: rsc@18200000 {
+                       compatible = "qcom,rpmh-rsc";
+                       reg = <0 0x18200000 0 0x10000>,
+                             <0 0x18210000 0 0x10000>,
+                             <0 0x18220000 0 0x10000>;
+                       reg-names = "drv-0", "drv-1", "drv-2";
+                       interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>,
+                                    <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>,
+                                    <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
+                       qcom,tcs-offset = <0xd00>;
+                       qcom,drv-id = <2>;
+                       qcom,tcs-config = <ACTIVE_TCS  2>,
+                                         <SLEEP_TCS   3>,
+                                         <WAKE_TCS    3>,
+                                         <CONTROL_TCS 1>;
+               };
        };
#17 lore raw

PATCH 6/13 arm64: dts: qcom: SC7280: Add rpmhcc clock controller node

In reply to Rajendra Nayak

Add rpmhcc clock controller node for SC7280. Also add the 'fixed clock' nodes which can now be referenced in gcc.

---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 55 ++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)
arch/arm64/boot/dts/qcom/sc7280.dtsi +55 -0
index 7848e88..10851e7 100644
@@ -6,6 +6,7 @@
  */
 
 #include <dt-bindings/clock/qcom,gcc-sc7280.h>
+#include <dt-bindings/clock/qcom,rpmh.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/soc/qcom,rpmh-rsc.h>
 
@@ -29,6 +30,42 @@
 			clock-frequency = <32000>;
 			#clock-cells = <0>;
 		};
+
+		pcie_0_pipe_clk: pcie-0-pipe-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <1000>;
+			#clock-cells = <0>;
+		};
+
+		pcie_1_pipe_clk: pcie-1-pipe-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <1000>;
+			#clock-cells = <0>;
+		};
+
+		ufs_phy_rx_symbol_0_clk: ufs-phy-rx-symbol-0-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <1000>;
+			#clock-cells = <0>;
+		};
+
+		ufs_phy_rx_symbol_1_clk: ufs-phy-rx-symbol-1-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <1000>;
+			#clock-cells = <0>;
+		};
+
+		ufs_phy_tx_symbol_0_clk: ufs-phy-tx-symbol-0-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <1000>;
+			#clock-cells = <0>;
+		};
+
+		usb3_phy_wrapper_gcc_usb30_pipe_clk: usb3-phy-wrapper-gcc-usb30-pipe-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <1000>;
+			#clock-cells = <0>;
+		};
 	};
 
 	reserved_memory: reserved-memory {
@@ -174,6 +211,17 @@
 		gcc: clock-controller@100000 {
 			compatible = "qcom,gcc-sc7280";
 			reg = <0 0x00100000 0 0x1f0000>;
+			clocks = <&rpmhcc RPMH_CXO_CLK>,
+				 <&rpmhcc RPMH_CXO_CLK_A>, <&sleep_clk>,
+				 <&pcie_0_pipe_clk>, <&pcie_1_pipe_clk>,
+				 <&ufs_phy_rx_symbol_0_clk>, <&ufs_phy_rx_symbol_1_clk>,
+				 <&ufs_phy_tx_symbol_0_clk>,
+				 <&usb3_phy_wrapper_gcc_usb30_pipe_clk>;
+			clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk",
+				      "pcie_0_pipe_clk", "pcie_1_pipe-clk",
+				      "ufs_phy_rx_symbol_0_clk", "ufs_phy_rx_symbol_1_clk",
+				      "ufs_phy_tx_symbol_0_clk",
+				      "usb3_phy_wrapper_gcc_usb30_pipe_clk";
 			#clock-cells = <1>;
 			#reset-cells = <1>;
 			#power-domain-cells = <1>;
@@ -325,6 +373,13 @@
 					  <SLEEP_TCS   3>,
 					  <WAKE_TCS    3>,
 					  <CONTROL_TCS 1>;
+
+			rpmhcc: qcom,rpmhcc {
+				compatible = "qcom,sc7280-rpmh-clk";
+				clocks = <&xo_board>;
+				clock-names = "xo";
+				#clock-cells = <1>;
+			};
 		};
 	};
 
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#18 lore raw

Re: [PATCH 06/13] arm64: dts: qcom: SC7280: Add rpmhcc clock controller node

Quoting Rajendra Nayak (2021-02-11 23:28:43)

Quoted 42 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +27 -0
index 7848e88..10851e7 100644
@@ -6,6 +6,7 @@
  */
 
 #include <dt-bindings/clock/qcom,gcc-sc7280.h>
+#include <dt-bindings/clock/qcom,rpmh.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/soc/qcom,rpmh-rsc.h>
 
@@ -29,6 +30,42 @@
                        clock-frequency = <32000>;
                        #clock-cells = <0>;
                };
+
+               pcie_0_pipe_clk: pcie-0-pipe-clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <1000>;
+                       #clock-cells = <0>;
+               };
+
+               pcie_1_pipe_clk: pcie-1-pipe-clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <1000>;
+                       #clock-cells = <0>;
+               };
+
+               ufs_phy_rx_symbol_0_clk: ufs-phy-rx-symbol-0-clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <1000>;
+                       #clock-cells = <0>;
+               };
+
+               ufs_phy_rx_symbol_1_clk: ufs-phy-rx-symbol-1-clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <1000>;
+                       #clock-cells = <0>;
+               };
+
+               ufs_phy_tx_symbol_0_clk: ufs-phy-tx-symbol-0-clk {

arch/arm64/boot/dts/qcom/sc7280.dtsi line 68

Quoted 10 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +10 -0
+                       compatible = "fixed-clock";
+                       clock-frequency = <1000>;
+                       #clock-cells = <0>;
+               };
+
+               usb3_phy_wrapper_gcc_usb30_pipe_clk: usb3-phy-wrapper-gcc-usb30-pipe-clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <1000>;
+                       #clock-cells = <0>;
+               };

Shouldn't these come from the phys? Why are they being added here?

arch/arm64/boot/dts/qcom/sc7280.dtsi line 219

Quoted 13 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +6 -0
        };
 
        reserved_memory: reserved-memory {
@@ -174,6 +211,17 @@
                gcc: clock-controller@100000 {
                        compatible = "qcom,gcc-sc7280";
                        reg = <0 0x00100000 0 0x1f0000>;
+                       clocks = <&rpmhcc RPMH_CXO_CLK>,
+                                <&rpmhcc RPMH_CXO_CLK_A>, <&sleep_clk>,
+                                <&pcie_0_pipe_clk>, <&pcie_1_pipe_clk>,
+                                <&ufs_phy_rx_symbol_0_clk>, <&ufs_phy_rx_symbol_1_clk>,
+                                <&ufs_phy_tx_symbol_0_clk>,
+                                <&usb3_phy_wrapper_gcc_usb30_pipe_clk>;

If the phys aren't ready then <0> should work. Unless something goes wrong?

Quoted 9 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +5 -0
+                       clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk",
+                                     "pcie_0_pipe_clk", "pcie_1_pipe-clk",
+                                     "ufs_phy_rx_symbol_0_clk", "ufs_phy_rx_symbol_1_clk",
+                                     "ufs_phy_tx_symbol_0_clk",
+                                     "usb3_phy_wrapper_gcc_usb30_pipe_clk";
                        #clock-cells = <1>;
                        #reset-cells = <1>;
                        #power-domain-cells = <1>;

arch/arm64/boot/dts/qcom/sc7280.dtsi line 377

Quoted 5 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +2 -0
@@ -325,6 +373,13 @@
                                          <SLEEP_TCS   3>,
                                          <WAKE_TCS    3>,
                                          <CONTROL_TCS 1>;
+
+                       rpmhcc: qcom,rpmhcc {

rpmhcc: clock-controller {

Quoted 8 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +5 -0
+                               compatible = "qcom,sc7280-rpmh-clk";
+                               clocks = <&xo_board>;
+                               clock-names = "xo";
+                               #clock-cells = <1>;
+                       };
                };
        };
 
#19 lore raw

Re: [PATCH 06/13] arm64: dts: qcom: SC7280: Add rpmhcc clock controller node

Hello Stephen,

Thanks for the review.

Quoted 47 lines · Stephen Boyd

Quoting Rajendra Nayak (2021-02-11 23:28:43)

Quoted 46 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +31 -0
index 7848e88..10851e7 100644
@@ -6,6 +6,7 @@
   */
 
  #include <dt-bindings/clock/qcom,gcc-sc7280.h>
+#include <dt-bindings/clock/qcom,rpmh.h>
  #include <dt-bindings/interrupt-controller/arm-gic.h>
  #include <dt-bindings/soc/qcom,rpmh-rsc.h>
 
@@ -29,6 +30,42 @@
                         clock-frequency = <32000>;
                         #clock-cells = <0>;
                 };
+
+               pcie_0_pipe_clk: pcie-0-pipe-clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <1000>;
+                       #clock-cells = <0>;
+               };
+
+               pcie_1_pipe_clk: pcie-1-pipe-clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <1000>;
+                       #clock-cells = <0>;
+               };
+
+               ufs_phy_rx_symbol_0_clk: ufs-phy-rx-symbol-0-clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <1000>;
+                       #clock-cells = <0>;
+               };
+
+               ufs_phy_rx_symbol_1_clk: ufs-phy-rx-symbol-1-clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <1000>;
+                       #clock-cells = <0>;
+               };
+
+               ufs_phy_tx_symbol_0_clk: ufs-phy-tx-symbol-0-clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <1000>;
+                       #clock-cells = <0>;
+               };
Quoted 9 lines

arch/arm64/boot/dts/qcom/sc7280.dtsi line 68

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +6 -0
+
+               usb3_phy_wrapper_gcc_usb30_pipe_clk: usb3-phy-wrapper-gcc-usb30-pipe-clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <1000>;
+                       #clock-cells = <0>;
+               };

Shouldn't these come from the phys? Why are they being added here?

Once the phys are added, these could be replaced, that was the reason to add them.

Quoted 17 lines

arch/arm64/boot/dts/qcom/sc7280.dtsi line 219

Quoted 13 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +6 -0
         };
 
         reserved_memory: reserved-memory {
@@ -174,6 +211,17 @@
                 gcc: clock-controller@100000 {
                         compatible = "qcom,gcc-sc7280";
                         reg = <0 0x00100000 0 0x1f0000>;
+                       clocks = <&rpmhcc RPMH_CXO_CLK>,
+                                <&rpmhcc RPMH_CXO_CLK_A>, <&sleep_clk>,
+                                <&pcie_0_pipe_clk>, <&pcie_1_pipe_clk>,
+                                <&ufs_phy_rx_symbol_0_clk>, <&ufs_phy_rx_symbol_1_clk>,
+                                <&ufs_phy_tx_symbol_0_clk>,
+                                <&usb3_phy_wrapper_gcc_usb30_pipe_clk>;

If the phys aren't ready then <0> should work. Unless something goes wrong?

Nothing would go wrong if we add <0>, but wanted them to be replaced once the support is added.

Quoted 8 lines
Quoted 8 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +5 -0
+                       clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk",
+                                     "pcie_0_pipe_clk", "pcie_1_pipe-clk",
+                                     "ufs_phy_rx_symbol_0_clk", "ufs_phy_rx_symbol_1_clk",
+                                     "ufs_phy_tx_symbol_0_clk",
+                                     "usb3_phy_wrapper_gcc_usb30_pipe_clk";
                         #clock-cells = <1>;
                         #reset-cells = <1>;
                         #power-domain-cells = <1>;
Quoted 9 lines

arch/arm64/boot/dts/qcom/sc7280.dtsi line 377

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +2 -0
@@ -325,6 +373,13 @@
                                           <SLEEP_TCS   3>,
                                           <WAKE_TCS    3>,
                                           <CONTROL_TCS 1>;
+
+                       rpmhcc: qcom,rpmhcc {

rpmhcc: clock-controller {

Will update in the next patch.

Quoted 8 lines
Quoted 8 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +5 -0
+                               compatible = "qcom,sc7280-rpmh-clk";
+                               clocks = <&xo_board>;
+                               clock-names = "xo";
+                               #clock-cells = <1>;
+                       };
                 };
         };
 
Signature · 4 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--
#20 lore raw

Re: [PATCH 06/13] arm64: dts: qcom: SC7280: Add rpmhcc clock controller node

Quoting Taniya Das (2021-03-01 09:27:06)

Quoted 33 lines · Stephen Boyd
Quoted 10 lines

Quoting Rajendra Nayak (2021-02-11 23:28:43)

arch/arm64/boot/dts/qcom/sc7280.dtsi line 68

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +5 -0
+               usb3_phy_wrapper_gcc_usb30_pipe_clk: usb3-phy-wrapper-gcc-usb30-pipe-clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <1000>;
+                       #clock-cells = <0>;
+               };

Shouldn't these come from the phys? Why are they being added here?

Once the phys are added, these could be replaced, that was the reason to add them.

Quoted 17 lines

arch/arm64/boot/dts/qcom/sc7280.dtsi line 219

Quoted 13 lines
         };
  
         reserved_memory: reserved-memory {
arch/arm64/boot/dts/qcom/sc7280.dtsi +6 -0
@@ -174,6 +211,17 @@
                 gcc: clock-controller@100000 {
                         compatible = "qcom,gcc-sc7280";
                         reg = <0 0x00100000 0 0x1f0000>;
+                       clocks = <&rpmhcc RPMH_CXO_CLK>,
+                                <&rpmhcc RPMH_CXO_CLK_A>, <&sleep_clk>,
+                                <&pcie_0_pipe_clk>, <&pcie_1_pipe_clk>,
+                                <&ufs_phy_rx_symbol_0_clk>, <&ufs_phy_rx_symbol_1_clk>,
+                                <&ufs_phy_tx_symbol_0_clk>,
+                                <&usb3_phy_wrapper_gcc_usb30_pipe_clk>;

If the phys aren't ready then <0> should work. Unless something goes wrong?

Quoted 2 lines

Nothing would go wrong if we add <0>, but wanted them to be replaced once the support is added.

Please use <0> to indicate that it's missing. Otherwise we may never realize that we should connect it up later.

#21 lore raw

PATCH 7/13 dt-bindings: arm-smmu: Add compatible for SC7280 SoC

In reply to Rajendra Nayak

From: Sai Prakash Ranjan <[email protected]>

Add the SoC specific compatible for SC7280 implementing arm,mmu-500.

---
 Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iommu/arm,smmu.yaml +1 -0
index 3b63f2a..c6e82ca 100644
@@ -34,6 +34,7 @@ properties:
         items:
           - enum:
               - qcom,sc7180-smmu-500
+              - qcom,sc7280-smmu-500
               - qcom,sdm845-smmu-500
               - qcom,sm8150-smmu-500
               - qcom,sm8250-smmu-500
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#23 lore raw

PATCH 8/13 arm64: dts: qcom: sc7280: Add device node for APPS SMMU

In reply to Rajendra Nayak

From: Sai Prakash Ranjan <[email protected]>

Adding device node for APPS SMMU available on SC7280 chipset. This is shared among the multiple client devices such as display, video, usb, mmc and others.

---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 89 ++++++++++++++++++++++++++++++++++++
 1 file changed, 89 insertions(+)
arch/arm64/boot/dts/qcom/sc7280.dtsi +89 -0
index 10851e7..f71ba21 100644
@@ -280,6 +280,95 @@
 			};
 		};
 
+		apps_smmu: iommu@15000000 {
+			compatible = "qcom,sc7280-smmu-500", "arm,mmu-500";
+			reg = <0 0x15000000 0 0x100000>;
+			#iommu-cells = <2>;
+			#global-interrupts = <1>;
+			dma-coherent;
+			interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 181 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 182 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 183 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 185 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 315 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 316 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 317 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 318 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 319 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 320 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 321 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 322 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 323 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 325 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 326 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 328 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 329 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 333 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 334 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 335 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 336 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 337 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 338 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 339 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 340 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 341 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 342 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 343 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 344 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 345 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 395 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 396 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 397 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 398 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 399 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 400 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 401 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 402 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 403 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 404 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 405 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 406 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 407 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 408 IRQ_TYPE_LEVEL_HIGH>;
+		};
+
 		intc: interrupt-controller@17a00000 {
 			compatible = "arm,gic-v3";
 			#address-cells = <2>;
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#24 lore raw

PATCH 9/13 arm64: dts: qcom: Add reserved memory for fw

In reply to Rajendra Nayak

From: Maulik Shah <[email protected]>

Add fw reserved memory area for CPUCP and AOP.

---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm64/boot/dts/qcom/sc7280.dtsi +10 -0
index f71ba21..b5b9b6a 100644
@@ -73,11 +73,21 @@
 		#size-cells = <2>;
 		ranges;
 
+		aop_mem: memory@80800000 {
+			reg = <0x0 0x80800000 0x0 0x60000>;
+			no-map;
+		};
+
 		aop_cmd_db_mem: memory@80860000 {
 			reg = <0x0 0x80860000 0x0 0x20000>;
 			compatible = "qcom,cmd-db";
 			no-map;
 		};
+
+		cpucp_mem: memory@80b00000 {
+			no-map;
+			reg = <0x0 0x80b00000 0x0 0x100000>;
+		};
 	};
 
 	cpus {
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#25 lore raw

Re: [PATCH 09/13] arm64: dts: qcom: Add reserved memory for fw

Quoting Rajendra Nayak (2021-02-11 23:28:46)

Quoted 3 lines

From: Maulik Shah <[email protected]>

Add fw reserved memory area for CPUCP and AOP.

Does CPUCP stand for CPU Content Protection? AOP is Always On Processor. It would help if the commit text told us what these acronyms were.

Quoted 7 lines
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
#26 lore raw

Re: [PATCH 09/13] arm64: dts: qcom: Add reserved memory for fw

Quoted 7 lines · Stephen Boyd

Quoting Rajendra Nayak (2021-02-11 23:28:46)

Quoted 3 lines

From: Maulik Shah <[email protected]>

Add fw reserved memory area for CPUCP and AOP.

Does CPUCP stand for CPU Content Protection? AOP is Always On Processor. It would help if the commit text told us what these acronyms were.

Thanks, I'll expand the acronyms when I re-post.

Quoted 7 lines
Quoted 7 lines
---
  arch/arm64/boot/dts/qcom/sc7280.dtsi | 10 ++++++++++
  1 file changed, 10 insertions(+)
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#27 lore raw

PATCH 10/13 dt-bindings: watchdog: Add compatible for SC7280 SoC

In reply to Rajendra Nayak

From: Sai Prakash Ranjan <[email protected]>

Add compatible for watchdog timer on SC7280 SoC.

---
 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +1 -0
index 8e3760a..b5b1268 100644
@@ -17,6 +17,7 @@ properties:
     enum:
       - qcom,apss-wdt-qcs404
       - qcom,apss-wdt-sc7180
+      - qcom,apss-wdt-sc7280
       - qcom,apss-wdt-sdm845
       - qcom,apss-wdt-sm8150
       - qcom,kpss-timer
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#29 lore raw

PATCH 11/13 arm64: dts: qcom: sc7280: Add APSS watchdog node

In reply to Rajendra Nayak

From: Sai Prakash Ranjan <[email protected]>

Add APSS (Application Processor Subsystem) watchdog DT node for SC7280 SoC.

---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/qcom/sc7280.dtsi +7 -0
index b5b9b6a..ef82d77 100644
@@ -399,6 +399,13 @@
 			};
 		};
 
+		watchdog@17c10000 {
+			compatible = "qcom,apss-wdt-sc7280", "qcom,kpss-wdt";
+			reg = <0 0x17c10000 0 0x1000>;
+			clocks = <&sleep_clk>;
+			interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
+		};
+
 		timer@17c20000 {
 			#address-cells = <2>;
 			#size-cells = <2>;
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#31 lore raw

PATCH 12/13 arm64: dts: qcom: sc7280: Add SPMI PMIC arbiter device for SC7280

In reply to Rajendra Nayak

From: satya priya <[email protected]>

Add SPMI PMIC arbiter device to communicate with PMICs attached to SPMI bus.

---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
arch/arm64/boot/dts/qcom/sc7280.dtsi +19 -0
index ef82d77..8f2002b 100644
@@ -273,6 +273,25 @@
 			interrupt-controller;
 		};
 
+		spmi_bus: qcom,spmi@c440000 {
+			compatible = "qcom,spmi-pmic-arb";
+			reg = <0 0x0c440000 0 0x1100>,
+			      <0 0x0c600000 0 0x2000000>,
+			      <0 0x0e600000 0 0x100000>,
+			      <0 0x0e700000 0 0xa0000>,
+			      <0 0x0c40a000 0 0x26000>;
+			reg-names = "core", "chnls", "obsrvr", "intr", "cnfg";
+			interrupt-names = "periph_irq";
+			interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
+			qcom,ee = <0>;
+			qcom,channel = <0>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			interrupt-controller;
+			#interrupt-cells = <4>;
+			cell-index = <0>;
+		};
+
 		tlmm: pinctrl@f100000 {
 			compatible = "qcom,sc7280-pinctrl";
 			reg = <0 0xf100000 0 0x1000000>;
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#32 lore raw

PATCH 13/13 arm64: dts: qcom: sc7280: Add cpuidle states

In reply to Rajendra Nayak

From: Maulik Shah <[email protected]>

Add cpuidle states for little and big cpus.

---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 78 ++++++++++++++++++++++++++++++++++++
 1 file changed, 78 insertions(+)
arch/arm64/boot/dts/qcom/sc7280.dtsi +78 -0
index 8f2002b..3b86052 100644
@@ -99,6 +99,9 @@
 			compatible = "arm,kryo";
 			reg = <0x0 0x0>;
 			enable-method = "psci";
+			cpu-idle-states = <&LITTLE_CPU_SLEEP_0
+					   &LITTLE_CPU_SLEEP_1
+					   &CLUSTER_SLEEP_0>;
 			next-level-cache = <&L2_0>;
 			L2_0: l2-cache {
 				compatible = "cache";
@@ -114,6 +117,9 @@
 			compatible = "arm,kryo";
 			reg = <0x0 0x100>;
 			enable-method = "psci";
+			cpu-idle-states = <&LITTLE_CPU_SLEEP_0
+					   &LITTLE_CPU_SLEEP_1
+					   &CLUSTER_SLEEP_0>;
 			next-level-cache = <&L2_100>;
 			L2_100: l2-cache {
 				compatible = "cache";
@@ -126,6 +132,9 @@
 			compatible = "arm,kryo";
 			reg = <0x0 0x200>;
 			enable-method = "psci";
+			cpu-idle-states = <&LITTLE_CPU_SLEEP_0
+					   &LITTLE_CPU_SLEEP_1
+					   &CLUSTER_SLEEP_0>;
 			next-level-cache = <&L2_200>;
 			L2_200: l2-cache {
 				compatible = "cache";
@@ -138,6 +147,9 @@
 			compatible = "arm,kryo";
 			reg = <0x0 0x300>;
 			enable-method = "psci";
+			cpu-idle-states = <&LITTLE_CPU_SLEEP_0
+					   &LITTLE_CPU_SLEEP_1
+					   &CLUSTER_SLEEP_0>;
 			next-level-cache = <&L2_300>;
 			L2_300: l2-cache {
 				compatible = "cache";
@@ -150,6 +162,9 @@
 			compatible = "arm,kryo";
 			reg = <0x0 0x400>;
 			enable-method = "psci";
+			cpu-idle-states = <&BIG_CPU_SLEEP_0
+					   &BIG_CPU_SLEEP_1
+					   &CLUSTER_SLEEP_0>;
 			next-level-cache = <&L2_400>;
 			L2_400: l2-cache {
 				compatible = "cache";
@@ -162,6 +177,9 @@
 			compatible = "arm,kryo";
 			reg = <0x0 0x500>;
 			enable-method = "psci";
+			cpu-idle-states = <&BIG_CPU_SLEEP_0
+					   &BIG_CPU_SLEEP_1
+					   &CLUSTER_SLEEP_0>;
 			next-level-cache = <&L2_500>;
 			L2_500: l2-cache {
 				compatible = "cache";
@@ -174,6 +192,9 @@
 			compatible = "arm,kryo";
 			reg = <0x0 0x600>;
 			enable-method = "psci";
+			cpu-idle-states = <&BIG_CPU_SLEEP_0
+					   &BIG_CPU_SLEEP_1
+					   &CLUSTER_SLEEP_0>;
 			next-level-cache = <&L2_600>;
 			L2_600: l2-cache {
 				compatible = "cache";
@@ -186,12 +207,69 @@
 			compatible = "arm,kryo";
 			reg = <0x0 0x700>;
 			enable-method = "psci";
+			cpu-idle-states = <&BIG_CPU_SLEEP_0
+					   &BIG_CPU_SLEEP_1
+					   &CLUSTER_SLEEP_0>;
 			next-level-cache = <&L2_700>;
 			L2_700: l2-cache {
 				compatible = "cache";
 				next-level-cache = <&L3_0>;
 			};
 		};
+
+		idle-states {
+			entry-method = "psci";
+
+			LITTLE_CPU_SLEEP_0: cpu-sleep-0-0 {
+				compatible = "arm,idle-state";
+				idle-state-name = "little-power-down";
+				arm,psci-suspend-param = <0x40000003>;
+				entry-latency-us = <549>;
+				exit-latency-us = <901>;
+				min-residency-us = <1774>;
+				local-timer-stop;
+			};
+
+			LITTLE_CPU_SLEEP_1: cpu-sleep-0-1 {
+				compatible = "arm,idle-state";
+				idle-state-name = "little-rail-power-down";
+				arm,psci-suspend-param = <0x40000004>;
+				entry-latency-us = <702>;
+				exit-latency-us = <915>;
+				min-residency-us = <4001>;
+				local-timer-stop;
+			};
+
+			BIG_CPU_SLEEP_0: cpu-sleep-1-0 {
+				compatible = "arm,idle-state";
+				idle-state-name = "big-power-down";
+				arm,psci-suspend-param = <0x40000003>;
+				entry-latency-us = <523>;
+				exit-latency-us = <1244>;
+				min-residency-us = <2207>;
+				local-timer-stop;
+			};
+
+			BIG_CPU_SLEEP_1: cpu-sleep-1-1 {
+				compatible = "arm,idle-state";
+				idle-state-name = "big-rail-power-down";
+				arm,psci-suspend-param = <0x40000004>;
+				entry-latency-us = <526>;
+				exit-latency-us = <1854>;
+				min-residency-us = <5555>;
+				local-timer-stop;
+			};
+
+			CLUSTER_SLEEP_0: cluster-sleep-0 {
+				compatible = "arm,idle-state";
+				idle-state-name = "cluster-power-down";
+				arm,psci-suspend-param = <0x40003444>;
+				entry-latency-us = <3263>;
+				exit-latency-us = <6562>;
+				min-residency-us = <9926>;
+				local-timer-stop;
+			};
+		};
 	};
 
 	memory@80000000 {
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#33 lore raw

Re: [PATCH 13/13] arm64: dts: qcom: sc7280: Add cpuidle states

Quoting Rajendra Nayak (2021-02-11 23:28:50)

Quoted 18 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +4 -0
index 8f2002b..3b86052 100644
@@ -186,12 +207,69 @@
                        compatible = "arm,kryo";
                        reg = <0x0 0x700>;
                        enable-method = "psci";
+                       cpu-idle-states = <&BIG_CPU_SLEEP_0
+                                          &BIG_CPU_SLEEP_1
+                                          &CLUSTER_SLEEP_0>;
                        next-level-cache = <&L2_700>;
                        L2_700: l2-cache {
                                compatible = "cache";
                                next-level-cache = <&L3_0>;
                        };
                };
+

arch/arm64/boot/dts/qcom/sc7280.dtsi line 229

Quoted 10 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +10 -0
+               idle-states {
+                       entry-method = "psci";
+
+                       LITTLE_CPU_SLEEP_0: cpu-sleep-0-0 {
+                               compatible = "arm,idle-state";
+                               idle-state-name = "little-power-down";
+                               arm,psci-suspend-param = <0x40000003>;
+                               entry-latency-us = <549>;
+                               exit-latency-us = <901>;
+                               min-residency-us = <1774>;

Are these preliminary numbers? They're the same as sc7180 from what I can tell, but presumably things changed between SoC versions?

Quoted 20 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +20 -0
+                               local-timer-stop;
+                       };
+
+                       LITTLE_CPU_SLEEP_1: cpu-sleep-0-1 {
+                               compatible = "arm,idle-state";
+                               idle-state-name = "little-rail-power-down";
+                               arm,psci-suspend-param = <0x40000004>;
+                               entry-latency-us = <702>;
+                               exit-latency-us = <915>;
+                               min-residency-us = <4001>;
+                               local-timer-stop;
+                       };
+
+                       BIG_CPU_SLEEP_0: cpu-sleep-1-0 {
+                               compatible = "arm,idle-state";
+                               idle-state-name = "big-power-down";
+                               arm,psci-suspend-param = <0x40000003>;
+                               entry-latency-us = <523>;
+                               exit-latency-us = <1244>;
+                               min-residency-us = <2207>;
#34 lore raw

Re: [PATCH 13/13] arm64: dts: qcom: sc7280: Add cpuidle states

Hi Stephen,

Quoted 23 lines · Stephen Boyd

Quoting Rajendra Nayak (2021-02-11 23:28:50)

Quoted 22 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +8 -0
index 8f2002b..3b86052 100644
@@ -186,12 +207,69 @@
                         compatible = "arm,kryo";
                         reg = <0x0 0x700>;
                         enable-method = "psci";
+                       cpu-idle-states = <&BIG_CPU_SLEEP_0
+                                          &BIG_CPU_SLEEP_1
+                                          &CLUSTER_SLEEP_0>;
                         next-level-cache = <&L2_700>;
                         L2_700: l2-cache {
                                 compatible = "cache";
                                 next-level-cache = <&L3_0>;
                         };
                 };
+
+               idle-states {
+                       entry-method = "psci";
+
+                       LITTLE_CPU_SLEEP_0: cpu-sleep-0-0 {
Quoted 8 lines

arch/arm64/boot/dts/qcom/sc7280.dtsi line 229

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +6 -0
+                               compatible = "arm,idle-state";
+                               idle-state-name = "little-power-down";
+                               arm,psci-suspend-param = <0x40000003>;
+                               entry-latency-us = <549>;
+                               exit-latency-us = <901>;
+                               min-residency-us = <1774>;

Are these preliminary numbers? They're the same as sc7180 from what I can tell, but presumably things changed between SoC versions?

yes they are preliminary numbers, we are yet to measure on sc7280 and will update later once measured.

Thanks,
Maulik

Quoted 21 lines
Quoted 21 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +20 -0
+                               local-timer-stop;
+                       };
+
+                       LITTLE_CPU_SLEEP_1: cpu-sleep-0-1 {
+                               compatible = "arm,idle-state";
+                               idle-state-name = "little-rail-power-down";
+                               arm,psci-suspend-param = <0x40000004>;
+                               entry-latency-us = <702>;
+                               exit-latency-us = <915>;
+                               min-residency-us = <4001>;
+                               local-timer-stop;
+                       };
+
+                       BIG_CPU_SLEEP_0: cpu-sleep-1-0 {
+                               compatible = "arm,idle-state";
+                               idle-state-name = "big-power-down";
+                               arm,psci-suspend-param = <0x40000003>;
+                               entry-latency-us = <523>;
+                               exit-latency-us = <1244>;
+                               min-residency-us = <2207>;
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#35 lore raw
In reply to Rajendra Nayak
Quoted 9 lines · Rajendra Nayak

This series includes a few minor binding updates and base device tree files (to boot to shell) for SC7280 SoC and the IDP board using this SoC.

The series is dependent on a few driver patches to merge first, for gcc, rpmhcc and pinctrl
https://lore.kernel.org/patchwork/project/lkml/list/?series=484517
https://lore.kernel.org/patchwork/project/lkml/list/?series=484489
https://lore.kernel.org/patchwork/patch/1379831/

I'm not able to find v2 of this series, but plenty of patches that depends on its content. Do I somehow miss it, or is it coming?

Regards,
Bjorn

Quoted 37 lines

Maulik Shah (3):
arm64: dts: qcom: sc7280: Add RSC and PDC devices
arm64: dts: qcom: Add reserved memory for fw
arm64: dts: qcom: sc7280: Add cpuidle states

Rajendra Nayak (5):
dt-bindings: arm: qcom: Document SC7280 SoC and board
dt-bindings: firmware: scm: Add SC7280 support
arm64: dts: sc7280: Add basic dts/dtsi files for SC7280 soc
dt-bindings: qcom,pdc: Add compatible for sc7280
arm64: dts: qcom: SC7280: Add rpmhcc clock controller node

Sai Prakash Ranjan (4):
dt-bindings: arm-smmu: Add compatible for SC7280 SoC
arm64: dts: qcom: sc7280: Add device node for APPS SMMU
dt-bindings: watchdog: Add compatible for SC7280 SoC
arm64: dts: qcom: sc7280: Add APSS watchdog node

satya priya (1):
arm64: dts: qcom: sc7280: Add SPMI PMIC arbiter device for SC7280

 Documentation/devicetree/bindings/arm/qcom.yaml    |   6 +
 .../devicetree/bindings/firmware/qcom,scm.txt      |   1 +
 .../bindings/interrupt-controller/qcom,pdc.txt     |   1 +
 .../devicetree/bindings/iommu/arm,smmu.yaml        |   1 +
 .../devicetree/bindings/watchdog/qcom-wdt.yaml     |   1 +
 arch/arm64/boot/dts/qcom/Makefile                  |   1 +
 arch/arm64/boot/dts/qcom/sc7280-idp.dts            |  47 ++
 arch/arm64/boot/dts/qcom/sc7280.dtsi               | 596 +++++++++++++++++++++
 8 files changed, 654 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sc7280-idp.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sc7280.dtsi
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#36 lore raw
Quoted 12 lines · Bjorn Andersson
Quoted 9 lines · Rajendra Nayak

This series includes a few minor binding updates and base device tree files (to boot to shell) for SC7280 SoC and the IDP board using this SoC.

The series is dependent on a few driver patches to merge first, for gcc, rpmhcc and pinctrl
https://lore.kernel.org/patchwork/project/lkml/list/?series=484517
https://lore.kernel.org/patchwork/project/lkml/list/?series=484489
https://lore.kernel.org/patchwork/patch/1379831/

Quoted 2 lines

I'm not able to find v2 of this series, but plenty of patches that depends on its content. Do I somehow miss it, or is it coming?

I did post v2 [1], and will post v3 shortly addressing some of the feedback from Stephen on v2. I was waiting on the rpmh clock fix to come out [2], which addresses the question about the XO clock frequency [3] in DT

[1] https://lore.kernel.org/patchwork/project/lkml/list/?series=487403
[2] https://lore.kernel.org/patchwork/patch/1393159/
[3] https://lore.kernel.org/patchwork/patch/1389019/

Quoted 40 lines

Regards,
Bjorn

Quoted 37 lines

Maulik Shah (3):
arm64: dts: qcom: sc7280: Add RSC and PDC devices
arm64: dts: qcom: Add reserved memory for fw
arm64: dts: qcom: sc7280: Add cpuidle states

Rajendra Nayak (5):
dt-bindings: arm: qcom: Document SC7280 SoC and board
dt-bindings: firmware: scm: Add SC7280 support
arm64: dts: sc7280: Add basic dts/dtsi files for SC7280 soc
dt-bindings: qcom,pdc: Add compatible for sc7280
arm64: dts: qcom: SC7280: Add rpmhcc clock controller node

Sai Prakash Ranjan (4):
dt-bindings: arm-smmu: Add compatible for SC7280 SoC
arm64: dts: qcom: sc7280: Add device node for APPS SMMU
dt-bindings: watchdog: Add compatible for SC7280 SoC
arm64: dts: qcom: sc7280: Add APSS watchdog node

satya priya (1):
arm64: dts: qcom: sc7280: Add SPMI PMIC arbiter device for SC7280

  Documentation/devicetree/bindings/arm/qcom.yaml    |   6 +
  .../devicetree/bindings/firmware/qcom,scm.txt      |   1 +
  .../bindings/interrupt-controller/qcom,pdc.txt     |   1 +
  .../devicetree/bindings/iommu/arm,smmu.yaml        |   1 +
  .../devicetree/bindings/watchdog/qcom-wdt.yaml     |   1 +
  arch/arm64/boot/dts/qcom/Makefile                  |   1 +
  arch/arm64/boot/dts/qcom/sc7280-idp.dts            |  47 ++
  arch/arm64/boot/dts/qcom/sc7280.dtsi               | 596 +++++++++++++++++++++
  8 files changed, 654 insertions(+)

create mode 100644 arch/arm64/boot/dts/qcom/sc7280-idp.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7280.dtsi

Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#37 lore raw
Quoted 14 lines · Rajendra Nayak
Quoted 12 lines · Bjorn Andersson
Quoted 9 lines · Rajendra Nayak

This series includes a few minor binding updates and base device tree files (to boot to shell) for SC7280 SoC and the IDP board using this SoC.

The series is dependent on a few driver patches to merge first, for gcc, rpmhcc and pinctrl
https://lore.kernel.org/patchwork/project/lkml/list/?series=484517
https://lore.kernel.org/patchwork/project/lkml/list/?series=484489
https://lore.kernel.org/patchwork/patch/1379831/

Quoted 4 lines
Quoted 2 lines

I'm not able to find v2 of this series, but plenty of patches that depends on its content. Do I somehow miss it, or is it coming?

I did post v2 [1], and will post v3 shortly addressing some of

Posted a v3 now [1], also re-based on msm/for-next

[1] https://lore.kernel.org/patchwork/project/lkml/list/?series=488871

Quoted 49 lines

the feedback from Stephen on v2. I was waiting on the rpmh clock fix to come out [2], which addresses the question about the XO clock frequency [3] in DT

[1] https://lore.kernel.org/patchwork/project/lkml/list/?series=487403
[2] https://lore.kernel.org/patchwork/patch/1393159/
[3] https://lore.kernel.org/patchwork/patch/1389019/

Quoted 40 lines

Regards,
Bjorn

Quoted 37 lines

Maulik Shah (3):
   arm64: dts: qcom: sc7280: Add RSC and PDC devices
   arm64: dts: qcom: Add reserved memory for fw
   arm64: dts: qcom: sc7280: Add cpuidle states

Rajendra Nayak (5):
   dt-bindings: arm: qcom: Document SC7280 SoC and board
   dt-bindings: firmware: scm: Add SC7280 support
   arm64: dts: sc7280: Add basic dts/dtsi files for SC7280 soc
   dt-bindings: qcom,pdc: Add compatible for sc7280
   arm64: dts: qcom: SC7280: Add rpmhcc clock controller node

Sai Prakash Ranjan (4):
   dt-bindings: arm-smmu: Add compatible for SC7280 SoC
   arm64: dts: qcom: sc7280: Add device node for APPS SMMU
   dt-bindings: watchdog: Add compatible for SC7280 SoC
   arm64: dts: qcom: sc7280: Add APSS watchdog node

satya priya (1):
   arm64: dts: qcom: sc7280: Add SPMI PMIC arbiter device for SC7280

  Documentation/devicetree/bindings/arm/qcom.yaml    |   6 + .../devicetree/bindings/firmware/qcom,scm.txt      |   1 + .../bindings/interrupt-controller/qcom,pdc.txt     |   1 + .../devicetree/bindings/iommu/arm,smmu.yaml        |   1 + .../devicetree/bindings/watchdog/qcom-wdt.yaml     |   1 + arch/arm64/boot/dts/qcom/Makefile                  |   1 + arch/arm64/boot/dts/qcom/sc7280-idp.dts            |  47 ++ arch/arm64/boot/dts/qcom/sc7280.dtsi               | 596 +++++++++++++++++++++

  8 files changed, 654 insertions(+)

  create mode 100644 arch/arm64/boot/dts/qcom/sc7280-idp.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7280.dtsi

Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#38 lore raw
In reply to Rajendra Nayak
Quoted 14 lines · Rajendra Nayak
Quoted 12 lines · Bjorn Andersson
Quoted 9 lines · Rajendra Nayak

This series includes a few minor binding updates and base device tree files (to boot to shell) for SC7280 SoC and the IDP board using this SoC.

The series is dependent on a few driver patches to merge first, for gcc, rpmhcc and pinctrl
https://lore.kernel.org/patchwork/project/lkml/list/?series=484517
https://lore.kernel.org/patchwork/project/lkml/list/?series=484489
https://lore.kernel.org/patchwork/patch/1379831/

Quoted 5 lines
Quoted 2 lines

I'm not able to find v2 of this series, but plenty of patches that depends on its content. Do I somehow miss it, or is it coming?

I did post v2 [1], and will post v3 shortly addressing some of the feedback from Stephen on v2.

Sorry, I had filtered my inbox view a little bit too hard and missed it.

v3 looks good to me, so I'll pick it to allow me to land other pending patches on top.

Thank you,
Bjorn

Quoted 51 lines

I was waiting on the rpmh clock fix to come out [2], which addresses the question about the XO clock frequency [3] in DT

[1] https://lore.kernel.org/patchwork/project/lkml/list/?series=487403
[2] https://lore.kernel.org/patchwork/patch/1393159/
[3] https://lore.kernel.org/patchwork/patch/1389019/

Quoted 40 lines

Regards,
Bjorn

Quoted 37 lines

Maulik Shah (3):
arm64: dts: qcom: sc7280: Add RSC and PDC devices
arm64: dts: qcom: Add reserved memory for fw
arm64: dts: qcom: sc7280: Add cpuidle states

Rajendra Nayak (5):
dt-bindings: arm: qcom: Document SC7280 SoC and board
dt-bindings: firmware: scm: Add SC7280 support
arm64: dts: sc7280: Add basic dts/dtsi files for SC7280 soc
dt-bindings: qcom,pdc: Add compatible for sc7280
arm64: dts: qcom: SC7280: Add rpmhcc clock controller node

Sai Prakash Ranjan (4):
dt-bindings: arm-smmu: Add compatible for SC7280 SoC
arm64: dts: qcom: sc7280: Add device node for APPS SMMU
dt-bindings: watchdog: Add compatible for SC7280 SoC
arm64: dts: qcom: sc7280: Add APSS watchdog node

satya priya (1):
arm64: dts: qcom: sc7280: Add SPMI PMIC arbiter device for SC7280

  Documentation/devicetree/bindings/arm/qcom.yaml    |   6 +
  .../devicetree/bindings/firmware/qcom,scm.txt      |   1 +
  .../bindings/interrupt-controller/qcom,pdc.txt     |   1 +
  .../devicetree/bindings/iommu/arm,smmu.yaml        |   1 +
  .../devicetree/bindings/watchdog/qcom-wdt.yaml     |   1 +
  arch/arm64/boot/dts/qcom/Makefile                  |   1 +
  arch/arm64/boot/dts/qcom/sc7280-idp.dts            |  47 ++
  arch/arm64/boot/dts/qcom/sc7280.dtsi               | 596 +++++++++++++++++++++
  8 files changed, 654 insertions(+)

create mode 100644 arch/arm64/boot/dts/qcom/sc7280-idp.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7280.dtsi

Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation