Skip to contentSkip to conversation

usbip: stub_rx: tidy the indenting in is_clear_halt_cmd()

PATCH In review Dan Carpenter 2 participants 2 messages Apr 24, 2019 – Apr 25, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usbip: stub_rx: tidy the indenting in is_clear_halt_cmd()

There is an extra space character before the return statement.

drivers/usb/usbip/stub_rx.c +3 -3
index 97b09a42a10c..f3230bed18af 100644
@@ -17,9 +17,9 @@ static int is_clear_halt_cmd(struct urb *urb)
 
 	req = (struct usb_ctrlrequest *) urb->setup_packet;
 
-	 return (req->bRequest = USB_REQ_CLEAR_FEATURE) &&
-		 (req->bRequestType = USB_RECIP_ENDPOINT) &&
-		 (req->wValue = USB_ENDPOINT_HALT);
+	return (req->bRequest = USB_REQ_CLEAR_FEATURE) &&
+	       (req->bRequestType = USB_RECIP_ENDPOINT) &&
+	       (req->wValue = USB_ENDPOINT_HALT);
 }
 
 static int is_set_interface_cmd(struct urb *urb)
maintainer Acked-by Shuah Khan on v1 1/1
#1 lore raw
Quoted 12 lines · Dan Carpenter

There is an extra space character before the return statement.

drivers/usb/usbip/stub_rx.c +0 -0
index 97b09a42a10c..f3230bed18af 100644
@@ -17,9 +17,9 @@ static int is_clear_halt_cmd(struct urb *urb)
 
  	req = (struct usb_ctrlrequest *) urb->setup_packet;

drivers/usb/usbip/stub_rx.c static int is_clear_halt_cmd(struct urb *urb) · line 25

Quoted 10 lines
drivers/usb/usbip/stub_rx.c +3 -3
 
-	 return (req->bRequest = USB_REQ_CLEAR_FEATURE) &&
-		 (req->bRequestType = USB_RECIP_ENDPOINT) &&
-		 (req->wValue = USB_ENDPOINT_HALT);
+	return (req->bRequest = USB_REQ_CLEAR_FEATURE) &&
+	       (req->bRequestType = USB_RECIP_ENDPOINT) &&
+	       (req->wValue = USB_ENDPOINT_HALT);
  }
 
  static int is_set_interface_cmd(struct urb *urb)

Thanks for the patch.

thanks,
-- Shuah