add json power policy interface for containers

+static unsigned int global_hypervisor_available;

On Thu, 30 Aug 2018 11:54:16 +0100
David Hunt <[email protected]> wrote:

Minor nits

Quoted 1 line

+static unsigned int global_hypervisor_available;

Please use bool for boolean values.

examples/vm_power_manager/channel_manager.c get_pcpus_mask(struct channel_info *chan_info, unsigned vcpu) · line 203

Quoted 9 lines

/*
* Represents a single Virtual Machine

examples/vm_power_manager/channel_manager.c +2 -1

@@ -198,7 +199,11 @@ get_pcpus_mask(struct channel_info *chan_info, unsigned vcpu)
  {
  	struct virtual_machine_info *vm_info =
  			(struct virtual_machine_info *)chan_info->priv_info;
-	return rte_atomic64_read(&vm_info->pcpu_mask[vcpu]);
+
+	if ((global_hypervisor_available) && (vm_info != NULL))

parenthesis are unnecessary here.

Signed-off-by David Hunt <[email protected]>

---
 lib/librte_power/channel_commands.h | 4 ++++
 1 file changed, 4 insertions(+)

lib/librte_power/channel_commands.h +1 -0

index ee638eefa..a82724911 100644
@@ -19,6 +19,7 @@ extern "C" {
 #define CPU_POWER               1
 #define CPU_POWER_CONNECT       2
 #define PKT_POLICY              3
+#define PKT_POLICY_REMOVE       4
 
 /* CPU Power Command Scaling */
 #define CPU_POWER_SCALE_UP      1

Quoted 21 lines · On Thu, 30 Aug 2018 11:54:17 +0100 David Hunt <[email protected]> wrote:

Signed-off-by David Hunt <[email protected]>

---
  lib/librte_power/channel_commands.h | 4 ++++
  1 file changed, 4 insertions(+)

lib/librte_power/channel_commands.h +1 -0

index ee638eefa..a82724911 100644
@@ -19,6 +19,7 @@ extern "C" {
  #define CPU_POWER               1
  #define CPU_POWER_CONNECT       2
  #define PKT_POLICY              3
+#define PKT_POLICY_REMOVE       4
 
  /* CPU Power Command Scaling */
  #define CPU_POWER_SCALE_UP      1

@@ -58,6 +59,8 @@ struct traffic {
  	uint32_t max_max_packet_thresh;
  };
 

lib/librte_power/channel_commands.h struct traffic { · line 63

Quoted 2 lines

lib/librte_power/channel_commands.h +2 -0

+enum core_type { VIRTUAL = 0, PHYSICAL };
+

Why this enum, looks like a boolean to me.

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of David Hunt
Sent: Thursday, August 30, 2018 6:54 PM
To: [email protected]
Cc: Mcnamara, John <[email protected]>; Hunt, David <[email protected]>
Subject: [dpdk-dev] [PATCH v1 4/7] examples/power: add host channel to power manager

This patch adds a fifo channel to the vm_power_manager app through which we can send commands and polices. Intended for sending JSON strings. The fifo is at /tmp/powermonitor/fifo.0

Signed-off-by David Hunt <[email protected]>

---
 examples/vm_power_manager/channel_manager.c | 108
+++++++++++++++
 examples/vm_power_manager/channel_manager.h |  17 ++-
 examples/vm_power_manager/channel_monitor.c | 146
+++++++++++++++-----
 examples/vm_power_manager/main.c            |   2 +
 4 files changed, 238 insertions(+), 35 deletions(-)

examples/vm_power_manager/channel_manager.c +18 -0

index 2bb8641d3..bcd106be1 100644
@@ -13,6 +13,7 @@
 
 #include <sys/queue.h>
 #include <sys/types.h>
+#include <sys/stat.h>
 #include <sys/socket.h>
 #include <sys/select.h>
 

@@ -284,6 +285,38 @@ open_non_blocking_channel(struct channel_info
 *info)
 	return 0;
 }
 
+static int
+open_host_channel(struct channel_info *info)
+{
+	int flags;
+
+	info->fd = open(info->channel_path, O_RDWR | O_RSYNC);
+	if (info->fd == -1) {
+		RTE_LOG(ERR, CHANNEL_MANAGER, "Error(%s) opening fifo
 for '%s'\n",
+				strerror(errno),
+				info->channel_path);
+		return -1;
+	}
+
+	/* Get current flags */
+	flags = fcntl(info->fd, F_GETFL, 0);
+	if (flags < 0) {
+		RTE_LOG(WARNING, CHANNEL_MANAGER, "Error(%s) fcntl

get flags socket for"

examples/vm_power_manager/channel_manager.c +1 -0

+				"'%s'\n", strerror(errno), info-

Quoted 1 line

channel_path);

examples/vm_power_manager/channel_manager.c +14 -0

+		return 1;
+	}
+	/* Set to Non Blocking */
+	flags |= O_NONBLOCK;
+	if (fcntl(info->fd, F_SETFL, flags) < 0) {
+		RTE_LOG(WARNING, CHANNEL_MANAGER,
+				"Error(%s) setting non-blocking "
+				"socket for '%s'\n",
+				strerror(errno), info->channel_path);
+		return -1;
+	}
+	return 0;
+}
+
 static int
 setup_channel_info(struct virtual_machine_info **vm_info_dptr,
 		struct channel_info **chan_info_dptr, unsigned

channel_num)

examples/vm_power_manager/channel_manager.c +1 -0

@@ -294,6 +327,7 @@ setup_channel_info(struct virtual_machine_info
 **vm_info_dptr,
 	chan_info->channel_num = channel_num;
 	chan_info->priv_info = (void *)vm_info;
 	chan_info->status = CHANNEL_MGR_CHANNEL_DISCONNECTED;
+	chan_info->type = CHANNEL_TYPE_BINARY;
 	if (open_non_blocking_channel(chan_info) < 0) {
 		RTE_LOG(ERR, CHANNEL_MANAGER, "Could not open

channel: "

examples/vm_power_manager/channel_manager.c +14 -0

 				"'%s' for VM '%s'\n",

@@ -316,6 +350,35 @@ setup_channel_info(struct virtual_machine_info
 **vm_info_dptr,
 	return 0;
 }
 
+static int
+setup_host_channel_info(struct channel_info **chan_info_dptr,
+		unsigned int channel_num)
+{
+	struct channel_info *chan_info = *chan_info_dptr;
+
+	chan_info->channel_num = channel_num;
+	chan_info->priv_info = (void *)0;
+	chan_info->status = CHANNEL_MGR_CHANNEL_DISCONNECTED;
+	chan_info->type = CHANNEL_TYPE_JSON;
+	sprintf(chan_info->channel_path, "%sfifo.0",
 CHANNEL_MGR_SOCKET_PATH);
+
+	if (open_host_channel(chan_info) < 0) {
+		RTE_LOG(ERR, CHANNEL_MANAGER, "Could not open host

channel: "

examples/vm_power_manager/channel_manager.c +31 -0

+				"'%s'\n",
+				chan_info->channel_path);
+		return -1;
+	}
+	if (add_channel_to_monitor(&chan_info) < 0) {
+		RTE_LOG(ERR, CHANNEL_MANAGER, "Could add channel: "
+				"'%s' to epoll ctl\n",
+				chan_info->channel_path);
+		return -1;
+
+	}
+	chan_info->status = CHANNEL_MGR_CHANNEL_CONNECTED;
+	return 0;
+}
+
 int
 add_all_channels(const char *vm_name)
 {

@@ -470,6 +533,51 @@ add_channels(const char *vm_name, unsigned
 *channel_list,
 	return num_channels_enabled;
 }
 
+int
+add_host_channel(void)
+{
+	struct channel_info *chan_info;
+	char socket_path[PATH_MAX];
+	int num_channels_enabled = 0;
+	int ret;
+
+	snprintf(socket_path, sizeof(socket_path), "%sfifo.%u",
+			CHANNEL_MGR_SOCKET_PATH, 0);
+
+	errno = 0;
+	ret = mkfifo(socket_path, 0666);
+	if ((errno != EEXIST) && (ret < 0)) {
+		printf(" %d %d, %d\n", ret, EEXIST, errno);
+		RTE_LOG(ERR, CHANNEL_MANAGER, "Cannot create fifo '%s'

error: "

examples/vm_power_manager/channel_manager.c +7 -0

+				"%s\n", socket_path, strerror(errno));
+		return 0;
+	}
+
+	errno = 0;
+	if (access(socket_path, F_OK) < 0) {
+		RTE_LOG(ERR, CHANNEL_MANAGER, "Channel path '%s'

error: "

examples/vm_power_manager/channel_manager.c +7 -0

+				"%s\n", socket_path, strerror(errno));
+		return 0;
+	}
+	chan_info = rte_malloc(NULL, sizeof(*chan_info),
+			RTE_CACHE_LINE_SIZE);
+	if (chan_info == NULL) {
+		RTE_LOG(ERR, CHANNEL_MANAGER, "Error allocating

memory for "

examples/vm_power_manager/channel_manager.c +15 -0

+				"channel '%s'\n", socket_path);
+		return 0;
+	}
+	snprintf(chan_info->channel_path,
+			sizeof(chan_info->channel_path), "%sfifo.%u",
+			CHANNEL_MGR_SOCKET_PATH, 0);
+	if (setup_host_channel_info(&chan_info, 0) < 0) {
+		rte_free(chan_info);
+		return 0;
+	}
+	num_channels_enabled++;
+
+	return num_channels_enabled;
+}
+
 int
 remove_channel(struct channel_info **chan_info_dptr)
 {

examples/vm_power_manager/channel_manager.h +6 -1

index 872ec6140..c157cc22b 100644
@@ -37,7 +37,7 @@ struct sockaddr_un _sockaddr_un;
 #define UNIX_PATH_MAX sizeof(_sockaddr_un.sun_path)
 #endif
 
-#define MAX_VMS 4
+#define MAX_VMS 64
 #define MAX_VCPUS 20
 
 

@@ -54,6 +54,11 @@ enum channel_status
 { CHANNEL_MGR_CHANNEL_DISCONNECTED = 0,
 	CHANNEL_MGR_CHANNEL_DISABLED,
 	CHANNEL_MGR_CHANNEL_PROCESSING};
 
+/* Communication Channel Type */
+enum channel_type { CHANNEL_TYPE_BINARY = 0,
+	CHANNEL_TYPE_INI,
+	CHANNEL_TYPE_JSON};
+
 /* VM libvirt(qemu/KVM) connection status */
 enum vm_status { CHANNEL_MGR_VM_INACTIVE = 0,

CHANNEL_MGR_VM_ACTIVE};

examples/vm_power_manager/channel_manager.h +0 -0

@@ -66,6 +71,7 @@ struct channel_info {
 	volatile uint32_t status;    /**< Connection status(enum

channel_status) */

examples/vm_power_manager/channel_manager.h +0 -0

 	int fd;                      /**< AF_UNIX socket fd */
 	unsigned channel_num;        /**<

CHANNEL_MGR_SOCKET_PATH/<vm_name>.channel_num */

examples/vm_power_manager/channel_manager.h +10 -0

+	enum channel_type type;      /**< Binary, ini, json, etc. */
 	void *priv_info;             /**< Pointer to private info, do not modify */
 };

@@ -226,6 +232,15 @@ int add_all_channels(const char *vm_name);
 int add_channels(const char *vm_name, unsigned *channel_list,
 		unsigned num_channels);
 
+/**
+ * Set up a fifo by which host applications can send command an policies
+ * through a fifo to the vm_power_manager
+ *
+ * @return
+ *  - 0 for success
+ */
+int add_host_channel(void);
+
 /**
  * Remove a channel definition from the channel manager. This must only be
  * called from the channel monitor thread.

examples/vm_power_manager/channel_monitor.c +27 -0

index f180d74e6..0ffa1112a 100644
@@ -85,6 +85,33 @@ core_share_status(int pNo)
 	}
 }
 
+
+static int
+pcpu_monitor(struct policy *pol, struct core_info *ci, int pcpu, int count)
+{
+	int ret = 0;
+
+	if (pol->pkt.policy_to_use == BRANCH_RATIO) {
+		ci->cd[pcpu].oob_enabled = 1;
+		ret = add_core_to_monitor(pcpu);
+		if (ret == 0)
+			RTE_LOG(INFO, CHANNEL_MONITOR,
+					"Monitoring pcpu %d OOB for %s\n",
+					pcpu, pol->pkt.vm_name);
+		else
+			RTE_LOG(ERR, CHANNEL_MONITOR,
+					"Error monitoring pcpu %d OOB
 for %s\n",
+					pcpu, pol->pkt.vm_name);
+
+	} else {
+		pol->core_share[count].pcpu = pcpu;
+		RTE_LOG(INFO, CHANNEL_MONITOR,
+				"Monitoring pcpu %d for %s\n",
+				pcpu, pol->pkt.vm_name);
+	}
+	return ret;
+}
+
 static void
 get_pcpu_to_control(struct policy *pol)

{

examples/vm_power_manager/channel_monitor.c +6 -23

@@ -94,34 +121,46 @@ get_pcpu_to_control(struct policy *pol)
 	int pcpu, count;
 	uint64_t mask_u64b;
 	struct core_info *ci;
-	int ret;
 
 	ci = get_core_info();
 
-	RTE_LOG(INFO, CHANNEL_MONITOR, "Looking for pcpu for %s\n",
-			pol->pkt.vm_name);
-	get_info_vm(pol->pkt.vm_name, &info);
-
-	for (count = 0; count < pol->pkt.num_vcpu; count++) {
-		mask_u64b = info.pcpu_mask[pol-
 >pkt.vcpu_to_control[count]];
-		for (pcpu = 0; mask_u64b; mask_u64b &= ~(1ULL << pcpu++))
 {
-			if ((mask_u64b >> pcpu) & 1) {
-				if (pol->pkt.policy_to_use == BRANCH_RATIO)
 {
-					ci->cd[pcpu].oob_enabled = 1;
-					ret = add_core_to_monitor(pcpu);
-					if (ret == 0)
-						printf("Monitoring pcpu %d
 via Branch Ratio\n",
-								pcpu);
-					else
-						printf("Failed to start OOB
 Monitoring pcpu %d\n",
-								pcpu);
-
-				} else {
-					pol->core_share[count].pcpu = pcpu;
-					printf("Monitoring pcpu %d\n", pcpu);
-				}
+	RTE_LOG(INFO, CHANNEL_MONITOR,
+			"Looking for pcpu for %s\n", pol->pkt.vm_name);
+
+	/*
+	 * So now that we're handling virtual and physical cores, we need to
+	 * differenciate between them when adding them to the branch

monitor.

examples/vm_power_manager/channel_monitor.c +16 -0

+	 * Virtual cores need to be converted to physical cores.
+	 */
+
+
+
+
+	if (pol->pkt.core_type == VIRTUAL) {
+		/*
+		 * If the cores in the policy are virtual, we need to map them
+		 * to physical core. We look up the vm info and use that for
+		 * the mapping.
+		 */
+		get_info_vm(pol->pkt.vm_name, &info);
+		for (count = 0; count < pol->pkt.num_vcpu; count++) {
+			mask_u64b =
+				info.pcpu_mask[pol-

Quoted 1 line

pkt.vcpu_to_control[count]];

examples/vm_power_manager/channel_monitor.c +13 -0

+			for (pcpu = 0; mask_u64b;
+					mask_u64b &= ~(1ULL << pcpu++)) {
+				if ((mask_u64b >> pcpu) & 1)
+					pcpu_monitor(pol, ci, pcpu, count);
 			}
 		}
+	} else {
+		/*
+		 * If the cores in the policy are physical, we just use
+		 * those core id's directly.
+		 */
+		for (count = 0; count < pol->pkt.num_vcpu; count++) {
+			pcpu = pol->pkt.vcpu_to_control[count];
+			pcpu_monitor(pol, ci, pcpu, count);
+		}
 	}
 }

examples/vm_power_manager/channel_monitor.c +19 -1

+			/* Copy the contents of *pkt into the policy.pkt */
 			policies[i].pkt = *pkt;
 			get_pcpu_to_control(&policies[i]);
 			if (get_pfid(&policies[i]) == -1) {

@@ -189,6 +233,24 @@ update_policy(struct channel_packet *pkt)
 	return 0;
 }
 
+static int
+remove_policy(struct channel_packet *pkt __rte_unused)
+{
+	int i;
+
+	/*
+	 * Disabling the policy is simply a case of setting
+	 * enabled to 0
+	 */
+	for (i = 0; i < MAX_VMS; i++) {
+		if (strcmp(policies[i].pkt.vm_name, pkt->vm_name) == 0) {
+			policies[i].enabled = 0;
+			return 0;
+		}
+	}
+	return -1;
+}
+
 static uint64_t
 get_pkt_diff(struct policy *pol)
 {

@@ -346,7 +408,6 @@ apply_policy(struct policy *pol)
 		apply_workload_profile(pol);
 }
 
-
 static int
 process_request(struct channel_packet *pkt, struct channel_info
 *chan_info)

{

examples/vm_power_manager/channel_monitor.c +2 -0

@@ -355,6 +416,8 @@ process_request(struct channel_packet *pkt, struct
 channel_info *chan_info)
 	if (chan_info == NULL)
 		return -1;
 
+	RTE_LOG(INFO, CHANNEL_MONITOR, "Processing Request %s\n",
 pkt->vm_name);
+
 	if (rte_atomic32_cmpset(&(chan_info->status),

CHANNEL_MGR_CHANNEL_CONNECTED,

examples/vm_power_manager/channel_monitor.c +0 -1

 			CHANNEL_MGR_CHANNEL_PROCESSING) == 0)
 		return -1;

@@ -362,10 +425,12 @@ process_request(struct channel_packet *pkt,
 struct channel_info *chan_info)
 	if (pkt->command == CPU_POWER) {
 		core_mask = get_pcpus_mask(chan_info, pkt->resource_id);
 		if (core_mask == 0) {
-			RTE_LOG(ERR, CHANNEL_MONITOR, "Error get

physical CPU mask for "

examples/vm_power_manager/channel_monitor.c +0 -1

-				"channel '%s' using vCPU(%u)\n", chan_info-

Quoted 1 line

channel_path,

examples/vm_power_manager/channel_monitor.c +8 -4

-				(unsigned)pkt->unit);
-			return -1;
+			/*
+			 * Core mask will be 0 in the case where
+			 * hypervisor is not available so we're working in
+			 * the host, so use the core as the mask.
+			 */
+			core_mask = 1 << pkt->resource_id;
 		}
 		if (__builtin_popcountll(core_mask) == 1) {

@@ -421,12 +486,20 @@ process_request(struct channel_packet *pkt,
 struct channel_info *chan_info)
 	}
 
 	if (pkt->command == PKT_POLICY) {
-		RTE_LOG(INFO, CHANNEL_MONITOR, "\nProcessing Policy
 request from Guest\n");
+		RTE_LOG(INFO, CHANNEL_MONITOR,
+				"\nProcessing Policy request\n");
 		update_policy(pkt);
 		policy_is_set = 1;
 	}
 
-	/* Return is not checked as channel status may have been set to

DISABLED

examples/vm_power_manager/channel_monitor.c +8 -0

+	if (pkt->command == PKT_POLICY_REMOVE) {
+		RTE_LOG(INFO, CHANNEL_MONITOR,
+				 "Removing policy %s\n", pkt->vm_name);
+		remove_policy(pkt);
+	}
+
+	/*
+	 * Return is not checked as channel status may have been set to

DISABLED

examples/vm_power_manager/channel_monitor.c +0 -0

 	 * from management thread
 	 */
 	rte_atomic32_cmpset(&(chan_info->status),

CHANNEL_MGR_CHANNEL_PROCESSING,

examples/vm_power_manager/channel_monitor.c +4 -1

@@ -448,13 +521,16 @@ add_channel_to_monitor(struct channel_info
 **chan_info)
 				"to epoll\n", info->channel_path);
 		return -1;
 	}
+	RTE_LOG(ERR, CHANNEL_MONITOR, "Added channel '%s' "
+			"to monitor\n", info->channel_path);
 	return 0;
 }
 
 int
 remove_channel_from_monitor(struct channel_info *chan_info)
 {
-	if (epoll_ctl(global_event_fd, EPOLL_CTL_DEL, chan_info->fd, NULL)
 < 0) {
+	if (epoll_ctl(global_event_fd, EPOLL_CTL_DEL,
+			chan_info->fd, NULL) < 0) {
 		RTE_LOG(ERR, CHANNEL_MONITOR, "Unable to remove

channel '%s' "

examples/vm_power_manager/channel_monitor.c +0 -1

 				"from epoll\n", chan_info->channel_path);
 		return -1;

@@ -467,11 +543,13 @@ channel_monitor_init(void)
 {
 	global_event_fd = epoll_create1(0);
 	if (global_event_fd == 0) {
-		RTE_LOG(ERR, CHANNEL_MONITOR, "Error creating epoll

context with "

examples/vm_power_manager/channel_monitor.c +3 -2

-				"error %s\n", strerror(errno));
+		RTE_LOG(ERR, CHANNEL_MONITOR,
+				"Error creating epoll context with error %s\n",
+				strerror(errno));
 		return -1;
 	}
-	global_events_list = rte_malloc("epoll_events",

sizeof(*global_events_list)

examples/vm_power_manager/channel_monitor.c +2 -0

+	global_events_list = rte_malloc("epoll_events",
+			sizeof(*global_events_list)
 			* MAX_EVENTS, RTE_CACHE_LINE_SIZE);
 	if (global_events_list == NULL) {
 		RTE_LOG(ERR, CHANNEL_MONITOR, "Unable to rte_malloc

for "

examples/vm_power_manager/main.c +2 -1

index 58c5fa45c..893bf4cdd 100644
@@ -421,6 +421,8 @@ main(int argc, char **argv)
 		return -1;
 	}
 
+	add_host_channel();
+
 	printf("Running core monitor on lcore id %d\n", lcore_id);
 	rte_eal_remote_launch(run_core_monitor, NULL, lcore_id);
 
--

2.17.1

Quoted 24 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of David Hunt
Sent: Thursday, August 30, 2018 6:54 PM
To: [email protected]
Cc: Mcnamara, John <[email protected]>; Hunt, David <[email protected]>
Subject: [dpdk-dev] [PATCH v1 4/7] examples/power: add host channel to power manager

This patch adds a fifo channel to the vm_power_manager app through which we can send commands and polices. Intended for sending JSON strings. The fifo is at /tmp/powermonitor/fifo.0

Signed-off-by David Hunt <[email protected]>

---
  examples/vm_power_manager/channel_manager.c | 108
+++++++++++++++
  examples/vm_power_manager/channel_manager.h |  17 ++-
  examples/vm_power_manager/channel_monitor.c | 146
+++++++++++++++-----
  examples/vm_power_manager/main.c            |   2 +
  4 files changed, 238 insertions(+), 35 deletions(-)

examples/vm_power_manager/channel_manager.c

Quoted 6 lines

examples/vm_power_manager/channel_manager.c +0 -0

index 2bb8641d3..bcd106be1 100644
@@ -13,6 +13,7 @@

Quoted 5 lines

examples/vm_power_manager/channel_manager.c +0 -0

@@ -160,8 +199,13 @@ update_policy(struct channel_packet *pkt)
  	unsigned int updated = 0;
  	int i;
 

examples/vm_power_manager/channel_manager.c update_policy(struct channel_packet *pkt) · line 207

Quoted 6 lines

examples/vm_power_manager/channel_manager.c +4 -0

+
+	RTE_LOG(INFO, CHANNEL_MONITOR,
+			"Updating policy for %s\n", pkt->vm_name);
+
  	for (i = 0; i < MAX_VMS; i++) {
  		if (strcmp(policies[i].pkt.vm_name, pkt->vm_name) == 0) {

I suggest add warning log here when no VM can match the policy name which we send through the fifo.0. Otherwise, the user can't aware the policy won't be applied.

Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user guide documentation updates.

This patch introduces a new dependency on Jansson, a C library for encoding, decoding and manipulating JSON data. To compile the sample app you now need to have installed libjansson4 and libjansson-dev (these may be named slightly differently depending on your Operating System)

Signed-off-by David Hunt <[email protected]>

Quoted 4 lines · On Thu, 30 Aug 2018 11:54:20 +0100 David Hunt <[email protected]> wrote:

Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user guide documentation updates.

Quoted 6 lines

This patch introduces a new dependency on Jansson, a C library for encoding, decoding and manipulating JSON data. To compile the sample app you now need to have installed libjansson4 and libjansson-dev (these may be named slightly differently depending on your Operating System)

Signed-off-by David Hunt <[email protected]>

If you introduce new dependency then it has to be in documentation, and off by default in Makefile, and checked in meson build.

Quoted 4 lines · On Thu, 30 Aug 2018 11:54:20 +0100 David Hunt <[email protected]> wrote:

Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user guide documentation updates.

Quoted 6 lines

This patch introduces a new dependency on Jansson, a C library for encoding, decoding and manipulating JSON data. To compile the sample app you now need to have installed libjansson4 and libjansson-dev (these may be named slightly differently depending on your Operating System)

Signed-off-by David Hunt <[email protected]>

If you introduce new dependency then it has to be in documentation, and off by default in Makefile, and checked in meson build.

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of David Hunt
Sent: Thursday, August 30, 2018 6:54 PM
To: [email protected]
Cc: Mcnamara, John <[email protected]>; Hunt, David <[email protected]>
Subject: [dpdk-dev] [PATCH v1 6/7] doc/vm_power_manager: add JSON interface API info

Signed-off-by David Hunt <[email protected]>

---
 .../sample_app_ug/vm_power_management.rst     | 195
++++++++++++++++++
 1 file changed, 195 insertions(+)

doc/guides/sample_app_ug/vm_power_management.rst +0 -0

index 855570d6b..13a325eae 100644
@@ -337,6 +337,201 @@ monitoring of branch ratio on cores doing busy

polling via PMDs.
and will need to be adjusted for different workloads.

doc/guides/sample_app_ug/vm_power_management.rst +5 -0

+
+JSON API
+~~~~~~~~
+
+In addition to the command line interface for host command and a virtio-

serial
+interface for VM power policies, there is also a JSON interface through which
+power commands and policies can be sent. Sending a command or policy to the

doc/guides/sample_app_ug/vm_power_management.rst +17 -0

+power manager application is achieved by simply opening a fifo file, writing
+a JSON string to that fifo, and closing the file.
+
+The fifo is at /tmp/powermonitor/fifo.0
+
+The jason string can be a policy or instruction, and takes the following
+format:
+
+  .. code-block:: console
+
+    {"packet_type": {
+      "pair_1": value,
+      "pair_2": value
+    }}
+
+The 'packet_type' header can contain one of two values, depending on
+whether a policy or power command is being sent. The two possible values

are
+"policy" and "instruction", and the expected name-value pairs is different

doc/guides/sample_app_ug/vm_power_management.rst +23 -0

+depending on which type is being sent.
+
+The pairs are the format of standard JSON name-value pairs. The value type
+varies between the different name/value pairs, and may be intgers, strings,
+arrays, etc. Examples of policies follow later in this document. The allowed
+names and value types are as follows:
+
+
+:Pair Name: "name"
+:Description: Name of the VM or Host. Allows the parser to associate the
+  policy with the relevant VM or Host OS.
+:Type: string
+:Values: any valid string
+:Required: yes
+:Example:
+
+  .. code-block:: console
+
+    ""name", "ubuntu2"
+
+
+:Pair Name: "command"
+:Description: The type of packet we're sending to the power manager. We

can be

doc/guides/sample_app_ug/vm_power_management.rst +18 -0

+  creating or destroying a policy, or sending a direct command to adjust
+  the frequency of a core, similar to the command line interface.
+:Type: string
+:Values:
+
+  :"CREATE": used when creating a new policy,
+  :"DESTROY": used when removing a policy,
+  :"POWER": used when sending an immediate command, max, min, etc.
+:Required: yes
+:Example:
+
+    .. code-block:: console
+
+      "command", "CREATE"
+
+
+:Pair Name: "policy_type"
+:Description: Type of policy to apply. Please see vm_power_manager

documentation

doc/guides/sample_app_ug/vm_power_management.rst +34 -0

+  for more information on the types of policies that may be used.
+:Type: string
+:Values:
+
+  :"TIME": Time-of-day policy. Frequencies of the relevant cores are
+    scaled up/down depending on busy and quiet hours.
+  :"TRAFFIC": This policy takes statistics from the NIC and scales up
+    and down accordingly.
+  :"WORKLOAD": This policy looks at how heavily loaded the cores are,
+    and scales up and down accordingly.
+  :"BRANCH_RATIO": This out-of-band policy can look at the ratio between
+    branch hits and misses on a core, and is useful for detecting
+    how much packet processing a core is doing.
+:Required: only for CREATE/DESTROY command
+:Example:
+
+  .. code-block:: console
+
+    "policy_type", "TIME"
+
+:Pair Name: "busy_hours"
+:Description: The hours of the day in which we scale up the cores for busy
+  times.
+:Type: array of integers
+:Values: array with list of hour numbers, (0-23)
+:Required: only for TIME policy
+:Example:
+
+  .. code-block:: console
+
+    "busy_hours":[ 17, 18, 19, 20, 21, 22, 23 ]
+
+:Pair Name: "quiet_hours"
+:Description: The hours of the day in which we scale down the cores for

quiet

+:Pair Name: "core_list"
+:Description: The cores to which to apply the policy. +:Type: array of integers
+:Values: array with list of virtual CPUs. +:Required: only policy CREATE/DESTROY +:Example:

doc/guides/sample_app_ug/vm_power_management.rst +77 -0

+
+  .. code-block:: console
+
+    "core_list":[ 10, 11 ]
+
+:Pair Name: "unit"
+:Description: the type of power operation to apply in the command
+:Type: string
+:Values:
+
+  :"SCALE_MAX": Scale frequency of this core to maximum
+  :"SCALE_MIN": Scale frequency of this core to minimum
+  :"SCALE_UP": Scale up frequency of this core
+  :"SCALE_DOWN": Scale down frequency of this core
+  :"ENABLE_TURBO": Enable Turbo Boost for this core
+  :"DISABLE_TURBO": Disable Turbo Boost for this core
+:Required: only for POWER instruction
+:Example:
+
+  .. code-block:: console
+
+    "unit", "SCALE_MAX"
+
+:Pair Name: "resource_id"
+:Description: The core to which to apply the power command.
+:Type: integer
+:Values: valid core id for VM or host OS.
+:Required: only POWER instruction
+:Example:
+
+  .. code-block:: console
+
+    "resource_id": 10
+
+JSON API Examples
+~~~~~~~~~~~~~~~~~
+
+Profile create example:
+
+  .. code-block:: console
+
+    {"policy": {
+      "name": "ubuntu",
+      "command": "create",
+      "policy_type": "TIME",
+      "busy_hours":[ 17, 18, 19, 20, 21, 22, 23 ],
+      "quiet_hours":[ 2, 3, 4, 5, 6 ],
+      "core_list":[ 11 ]
+    }}
+
+Profile destroy example:
+
+  .. code-block:: console
+
+    {"profile": {
+      "name": "ubuntu",
+      "command": "destroy",
+    }}
+
+Power command example:
+
+  .. code-block:: console
+
+    {"command": {
+      "name": "ubuntu",
+      "unit": "SCALE_MAX",
+      "resource_id": 10
+    }}
+
+To send a JSON string to the Power Manager application, simply paste the
+example JSON string into a text file and cat it into the fifo:
+
+  .. code-block:: console
+
+    cat file.json >/tmp/powermonitor/fifo.0
+
+The console of the Power Manager application should indicate the

command that

doc/guides/sample_app_ug/vm_power_management.rst +2 -1

+was just received via the fifo.
+
 Compiling and Running the Guest Applications
 --------------------------------------------
 
--

2.17.1

Quoted 26 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of David Hunt
Sent: Thursday, August 30, 2018 6:54 PM
To: [email protected]
Cc: Mcnamara, John <[email protected]>; Hunt, David <[email protected]>
Subject: [dpdk-dev] [PATCH v1 6/7] doc/vm_power_manager: add JSON interface API info

Signed-off-by David Hunt <[email protected]>

---
  .../sample_app_ug/vm_power_management.rst     | 195
++++++++++++++++++
  1 file changed, 195 insertions(+)

doc/guides/sample_app_ug/vm_power_management.rst +0 -0

index 855570d6b..13a325eae 100644
@@ -337,6 +337,201 @@ monitoring of branch ratio on cores doing busy

polling via PMDs.
and will need to be adjusted for different workloads.

doc/guides/sample_app_ug/vm_power_management.rst monitoring of branch ratio on cores doing busy polling via PMDs. · line 343

Quoted 4 lines

doc/guides/sample_app_ug/vm_power_management.rst +4 -0

+
+JSON API
+~~~~~~~~
+

Quoted 10 lines

+:Pair Name: "quiet_hours"
+:Description: The hours of the day in which we scale down the cores for quiet

doc/guides/sample_app_ug/vm_power_management.rst +7 -0

+  times.
+:Type: array of integers
+:Values: array with list of hour numbers, (0-23)
+:Required: only for TIME policy
+:Example:
+
+  .. code-block:: console

doc/guides/sample_app_ug/vm_power_management.rst monitoring of branch ratio on cores doing busy polling via PMDs. · line 449

Quoted 3 lines

doc/guides/sample_app_ug/vm_power_management.rst +3 -0

+
+    "quiet_hours":[ 2, 3, 4, 5, 6 ]
+

Do you think we need document following three key here? min_packet_thresh
avg_packet_thresh
max_packet_thresh
I see them in the code but not documented.

Allow vm_power_manager to run without requiring qemu to be present on the machine. This will be required for instances where the JSON interface is used for commands and polices, without any VMs present. A use case for this is a container enviromnent.

Signed-off-by David Hunt <[email protected]>

---

examples/vm_power_manager/channel_monitor.c +0 -0

  	get_all_vm(&noVms, &noVcpus);
 

Quoted 7 lines · David Hunt

Allow vm_power_manager to run without requiring qemu to be present on the machine. This will be required for instances where the JSON interface is used for commands and polices, without any VMs present. A use case for this is a container enviromnent.

Signed-off-by David Hunt <[email protected]>

---

<snip>

examples/vm_power_manager/channel_monitor.c static void · line 69

Quoted 7 lines

examples/vm_power_manager/channel_monitor.c +1 -0

@@ -66,7 +66,7 @@ static void
   core_share_status(int pNo)
   {
   -    int noVms, noVcpus, z, x, t;
+    int noVms = 0, noVcpus = 0, z, x, t;

This looks like a unrelated change?

Quoted 2 lines

examples/vm_power_manager/channel_monitor.c +0 -0

       get_all_vm(&noVms, &noVcpus);
 

Signed-off-by David Hunt <[email protected]>

Quoted 1 line · David Hunt

Signed-off-by David Hunt <[email protected]>

The commit message is not very descriptive as to what these chages are and why they are added.

The changes here are minimal, as the guest app functionality is not changing at all, but there is a new element in the channel_packet struct that needs to have a default set (channel_packet->core_type).

Signed-off-by David Hunt <[email protected]>

---

This patch adds a fifo channel to the vm_power_manager app through which we can send commands and polices. Intended for sending JSON strings. The fifo is at /tmp/powermonitor/fifo.0

Signed-off-by David Hunt <[email protected]>

---

  examples/vm_power_manager/channel_manager.c | 108 +++++++++++++++
  examples/vm_power_manager/channel_manager.h |  17 ++-
  examples/vm_power_manager/channel_monitor.c | 146 +++++++++++++++-----
  examples/vm_power_manager/main.c            |   2 +
  4 files changed, 238 insertions(+), 35 deletions(-)

static int
setup_channel_info(struct virtual_machine_info **vm_info_dptr,
struct channel_info **chan_info_dptr, unsigned channel_num)

examples/vm_power_manager/channel_manager.c +1 -0

@@ -294,6 +327,7 @@ setup_channel_info(struct virtual_machine_info **vm_info_dptr,
  	chan_info->channel_num = channel_num;
  	chan_info->priv_info = (void *)vm_info;
  	chan_info->status = CHANNEL_MGR_CHANNEL_DISCONNECTED;
+	chan_info->type = CHANNEL_TYPE_BINARY;
  	if (open_non_blocking_channel(chan_info) < 0) {
  		RTE_LOG(ERR, CHANNEL_MANAGER, "Could not open channel: "
  				"'%s' for VM '%s'\n",

@@ -316,6 +350,35 @@ setup_channel_info(struct virtual_machine_info **vm_info_dptr,
  	return 0;

examples/vm_power_manager/channel_manager.c +7 -0

+
+	if (open_host_channel(chan_info) < 0) {
+		RTE_LOG(ERR, CHANNEL_MANAGER, "Could not open host channel: "
+				"'%s'\n",
+				chan_info->channel_path);
+		return -1;
+	}

examples/vm_power_manager/channel_manager.c +9 -0

+	if (setup_host_channel_info(&chan_info, 0) < 0) {
+		rte_free(chan_info);
+		return 0;
+	}
+	num_channels_enabled++;
+
+	return num_channels_enabled;
+}
+
  int
  remove_channel(struct channel_info **chan_info_dptr)
  {

examples/vm_power_manager/channel_manager.h +0 -0

index 872ec6140..c157cc22b 100644

examples/vm_power_manager/channel_manager.h +3 -0

+	CHANNEL_TYPE_INI,
+	CHANNEL_TYPE_JSON};
+
  /* VM libvirt(qemu/KVM) connection status */
  enum vm_status { CHANNEL_MGR_VM_INACTIVE = 0, CHANNEL_MGR_VM_ACTIVE};
 

@@ -66,6 +71,7 @@ struct channel_info {
  	volatile uint32_t status;    /**< Connection status(enum channel_status) */

examples/vm_power_manager/channel_manager.h +2 -3

-					pol->core_share[count].pcpu = pcpu;
-					printf("Monitoring pcpu %d\n", pcpu);
-				}
+	RTE_LOG(INFO, CHANNEL_MONITOR,
+			"Looking for pcpu for %s\n", pol->pkt.vm_name);

examples/vm_power_manager/channel_manager.h +7 -0

+	if (pol->pkt.core_type == CORE_TYPE_VIRTUAL) {
+		/*
+		 * If the cores in the policy are virtual, we need to map them
+		 * to physical core. We look up the vm info and use that for
+		 * the mapping.
+		 */
+		get_info_vm(pol->pkt.vm_name, &info);

examples/vm_power_manager/channel_manager.h +0 -0

@@ -362,10 +425,12 @@ process_request(struct channel_packet *pkt, struct channel_info *chan_info)
  	if (pkt->command == CPU_POWER) {
  		core_mask = get_pcpus_mask(chan_info, pkt->resource_id);
  		if (core_mask == 0) {

Quoted 6 lines · David Hunt

This patch adds a fifo channel to the vm_power_manager app through which we can send commands and polices. Intended for sending JSON strings. The fifo is at /tmp/powermonitor/fifo.0

Signed-off-by David Hunt <[email protected]>

---

A bunch of nitpick comments below :)

Quoted 6 lines

examples/vm_power_manager/channel_manager.c | 108 +++++++++++++++ examples/vm_power_manager/channel_manager.h |  17 ++- examples/vm_power_manager/channel_monitor.c | 146 +++++++++++++++----- examples/vm_power_manager/main.c            |   2 +

  4 files changed, 238 insertions(+), 35 deletions(-)

<snip>

Review

Quoted 8 lines

+                "Error(%s) setting non-blocking " +                "socket for '%s'\n",
+                strerror(errno), info->channel_path); +        return -1;
+    }
+    return 0;

(quoted diff) +2 -0

+}
+

As far as i can tell, vm power manager is a proper DPDK application, meaning there can technically be several of these running independently under different prefixes. Hardcoded paths are OK, but you probably need to place a write-lock on a file to prevent another VM power manager from (accidentally) taking over the FIFO? Init would probably fail earlier, but you never know :)

Quoted 19 lines

  static int
  setup_channel_info(struct virtual_machine_info **vm_info_dptr, struct channel_info **chan_info_dptr, unsigned channel_num)

examples/vm_power_manager/channel_manager.c +1 -0

@@ -294,6 +327,7 @@ setup_channel_info(struct virtual_machine_info 
 **vm_info_dptr,
       chan_info->channel_num = channel_num;
       chan_info->priv_info = (void *)vm_info;
       chan_info->status = CHANNEL_MGR_CHANNEL_DISCONNECTED;
+    chan_info->type = CHANNEL_TYPE_BINARY;
       if (open_non_blocking_channel(chan_info) < 0) {

          RTE_LOG(ERR, CHANNEL_MANAGER, "Could not open channel: " "'%s' for VM '%s'\n",

examples/vm_power_manager/channel_manager.c +0 -0

@@ -316,6 +350,35 @@ setup_channel_info(struct virtual_machine_info 
 **vm_info_dptr,
       return 0;
   }

  +static int
+setup_host_channel_info(struct channel_info **chan_info_dptr,

examples/vm_power_manager/channel_manager.c setup_channel_info(struct virtual_machine_info **vm_info_dptr, · line 360

Quoted 6 lines

+        unsigned int channel_num)

examples/vm_power_manager/channel_manager.c +5 -0

+{
+    struct channel_info *chan_info = *chan_info_dptr;
+
+    chan_info->channel_num = channel_num;
+    chan_info->priv_info = (void *)0;

NULL?

Quoted 4 lines

+    chan_info->status = CHANNEL_MGR_CHANNEL_DISCONNECTED; +    chan_info->type = CHANNEL_TYPE_JSON;
+    sprintf(chan_info->channel_path, "%sfifo.0", CHANNEL_MGR_SOCKET_PATH);

Here, 0 is part of the format string...

Quoted 7 lines

+
+    if (open_host_channel(chan_info) < 0) {
+        RTE_LOG(ERR, CHANNEL_MANAGER, "Could not open host channel: " +                "'%s'\n",
+                chan_info->channel_path);
+        return -1;
+    }

<snip>

examples/vm_power_manager/channel_manager.c add_channels(const char *vm_name, unsigned *channel_list, · line 545

Quoted 10 lines

examples/vm_power_manager/channel_manager.c +10 -0

+int
+add_host_channel(void)
+{
+    struct channel_info *chan_info;
+    char socket_path[PATH_MAX];
+    int num_channels_enabled = 0;
+    int ret;
+
+    snprintf(socket_path, sizeof(socket_path), "%sfifo.%u",
+            CHANNEL_MGR_SOCKET_PATH, 0);

...while here, it's an argument. What's the significance of 0 in this context? Also, maybe better to put it in a function, so as to only have one place to fix if anything changes, instead of two?

Quoted 3 lines

+
+    errno = 0;
+    ret = mkfifo(socket_path, 0666);

0666 seems like overly permissive to me?

Quoted 2 lines

+    if ((errno != EEXIST) && (ret < 0)) {
+        printf(" %d %d, %d\n", ret, EEXIST, errno);

This looks like a leftover debug printf?

Also, maybe if (ret < 0 && errno != EEXIST)? I don't think there's a need to set errno beforehand here.

Quoted 6 lines

+        RTE_LOG(ERR, CHANNEL_MANAGER, "Cannot create fifo '%s' error: " +                "%s\n", socket_path, strerror(errno));
+        return 0;
+    }
+
+    errno = 0;

...and here too - if access() call failed, does it not always set errno value?

Quoted 8 lines

+    if (access(socket_path, F_OK) < 0) {
+        RTE_LOG(ERR, CHANNEL_MANAGER, "Channel path '%s' error: " +                "%s\n", socket_path, strerror(errno)); +        return 0;
+    }
+    chan_info = rte_malloc(NULL, sizeof(*chan_info),
+            RTE_CACHE_LINE_SIZE);

0 alignment is equivalent to RTE_CACHE_LINE_SIZE, so no need to specify it explicitly.

Quoted 8 lines

+    if (chan_info == NULL) {
+        RTE_LOG(ERR, CHANNEL_MANAGER, "Error allocating memory for " +                "channel '%s'\n", socket_path);
+        return 0;
+    }
+    snprintf(chan_info->channel_path,
+            sizeof(chan_info->channel_path), "%sfifo.%u", +            CHANNEL_MGR_SOCKET_PATH, 0);

Creating FIFO path again. Definitely needs a function :)

Quoted 15 lines

+    if (setup_host_channel_info(&chan_info, 0) < 0) { +        rte_free(chan_info);
+        return 0;
+    }
+    num_channels_enabled++;

examples/vm_power_manager/channel_manager.c +4 -0

+
+    return num_channels_enabled;
+}
+

  int
  remove_channel(struct channel_info **chan_info_dptr) {

examples/vm_power_manager/channel_manager.h +0 -1

index 872ec6140..c157cc22b 100644
--- a/examples/vm_power_manager/channel_manager.h

Quoted 6 lines

+++ b/examples/vm_power_manager/channel_manager.h

examples/vm_power_manager/channel_manager.h +0 -0

@@ -37,7 +37,7 @@ struct sockaddr_un _sockaddr_un;
   #define UNIX_PATH_MAX sizeof(_sockaddr_un.sun_path)
   #endif

  -#define MAX_VMS 4
+#define MAX_VMS 64

This change probably needs to be called out in commit message and explained. Or broken into a separate commit? Also, i think technically "MAX_VMS" is a bad name now that you're supporting containers as well as VM's. MAX_CLIENTS maybe?

Quoted 6 lines

  #define MAX_VCPUS 20
    @@ -54,6 +54,11 @@ enum channel_status { CHANNEL_MGR_CHANNEL_DISCONNECTED = 0, CHANNEL_MGR_CHANNEL_DISABLED,
      CHANNEL_MGR_CHANNEL_PROCESSING};
  +/* Communication Channel Type */
+enum channel_type { CHANNEL_TYPE_BINARY = 0,

Should probably start values on a new line?

Quoted 7 lines

+    CHANNEL_TYPE_INI,
+    CHANNEL_TYPE_JSON};
+
  /* VM libvirt(qemu/KVM) connection status */
  enum vm_status { CHANNEL_MGR_VM_INACTIVE = 0, CHANNEL_MGR_VM_ACTIVE}; @@ -66,6 +71,7 @@ struct channel_info {
      volatile uint32_t status;    /**< Connection status(enum channel_status) */

<snip>

Quoted 11 lines

- pol->core_share[count].pcpu = pcpu;
-                    printf("Monitoring pcpu %d\n", pcpu); -                }
+    RTE_LOG(INFO, CHANNEL_MONITOR,
+            "Looking for pcpu for %s\n", pol->pkt.vm_name); +
+    /*
+     * So now that we're handling virtual and physical cores, we need to
+     * differenciate between them when adding them to the branch monitor.

examples/vm_power_manager/channel_manager.h

Quoted 6 lines

+     * Virtual cores need to be converted to physical cores. +     */

examples/vm_power_manager/channel_manager.h +4 -0

+
+
+
+

Needs moar newlines :)

Quoted 7 lines

+    if (pol->pkt.core_type == CORE_TYPE_VIRTUAL) {
+        /*
+         * If the cores in the policy are virtual, we need to map them +         * to physical core. We look up the vm info and use that for +         * the mapping.
+         */
+        get_info_vm(pol->pkt.vm_name, &info);

<snip>

Quoted 11 lines

examples/vm_power_manager/channel_manager.h +0 -1

@@ -362,10 +425,12 @@ process_request(struct channel_packet *pkt, 
 struct channel_info *chan_info)
       if (pkt->command == CPU_POWER) {
           core_mask = get_pcpus_mask(chan_info, pkt->resource_id);
           if (core_mask == 0) {
-            RTE_LOG(ERR, CHANNEL_MONITOR, "Error get physical CPU 

mask for "
-                "channel '%s' using vCPU(%u)\n",
chan_info->channel_path,
-                (unsigned)pkt->unit);
-            return -1;

Quoted 6 lines

+            /*
+             * Core mask will be 0 in the case where +             * hypervisor is not available so we're working in +             * the host, so use the core as the mask. +             */
+            core_mask = 1 << pkt->resource_id;

1ULL?

Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user guide documentation updates.

This patch introduces a new dependency on Jansson, a C library for encoding, decoding and manipulating JSON data. To compile the sample app you now need to have installed libjansson4 and libjansson-dev (these may be named slightly differently depending on your Operating System)

Signed-off-by David Hunt <[email protected]>

---

  void channel_monitor_exit(void)
  {
  	run_loop = 0;

examples/vm_power_manager/channel_monitor.c +0 -2

@@ -124,18 +259,11 @@ get_pcpu_to_control(struct policy *pol)
 
  	ci = get_core_info();
 
-	RTE_LOG(INFO, CHANNEL_MONITOR,
-			"Looking for pcpu for %s\n", pol->pkt.vm_name);

examples/vm_power_manager/channel_monitor.c +0 -1

  	if (diff >= (pol->pkt.traffic_policy.max_max_packet_thresh)) {
  		for (count = 0; count < pol->pkt.num_vcpu; count++) {
  			if (pol->core_share[count].status != 1)

@@ -340,9 +466,6 @@ apply_time_profile(struct policy *pol)
  				if (pol->core_share[count].status != 1) {
  					power_manager_scale_core_max(
  						pol->core_share[count].pcpu);
-				RTE_LOG(INFO, CHANNEL_MONITOR,