ice: Do not use WQ_MEM_RECLAIM flag for workqueue
Subsystems (2)
PATCH 1/1 ice: Do not use WQ_MEM_RECLAIM flag for workqueue
When both ice and the irdma driver are loaded, a warning in check_flush_dependency is being triggered. This seems to be because of the ice driver workqueue is allocated with the WQ_MEM_RECLAIM flag, and the irdma one is not.
Looking at the kernel documentation, it doesn't seem like the ice driver needs to use WQ_MEM_RECLAIM. Remove it.
--- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/ice_main.c +1 -1
@@ -5617,7 +5617,7 @@ static int __init ice_module_init(void)pr_info ("%s\n" , ice_driver_string);pr_info ("%s\n" , ice_copyright); - ice_wq =alloc_workqueue ("%s" ,WQ_MEM_RECLAIM ,0 ,KBUILD_MODNAME ); + ice_wq =alloc_workqueue ("%s" ,0 ,0 ,KBUILD_MODNAME );if (!ice_wq) {pr_err ("Failed to create workqueue\n" );return -ENOMEM ;
Signature · 6 lines
2.38.1 _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Tony Nguyen
maintainerOn 11/30/2022 4:34 AM, Marcin Szycik wrote:
I believe Ani is the author for this? I don't see him as the author though.
i.e.
From: Anirudh Venkataramanan <[email protected]>
Quoted 19 lines
When both ice and the irdma driver are loaded, a warning in
check_flush_dependencyis being triggered. This seems to be because of the ice driver workqueue is allocated with theWQ_MEM_RECLAIMflag, and the irdma one is not.Looking at the kernel documentation, it doesn't seem like the ice driver needs to use
WQ_MEM_RECLAIM. Remove it.Signed-off-by Anirudh Venkataramanan <[email protected]>Signed-off-by Marcin Szycik <[email protected]>--- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ethernet/intel/ice/ice_main.c +0
-0
drivers/net/ethernet/intel/ice/ice_main.c static int __init ice_module_init(void) · line 5623
Quoted 8 lines
drivers/net/ethernet/intel/ice/ice_main.c +1
-1@@ -5617,7 +5617,7 @@ static int __init ice_module_init(void)pr_info ("%s\n" , ice_driver_string);pr_info ("%s\n" , ice_copyright); - ice_wq =alloc_workqueue ("%s" ,WQ_MEM_RECLAIM ,0 ,KBUILD_MODNAME ); + ice_wq =alloc_workqueue ("%s" ,0 ,0 ,KBUILD_MODNAME );if (!ice_wq) {pr_err ("Failed to create workqueue\n" );return -ENOMEM ;
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Sorry, my bad. I'll send v2.
Quoted 23 lines · Tony Nguyen
On 11/30/2022 4:34 AM, Marcin Szycik wrote:
I believe Ani is the author for this? I don't see him as the author though.
i.e.
From: Anirudh Venkataramanan <[email protected]>Quoted 14 lines
When both ice and the irdma driver are loaded, a warning in
check_flush_dependencyis being triggered. This seems to be because of the ice driver workqueue is allocated with theWQ_MEM_RECLAIMflag, and the irdma one is not.Looking at the kernel documentation, it doesn't seem like the ice driver needs to use
WQ_MEM_RECLAIM. Remove it.Signed-off-by Anirudh Venkataramanan <[email protected]>Signed-off-by Marcin Szycik <[email protected]>---
drivers/net/ethernet/intel/ice/ice_main.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines
drivers/net/ethernet/intel/ice/ice_main.c static int __init ice_module_init(void) · line 5623
Quoted 12 lines
drivers/net/ethernet/intel/ice/ice_main.c +1
-0@@ -5617,7 +5617,7 @@ static int __init ice_module_init(void) pr_info("%s\n", ice_driver_string); pr_info("%s\n", ice_copyright); - ice_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 0, KBUILD_MODNAME); + ice_wq = alloc_workqueue("%s", 0, 0, KBUILD_MODNAME); if (!ice_wq) { pr_err("Failed to create workqueue\n"); return -ENOMEM;
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan