drm/amdgpu: align between libdrm and drm api
Subsystems (3)
PATCH 1/1 drm/amdgpu: align between libdrm and drm api
define HW_IP_VCN_UNIFIED the same as HW_IP_VCN_ENC
--- include/uapi/drm/amdgpu_drm.h | 1 + 1 file changed, 1 insertion(+)
include/uapi/drm/amdgpu_drm.h +1 -0
@@ -560,6 +560,7 @@ struct drm_amdgpu_gem_va {#define AMDGPU_HW_IP_UVD_ENC 5#define AMDGPU_HW_IP_VCN_DEC 6#define AMDGPU_HW_IP_VCN_ENC 7 +#define AMDGPU_HW_IP_VCN_UNIFIED AMDGPU_HW_IP_VCN_ENC#define AMDGPU_HW_IP_VCN_JPEG 8#define AMDGPU_HW_IP_NUM 9
Signature · 1 line
2.25.1
Am 14.07.22 um 23:22 schrieb Ruijing Dong:
Quoted 1 line
define
HW_IP_VCN_UNIFIEDthe same asHW_IP_VCN_ENC
Usually that should be the other way around, libdrm aligns to the kernel.
Why was that modification committed to libdrm first? There are usually plenty of warnings before we can do that.
Regards,
Christian.
Quoted 18 lines
Signed-off-by Ruijing Dong <[email protected]>--- include/uapi/drm/amdgpu_drm.h | 1 + 1 file changed, 1 insertion(+)include/uapi/drm/amdgpu_drm.h +1
-0@@ -560,6 +560,7 @@ struct drm_amdgpu_gem_va {#define AMDGPU_HW_IP_UVD_ENC 5#define AMDGPU_HW_IP_VCN_DEC 6#define AMDGPU_HW_IP_VCN_ENC 7 +#define AMDGPU_HW_IP_VCN_UNIFIED AMDGPU_HW_IP_VCN_ENC#define AMDGPU_HW_IP_VCN_JPEG 8#define AMDGPU_HW_IP_NUM 9
[AMD Official Use Only - General]
Hi Christian,
You are right, when process the libdrm code review (not committed yet), we realized the corresponding file needs to align to the kernel. So we will need to have this header file changed first, then to process libdrm code again.
Thanks,
Ruijing
-----Original Message-----
From: Christian König <[email protected]>
Sent: Friday, July 15, 2022 4:41 AM
To: Dong, Ruijing <[email protected]>; [email protected]
Cc: Deucher, Alexander <[email protected]>; Liu, Leo <[email protected]>; Koenig, Christian <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: align between libdrm and drm api
Am 14.07.22 um 23:22 schrieb Ruijing Dong:
Quoted 1 line
define
HW_IP_VCN_UNIFIEDthe same asHW_IP_VCN_ENC
Usually that should be the other way around, libdrm aligns to the kernel.
Why was that modification committed to libdrm first? There are usually plenty of warnings before we can do that.
Regards,
Christian.
Quoted 19 lines
Signed-off-by Ruijing Dong <[email protected]>--- include/uapi/drm/amdgpu_drm.h | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/include/uapi/drm/amdgpu_drm.hindex18d3246d636e..fe33db8441bc100644include/uapi/drm/amdgpu_drm.h +1
-0@@ -560,6 +560,7 @@ struct drm_amdgpu_gem_va {#define AMDGPU_HW_IP_UVD_ENC 5#define AMDGPU_HW_IP_VCN_DEC 6#define AMDGPU_HW_IP_VCN_ENC 7 +#define AMDGPU_HW_IP_VCN_UNIFIED AMDGPU_HW_IP_VCN_ENC#define AMDGPU_HW_IP_VCN_JPEG 8#define AMDGPU_HW_IP_NUM 9
Christian König
maintainerHi Ruijing,
ok in this case please prepare a kernel patch and send it to the mailing list with full description why we do this change.
Thanks,
Christian.
Am 15.07.22 um 15:33 schrieb Dong, Ruijing:
Quoted 44 lines
[AMD Official Use Only - General]
Hi Christian,
You are right, when process the libdrm code review (not committed yet), we realized the corresponding file needs to align to the kernel. So we will need to have this header file changed first, then to process libdrm code again.
Thanks,
Ruijing-----Original Message-----
From: Christian König <[email protected]>
Sent: Friday, July 15, 2022 4:41 AM
To: Dong, Ruijing <[email protected]>; [email protected]
Cc: Deucher, Alexander <[email protected]>; Liu, Leo <[email protected]>; Koenig, Christian <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: align between libdrm and drm apiAm 14.07.22 um 23:22 schrieb Ruijing Dong:
Quoted 1 line
define
HW_IP_VCN_UNIFIEDthe same asHW_IP_VCN_ENCUsually that should be the other way around, libdrm aligns to the kernel.
Why was that modification committed to libdrm first? There are usually plenty of warnings before we can do that.
Regards,
Christian.Quoted 18 lines
Signed-off-by Ruijing Dong <[email protected]>--- include/uapi/drm/amdgpu_drm.h | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/include/uapi/drm/amdgpu_drm.hindex18d3246d636e..fe33db8441bc100644include/uapi/drm/amdgpu_drm.h +1
-0@@ -560,6 +560,7 @@ struct drm_amdgpu_gem_va {#define AMDGPU_HW_IP_UVD_ENC 5#define AMDGPU_HW_IP_VCN_DEC 6#define AMDGPU_HW_IP_VCN_ENC 7 +#define AMDGPU_HW_IP_VCN_UNIFIED AMDGPU_HW_IP_VCN_ENC#define AMDGPU_HW_IP_VCN_JPEG 8#define AMDGPU_HW_IP_NUM 9