Skip to contentSkip to conversation

partitions: fix coding style

PATCH In review [email protected] 2 participants 2 messages Dec 14, 2018 Block layer

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 partitions: fix coding style

From: Sungkyung Kim <[email protected]>

Fix coding style of osf.c

Signed-off-by Sungkyung Kim <[email protected]>
---
 block/partitions/osf.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
block/partitions/osf.c +4 -4
index 4b873973d6c0..96921a1e31ce 100644
@@ -22,7 +22,7 @@ int osf_partition(struct parsed_partitions *state)
 	unsigned char *data;
 	struct disklabel {
 		__le32 d_magic;
-		__le16 d_type,d_subtype;
+		__le16 d_type, d_subtype;
 		u8 d_typename[16];
 		u8 d_packname[16];
 		__le32 d_secsize;

@@ -50,8 +50,8 @@ int osf_partition(struct parsed_partitions *state)
 			u8  p_frag;
 			__le16 p_cpg;
 		} d_partitions[MAX_OSF_PARTITIONS];
-	} * label;
-	struct d_partition * partition;
+	} *label;
+	struct d_partition *partition;
 
 	data = read_part_sector(state, 0, &sect);
 	if (!data)

@@ -74,7 +74,7 @@ int osf_partition(struct parsed_partitions *state)
 	}
 	for (i = 0 ; i < npartitions; i++, partition++) {
 		if (slot == state->limit)
-		        break;
+			break;
 		if (le32_to_cpu(partition->p_size))
 			put_partition(state, slot,
 				le32_to_cpu(partition->p_offset),
Signature · 1 line
2.18.0
#1 lore raw
Quoted 23 lines · On 12/14/2018 12:34 PM, [email protected] wrote:

From: Sungkyung Kim <[email protected]>

Fix coding style of osf.c

Signed-off-by Sungkyung Kim <[email protected]>
---
  block/partitions/osf.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
block/partitions/osf.c +1 -1
index 4b873973d6c0..96921a1e31ce 100644
@@ -22,7 +22,7 @@ int osf_partition(struct parsed_partitions *state)
  	unsigned char *data;
  	struct disklabel {
  		__le32 d_magic;
-		__le16 d_type,d_subtype;
+		__le16 d_type, d_subtype;
  		u8 d_typename[16];
  		u8 d_packname[16];
  		__le32 d_secsize;

block/partitions/osf.c int osf_partition(struct parsed_partitions *state) · line 52

Quoted 3 lines
block/partitions/osf.c +0 -0
@@ -50,8 +50,8 @@ int osf_partition(struct parsed_partitions *state)
  			u8  p_frag;
  			__le16 p_cpg;
  		} d_partitions[MAX_OSF_PARTITIONS];

Also include this change as well

block/partitions/osf.c +0 -0
@@ -57,7 +57,7 @@ int osf_partition(struct parsed_partitions *state)

        if (!data)
                return -1;

-       label = (struct disklabel *) (data+64);
+       label = (struct disklabel *) (data + 64);
        partition = label->d_partitions;

would be better a bit more you add in your changelog.

Cheers,
Mukesh

Quoted 16 lines
block/partitions/osf.c +3 -3
-	} * label;
-	struct d_partition * partition;
+	} *label;
+	struct d_partition *partition;
 
  	data = read_part_sector(state, 0, &sect);
  	if (!data)

@@ -74,7 +74,7 @@ int osf_partition(struct parsed_partitions *state)
  	}
  	for (i = 0 ; i < npartitions; i++, partition++) {
  		if (slot == state->limit)
-		        break;
+			break;
  		if (le32_to_cpu(partition->p_size))
  			put_partition(state, slot,
  				le32_to_cpu(partition->p_offset),