tty/serial: atmel: add new version check for usart
Subsystems (3)
PATCH 1/1 tty/serial: atmel: add new version check for usart
On our at91sam9260 based board the usart0 and usart1 ports report their versions (ATMEL_US_VERSION) as 0x10302. This version is not included in the current checks in the driver.
--- drivers/tty/serial/atmel_serial.c | 1 + 1 file changed, 1 insertion(+)
drivers/tty/serial/atmel_serial.c +1 -0
@@ -1734,6 +1734,7 @@ static void atmel_get_ip_name(struct uart_port *port)switch (version) {case 0x302 :case 0x10213 : +case 0x10302 :dev_dbg (port->dev,"This version is usart\n" ); atmel_port->has_frac_baudrate = true; atmel_port->has_hw_timer = true;
Signature · 1 line
2.14.1
Nicolas Ferre
maintainerPATCH 1/1 tty/serial: atmel: add new version check for usart
Quoted 5 lines · Jonas Danielsson
On our at91sam9260 based board the usart0 and usart1 ports report their versions (
ATMEL_US_VERSION) as0x10302. This version is not included in the current checks in the driver.Signed-off-by Jonas Danielsson <[email protected]>
It must be the AT91SAM9260 rev. B SoC, isn't it?
Thanks for your patch.
Best regards,
Nicolas
Quoted 17 lines
--- drivers/tty/serial/atmel_serial.c | 1 + 1 file changed, 1 insertion(+)drivers/tty/serial/atmel_serial.c +1
-0@@ -1734,6 +1734,7 @@ static void atmel_get_ip_name(struct uart_port *port)switch (version) {case 0x302 :case 0x10213 : +case 0x10302 :dev_dbg (port->dev,"This version is usart\n" ); atmel_port->has_frac_baudrate = true; atmel_port->has_hw_timer = true;
Signature · 1 line
Nicolas Ferre
PATCH 1/1 tty/serial: atmel: add new version check for usart
Quoted 7 lines · Nicolas Ferre
Quoted 5 lines · Jonas Danielsson
On our at91sam9260 based board the usart0 and usart1 ports report their versions (
ATMEL_US_VERSION) as0x10302. This version is not included in the current checks in the driver.Signed-off-by Jonas Danielsson <[email protected]>
Quoted 9 lines
Acked-by Nicolas Ferre <[email protected]>It must be the AT91SAM9260 rev. B SoC, isn't it?
Thanks for your patch.
Best regards,
Nicolas
Hi Nicolas!
Thank you for the review!
Yes that is right, we have the rev B SoC :) I Tried to find some documentation online
regarding the US_VERSION register, but fell short.
Allt the best
Jonas
Nicolas Ferre
maintainerPATCH 1/1 tty/serial: atmel: add new version check for usart
Quoted 19 lines · Jonas Danielsson
Quoted 7 lines · Nicolas Ferre
Quoted 5 lines · Jonas Danielsson
On our at91sam9260 based board the usart0 and usart1 ports report their versions (
ATMEL_US_VERSION) as0x10302. This version is not included in the current checks in the driver.Signed-off-by Jonas Danielsson <[email protected]>Quoted 9 lines
Acked-by Nicolas Ferre <[email protected]>It must be the AT91SAM9260 rev. B SoC, isn't it?
Thanks for your patch.
Best regards,
Nicolas
Quoted 7 lines
Hi Nicolas!
Thank you for the review!
Yes that is right, we have the rev B SoC :) I Tried to find some documentation online
regarding theUS_VERSIONregister, but fell short.
It's actually a non-documented register ;-)
In short, bits [0-11] Hardware module version bits [16-18] Metal fix number.
So your at91sam9260 revB benefit from the metal fix #1.
Best regards,
Signature · 1 line
Nicolas Ferre
PATCH 1/1 tty/serial: atmel: add new version check for usart
In reply to Nicolas Ferre2018-02-05 13:36 GMT+01:00 Nicolas Ferre <[email protected]>:
Quoted 9 lines · Jonas Danielsson
Quoted 5 lines
On our at91sam9260 based board the usart0 and usart1 ports report their versions (
ATMEL_US_VERSION) as0x10302. This version is not included in the current checks in the driver.Signed-off-by Jonas Danielsson <[email protected]>Acked-by Nicolas Ferre <[email protected]>
Quoted 6 lines
It must be the AT91SAM9260 rev. B SoC, isn't it?
Thanks for your patch.
Best regards,
Nicolas
Thanks !
Richard.