Skip to contentSkip to conversation

arc: Explicitly include correct DT includes

PATCH In review Rob Herring 3 participants 4 messages Jul 14, 2023 – Aug 24, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arc: Explicitly include correct DT includes

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

---
 arch/arc/plat-axs10x/axs10x.c | 1 -
 1 file changed, 1 deletion(-)
arch/arc/plat-axs10x/axs10x.c +0 -1
index b821df7b0089..1feb990a56bc 100644
@@ -6,7 +6,6 @@
  */
 
 #include <linux/of_fdt.h>
-#include <linux/of_platform.h>
 #include <linux/libfdt.h>
 
 #include <asm/asm-offsets.h>
Signature · 1 line
2.40.1
#1 lore raw
Quoted 9 lines · Rob Herring

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

Quoted 4 lines
---
 arch/arc/plat-axs10x/axs10x.c | 1 -
 1 file changed, 1 deletion(-)

Ping!

Quoted 16 lines
arch/arc/plat-axs10x/axs10x.c +0 -1
index b821df7b0089..1feb990a56bc 100644
@@ -6,7 +6,6 @@
  */
 
 #include <linux/of_fdt.h>
-#include <linux/of_platform.h>
 #include <linux/libfdt.h>
 
 #include <asm/asm-offsets.h>
Signature · 1 line
2.40.1
Tested-by
#2 lore raw

Hi Rob,

Quoted 10 lines · Rob Herring
Quoted 9 lines

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

Quoted 6 lines
Quoted 4 lines
---
 arch/arc/plat-axs10x/axs10x.c | 1 -
 1 file changed, 1 deletion(-)

Ping!

Thanks for the enhancement!

Quoted 9 lines
Quoted 9 lines
arch/arc/plat-axs10x/axs10x.c +0 -0
index b821df7b0089..1feb990a56bc 100644
@@ -6,7 +6,6 @@
  */
 
Quoted 8 lines
Quoted 8 lines
arch/arc/plat-axs10x/axs10x.c +0 -2
 #include <linux/of_fdt.h>
-#include <linux/of_platform.h>
 #include <linux/libfdt.h>
 
 #include <asm/asm-offsets.h>
--

2.40.1

_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

maintainer
#3 lore raw
In reply to Rob Herring
Quoted 10 lines · Rob Herring
Quoted 9 lines · Rob Herring

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

Quoted 5 lines
Quoted 4 lines
---
  arch/arc/plat-axs10x/axs10x.c | 1 -
  1 file changed, 1 deletion(-)

Ping!

Sorry this fell through cracks, added to for-curr now !

Thx,
-Vineet

_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc