Skip to contentSkip to conversation

MIPS: prefer 'unsigned int' to bare use of 'unsigned'

PATCH In review [email protected] 3 participants 3 messages Jul 9, 2023 – Jul 25, 2023 1 message not in the archive MIPS

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 MIPS: prefer 'unsigned int' to bare use of 'unsigned'

Fix the following warnings reported by checkpatch:

arch/mips/kernel/linux32.c:128: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

---
 arch/mips/kernel/linux32.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/mips/kernel/linux32.c +2 -2
index 6b61be486303..4bd52b38dd00 100644
@@ -125,8 +125,8 @@ asmlinkage long sys32_fadvise64_64(int fd, int __pad,
             flags);
 }
 
-asmlinkage long sys32_fallocate(int fd, int mode, unsigned offset_a2,
-    unsigned offset_a3, unsigned len_a4, unsigned len_a5)
+asmlinkage long sys32_fallocate(int fd, int mode, unsigned int offset_a2,
+    unsigned int offset_a3, unsigned int len_a4, unsigned int len_a5)
 {
     return ksys_fallocate(fd, mode, merge_64(offset_a2, offset_a3),
                   merge_64(len_a4, len_a5));
Reviewed-by on v1 1/1
#2 lore raw
Quoted 11 lines · On 9/7/23 16:19, [email protected] wrote:

Fix the following warnings reported by checkpatch:

arch/mips/kernel/linux32.c:128: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

---
  arch/mips/kernel/linux32.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
#3 lore raw
In reply to [email protected]
Quoted 21 lines · On Sun, Jul 09, 2023 at 10:19:50PM +0800, [email protected] wrote:

Fix the following warnings reported by checkpatch:

arch/mips/kernel/linux32.c:128: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

---
 arch/mips/kernel/linux32.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/mips/kernel/linux32.c +0 -0
index 6b61be486303..4bd52b38dd00 100644

arch/mips/kernel/linux32.c asmlinkage long sys32_fadvise64_64(int fd, int __pad, · line 132

Quoted 10 lines
arch/mips/kernel/linux32.c +2 -2
@@ -125,8 +125,8 @@ asmlinkage long sys32_fadvise64_64(int fd, int __pad,
             flags);
 }
 
-asmlinkage long sys32_fallocate(int fd, int mode, unsigned offset_a2,
-    unsigned offset_a3, unsigned len_a4, unsigned len_a5)
+asmlinkage long sys32_fallocate(int fd, int mode, unsigned int offset_a2,
+    unsigned int offset_a3, unsigned int len_a4, unsigned int len_a5)
 {
     return ksys_fallocate(fd, mode, merge_64(offset_a2, offset_a3),
                   merge_64(len_a4, len_a5));

this is white-space damaged, please resend with that corrected.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]