platform/x86: think-lmi: Fix "Call Trace" error warning
Subsystems (3)
PATCH 1/1 platform/x86: think-lmi: Fix "Call Trace" error warning
From: goutongchen <[email protected]>
The maximum BIOS password length returned by the Lenovo platform BIOS/WMI exceeded the size assumed by the think_lmi driver's internal static buffer, causing the driver to trigger a WARN_ON() during self-checks.
Increase TLMI_PWD_BUFSIZE from 128 to 256 to eliminate the recurring Call Trace warnings.
Here is the kernel warning triggered by the bug:
kernel: WARNING: CPU: 4 PID: 665 at drivers/platform/x86/think-lmi.c:326
kernel: tlmi_get_pwd_settings.constprop.0+0xe6/0x130 [think_lmi]
kernel: Call Trace:
kernel: tlmi_analyze+0x31c/0x640 [think_lmi]
...
--- drivers/platform/x86/lenovo/think-lmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/lenovo/think-lmi.h +1 -1
@@ -8,7 +8,7 @@#define TLMI_SETTINGS_COUNT 256#define TLMI_SETTINGS_MAXLEN 512 -#define TLMI_PWD_BUFSIZE 129 +#define TLMI_PWD_BUFSIZE 256#define TLMI_LANG_MAXLEN 4#define TLMI_INDEX_MAX 32
Signature · 1 line
2.20.1
Mark Pearson
maintainerHi
Quoted 11 lines · On Tue, Jul 7, 2026, at 5:15 AM, [email protected] wrote:
From: goutongchen <[email protected]>
The maximum BIOS password length returned by the Lenovo platform BIOS/WMI exceeded the size assumed by the
think_lmidriver's internal static buffer, causing the driver to trigger aWARN_ON()during self-checks.Increase
TLMI_PWD_BUFSIZEfrom 128 to 256 to eliminate the recurring Call Trace warnings.Here is the kernel warning triggered by the bug:
Quoted 7 lines
kernel: WARNING: CPU: 4 PID: 665 at
drivers/platform/x86/think-lmi.c:326
kernel: tlmi_get_pwd_settings.constprop.0+0xe6/0x130 [think_lmi]
kernel: Call Trace:
kernel:tlmi_analyze+0x31c/0x640[think_lmi]
...Fixes 651b57dd4087 ("platform/x86: Move Lenovo files into lenovo subdir")
Minor - but I don't think this is really the culprit :)
Quoted 21 lines
Signed-off-by goutongchen <[email protected]>--- drivers/platform/x86/lenovo/think-lmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/lenovo/think-lmi.h +1
-1@@ -8,7 +8,7 @@#define TLMI_SETTINGS_COUNT 256#define TLMI_SETTINGS_MAXLEN 512 -#define TLMI_PWD_BUFSIZE 129 +#define TLMI_PWD_BUFSIZE 256#define TLMI_LANG_MAXLEN 4#define TLMI_INDEX_MAX 32Signature · 1 line
2.20.1
Which platform are you seeing this on please? The maxlen for passwords from the BIOS is supposed to be 128 so I'm intrigued as to where you're seeing different. It maybe should be fixed in a platform BIOS?
Mark
On 7/7/26 21:31, Mark Pearson wrote:
Hi
Quoted 14 lines
Hi
Quoted 11 lines · On Tue, Jul 7, 2026, at 5:15 AM, [email protected] wrote:
From: goutongchen <[email protected]>
The maximum BIOS password length returned by the Lenovo platform BIOS/WMI exceeded the size assumed by the
think_lmidriver's internal static buffer, causing the driver to trigger aWARN_ON()during self-checks.Increase
TLMI_PWD_BUFSIZEfrom 128 to 256 to eliminate the recurring Call Trace warnings.Here is the kernel warning triggered by the bug:
Quoted 8 lines
Quoted 7 lines
kernel: WARNING: CPU: 4 PID: 665 at drivers/platform/x86/think-lmi.c:326 kernel: tlmi_get_pwd_settings.constprop.0+0xe6/0x130 [think_lmi] kernel: Call Trace: kernel: tlmi_analyze+0x31c/0x640 [think_lmi] ...Fixes 651b57dd4087 ("platform/x86: Move Lenovo files into lenovo subdir")Minor - but I don't think this is really the culprit :)
Gou Tongchen - Because it was initially discovered on an older kernel version, the path hadn't been changed at that time.
Quoted 20 lines
Quoted 20 lines
Signed-off-by goutongchen <[email protected]>--- drivers/platform/x86/lenovo/think-lmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/lenovo/think-lmi.h +1
-1@@ -8,7 +8,7 @@#define TLMI_SETTINGS_COUNT 256#define TLMI_SETTINGS_MAXLEN 512 -#define TLMI_PWD_BUFSIZE 129 +#define TLMI_PWD_BUFSIZE 256#define TLMI_LANG_MAXLEN 4#define TLMI_INDEX_MAX 32
Quoted 5 lines
Quoted 2 lines
Signature · 1 line
2.20.1Which platform are you seeing this on please? The maxlen for passwords from the BIOS is supposed to be 128 so I'm intrigued as to where you're seeing different. It maybe should be fixed in a platform BIOS?
Mark
The hardware platform is a Lenovo X7h with a Hygon 4 CPU. The specific model and BIOS version are as follows:
kernel: DMI: KaiTian /LXKT-HG4M-X7, BIOS W0WKT1FA 11/18/2025
I found through kernel log printing that the BIOS returned a password length of 255, so I increased TLMI_PWD_BUFSIZE to 256.
Thanks.
Gou Tongchen
Quoted 1 line
Ilpo Järvinen
maintainerQuoted 20 lines · Gou Tongchen
Quoted 19 lines · Mark Pearson
Quoted 18 lines · On Tue, Jul 7, 2026, at 5:15 AM, [email protected] wrote:
From: goutongchen <[email protected]>
The maximum BIOS password length returned by the Lenovo platform BIOS/WMI exceeded the size assumed by the
think_lmidriver's internal static buffer, causing the driver to trigger aWARN_ON()during self-checks.Increase
TLMI_PWD_BUFSIZEfrom 128 to 256 to eliminate the recurring Call Trace warnings.Here is the kernel warning triggered by the bug:
kernel: WARNING: CPU: 4 PID: 665 at
drivers/platform/x86/think-lmi.c:326
kernel: tlmi_get_pwd_settings.constprop.0+0xe6/0x130 [think_lmi]
kernel: Call Trace:kernel: tlmi_analyze+0x31c/0x640 [think_lmi] ...
Quoted 5 lines
Quoted 2 lines
Quoted 1 line
Fixes 651b57dd4087 ("platform/x86: Move Lenovo files into lenovo subdir")Minor - but I don't think this is really the culprit :)
Gou Tongchen - Because it was initially discovered on an older kernel version, the path hadn't been changed at that time.
Please try to find the commit past that. You can use e.g.
git annotate 651b57dd4087^
to start annotating from right before that commit.
Quoted 25 lines
Quoted 25 lines
Quoted 21 lines
Signed-off-by goutongchen <[email protected]>--- drivers/platform/x86/lenovo/think-lmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/lenovo/think-lmi.h +1
-1@@ -8,7 +8,7 @@#define TLMI_SETTINGS_COUNT 256#define TLMI_SETTINGS_MAXLEN 512 -#define TLMI_PWD_BUFSIZE 129 +#define TLMI_PWD_BUFSIZE 256#define TLMI_LANG_MAXLEN 4#define TLMI_INDEX_MAX 32Signature · 1 line
2.20.1Which platform are you seeing this on please? The maxlen for passwords from the BIOS is supposed to be 128 so I'm intrigued as to where you're seeing different. It maybe should be fixed in a platform BIOS?
Quoted 6 lines
Quoted 1 line
Mark
The hardware platform is a Lenovo X7h with a Hygon 4 CPU. The specific model and BIOS version are as follows:
kernel: DMI: KaiTian /LXKT-HG4M-X7, BIOS W0WKT1FA 11/18/2025
This kind of information should be in the changelog, but lets wait a bit if Mark wants to check this internally.
We'll probably need to make this change anyway to avoid triggering the WARN_ON() even if it would be fixed by some version of the BIOS.
Quoted 2 lines
I found through kernel log printing that the BIOS returned a password length of 255, so I increased TLMI_PWD_BUFSIZE to 256.
Signature · 1 line
i.
Quoted 1 line · On Tue, Jul 07, 2026 at 05:15:55PM +0800, [email protected] wrote:
From: goutongchen <[email protected]>
Use your real name and not an alias.
Quoted 1 line
The maximum BIOS password length returned by the Lenovo platform BIOS/WMI
Which platform? We need more details about the BIOS/HW.
Quoted 8 lines
exceeded the size assumed by the
think_lmidriver's internal static buffer, causing the driver to trigger aWARN_ON()during self-checks.Increase
TLMI_PWD_BUFSIZEfrom 128 to 256 to eliminate the recurring Call Trace warnings.Here is the kernel warning triggered by the bug:
Quoted 8 lines
kernel: WARNING: CPU: 4 PID: 665 at
drivers/platform/x86/think-lmi.c:326
kernel: tlmi_get_pwd_settings.constprop.0+0xe6/0x130 [think_lmi]
kernel: Call Trace:
kernel:tlmi_analyze+0x31c/0x640[think_lmi]
...Fixes 651b57dd4087 ("platform/x86: Move Lenovo files into lenovo subdir")Signed-off-by goutongchen <[email protected]>
Ditto.
Signature · 2 lines
With Best Regards, Andy Shevchenko