Skip to contentSkip to conversation

use generic_file_buffered_read()

PATCH In review Bean Huo 2 participants 5 messages Sep 4, 2020 – Sep 7, 2020

Subsystems (2)
lore
Share & tools
lore

Bean Huo

author
#0 lore raw

cover use generic_file_buffered_read()

From: Bean Huo <[email protected]>

Bean Huo (2):
block: use generic_file_buffered_read()
fs: isofs: use generic_file_buffered_read()

 drivers/block/sunvdc.c | 6 +++---
 fs/isofs/compress.c    | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 1/2 block: use generic_file_buffered_read()

From: Bean Huo <[email protected]>

do_generic_file_read() has been renamed to generic_file_buffered_read() since commit 47c27bc46946 ("fs: pass iocb to do_generic_file_read").

---
 drivers/block/sunvdc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/block/sunvdc.c +3 -3
index 39aeebc6837d..06262e990c9b 100644
@@ -1017,9 +1017,9 @@ static int vdc_port_probe(struct vio_dev *vdev, const struct vio_device_id *id)
 			 VDCBLK_NAME "%c", 'a' + ((int)vdev->dev_no % 26));
 	port->vdisk_size = -1;
 
-	/* Actual wall time may be double due to do_generic_file_read() doing
-	 * a readahead I/O first, and once that fails it will try to read a
-	 * single page.
+	/* Actual wall time may be double due to generic_file_buffered_read()
+	 * doing a readahead I/O first, and once that fails it will try to read
+	 * a single page.
 	 */
 	ldc_timeout = mdesc_get_property(hp, vdev->mp, "vdc-timeout", NULL);
 	port->ldc_timeout = ldc_timeout ? *ldc_timeout : 0;
Signature · 1 line
2.17.1
author
#2 lore raw

PATCH 2/2 fs: isofs: use generic_file_buffered_read()

In reply to Bean Huo

From: Bean Huo <[email protected]>

do_generic_file_read() has been renamed to generic_file_buffered_read() since commit 47c27bc46946 ("fs: pass iocb to do_generic_file_read").

---
 fs/isofs/compress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/isofs/compress.c +1 -1
index bc12ac7e2312..7541581c1064 100644
@@ -312,7 +312,7 @@ static int zisofs_readpage(struct file *file, struct page *page)
 	end_index = (inode->i_size + PAGE_SIZE - 1) >> PAGE_SHIFT;
 	/*
 	 * If this page is wholly outside i_size we just return zero;
-	 * do_generic_file_read() will handle this for us
+	 * generic_file_buffered_read() will handle this for us
 	 */
 	if (index >= end_index) {
 		SetPageUptodate(page);
Signature · 1 line
2.17.1
maintainer
#3 lore raw
In reply to Bean Huo
Quoted 6 lines · Bean Huo

From: Bean Huo <[email protected]>

Bean Huo (2):
block: use generic_file_buffered_read()
fs: isofs: use generic_file_buffered_read()

The change is fine, but the title/commit message should reflect that this is just a comment change. The way it currently reads, it sounds like a functional change where something is switched over to using generic_file_buffered_read().

Signature · 1 line
Jens Axboe
author
#4 lore raw
Quoted 9 lines · Jens Axboe
Quoted 3 lines

Bean Huo (2):
block: use generic_file_buffered_read()
fs: isofs: use generic_file_buffered_read()

The change is fine, but the title/commit message should reflect that this is just a comment change. The way it currently reads, it sounds like a functional change where something is switched over to using generic_file_buffered_read().

Hi Jens
Indeed, it's easy to mistake this for a functional change, but it's actually a comment change. I have corrected them in the new patch, you can check now.

thanks,
Bean