Skip to contentSkip to conversation

io_uring: add support for sqe links

bug report Dan Carpenter 2 participants 5 messages May 27, 2019 VFS

lore
Share & tools
lore
#0 lore raw

Hello Jens Axboe,

The patch f3fafe4103bd: "io_uring: add support for sqe links" from May 10, 2019, leads to the following static checker warning:

	fs/io_uring.c:623 io_req_link_next()
	error: potential NULL dereference 'nxt'.

fs/io_uring.c
614 static void io_req_link_next(struct io_kiocb *req) 615 {
616 struct io_kiocb *nxt;
617
618 nxt = list_first_entry_or_null(&req->link_list, struct io_kiocb, list);

   619          list_del(&nxt->list);
                          ^^^^^^^^^

The warning is a false positive but this is a NULL dereference.

620 if (!list_empty(&req->link_list)) {

   621                  INIT_LIST_HEAD(&nxt->link_list);
                                        ^^^^^

False positive.

622 list_splice(&req->link_list, &nxt->link_list);
623 nxt->flags |= REQ_F_LINK;
624 }
625

   626          INIT_WORK(&nxt->work, io_sq_wq_submit_work);
                          ^^^^^^^^^^
   627          queue_work(req->ctx->sqo_wq, &nxt->work);
                                             ^^^^^^^^^^

Other bugs.

628 }

regards,
dan carpenter

#1 lore raw
Quoted 16 lines · Dan Carpenter

Hello Jens Axboe,

The patch f3fafe4103bd: "io_uring: add support for sqe links" from May 10, 2019, leads to the following static checker warning:

	fs/io_uring.c:623 io_req_link_next()
	error: potential NULL dereference 'nxt'.

fs/io_uring.c

    614  static void io_req_link_next(struct io_kiocb *req)
    615  {
    616          struct io_kiocb *nxt;
    617
    618          nxt = list_first_entry_or_null(&req->link_list, struct io_kiocb, list);
    619          list_del(&nxt->list);
                           ^^^^^^^^^
Quoted 6 lines

The warning is a false positive but this is a NULL dereference.

    620          if (!list_empty(&req->link_list)) {
    621                  INIT_LIST_HEAD(&nxt->link_list);
                                         ^^^^^

False positive.

Both of them are false positives. I can work around them though, as it probably makes it a bit cleaner, too.

Quoted 10 lines
    622                  list_splice(&req->link_list, &nxt->link_list);
    623                  nxt->flags |= REQ_F_LINK;
    624          }
    625
    626          INIT_WORK(&nxt->work, io_sq_wq_submit_work);
                           ^^^^^^^^^^
    627          queue_work(req->ctx->sqo_wq, &nxt->work);
                                              ^^^^^^^^^^

Other bugs.

Not sure what that means?

Signature · 1 line
Jens Axboe
#2 lore raw
Quoted 9 lines · Jens Axboe
Quoted 8 lines · Dan Carpenter

Hello Jens Axboe,

The patch f3fafe4103bd: "io_uring: add support for sqe links" from May 10, 2019, leads to the following static checker warning:

	fs/io_uring.c:623 io_req_link_next()
	error: potential NULL dereference 'nxt'.
Quoted 6 lines
Quoted 6 lines

fs/io_uring.c

    614  static void io_req_link_next(struct io_kiocb *req)
    615  {
    616          struct io_kiocb *nxt;
    617
    618          nxt = list_first_entry_or_null(&req->link_list, struct io_kiocb, list);
                                                    ^^^^^^^^^^^^^^^

If this list is empty then "nxt" is NULL.

Quoted 5 lines
Quoted 5 lines
    619          list_del(&nxt->list);
                           ^^^^^^^^^

The warning is a false positive but this is a NULL dereference.

    620          if (!list_empty(&req->link_list)) {
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

We're checking for list_empty() here.

Quoted 18 lines
Quoted 3 lines
    621                  INIT_LIST_HEAD(&nxt->link_list);
                                         ^^^^^

False positive.

Both of them are false positives. I can work around them though, as it probably makes it a bit cleaner, too.

Quoted 10 lines
    622                  list_splice(&req->link_list, &nxt->link_list);
    623                  nxt->flags |= REQ_F_LINK;
    624          }
    625
    626          INIT_WORK(&nxt->work, io_sq_wq_submit_work);
                           ^^^^^^^^^^
    627          queue_work(req->ctx->sqo_wq, &nxt->work);
                                              ^^^^^^^^^^

Other bugs.

Quoted 1 line

Not sure what that means?

All these dereferences outside the if not empty check are a problem.

regards,
dan carpenter

#3 lore raw
Quoted 10 lines · Dan Carpenter
Quoted 9 lines · Jens Axboe
Quoted 8 lines · Dan Carpenter

Hello Jens Axboe,

The patch f3fafe4103bd: "io_uring: add support for sqe links" from May 10, 2019, leads to the following static checker warning:

	fs/io_uring.c:623 io_req_link_next()
	error: potential NULL dereference 'nxt'.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines

fs/io_uring.c

     614  static void io_req_link_next(struct io_kiocb *req)
     615  {
     616          struct io_kiocb *nxt;
     617
     618          nxt = list_first_entry_or_null(&req->link_list, struct io_kiocb, list);
                                                     ^^^^^^^^^^^^^^^

If this list is empty then "nxt" is NULL.

Right...

Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
     619          list_del(&nxt->list);
                            ^^^^^^^^^

The warning is a false positive but this is a NULL dereference.

     620          if (!list_empty(&req->link_list)) {
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

We're checking for list_empty() here.

After deleting an entry from it.

Quoted 18 lines
Quoted 18 lines
Quoted 3 lines
     621                  INIT_LIST_HEAD(&nxt->link_list);
                                          ^^^^^

False positive.

Both of them are false positives. I can work around them though, as it probably makes it a bit cleaner, too.

Quoted 10 lines
     622                  list_splice(&req->link_list, &nxt->link_list);
     623                  nxt->flags |= REQ_F_LINK;
     624          }
     625
     626          INIT_WORK(&nxt->work, io_sq_wq_submit_work);
                            ^^^^^^^^^^
     627          queue_work(req->ctx->sqo_wq, &nxt->work);
                                               ^^^^^^^^^^

Other bugs.

Quoted 3 lines
Quoted 1 line

Not sure what that means?

All these dereferences outside the if not empty check are a problem.

But this is the same thing If 'nxt' can ever be NULL, it's a problem. If it cannot, then it's a false positive.

I'll just add a check. It should not happen, but it probably can if the chain is messed up.

Signature · 1 line
Jens Axboe
#4 lore raw
Quoted 26 lines · Jens Axboe
Quoted 10 lines · Dan Carpenter
Quoted 9 lines · Jens Axboe
Quoted 8 lines · Dan Carpenter

Hello Jens Axboe,

The patch f3fafe4103bd: "io_uring: add support for sqe links" from May 10, 2019, leads to the following static checker warning:

	fs/io_uring.c:623 io_req_link_next()
	error: potential NULL dereference 'nxt'.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines

fs/io_uring.c

     614  static void io_req_link_next(struct io_kiocb *req)
     615  {
     616          struct io_kiocb *nxt;
     617
     618          nxt = list_first_entry_or_null(&req->link_list, struct io_kiocb, list);
                                                     ^^^^^^^^^^^^^^^

If this list is empty then "nxt" is NULL.

Right...

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
     619          list_del(&nxt->list);
                            ^^^^^^^^^

The warning is a false positive but this is a NULL dereference.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
     620          if (!list_empty(&req->link_list)) {
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

We're checking for list_empty() here.

After deleting an entry from it.

Ah... Right. Sorry.

regards,
dan carpenter