makedumpfile: cope with not-present mem section
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): 20200120085919.GB16539@MiWiFi-R3L-srv
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): TY2PR01MB5210FAB04501E6C59AAB2B06DD0F0@TY2PR01MB5210.jpnprd01.prod.outlook.com
A message that is not in the archive (sent off-list or not yet received): 20200127170447.GA4080@calabresa
A message that is not in the archive (sent off-list or not yet received): 20200127180627.GB4080@calabresa
A message that is not in the archive (sent off-list or not yet received): TY2PR01MB521005B2E72D78C4561C0562DD0A0@TY2PR01MB5210.jpnprd01.prod.outlook.com
A message that is not in the archive (sent off-list or not yet received): 20200128193302.GC4080@calabresa
Hi Kazu and Cascardo,
I encounter a weird problem when running makedumpfile on a s390 machine.
Our production kernel uses extreme sparse memory model, and has the following:
in mm/sparse.c
#ifdef CONFIG_SPARSEMEM_EXTREME
struct mem_section **mem_section;
#else
struct mem_section mem_section[NR_SECTION_ROOTS][SECTIONS_PER_ROOT]
____cacheline_internodealigned_in_smp;
#endif
So in makedumpfile.c, get_mem_section(), it got a failed result when the first call site to validate_mem_section(), then it should success at the second call site to validate_mem_section(), which is inside if (is_sparsemem_extreme()) condition.
But the actual result is not like expected.
After introducing
commit e113f1c974c820f9633dc0073eda525d7575f365 [PATCH] cope with
not-present mem section
I got two successful calls to validate_mem_section(), and finally failed at the condition
ret = symbol_valid ^ pointer_valid;
if (!ret) {
ERRMSG("Could not validate mem_section.\n");
}Do you have any idea?
Thanks,
Pingfan
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Hi Pingfan,
Quoted 14 lines
-----Original Message-----
Hi Kazu and Cascardo,I encounter a weird problem when running makedumpfile on a s390 machine.
Our production kernel uses extreme sparse memory model, and has the following:
in
mm/sparse.c#ifdef
CONFIG_SPARSEMEM_EXTREME
structmem_section**mem_section;
#else
structmem_sectionmem_section[NR_SECTION_ROOTS][SECTIONS_PER_ROOT]
Quoted 7 lines
____cacheline_internodealigned_in_smp;#endif
So in
makedumpfile.c,get_mem_section(), it got a failed result when the first call site tovalidate_mem_section(), then it should success at the second call site tovalidate_mem_section(), which is inside if (is_sparsemem_extreme()) condition.
I think your production kernel should have kernel commit a0b1280368d1 ("kdump: write correct address of mem_section into vmcoreinfo"), so the first call should return TRUE and the second one should return FALSE.
Quoted 9 lines
But the actual result is not like expected.
After introducing
commite113f1c974c820f9633dc0073eda525d7575f365[PATCH] cope with
not-present mem sectionI got two successful calls to
validate_mem_section(), and finally failed at the condition
Quoted 7 lines
ret = symbol_valid ^ pointer_valid; if (!ret) { ERRMSG("Could not validate mem_section.\n"); }Do you have any idea?
Presumably this will be what I expected that it might be possible. I can apply the patch below this time, what about this?
https://github.com/k-hagio/makedumpfile-old/commit/ce883df3864a5744ac0f1eff47de06b5074edb5f.patch
or, we can also investigate why the second call returns TRUE, and fix the conditions in the validate_mem_section()..
Thanks,
Kazu
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Quoted 19 lines · HAGIO KAZUHITO(萩尾 一仁)
Hi Pingfan,
Quoted 17 lines
-----Original Message-----
Hi Kazu and Cascardo,I encounter a weird problem when running makedumpfile on a s390 machine.
Our production kernel uses extreme sparse memory model, and has the following:
in
mm/sparse.c#ifdef
CONFIG_SPARSEMEM_EXTREME
structmem_section**mem_section;
#else
structmem_sectionmem_section[NR_SECTION_ROOTS][SECTIONS_PER_ROOT]____cacheline_internodealigned_in_smp;#endif
Quoted 8 lines
Quoted 4 lines
So in
makedumpfile.c,get_mem_section(), it got a failed result when the first call site tovalidate_mem_section(), then it should success at the second call site tovalidate_mem_section(), which is inside if (is_sparsemem_extreme()) condition.I think your production kernel should have kernel commit
a0b1280368d1("kdump: write correct address ofmem_sectioninto vmcoreinfo"), so the first call should return TRUE and the second one should return FALSE.
Yes, it is.
Quoted 16 lines
Quoted 16 lines
But the actual result is not like expected.
After introducing
commite113f1c974c820f9633dc0073eda525d7575f365[PATCH] cope with
not-present mem sectionI got two successful calls to
validate_mem_section(), and finally failed at the conditionret = symbol_valid ^ pointer_valid; if (!ret) { ERRMSG("Could not validate mem_section.\n"); }
Quoted 5 lines
Quoted 1 line
Do you have any idea?
Presumably this will be what I expected that it might be possible. I can apply the patch below this time, what about this?
https://github.com/k-hagio/makedumpfile-old/commit/ce883df3864a5744ac0f1eff47de06b5074edb5f.patch
looks good.
Quoted 3 lines
or, we can also investigate why the second call returns TRUE, and fix the conditions in the
validate_mem_section()..
This is due to the relaxed condition check after applying my commit commit e113f1c974("[PATCH] cope with not-present mem section")
makedumpfile.c +0 -0
@@ -3406,8 +3406,6 @@ section_mem_map_addr(unsigned long addr, unsigned
long *map_mask)
map = ULONG(mem_section + OFFSET(mem_section.section_mem_map));
mask = SECTION_MAP_MASK;
*map_mask = map & ~mask;
- if (map == 0x0)
- *map_mask |= SECTION_MARKED_PRESENT;
map &= mask;
free(mem_section);@@ -3453,10 +3451,8 @@ validate_mem_section(unsigned long *mem_sec,
mem_map = NOT_MEMMAP_ADDR;
} else {
mem_map = section_mem_map_addr(section, &map_mask);
+ /* for either no mem_map or hot-removed */
if (!(map_mask & SECTION_MARKED_PRESENT)) {
- return FALSE; ------> a strict check
- }
- if (mem_map == 0) {
mem_map = NOT_MEMMAP_ADDR;
} else {
mem_map = sparse_decode_mem_map(mem_map,Before my patch, it return FALSE for any non NULL value without SECTION_MARKED_PRESENT. But my patch relaxes the restriction and consider it as hot-removed mem_section and keeps the parsing on.
Thanks,
Pingfan
Quoted 8 lines
Thanks,
Kazu
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Quoted 46 lines
-----Original Message-----
Quoted 19 lines · HAGIO KAZUHITO
Hi Pingfan,
Quoted 17 lines
-----Original Message-----
Hi Kazu and Cascardo,I encounter a weird problem when running makedumpfile on a s390 machine.
Our production kernel uses extreme sparse memory model, and has the following:
in
mm/sparse.c#ifdef
CONFIG_SPARSEMEM_EXTREME
structmem_section**mem_section;
#else
structmem_sectionmem_section[NR_SECTION_ROOTS][SECTIONS_PER_ROOT]____cacheline_internodealigned_in_smp;#endif
Quoted 8 lines
Quoted 4 lines
So in
makedumpfile.c,get_mem_section(), it got a failed result when the first call site tovalidate_mem_section(), then it should success at the second call site tovalidate_mem_section(), which is inside if (is_sparsemem_extreme()) condition.I think your production kernel should have kernel commit
a0b1280368d1("kdump: write correct address ofmem_sectioninto vmcoreinfo"), so the first call should return TRUE and the second one should return FALSE.Yes, it is.
Quoted 16 lines
Quoted 16 lines
But the actual result is not like expected.
After introducing
commite113f1c974c820f9633dc0073eda525d7575f365[PATCH] cope with
not-present mem sectionI got two successful calls to
validate_mem_section(), and finally failed at the conditionret = symbol_valid ^ pointer_valid; if (!ret) { ERRMSG("Could not validate mem_section.\n"); }
Quoted 6 lines
Quoted 5 lines
Quoted 1 line
Do you have any idea?
Presumably this will be what I expected that it might be possible. I can apply the patch below this time, what about this?
https://github.com/k-hagio/makedumpfile-old/commit/ce883df3864a5744ac0f1eff47de06b5074edb5f.patchlooks good.
Thanks.
Quoted 34 lines
Quoted 3 lines
or, we can also investigate why the second call returns TRUE, and fix the conditions in the
validate_mem_section()..This is due to the relaxed condition check after applying my commit commit
e113f1c974("[PATCH] cope with not-present mem section")makedumpfile.c +1
-5@@ -3406,8 +3406,6 @@ section_mem_map_addr(unsigned long addr, unsigned long *map_mask) map =ULONG (mem_section +OFFSET (mem_section.section_mem_map)); mask =SECTION_MAP_MASK ; *map_mask = map & ~mask; -if (map ==0x0 ) - *map_mask |=SECTION_MARKED_PRESENT ; map &= mask;free (mem_section);@@ -3453,10 +3451,8 @@ validate_mem_section(unsigned long *mem_sec, mem_map =NOT_MEMMAP_ADDR ; }else { mem_map =section_mem_map_addr (section, &map_mask); +/* for either no mem_map or hot-removed */ if (!(map_mask &SECTION_MARKED_PRESENT )) { - return FALSE; ------> a strict check - } -if (mem_map ==0 ) { mem_map =NOT_MEMMAP_ADDR ; }else { mem_map = sparse_decode_mem_map(mem_map,
Quoted 3 lines
Before my patch, it return FALSE for any non NULL value without
SECTION_MARKED_PRESENT. But my patch relaxes the restriction and consider it as hot-removedmem_sectionand keeps the parsing on.
Yes, so I meant that we might add some conditions so that the second call could return FALSE for your vmcore as expected. But I decided to apply the patch I wrote before.. and applied:
https://github.com/makedumpfile/makedumpfile/commit/81b79c514ff6fc881f1df4cb04ecb2d7cb22badc
I deferred merging this at that time because it might not be needed actually and I didn't want to change the behavior if possible. But it happened.
Thank you for the report.
Kazu
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec