Skip to contentSkip to conversation

linux-firmware: Add qcom-qcm6490-{audio,compute} firmware packages

PATCH Vivek Puar 2 participants 3 messages Oct 25, 2024 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Vivek Puar

author
#1 lore raw

Hi Richard,

Can you please review this?

Quoted 52 lines · Vivek Puar

linux-firmware-qcom-qcm6490-{audio,compute} contains ADSP and CDSP firmware for qcom QCM6490 variant

---
  .../linux-firmware/linux-firmware_20241017.bb          | 10 ++++++++--
  1 file changed, 8 insertions(+), 2 deletions(-)
meta/recipes-kernel/linux-firmware/linux-firmware_20241017.bb +8 -3
index d18e7414db..60d24efca4 100644
@@ -408,8 +408,8 @@ PACKAGES =+ "${PN}-amphion-vpu-license ${PN}-amphion-vpu \
               ${PN}-qcom-apq8016-modem ${PN}-qcom-apq8016-wifi \
               ${PN}-qcom-apq8096-adreno ${PN}-qcom-apq8096-audio ${PN}-qcom-apq8096-modem \
               ${PN}-qcom-qcm2290-adreno ${PN}-qcom-qcm2290-audio ${PN}-qcom-qcm2290-modem \
-             ${PN}-qcom-qrb4210-adreno ${PN}-qcom-qrb4210-audio ${PN}-qcom-qrb4210-compute \
-             ${PN}-qcom-qrb4210-modem \
+             ${PN}-qcom-qcm6490-audio ${PN}-qcom-qcm6490-compute ${PN}-qcom-qrb4210-adreno \
+             ${PN}-qcom-qrb4210-audio ${PN}-qcom-qrb4210-compute ${PN}-qcom-qrb4210-modem \
               ${PN}-qcom-sc8280xp-lenovo-x13s-compat \
               ${PN}-qcom-sc8280xp-lenovo-x13s-audio \
               ${PN}-qcom-sc8280xp-lenovo-x13s-adreno \
@@ -1442,6 +1442,8 @@ LICENSE:${PN}-qcom-qcm2290-adreno = "Firmware-qcom"
  LICENSE:${PN}-qcom-qcm2290-audio = "Firmware-qcom"
  LICENSE:${PN}-qcom-qcm2290-modem = "Firmware-qcom"
  LICENSE:${PN}-qcom-qcm2290-wifi = "Firmware-qcom"
+LICENSE:${PN}-qcom-qcm6490-audio = "Firmware-qcom"
+LICENSE:${PN}-qcom-qcm6490-compute  = "Firmware-qcom"
  LICENSE:${PN}-qcom-qrb4210-adreno = "Firmware-qcom"
  LICENSE:${PN}-qcom-qrb4210-audio = "Firmware-qcom"
  LICENSE:${PN}-qcom-qrb4210-compute  = "Firmware-qcom"
@@ -1494,6 +1496,8 @@ FILES:${PN}-qcom-qcm2290-adreno = "${nonarch_base_libdir}/firmware/qcom/qcm2290/
  FILES:${PN}-qcom-qcm2290-audio = "${nonarch_base_libdir}/firmware/qcom/qcm2290/adsp*.*"
  FILES:${PN}-qcom-qcm2290-modem = "${nonarch_base_libdir}/firmware/qcom/qcm2290/modem*.*"
  FILES:${PN}-qcom-qcm2290-wifi = "${nonarch_base_libdir}/firmware/qcom/qcm2290/wlanmdsp.mbn* ${nonarch_base_libdir}/firmware/ath10k/WCN3990/hw1.0/qcm2290/*"
+FILES:${PN}-qcom-qcm6490-audio = "${nonarch_base_libdir}/firmware/qcom/qcm6490/adsp*.*"
+FILES:${PN}-qcom-qcm6490-compute = "${nonarch_base_libdir}/firmware/qcom/qcm6490/cdsp*.*"
  FILES:${PN}-qcom-qrb4210-adreno = "${nonarch_base_libdir}/firmware/qcom/qrb4210/a610_zap.mbn*"
  FILES:${PN}-qcom-qrb4210-audio = "${nonarch_base_libdir}/firmware/qcom/qrb4210/adsp*.*"
  FILES:${PN}-qcom-qrb4210-compute = "${nonarch_base_libdir}/firmware/qcom/qrb4210/cdsp*.*"
@@ -1542,6 +1546,8 @@ RDEPENDS:${PN}-qcom-qcm2290-adreno = "${PN}-qcom-license"
  RDEPENDS:${PN}-qcom-qcm2290-audio = "${PN}-qcom-license"
  RDEPENDS:${PN}-qcom-qcm2290-modem = "${PN}-qcom-license"
  RDEPENDS:${PN}-qcom-qcm2290-wifi = "${PN}-qcom-license"
+RDEPENDS:${PN}-qcom-qcm6490-audio = "${PN}-qcom-license"
+RDEPENDS:${PN}-qcom-qcm6490-compute = "${PN}-qcom-license"
  RDEPENDS:${PN}-qcom-qrb4210-adreno = "${PN}-qcom-license"
  RDEPENDS:${PN}-qcom-qrb4210-audio = "${PN}-qcom-license"
  RDEPENDS:${PN}-qcom-qrb4210-compute = "${PN}-qcom-license"
 
-=-=-=-=-=-=-=-=-=-=-=-
Quoted 6 lines

Links: You receive all messages sent to this group.
View/Reply Online (#206170): https://lists.openembedded.org/g/openembedded-core/message/206170
Mute This Topic: https://lists.openembedded.org/mt/109156111/8903276
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Regards,

Vivek

#2 lore raw

Hi Vivek,

Quoted 4 lines · Vivek Puar via lists.openembedded.org

Hi Richard,

Can you please review this?

Please be patient, you literally gave the community one working day (on European timezone) to review this. It's a bit fast to ping people, especially on non-critical pieces of code like this one (non-critical because this could be done in your own layer via a bbappend until it gets merged upstream).

Cheers,
Quentin

author
#3 lore raw

Hi Quentin,

Thank you for the response, I understand this and will keep in mind next time.

Quoted 5 lines · Quentin Schulz

Hi Vivek,

Quoted 2 lines · Vivek Puar via lists.openembedded.org

Hi Richard,

Quoted 7 lines
Quoted 2 lines

Can you please review this?

Please be patient, you literally gave the community one working day (on European timezone) to review this. It's a bit fast to ping people, especially on non-critical pieces of code like this one (non-critical because this could be done in your own layer via a bbappend until it gets merged upstream).

Cheers,
Quentin

Regards,
Vivek