Skip to contentSkip to conversation

hv: put parentheses on macros with complex values in hyperv.h

PATCH New [email protected] 2 participants 3 messages Jul 20, 2023 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 hv: put parentheses on macros with complex values in hyperv.h

Fix "Macros with complex values should be enclosed in parentheses" checkpatch error.

---
 include/linux/hyperv.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/hyperv.h +2 -2
index bfbc37ce223b..6f6fdc7cf086 100644
@@ -428,9 +428,9 @@ union vmpacket_largest_possible_header {
 	struct vmdata_gpa_direct data_gpa_direct_hdr;
 };
 
-#define VMPACKET_DATA_START_ADDRESS(__packet)	\
+#define VMPACKET_DATA_START_ADDRESS((__packet)	\
 	(void *)(((unsigned char *)__packet) +	\
-	 ((struct vmpacket_descriptor)__packet)->offset8 * 8)
+	 ((struct vmpacket_descriptor)__packet)->offset8 * 8))
 
 #define VMPACKET_DATA_LENGTH(__packet)		\
 	((((struct vmpacket_descriptor)__packet)->len8 -	\
#2 lore raw
kernel test robot noticed the following build errors:

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on sailus-media-tree/streams v6.5-rc2 next-20230719] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/sunran001-208suo-com/hv-put-parentheses-on-macros-with-complex-values-in-hyperv-h/20230720-110337
base:   linus/master
patch link:    https://lore.kernel.org/r/e4b504ab6a1534cd26be777c9cb0bb6a%40208suo.com
patch subject: [PATCH] hv: put parentheses on macros with complex values in hyperv.h
config: x86_64-buildonly-randconfig-r003-20230720 (https://download.01.org/0day-ci/archive/20230720/[email protected]/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230720/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

In file included from arch/x86/include/asm/kvm_host.h:27,

                    from include/linux/kvm_host.h:45,
                    from arch/x86/kvm/svm/nested.c:18:
>> include/linux/hyperv.h:431:37: error: expected parameter name, found "("
     431 | #define VMPACKET_DATA_START_ADDRESS((__packet)  \
         |                                     ^

vim +431 include/linux/hyperv.h

430

 > 431	#define VMPACKET_DATA_START_ADDRESS((__packet)	\

432 (void *)(((unsigned char *)__packet) + \
433 ((struct vmpacket_descriptor)__packet)->offset8 * 8))
434

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#3 lore raw
In reply to [email protected]
kernel test robot noticed the following build errors:

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on sailus-media-tree/streams v6.5-rc2 next-20230720] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/sunran001-208suo-com/hv-put-parentheses-on-macros-with-complex-values-in-hyperv-h/20230720-110337
base:   linus/master
patch link:    https://lore.kernel.org/r/e4b504ab6a1534cd26be777c9cb0bb6a%40208suo.com
patch subject: [PATCH] hv: put parentheses on macros with complex values in hyperv.h
config: i386-randconfig-i013-20230720 (https://download.01.org/0day-ci/archive/20230720/[email protected]/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce: (https://download.01.org/0day-ci/archive/20230720/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

In file included from arch/x86/events/intel/core.c:17:
In file included from include/linux/kvm_host.h:45:
In file included from arch/x86/include/asm/kvm_host.h:27:

>> include/linux/hyperv.h:431:37: error: invalid token in macro parameter list
   #define VMPACKET_DATA_START_ADDRESS((__packet)  \
                                       ^

1 error generated.

vim +431 include/linux/hyperv.h

430

 > 431	#define VMPACKET_DATA_START_ADDRESS((__packet)	\

432 (void *)(((unsigned char *)__packet) + \
433 ((struct vmpacket_descriptor)__packet)->offset8 * 8))
434

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki