platform/x86: x86-android-tablets: Fix Bluetooth on Lenovo Yoga Book
PATCH 1/2 platform/x86: x86-android-tablets: Fix Bluetooth on Lenovo Yoga Book
The Lenovo Yoga Book yb1-x90f/l has (another) bug in its DSDT where the UART resource for the BTH0 ACPI device contains "\\_SB.PCIO.URT1" as path to the UART.
Note that is with a letter 'O' instead of the number '0' which is wrong.
Add a x86_serdev_info entry to make the x86-android-tablets module manually setup the /sys/bus/serial device for the Bluetooth UART to fix Bluetooth not working due to this bug.
--- drivers/platform/x86/x86-android-tablets/lenovo.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
drivers/platform/x86/x86-android-tablets/lenovo.c +15 -0
@@ -147,6 +147,19 @@ static const struct platform_device_info lenovo_yb1_x90_pdevs[] __initconst = { }, }; +/* +* DSDT says UART path is "\\_SB.PCIO.URT1" with a letter 'O' instead of +* the number '0' add the link manually. +*/ +static const struct x86_serdev_info lenovo_yb1_x90_serdevs[]__initconst = { + { + .ctrl_hid ="8086228A" , + .ctrl_uid ="1" , + .ctrl_devname ="serial0" , + .serdev_hid ="BCM2E1A" , + }, +}; +static struct gpiod_lookup_table lenovo_yb1_x90_goodix_gpios = { .dev_id ="i2c-goodix_ts" , .table = {
@@ -203,6 +216,8 @@ const struct x86_dev_info lenovo_yogabook_x90_info __initconst = { .i2c_client_count = ARRAY_SIZE(lenovo_yb1_x90_i2c_clients), .pdev_info = lenovo_yb1_x90_pdevs, .pdev_count = ARRAY_SIZE(lenovo_yb1_x90_pdevs), + .serdev_info = lenovo_yb1_x90_serdevs, + .serdev_count = ARRAY_SIZE(lenovo_yb1_x90_serdevs), .gpiod_lookup_tables = lenovo_yb1_x90_gpios, .init = lenovo_yb1_x90_init, };
Signature · 1 line
2.39.2
PATCH 2/2 platform/x86: x86-android-tablets: Add Lenovo Yoga Book lid switch
Add x86_gpio_button info for the yb1-x90f/l describing the lid switch on the Lenovo Yoga Book Android models.
--- drivers/platform/x86/x86-android-tablets/lenovo.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
drivers/platform/x86/x86-android-tablets/lenovo.c +14 -0
@@ -160,6 +160,19 @@ static const struct x86_serdev_info lenovo_yb1_x90_serdevs[] __initconst = { }, }; +static struct x86_gpio_button lenovo_yb1_x90_lid = { + .button = { + .code =SW_LID , + .active_low = true, + .desc ="lid_sw" , + .type =EV_SW , + .wakeup = true, + .debounce_interval =50 , + }, + .chip ="INT33FF:02" , + .pin =19 , +}; +static struct gpiod_lookup_table lenovo_yb1_x90_goodix_gpios = { .dev_id ="i2c-goodix_ts" , .table = {
@@ -218,6 +231,7 @@ const struct x86_dev_info lenovo_yogabook_x90_info __initconst = { .pdev_count = ARRAY_SIZE(lenovo_yb1_x90_pdevs), .serdev_info = lenovo_yb1_x90_serdevs, .serdev_count = ARRAY_SIZE(lenovo_yb1_x90_serdevs), + .gpio_button = &lenovo_yb1_x90_lid, .gpiod_lookup_tables = lenovo_yb1_x90_gpios, .init = lenovo_yb1_x90_init, };
Signature · 1 line
2.39.2
Hi,
Quoted 11 lines · Hans de Goede
The Lenovo Yoga Book yb1-x90f/l has (another) bug in its DSDT where the UART resource for the BTH0 ACPI device contains "\\_SB.PCIO.URT1" as path to the UART.
Note that is with a letter 'O' instead of the number '0' which is wrong.
Add a
x86_serdev_infoentry to make the x86-android-tablets module manually setup the/sys/bus/serialdevice for the Bluetooth UART to fix Bluetooth not working due to this bug.Signed-off-by Hans de Goede <[email protected]>
I've added this series to my review-hans (soon to be for-next) branch now.
Regards,
Hans
Quoted 37 lines
--- drivers/platform/x86/x86-android-tablets/lenovo.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)drivers/platform/x86/x86-android-tablets/lenovo.c +15
-0@@ -147,6 +147,19 @@ static const struct platform_device_info lenovo_yb1_x90_pdevs[] __initconst = { }, }; +/* +* DSDT says UART path is "\\_SB.PCIO.URT1" with a letter 'O' instead of +* the number '0' add the link manually. +*/ +static const struct x86_serdev_info lenovo_yb1_x90_serdevs[]__initconst = { + { + .ctrl_hid ="8086228A" , + .ctrl_uid ="1" , + .ctrl_devname ="serial0" , + .serdev_hid ="BCM2E1A" , + }, +}; +static struct gpiod_lookup_table lenovo_yb1_x90_goodix_gpios = { .dev_id ="i2c-goodix_ts" , .table = {@@ -203,6 +216,8 @@ const struct x86_dev_info lenovo_yogabook_x90_info __initconst = { .i2c_client_count = ARRAY_SIZE(lenovo_yb1_x90_i2c_clients), .pdev_info = lenovo_yb1_x90_pdevs, .pdev_count = ARRAY_SIZE(lenovo_yb1_x90_pdevs), + .serdev_info = lenovo_yb1_x90_serdevs, + .serdev_count = ARRAY_SIZE(lenovo_yb1_x90_serdevs), .gpiod_lookup_tables = lenovo_yb1_x90_gpios, .init = lenovo_yb1_x90_init, };