package/proftpd: prevent openssl pthread detection
PATCH v2 1/1 package/proftpd: prevent openssl pthread detection
Openssl cmdline executable can be used as a config test which results in either the host-openssl or host system's openssl being used to detect the linking with -pthread. This is an issue as a system maybe building with a toolchain without thread support. (To review the detection logic, see proftpd configure.in and search for pr_use_pthread_for_openssl)
Fixes
http://autobuild.buildroot.net/results/9c25c3cb3cf93b76c0538c5376a803641bf6575b
---
To recreate the failure, with a clean build.
make host-openssl proftpd
Changes
v1 -> v2
[Arnout
- Noted the inhert dependency that was going on and suggested the configure step fix to prevent the openssl flag detection leading to the -pthread being added the the linker flags.
--- package/proftpd/proftpd.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/proftpd/proftpd.mk +2 -1
@@ -22,7 +22,8 @@ PROFTPD_CONF_OPTS = \ --disable-dso \ --enable-sendfile \ --enable-shadow \ - --with-gnu-ld + --with-gnu-ld \ + --without-openssl-cmdline ifeq ($(BR2_PACKAGE_PROFTPD_MOD_REWRITE),y) PROFTPD_MODULES += mod_rewrite
Signature · 1 line
1.9.1
PATCH v2 1/1 package/proftpd: prevent openssl pthread detection
Quoted 6 lines · Matt Weber
Openssl cmdline executable can be used as a config test which results in either the host-openssl or host system's openssl being used to detect the linking with -pthread. This is an issue as a system maybe building with a toolchain without thread support. (To review the detection logic, see proftpd configure.in and search for
pr_use_pthread_for_openssl)
I noticed a potential issue: now pthread never gets linked in, even if openssl
is built with thread support and when linking statically.
However, it turns out that that is not a problem because openssl (at least in
the version we use) doesn't pull in its thread support automatically.
So, I completely rewrote the commit message and applied to master, thanks.
Quoted 2 lines
Fixes
Could you in the future add a colon after Fixes: so patchwork picks it up and
marks it with the 'Fixes' tag?
Regards,
Arnout
Quoted 32 lines
http://autobuild.buildroot.net/results/9c25c3cb3cf93b76c0538c5376a803641bf6575b
Signed-off-by Matthew Weber <[email protected]>---
To recreate the failure, with a clean build.
make host-openssl proftpdChanges
v1 -> v2
[Arnout
- Noted the inhert dependency that was going on and suggested the configure step fix to prevent the openssl flag detection leading to the -pthread being added the the linker flags.--- package/proftpd/proftpd.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/proftpd/proftpd.mk +2
-1@@ -22,7 +22,8 @@ PROFTPD_CONF_OPTS = \ --disable-dso \ --enable-sendfile \ --enable-shadow \ - --with-gnu-ld + --with-gnu-ld \ + --without-openssl-cmdline ifeq ($(BR2_PACKAGE_PROFTPD_MOD_REWRITE),y) PROFTPD_MODULES += mod_rewrite
PATCH v2 1/1 package/proftpd: prevent openssl pthread detection
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle <[email protected]> writes:
Quoted 6 lines · Matt Weber
Openssl cmdline executable can be used as a config test which results in either the host-openssl or host system's openssl being used to detect the linking with -pthread. This is an issue as a system maybe building with a toolchain without thread support. (To review the detection logic, see proftpd configure.in and search for
pr_use_pthread_for_openssl)
Quoted 7 lines
I noticed a potential issue: now pthread never gets linked in, even if openssl
is built with thread support and when linking statically.However, it turns out that that is not a problem because openssl (at least in
the version we use) doesn't pull in its thread support automatically.So, I completely rewrote the commit message and applied to master, thanks.
Committed to 2018.02.x and 2018.11.x, thanks.
I did a test build on 2018.02.x to verify.
Signature · 1 line
Bye, Peter Korsgaard