drm/i915/psr: Use hw.adjusted mode when calculating io/fast wake times
Subsystems (3)
PATCH 1/1 drm/i915/psr: Use hw.adjusted mode when calculating io/fast wake times
Encoder compute config is changing hw.adjusted mode. Uapi.adjusted mode doesn't get updated before psr compute config gets called. This causes io and fast wake line calculation using adjusted mode containing values before encoder adjustments. Fix this by using hw.adjusted mode instead of uapi.adjusted mode.
--- drivers/gpu/drm/i915/display/intel_psr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_psr.c +2 -2
@@ -1044,9 +1044,9 @@ static bool _compute_psr2_wake_times(struct intel_dp *intel_dp, } io_wake_lines =intel_usecs_to_scanlines ( - &crtc_state->uapi.adjusted_mode, io_wake_time); + &crtc_state->hw.adjusted_mode, io_wake_time); fast_wake_lines =intel_usecs_to_scanlines ( - &crtc_state->uapi.adjusted_mode, fast_wake_time); + &crtc_state->hw.adjusted_mode, fast_wake_time);if (io_wake_lines > max_wake_lines || fast_wake_lines > max_wake_lines)
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Use hw.adjusted mode when calculating io/fast wake times
== Series Details ==
== Series Details ==
Series: drm/i915/psr: Use hw.adjusted mode when calculating io/fast wake times
URL : https://patchwork.freedesktop.org/series/119580/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13293 -> Patchwork_119580v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/index.html
Participating hosts (42 -> 42)
------------------------------
Additional (1): fi-kbl-soraka
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_119580v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-adlp-11: NOTRUN -> [SKIP][1] ([i915#7456])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-adlp-11/igt@[email protected]
* igt@gem_exec_suspend@basic-s0@smem:
- bat-rpls-1: NOTRUN -> [FAIL][2] ([fdo#103375] / [i915#8011])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-rpls-1/igt@gem_exec_suspend@[email protected]
* igt@gem_exec_suspend@basic-s3@smem:
- bat-rpls-1: NOTRUN -> [FAIL][3] ([fdo#103375])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-rpls-1/igt@gem_exec_suspend@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/fi-kbl-soraka/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/fi-kbl-soraka/igt@[email protected]
* igt@gem_tiled_pread_basic:
- bat-adlp-11: NOTRUN -> [SKIP][6] ([i915#3282])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-adlp-11/igt@gem_tiled_pread_basic.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][7] ([i915#5334] / [i915#7872])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][8] ([i915#1886] / [i915#7913])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@requests:
- bat-mtlp-8: [PASS][9] -> [DMESG-FAIL][10] ([i915#8497])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/bat-mtlp-8/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-mtlp-8/igt@i915_selftest@[email protected]
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-1: [PASS][11] -> [FAIL][12] ([fdo#103375])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/bat-rpls-1/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-rpls-1/igt@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- bat-atsm-1: NOTRUN -> [SKIP][13] ([i915#6645])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-atsm-1/igt@[email protected]
* igt@kms_chamelium_frames@hdmi-crc-fast:
- bat-adlp-11: NOTRUN -> [SKIP][14] ([i915#7828]) +7 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-adlp-11/igt@[email protected]
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-adlp-9: NOTRUN -> [SKIP][15] ([i915#7828])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-adlp-9/igt@[email protected]
- bat-atsm-1: NOTRUN -> [SKIP][16] ([i915#6078])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-atsm-1/igt@[email protected]
- bat-rpls-1: NOTRUN -> [SKIP][17] ([i915#7828])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-rpls-1/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-kbl-soraka: NOTRUN -> [SKIP][18] ([fdo#109271]) +14 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/fi-kbl-soraka/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-adlp-11: NOTRUN -> [SKIP][19] ([i915#4103]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-adlp-11/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- bat-adlp-11: NOTRUN -> [ABORT][20] ([i915#4423])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-adlp-11/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [PASS][21] -> [FAIL][22] ([i915#7932])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-atsm-1: NOTRUN -> [SKIP][23] ([i915#1836])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-atsm-1/igt@[email protected]
- bat-rpls-1: NOTRUN -> [SKIP][24] ([i915#1845])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-rpls-1/igt@[email protected]
* igt@kms_setmode@basic-clone-single-crtc:
- fi-kbl-soraka: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#4579])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/fi-kbl-soraka/igt@[email protected]
#### Possible fixes ####
* igt@core_auth@basic-auth:
- bat-adlp-11: [ABORT][26] ([i915#8011]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/bat-adlp-11/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-adlp-11/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-engines@lmem0:
- bat-atsm-1: [INCOMPLETE][28] ([i915#7967]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/bat-atsm-1/igt@gem_lmem_swapping@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-atsm-1/igt@gem_lmem_swapping@[email protected]
* igt@i915_module_load@load:
- bat-adlp-11: [DMESG-WARN][30] ([i915#4423]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/bat-adlp-11/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-adlp-11/igt@[email protected]
* igt@i915_selftest@live@gt_lrc:
- bat-adlp-9: [INCOMPLETE][32] ([i915#7913]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/bat-adlp-9/igt@i915_selftest@live@gt_lrc.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-adlp-9/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-6: [DMESG-FAIL][34] ([i915#7059]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@slpc:
- bat-mtlp-6: [DMESG-WARN][36] ([i915#6367]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/bat-mtlp-6/igt@i915_selftest@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-mtlp-6/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@workarounds:
- bat-mtlp-6: [DMESG-FAIL][38] ([i915#6763]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/bat-mtlp-6/igt@i915_selftest@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-mtlp-6/igt@i915_selftest@[email protected]
#### Warnings ####
* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-1: [ABORT][40] ([i915#6687] / [i915#7978]) -> [FAIL][41] ([fdo#103375])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/bat-rpls-1/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/bat-rpls-1/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6763]: https://gitlab.freedesktop.org/drm/intel/issues/6763
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7967]: https://gitlab.freedesktop.org/drm/intel/issues/7967
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
Build changes
-------------
* Linux: CI_DRM_13293 -> Patchwork_119580v1
CI-20190529: 20190529
CI_DRM_13293: 0b6c4d4f639c4077e28e1d6fcb97412ae8f69d7c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7340: e975155e9167f0fed8f3da9c5b61de71d082b5c7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_119580v1: 0b6c4d4f639c4077e28e1d6fcb97412ae8f69d7c @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
e9b683656c85 drm/i915/psr: Use hw.adjusted mode when calculating io/fast wake times
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/psr: Use hw.adjusted mode when calculating io/fast wake times
In reply to Jouni Högander== Series Details ==
== Series Details ==
Series: drm/i915/psr: Use hw.adjusted mode when calculating io/fast wake times
URL : https://patchwork.freedesktop.org/series/119580/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13293_full -> Patchwork_119580v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_119580v1_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_119580v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_119580v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_plane_lowres@tiling-x@pipe-a-hdmi-a-2:
- shard-rkl: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-6/igt@kms_plane_lowres@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-2/igt@kms_plane_lowres@[email protected]
* igt@kms_plane_lowres@tiling-x@pipe-b-hdmi-a-2:
- shard-rkl: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-6/igt@kms_plane_lowres@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-2/igt@kms_plane_lowres@[email protected]
Known issues
------------
Here are the changes found in Patchwork_119580v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_fdinfo@virtual-idle:
- shard-rkl: [PASS][5] -> [FAIL][6] ([i915#7742])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-1/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2846])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-glk9/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-glk2/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-rkl: [PASS][9] -> [FAIL][10] ([i915#2842]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-2/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-apl7/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-apl1/igt@gem_exec_fair@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-tglu: [PASS][13] -> [SKIP][14] ([i915#4281])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-tglu-10/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-tglu-8/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-hdmi-a-2:
- shard-rkl: [PASS][15] -> [FAIL][16] ([i915#2521])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-4/igt@kms_async_flips@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-6/igt@kms_async_flips@[email protected]
* igt@kms_color@deep-color:
- shard-rkl: NOTRUN -> [SKIP][17] ([i915#3555] / [i915#4579])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-7/igt@[email protected]
* igt@kms_cursor_legacy@forked-move@pipe-b:
- shard-rkl: [PASS][18] -> [INCOMPLETE][19] ([i915#8011])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-1/igt@kms_cursor_legacy@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-7/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
- shard-glk: [PASS][20] -> [FAIL][21] ([i915#79])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-glk3/igt@kms_flip@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-glk8/igt@kms_flip@[email protected]
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][22] ([i915#5176]) +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-2/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][23] ([i915#4579] / [i915#5176]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-2/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@plane-upscale-with-modifiers-20x20@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4579]) +8 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-snb1/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][25] ([fdo#109271]) +13 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-snb6/igt@kms_plane_scaling@[email protected]
* igt@kms_rotation_crc@primary-rotation-270:
- shard-rkl: [PASS][26] -> [ABORT][27] ([i915#7461])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-6/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-1/igt@[email protected]
#### Possible fixes ####
* igt@gem_eio@reset-stress:
- {shard-dg1}: [FAIL][28] ([i915#5784]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-dg1-19/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-dg1-15/igt@[email protected]
* igt@gem_exec_balancer@nop:
- {shard-dg1}: [DMESG-WARN][30] ([i915#4423]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-dg1-12/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-dg1-19/igt@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-rkl: [FAIL][32] ([i915#2842]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-2/igt@gem_exec_fair@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-2/igt@gem_exec_fair@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [FAIL][34] ([i915#2346]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-apl1/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-apl3/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1:
- shard-apl: [FAIL][36] ([i915#79]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-apl2/igt@kms_flip@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-apl2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-glk: [FAIL][38] ([i915#79]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-glk1/igt@kms_flip@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-glk4/igt@kms_flip@[email protected]
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- shard-tglu: [WARN][40] ([i915#2681]) -> [FAIL][41] ([i915#2681] / [i915#3591])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-tglu-9/igt@i915_pm_rc6_residency@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-tglu-2/igt@i915_pm_rc6_residency@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8304]: https://gitlab.freedesktop.org/drm/intel/issues/8304
Build changes
-------------
* Linux: CI_DRM_13293 -> Patchwork_119580v1
CI-20190529: 20190529
CI_DRM_13293: 0b6c4d4f639c4077e28e1d6fcb97412ae8f69d7c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7340: e975155e9167f0fed8f3da9c5b61de71d082b5c7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_119580v1: 0b6c4d4f639c4077e28e1d6fcb97412ae8f69d7c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/index.html
Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/psr: Use hw.adjusted mode when calculating io/fast wake times
Possible regressions here are not related to my patch.
BR,
Jouni Högander
On Tue, 2023-06-20 at 22:48 +0000, Patchwork wrote:
Patch Details
Series: drm/i915/psr: Use hw.adjusted mode when calculating io/fast wake times URL: https://patchwork.freedesktop.org/series/119580/ State: failure Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/index.html
CI Bug Log - changes from CI_DRM_13293_full -> Patchwork_119580v1_full Summary
FAILURE
Serious unknown changes coming with Patchwork_119580v1_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_119580v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (7 -> 7)
No changes in participating hosts
Possible new issues
Here are the unknown changes that may have been introduced in Patchwork_119580v1_full:
IGT changes
Possible regressions
* igt@kms_plane_lowres@tiling-x@pipe-a-hdmi-a-2:
* shard-rkl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-6/igt@kms_plane_lowres@[email protected]> -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-2/igt@kms_plane_lowres@[email protected]>
* igt@kms_plane_lowres@tiling-x@pipe-b-hdmi-a-2:
* shard-rkl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-6/igt@kms_plane_lowres@[email protected]> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-2/igt@kms_plane_lowres@[email protected]>
Known issues
Here are the changes found in Patchwork_119580v1_full that come from known issues:
IGT changes
Issues hit
* igt@drm_fdinfo@virtual-idle:
* shard-rkl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-2/igt@[email protected]> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-1/igt@[email protected]> (i915#7742<https://gitlab.freedesktop.org/drm/intel/issues/7742>)
* igt@gem_exec_fair@basic-deadline:
* shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-glk9/igt@[email protected]> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-glk2/igt@[email protected]> (i915#2846<https://gitlab.freedesktop.org/drm/intel/issues/2846>)
* igt@gem_exec_fair@basic-flow@rcs0:
* shard-rkl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-2/igt@gem_exec_fair@[email protected]> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-1/igt@gem_exec_fair@[email protected]> (i915#2842<https://gitlab.freedesktop.org/drm/intel/issues/2842>) +3 similar issues
* igt@gem_exec_fair@basic-none-solo@rcs0:
* shard-apl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-apl7/igt@gem_exec_fair@[email protected]> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-apl1/igt@gem_exec_fair@[email protected]> (i915#2842<https://gitlab.freedesktop.org/drm/intel/issues/2842>)
* igt@i915_pm_dc@dc9-dpms:
* shard-tglu: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-tglu-10/igt@[email protected]> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-tglu-8/igt@[email protected]> (i915#4281<https://gitlab.freedesktop.org/drm/intel/issues/4281>)
* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-hdmi-a-2:
* shard-rkl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-4/igt@kms_async_flips@[email protected]> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-6/igt@kms_async_flips@[email protected]> (i915#2521<https://gitlab.freedesktop.org/drm/intel/issues/2521>)
* igt@kms_color@deep-color:
* shard-rkl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-7/igt@[email protected]> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555> / i915#4579<https://gitlab.freedesktop.org/drm/intel/issues/4579>)
* igt@kms_cursor_legacy@forked-move@pipe-b:
* shard-rkl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-1/igt@kms_cursor_legacy@[email protected]> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-7/igt@kms_cursor_legacy@[email protected]> (i915#8011<https://gitlab.freedesktop.org/drm/intel/issues/8011>)
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
* shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-glk3/igt@kms_flip@[email protected]> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-glk8/igt@kms_flip@[email protected]> (i915#79<https://gitlab.freedesktop.org/drm/intel/issues/79>)
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-a-hdmi-a-2:
* shard-rkl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-2/igt@kms_plane_scaling@[email protected]> (i915#5176<https://gitlab.freedesktop.org/drm/intel/issues/5176>) +2 similar issues
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-2:
* shard-rkl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-2/igt@kms_plane_scaling@[email protected]> (i915#4579<https://gitlab.freedesktop.org/drm/intel/issues/4579> / i915#5176<https://gitlab.freedesktop.org/drm/intel/issues/5176>) +2 similar issues
* igt@kms_plane_scaling@plane-upscale-with-modifiers-20x20@pipe-b-hdmi-a-1:
* shard-snb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-snb1/igt@kms_plane_scaling@[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4579<https://gitlab.freedesktop.org/drm/intel/issues/4579>) +8 similar issues
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-a-vga-1:
* shard-snb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-snb6/igt@kms_plane_scaling@[email protected]> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +13 similar issues
* igt@kms_rotation_crc@primary-rotation-270:
* shard-rkl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-6/igt@[email protected]> -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-1/igt@[email protected]> (i915#7461<https://gitlab.freedesktop.org/drm/intel/issues/7461>)
Possible fixes
* igt@gem_eio@reset-stress:
* {shard-dg1}: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-dg1-19/igt@[email protected]> (i915#5784<https://gitlab.freedesktop.org/drm/intel/issues/5784>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-dg1-15/igt@[email protected]>
* igt@gem_exec_balancer@nop:
* {shard-dg1}: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-dg1-12/igt@[email protected]> (i915#4423<https://gitlab.freedesktop.org/drm/intel/issues/4423>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-dg1-19/igt@[email protected]>
* igt@gem_exec_fair@basic-pace-solo@rcs0:
* shard-rkl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-rkl-2/igt@gem_exec_fair@[email protected]> (i915#2842<https://gitlab.freedesktop.org/drm/intel/issues/2842>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-rkl-2/igt@gem_exec_fair@[email protected]>
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
* shard-apl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-apl1/igt@[email protected]> (i915#2346<https://gitlab.freedesktop.org/drm/intel/issues/2346>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-apl3/igt@[email protected]>
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1:
* shard-apl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-apl2/igt@kms_flip@[email protected]> (i915#79<https://gitlab.freedesktop.org/drm/intel/issues/79>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-apl2/igt@kms_flip@[email protected]>
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
* shard-glk: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-glk1/igt@kms_flip@[email protected]> (i915#79<https://gitlab.freedesktop.org/drm/intel/issues/79>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-glk4/igt@kms_flip@[email protected]>
Warnings
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
* shard-tglu: WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13293/shard-tglu-9/igt@i915_pm_rc6_residency@[email protected]> (i915#2681<https://gitlab.freedesktop.org/drm/intel/issues/2681>) -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119580v1/shard-tglu-2/igt@i915_pm_rc6_residency@[email protected]> (i915#2681<https://gitlab.freedesktop.org/drm/intel/issues/2681> / i915#3591<https://gitlab.freedesktop.org/drm/intel/issues/3591>)
{name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE).
Build changes
* Linux: CI_DRM_13293 -> Patchwork_119580v1
CI-20190529: 20190529CI_DRM_13293: 0b6c4d4f639c4077e28e1d6fcb97412ae8f69d7c @ git://anongit.freedesktop.org/gfx-ci/linuxIGT_7340: e975155e9167f0fed8f3da9c5b61de71d082b5c7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.gitPatchwork_119580v1: 0b6c4d4f639c4077e28e1d6fcb97412ae8f69d7c @ git://anongit.freedesktop.org/gfx-ci/linuxpiglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
Quoted 6 lines
-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Jouni Högander
Sent: Tuesday, June 20, 2023 2:18 PM
To: [email protected]
Subject: [Intel-gfx] [PATCH] drm/i915/psr: Use hw.adjusted mode when calculating io/fast wake times
Quoted 6 lines
Encoder compute config is changing hw.adjusted mode. Uapi.adjusted mode doesn't get updated before psr compute config gets called. This causes io and fast wake line calculation using adjusted mode containing values before encoder adjustments. Fix this by using hw.adjusted mode instead of uapi.adjusted mode.
Cc Stanislav Lisovskiy <[email protected]>
Quoted 25 lines
Signed-off-by Jouni Högander <[email protected]>Fixes cb42e8ede5b4 ("drm/i915/psr: Use calculated io and fast wake lines")--- drivers/gpu/drm/i915/display/intel_psr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/intel_psr.c +2
-3@@ -1044,9 +1044,9 @@ static bool _compute_psr2_wake_times(struct intel_dp *intel_dp, } io_wake_lines =intel_usecs_to_scanlines ( - &crtc_state->uapi.adjusted_mode, io_wake_time); + &crtc_state->hw.adjusted_mode, io_wake_time); fast_wake_lines =intel_usecs_to_scanlines ( - &crtc_state->uapi.adjusted_mode, fast_wake_time); + &crtc_state->hw.adjusted_mode, fast_wake_time);if (io_wake_lines > max_wake_lines || fast_wake_lines > max_wake_lines) --2.34.1
Quoted 14 lines · Mika
Quoted 14 lines
-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Jouni Högander
Sent: Tuesday, June 20, 2023 2:18 PM
To: [email protected]
Subject: [Intel-gfx] [PATCH] drm/i915/psr: Use hw.adjusted mode when calculating io/fast wake timesEncoder compute config is changing hw.adjusted mode. Uapi.adjusted mode doesn't get updated before psr compute config
gets called. This causes io and fast wake line calculation using adjusted mode containing values before encoder adjustments. Fix this by using hw.adjusted mode instead of uapi.adjusted mode.
Quoted 4 lines
Quoted 2 lines
Cc Stanislav Lisovskiy <[email protected]>Reviewed-by Mika Kahola <[email protected]>
Thank you Mika for the review. This noow pushed.
BR,
Jouni Högander
Quoted 30 lines
Quoted 29 lines
Signed-off-by Jouni Högander <[email protected]>Fixes cb42e8ede5b4 ("drm/i915/psr: Use calculated io and fast wakelines")
---
drivers/gpu/drm/i915/display/intel_psr.c | 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/intel_psr.c +0
-0@@ -1044,9 +1044,9 @@ static bool _compute_psr2_wake_times(struct intel_dp *intel_dp, }io_wake_lines = intel_usecs_to_scanlines(
- &crtc_state->uapi.adjusted_mode,io_wake_time); + &crtc_state->hw.adjusted_mode,io_wake_time);fast_wake_lines= intel_usecs_to_scanlines(
- &crtc_state->uapi.adjusted_mode,fast_wake_time); + &crtc_state->hw.adjusted_mode,fast_wake_time);if (
io_wake_lines>max_wake_lines||
fast_wake_lines>max_wake_lines)
--
2.34.1