Add Meta (Facebook) Ventura BMC (AST2600)
Subsystems (2)
v13 cover Add Meta (Facebook) Ventura BMC (AST2600)
Add Linux device tree entry related to Meta (Facebook) Ventura specific devices connected to the BMC (AST2600) SoC. The purpose of Ventura is to detect liquid leakage from all compute trays, switch trays and rack sensors within the rack, log the events, and take necessary actions accordingly.
---
v1:
1. Create ventura dts file.
2. Add commit msg.
3. Use format-patch to generate patch.
4. Add subject prefixes matching the subsystem.
---
v2:
1. Modify email content.
---
v3:
1. Add mail list.
---
v4:
1. Apply git send-email --thread option.
2. Sort nodes in the dts alphanumerically.
---
v5:
1. Run scripts/checkpatch.pl and fix reported warnings.
2. Remove unnecessary 88E6393X CONFIG FRU.
---
v6:
1. Add a new stage for the DTS change.
2. Run scripts/checkpatch.pl and fix reported error.
3. Fix the issue in a separate patch.
---
v7:
1. Fix broken indentation in the device tree file.
2. Sort nodes alphabetically, then by address if equal.
3. Rename fan sensor nodes from 'hwmon' to 'fan-controller'.
---
v8:
1. This patch series has significant changes compared to previous versions, and quite some time has passed since the last submission.Therefore, previously received Acked-by/Reviewed-by/Tested-by tags are not included in this version.
If needed, tags can be added again after review of thisnew version.
---
v9:
1. Reordered the node sequence under i2c5.
2. Added a description of the platform's intended use to the commit messages.
3. Added 3 GPIO expanders to i2c10 and defined the necessary GPIO line names.
---
v10:
1. Added IRQ support in GPIO expanders under i2c10 to handle edge-triggered events.
2. Reordered the nodes.
---
v11:
1. Modified the position for i2c3mux0ch6 and i2c3mux0ch7.
---
v12:
1. Added a GPIO expander at address 0x11 on i2c10, and assign an SGPIO pin as the IRQ for it.
2. Fixed the "failed to match any schema with compatible" issues.
3. Reorder the nodes in alphabetically.
---
v13:
1. Add two GPIO expanders (0x16 and 0x17) to i2c10 and assign two SGPIO pins as IRQs.
2. Move the RPU_READY_SPARE_PLD_R and RPU_2_READY_PLD_R pins from SGPIO to the GPIO expander (0x10).
3. Add all tray PWREN pins to the GPIO expanders (0x16, 0x17 and 0x1b).
4. Add explanatory comments for "unmanaged mode" under &mac3 and "intentionally left empty" under &mdio.
P.K. Lee (2):
dt-bindings: arm: aspeed: add Meta Ventura board
arm: dts: aspeed: ventura: add Meta Ventura BMC
.../bindings/arm/aspeed/aspeed.yaml | 1 + arch/arm/boot/dts/aspeed/Makefile | 1 + .../aspeed/aspeed-bmc-facebook-ventura.dts | 1636 +++++++++++++++++ 3 files changed, 1638 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts
base-commit: e11fa6b1ff6c27c808d17e479bd7d5582e772062
branch: dev-6.6
Signature · 1 line
2.43.0
PATCH v13 1/2 dt-bindings: arm: aspeed: add Meta Ventura board
Document the new compatibles used on Meta Ventura.
--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
@@ -92,6 +92,7 @@ properties: - facebook,harma-bmc - facebook,minerva-cmc - facebook,santabarbara-bmc + - facebook,ventura-rmc - facebook,yosemite4-bmc - ibm,blueridge-bmc - ibm,everest-bmc
Signature · 1 line
2.43.0
PATCH v13 2/2 arm: dts: aspeed: ventura: add Meta Ventura BMC
In reply to P.K. LeeAdd Linux device tree related to Meta (Facebook) Ventura specific devices connected to the BMC (AST2600) SoC. The purpose of Ventura is to detect liquid leakage from all compute trays, switch trays and rack sensors within the rack, log the events, and take necessary actions accordingly.
--- arch/arm/boot/dts/aspeed/Makefile | 1 + .../aspeed/aspeed-bmc-facebook-ventura.dts | 1636 +++++++++++++++++ 2 files changed, 1637 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts
arch/arm/boot/dts/aspeed/Makefile +1 -0
@@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-facebook-minipack.dtb \ aspeed-bmc-facebook-santabarbara.dtb \ aspeed-bmc-facebook-tiogapass.dtb \ + aspeed-bmc-facebook-ventura.dtb \ aspeed-bmc-facebook-wedge40.dtb \ aspeed-bmc-facebook-wedge100.dtb \ aspeed-bmc-facebook-wedge400-data64.dtb \
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +1636 -0
1,636 lines not on this page · raw message
Signature · 1 line
2.43.0
Andrew Jeffery
maintainerRe: [PATCH v13 2/2] arm: dts: aspeed: ventura: add Meta Ventura BMC
Hi P.K.
Quoted 31 lines · P.K. Lee
Add Linux device tree related to Meta (Facebook) Ventura specific devices connected to the BMC (AST2600) SoC. The purpose of Ventura is to detect liquid leakage from all compute trays, switch trays and rack sensors within the rack, log the events, and take necessary actions accordingly.
Signed-off-by P.K. Lee <[email protected]>---
arch/arm/boot/dts/aspeed/Makefile | 1 + .../aspeed/aspeed-bmc-facebook-ventura.dts | 1636 +++++++++++++++++2 files changed, 1637 insertions(+)create mode 100644
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dtsarch/arm/boot/dts/aspeed/Makefile +1
-0@@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-facebook-minipack.dtb \ aspeed-bmc-facebook-santabarbara.dtb \ aspeed-bmc-facebook-tiogapass.dtb \ + aspeed-bmc-facebook-ventura.dtb \ aspeed-bmc-facebook-wedge40.dtb \ aspeed-bmc-facebook-wedge100.dtb \ aspeed-bmc-facebook-wedge400-data64.dtb \arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +0
-0
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts line 10
Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +10
-0@@ -0,0 +1,1636 @@ +// SPDX-License-Identifier: GPL-2.0+ +// Copyright (c) 2023 Facebook Inc. +/dts-v1/; + +#include "aspeed-g6.dtsi" +#include <dt-bindings/i2c/i2c.h> +#include <dt-bindings/gpio/aspeed-gpio.h> + +/ { + model = "Facebook ventura RMC";
I suggest capitalising 'Ventura'.
Quoted 26 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +26
-0+ compatible = "facebook,ventura-rmc", "aspeed,ast2600"; + + aliases { + serial4 = &uart5; + i2c16 = &i2c3mux0ch3; + i2c17 = &i2c3mux0ch4; + i2c18 = &i2c3mux0ch5; + i2c19 = &i2c3mux0ch6; + i2c20 = &i2c3mux0ch0; + i2c21 = &i2c3mux0ch1; + i2c22 = &i2c3mux0ch2; + i2c23 = &i2c3mux0ch7; + i2c24 = &i2c0mux0ch0; + i2c25 = &i2c0mux0ch1; + i2c26 = &i2c0mux0ch2; + i2c27 = &i2c0mux0ch3; + i2c28 = &i2c0mux0ch4; + i2c29 = &i2c0mux0ch5; + i2c30 = &i2c0mux0ch6; + i2c31 = &i2c0mux0ch7; + i2c32 = &i2c1mux0ch0; + i2c33 = &i2c1mux0ch1; + i2c34 = &i2c1mux0ch2; + i2c35 = &i2c1mux0ch3; + i2c36 = &i2c1mux0ch4; + i2c37 = &i2c1mux0ch5;
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts line 46
Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +10
-0+ i2c38 = &i2c1mux0ch6; + i2c39 = &i2c1mux0ch7; + i2c40 = &i2c2mux0ch0; + i2c41 = &i2c2mux0ch1; + i2c42 = &i2c2mux0ch2; + i2c43 = &i2c2mux0ch3; + i2c44 = &i2c2mux0ch4; + i2c45 = &i2c2mux0ch5; + i2c46 = &i2c2mux0ch6; + i2c47 = &i2c2mux0ch7;
Many of the buses aliased here don't have any devices described below them. Can you add some commentary about why it's necessary to enable and alias each of these?
Quoted 13 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +13
-0+ }; + + chosen { + stdout-path = "serial4:57600n8"; + }; + + iio-hwmon { + compatible = "iio-hwmon"; + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>, + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>, + <&adc1 2>; + }; +
...
Quoted 24 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +24
-0+ i2c3mux0ch4: i2c@4 { + #address-cells = <1>; + #size-cells = <0>; + reg = <4>; + + adc@1f { + compatible = "ti,adc128d818"; + reg = <0x1f>; + ti,mode = /bits/ 8 <1>; + }; + + fan_leds_g2_gpio: gpio@21 { + compatible = "nxp,pca9555"; + reg = <0x21>; + gpio-controller; + #gpio-cells = <2>; + + gpio-line-names = + "", "", + "", "", + "", "", + "", "", + "FAN2_PRSNT", "FAN3_PRSNT", + "", "",
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts line 1040
Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +10
-0+ "", "", + "", ""; + }; + + adc@35 { + compatible = "maxim,max11617"; + reg = <0x35>; + }; + + // Fan Board 1 FRU
I'd rather we pick one commenting style (/* */). Can you please fix that throughout?
Quoted 22 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +22
-0+ eeprom@56 { + compatible = "atmel,24c128"; + reg = <0x56>; + }; + }; + + i2c3mux0ch5: i2c@5 { + #address-cells = <1>; + #size-cells = <0>; + reg = <5>; + + pwm@20 { + compatible = "maxim,max31790"; + reg = <0x20>; + #address-cells = <1>; + #size-cells = <0>; + channel@2 { + reg = <2>; + sensor-type = "TACH"; + }; + channel@5 { + reg = <5>;
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts line 1072
Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +10
-0+ sensor-type = "TACH"; + }; + }; + + hwmon: hwmon@23 { + compatible = "nuvoton,nct7363"; + reg = <0x23>; + #pwm-cells = <2>; + + //fan 0 IL
Can you please add a space between the comment marker and the comment itself? This needs fixing throughout.
Quoted 50 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +49
-0+ fan-0 { + pwms = <&hwmon 0 20000>; + tach-ch = /bits/ 8 <0x09>; + }; + + //fan 0 OL + fan-1 { + pwms = <&hwmon 0 20000>; + tach-ch = /bits/ 8 <0x0B>; + }; + + //fan 1 IL + fan-2 { + pwms = <&hwmon 4 20000>; + tach-ch = /bits/ 8 <0x0A>; + }; + + //fan 1 OL + fan-3 { + pwms = <&hwmon 4 20000>; + tach-ch = /bits/ 8 <0x0D>; + }; + + //fan 2 IL + fan-4 { + pwms = <&hwmon 6 20000>; + tach-ch = /bits/ 8 <0x0F>; + }; + + //fan 2 OL + fan-5 { + pwms = <&hwmon 6 20000>; + tach-ch = /bits/ 8 <0x01>; + }; + + //fan 3 IL + fan-6 { + pwms = <&hwmon 10 20000>; + tach-ch = /bits/ 8 <0x00>; + }; + + //fan 3 OL + fan-7 { + pwms = <&hwmon 10 20000>; + tach-ch = /bits/ 8 <0x03>; + }; + }; + }; +
...
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts line 1464
Quoted 4 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +4
-0+ +&mdio0 { + status = "okay"; + /* * Intentionally left empty.
The comment is a bit busted here. Can you please fix it?
Andrew
Quoted 5 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +5
-0+ * Enabled to allow user-space tools (e.g., mdio) + * to access the unmanaged Marvell switch registers. + */ +}; +
Re: [PATCH v13 2/2] arm: dts: aspeed: ventura: add Meta Ventura BMC
Quoted 29 lines
Quoted 1 line
+ model = "Facebook ventura RMC";
I suggest capitalising 'Ventura'.
...
Quoted 1 line
+ i2c47 = &i2c2mux0ch7;
Many of the buses aliased here don't have any devices described below them. Can you add some commentary about why it's necessary to enable and alias each of these?
...
Quoted 1 line
+ // Fan Board 1 FRU
I'd rather we pick one commenting style (/* */). Can you please fix that throughout?
...
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts line 1072
Quoted 2 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +2
-0+ + //fan 0 ILCan you please add a space between the comment marker and the comment itself? This needs fixing throughout.
...
Quoted 8 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts line 1464
Quoted 3 lines
+&mdio0 {
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts new file +2
-0+ status = "okay"; + /* * Intentionally left empty.The comment is a bit busted here. Can you please fix it?
Andrew
Thank you for your suggestions. I will address them in the next revision of the DTS patch.
P.K.
Andrew Jeffery
maintainerHi P.K.,
Quoted 6 lines · P.K. Lee
Add Linux device tree entry related to Meta (Facebook) Ventura specific devices connected to the BMC (AST2600) SoC. The purpose of Ventura is to detect liquid leakage from all compute trays, switch trays and rack sensors within the rack, log the events, and take necessary actions accordingly.
...
Quoted 5 lines
---
P.K. Lee (2):
dt-bindings: arm: aspeed: add Meta Ventura board
arm: dts: aspeed: ventura: add Meta Ventura BMC
A few things on the commit subjects. Can you please:
- Capitalise the first word of the short description (the word after the final colon)
- For the DTS patch, capitalise 'ARM' for consistency
- Avoid redundancies
So:
dt-bindings: arm: aspeed: Add Meta Ventura board
ARM: dts: aspeed: Add Meta Ventura BMC
Cheers,
Andrew