Skip to contentSkip to conversation

gpio: sprd: Add clear interrupt

PATCH In review Wenhua Lin 5 participants 7 messages Aug 8, 2023 – Aug 11, 2023

Subsystems (3)
lore
Share & tools
lore

Wenhua Lin

author
#0 lore raw

PATCH 3/3 gpio: sprd: Add clear interrupt

Clear interrupt after set the interrupt type.

---
 drivers/gpio/gpio-eic-sprd.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/gpio/gpio-eic-sprd.c +10 -0
index c506cfd6df8e..31125f53bc97 100644
@@ -374,29 +374,34 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
 			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
 			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
 			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 1);
+			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
 			irq_set_handler_locked(data, handle_edge_irq);
 			break;
 		case IRQ_TYPE_EDGE_FALLING:
 			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
 			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
 			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 0);
+			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
 			irq_set_handler_locked(data, handle_edge_irq);
 			break;
 		case IRQ_TYPE_EDGE_BOTH:
 			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
 			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 1);
+			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
 			irq_set_handler_locked(data, handle_edge_irq);
 			break;
 		case IRQ_TYPE_LEVEL_HIGH:
 			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
 			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 1);
 			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 1);
+			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
 			irq_set_handler_locked(data, handle_level_irq);
 			break;
 		case IRQ_TYPE_LEVEL_LOW:
 			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
 			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 1);
 			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 0);
+			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
 			irq_set_handler_locked(data, handle_level_irq);
 			break;
 		default:
@@ -409,29 +414,34 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
 			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
 			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
 			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 1);
+			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
 			irq_set_handler_locked(data, handle_edge_irq);
 			break;
 		case IRQ_TYPE_EDGE_FALLING:
 			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
 			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
 			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 0);
+			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
 			irq_set_handler_locked(data, handle_edge_irq);
 			break;
 		case IRQ_TYPE_EDGE_BOTH:
 			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
 			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 1);
+			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
 			irq_set_handler_locked(data, handle_edge_irq);
 			break;
 		case IRQ_TYPE_LEVEL_HIGH:
 			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
 			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 1);
 			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 1);
+			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
 			irq_set_handler_locked(data, handle_level_irq);
 			break;
 		case IRQ_TYPE_LEVEL_LOW:
 			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
 			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 1);
 			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 0);
+			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
 			irq_set_handler_locked(data, handle_level_irq);
 			break;
 		default:
Signature · 1 line
2.17.1
#1 lore raw
Quoted 1 line · Wenhua Lin

Clear interrupt after set the interrupt type.

Why?

Can't it be done in the ->init_hw() callback of GPIO IRQ chip?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 7 lines · Andy Shevchenko
Quoted 1 line · Wenhua Lin

Clear interrupt after set the interrupt type.

Why?

Can't it be done in the ->init_hw() callback of GPIO IRQ chip?

Hi Andy:
The initialization state of EIC is high-level trigger. If the external level is high and the interrupt condition is met,
EIC has a latch function. If the module registers the eic interrupt, an interrupt will be generated immediately
as soon as the eic interrupt is enabled. To solve this problem, our
processing method is to clear the interrupt
once when setting the interrupt trigger type, in order to avoid that
this interrupt is the last interrupt.

Thanks
Wenhua.Lin

Quoted 6 lines

--
With Best Regards,
Andy Shevchenko

#3 lore raw
Quoted 8 lines · wenhua lin
Quoted 6 lines · Andy Shevchenko
Quoted 1 line · Wenhua Lin

Clear interrupt after set the interrupt type.

Why?

Can't it be done in the ->init_hw() callback of GPIO IRQ chip?

Quoted 9 lines

Hi Andy:
The initialization state of EIC is high-level trigger. If the external level is high and the interrupt condition is met,
EIC has a latch function. If the module registers the eic interrupt, an interrupt will be generated immediately
as soon as the eic interrupt is enabled. To solve this problem, our
processing method is to clear the interrupt
once when setting the interrupt trigger type, in order to avoid that
this interrupt is the last interrupt.

Obvious question, isn't this needed to be added to ->init_hw() as well?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
Quoted 20 lines · Andy Shevchenko
Quoted 8 lines · wenhua lin
Quoted 6 lines · Andy Shevchenko
Quoted 1 line · Wenhua Lin

Clear interrupt after set the interrupt type.

Why?

Can't it be done in the ->init_hw() callback of GPIO IRQ chip?

Quoted 9 lines

Hi Andy:
The initialization state of EIC is high-level trigger. If the external level is high and the interrupt condition is met,
EIC has a latch function. If the module registers the eic interrupt, an interrupt will be generated immediately
as soon as the eic interrupt is enabled. To solve this problem, our
processing method is to clear the interrupt
once when setting the interrupt trigger type, in order to avoid that
this interrupt is the last interrupt.

Quoted 1 line

Obvious question, isn't this needed to be added to ->init_hw() as well?

In the ->init_hw() function, the sprd_gpio_irq_ack interface will be called
to clear the interrupt, and there is no need to add it repeatedly

Quoted 4 lines

--
With Best Regards,
Andy Shevchenko

#5 lore raw
In reply to Wenhua Lin
Quoted 1 line · Wenhua Lin

Clear interrupt after set the interrupt type.

Sorry, NAK. The commit message is meaningless.

Quoted 79 lines
---
  drivers/gpio/gpio-eic-sprd.c | 10 ++++++++++
  1 file changed, 10 insertions(+)
drivers/gpio/gpio-eic-sprd.c +10 -0
index c506cfd6df8e..31125f53bc97 100644
@@ -374,29 +374,34 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
  			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
  			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
  			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 1);
+			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
  			irq_set_handler_locked(data, handle_edge_irq);
  			break;
  		case IRQ_TYPE_EDGE_FALLING:
  			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
  			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
  			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 0);
+			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
  			irq_set_handler_locked(data, handle_edge_irq);
  			break;
  		case IRQ_TYPE_EDGE_BOTH:
  			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
  			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 1);
+			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
  			irq_set_handler_locked(data, handle_edge_irq);
  			break;
  		case IRQ_TYPE_LEVEL_HIGH:
  			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
  			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 1);
  			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 1);
+			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
  			irq_set_handler_locked(data, handle_level_irq);
  			break;
  		case IRQ_TYPE_LEVEL_LOW:
  			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
  			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 1);
  			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 0);
+			sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
  			irq_set_handler_locked(data, handle_level_irq);
  			break;
  		default:
@@ -409,29 +414,34 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
  			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
  			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
  			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 1);
+			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
  			irq_set_handler_locked(data, handle_edge_irq);
  			break;
  		case IRQ_TYPE_EDGE_FALLING:
  			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
  			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
  			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 0);
+			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
  			irq_set_handler_locked(data, handle_edge_irq);
  			break;
  		case IRQ_TYPE_EDGE_BOTH:
  			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
  			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 1);
+			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
  			irq_set_handler_locked(data, handle_edge_irq);
  			break;
  		case IRQ_TYPE_LEVEL_HIGH:
  			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
  			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 1);
  			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 1);
+			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
  			irq_set_handler_locked(data, handle_level_irq);
  			break;
  		case IRQ_TYPE_LEVEL_LOW:
  			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
  			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 1);
  			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 0);
+			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
  			irq_set_handler_locked(data, handle_level_irq);
  			break;
  		default:
#6 lore raw
Quoted 7 lines · Baolin Wang
Quoted 1 line · Wenhua Lin

Clear interrupt after set the interrupt type.

Sorry, NAK. The commit message is meaningless.

Hi baolin:
We will re-modify the commit message and submit it in patch v2.

Thanks
Wenhua.Lin

Quoted 80 lines
Quoted 80 lines
---
  drivers/gpio/gpio-eic-sprd.c | 10 ++++++++++
  1 file changed, 10 insertions(+)
drivers/gpio/gpio-eic-sprd.c +10 -0
index c506cfd6df8e..31125f53bc97 100644
@@ -374,29 +374,34 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
                      sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
                      sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
                      sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 1);
+                     sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
                      irq_set_handler_locked(data, handle_edge_irq);
                      break;
              case IRQ_TYPE_EDGE_FALLING:
                      sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
                      sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
                      sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 0);
+                     sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
                      irq_set_handler_locked(data, handle_edge_irq);
                      break;
              case IRQ_TYPE_EDGE_BOTH:
                      sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
                      sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 1);
+                     sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
                      irq_set_handler_locked(data, handle_edge_irq);
                      break;
              case IRQ_TYPE_LEVEL_HIGH:
                      sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
                      sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 1);
                      sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 1);
+                     sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
                      irq_set_handler_locked(data, handle_level_irq);
                      break;
              case IRQ_TYPE_LEVEL_LOW:
                      sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
                      sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 1);
                      sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 0);
+                     sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
                      irq_set_handler_locked(data, handle_level_irq);
                      break;
              default:
@@ -409,29 +414,34 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
                      sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
                      sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
                      sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 1);
+                     sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
                      irq_set_handler_locked(data, handle_edge_irq);
                      break;
              case IRQ_TYPE_EDGE_FALLING:
                      sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
                      sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
                      sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 0);
+                     sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
                      irq_set_handler_locked(data, handle_edge_irq);
                      break;
              case IRQ_TYPE_EDGE_BOTH:
                      sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
                      sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 1);
+                     sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
                      irq_set_handler_locked(data, handle_edge_irq);
                      break;
              case IRQ_TYPE_LEVEL_HIGH:
                      sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
                      sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 1);
                      sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 1);
+                     sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
                      irq_set_handler_locked(data, handle_level_irq);
                      break;
              case IRQ_TYPE_LEVEL_LOW:
                      sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
                      sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 1);
                      sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 0);
+                     sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
                      irq_set_handler_locked(data, handle_level_irq);
                      break;
              default: