net/bnxt: limit per-poll Rx representor pkts
PATCH 1/1 net/bnxt: limit per-poll Rx representor pkts
Limit number of representor packets transferred per poll to requested burst size.
--- drivers/net/bnxt/bnxt_rxr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/bnxt_rxr.c +1 -1
@@ -901,7 +901,7 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, } raw_cons =NEXT_RAW_CMP (raw_cons); -if (nb_rx_pkts == nb_pkts || evt) +if (nb_rx_pkts == nb_pkts || nb_rep_rx_pkts == nb_pkts || evt)break ;/* Post some Rx buf early in case of larger burst processing */ if (nb_rx_pkts ==BNXT_RX_POST_THRESH )
Signature · 15 lines
2.25.1 -- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.
Quoted 9 lines · Lance Richardson
Limit number of representor packets transferred per poll to requested burst size.
Fixes 6dc83230b43b ("net/bnxt: support port representor data path")Signed-off-by Lance Richardson <[email protected]>Reviewed-by Ajit Kumar Khaparde <[email protected]>Reviewed-by Somnath Kotur <[email protected]>
Patch applied to dpdk-next-net-brcm. Thanks
Quoted 33 lines
--- drivers/net/bnxt/bnxt_rxr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/bnxt/bnxt_rxr.c +1
-2@@ -901,7 +901,7 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, } raw_cons =NEXT_RAW_CMP (raw_cons); -if (nb_rx_pkts == nb_pkts || evt) +if (nb_rx_pkts == nb_pkts || nb_rep_rx_pkts == nb_pkts || evt)break ;/* Post some Rx buf early in case of larger burst processing */ if (nb_rx_pkts ==BNXT_RX_POST_THRESH ) --2.25.1
--
This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.
Signature · 1 line
Ajit Khaparde
Quoted 3 lines · Lance Richardson
Limit number of representor packets transferred per poll to requested burst size.
Hi Lance,
Can you please describe the impact of the change? Since it has a fixes line, it seems it is fixing something but it is not clear what is fixed.
Quoted 23 lines
Fixes 6dc83230b43b ("net/bnxt: support port representor data path")Signed-off-by Lance Richardson <[email protected]>Reviewed-by Ajit Kumar Khaparde <[email protected]>Reviewed-by Somnath Kotur <[email protected]>--- drivers/net/bnxt/bnxt_rxr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/bnxt/bnxt_rxr.c +1
-1@@ -901,7 +901,7 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, } raw_cons =NEXT_RAW_CMP (raw_cons); -if (nb_rx_pkts == nb_pkts || evt) +if (nb_rx_pkts == nb_pkts || nb_rep_rx_pkts == nb_pkts || evt)break ;/* Post some Rx buf early in case of larger burst processing */ if (nb_rx_pkts ==BNXT_RX_POST_THRESH )
Quoted 11 lines · Ferruh Yigit
Quoted 3 lines · Lance Richardson
Limit number of representor packets transferred per poll to requested burst size.
Hi Lance,
Can you please describe the impact of the change? Since it has a fixes line, it seems it is fixing something but it is not clear what is fixed.
Hi Ferruh,
How does this look:
Without some limit on the number of packets transferred from the hw ring to the representor ring per burst receive call, an entire ring's worth of packets can be transferred. This can break assumptions about ring indices (index on return could be identical to the index on entry, which is assumed to mean that no packets were processed), and can result in representor packets being dropped unnecessarily due to representor ring overflow.
Fix by limiting the number of representor packets transferred per poll to requested burst size.
Thanks,
Lance
Quoted 24 lines · Lance Richardson
Quoted 11 lines · Ferruh Yigit
Quoted 3 lines · Lance Richardson
Limit number of representor packets transferred per poll to requested burst size.
Hi Lance,
Can you please describe the impact of the change? Since it has a fixes line, it seems it is fixing something but it is not clear what is fixed.
Hi Ferruh,
How does this look:
Without some limit on the number of packets transferred from the hw ring to the representor ring per burst receive call, an entire ring's worth of packets can be transferred. This can break assumptions about ring indices (index on return could be identical to the index on entry, which is assumed to mean that no packets were processed), and can result in representor packets being dropped unnecessarily due to representor ring overflow.
Quoted 3 lines
Fix by limiting the number of representor packets transferred per poll to requested burst size.
Thank you, updated the commit log in next-net.