Skip to contentSkip to conversation

staging: hp100: Block comments use a trailing */ on a separate line

PATCH In review Gokce Kuler 3 participants 6 messages Mar 21, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: hp100: Block comments use a trailing */ on a separate line

Moved to the bottom line */ for block comments

---
 drivers/staging/hp/hp100.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/hp/hp100.h +2 -1
index 7239b94..a331587 100644
@@ -538,7 +538,8 @@
 /* Tx or Rx Ring Entry */
 typedef struct hp100_ring {
 	u_int *pdl;		/* Address of PDLs PDH, dword before
-				 * this address is used for rx hdr */
+				 * this address is used for rx hdr 
+				 */ 
 	u_int pdl_paddr;	/* Physical address of PDL */
 	struct sk_buff *skb;
 	struct hp100_ring *next;
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 1 line · Gokce Kuler

Moved to the bottom line */ for block comments

Again, you said what you did, but not why.

Also, you _added_ two new checkpatch warnings, not a good ratio :(

thanks,

greg k-h

#2 lore raw
Quoted 9 lines · Greg KH
Quoted 1 line · Gokce Kuler

Moved to the bottom line */ for block comments

Again, you said what you did, but not why.

Also, you _added_ two new checkpatch warnings, not a good ratio :(

thanks,

Iam sorry, are we allowed to work on this driver, because i got;
WARNING: drivers/staging/hp/hp100.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.

Sam

Quoted 2 lines

greg k-h

maintainer
#3 lore raw
Quoted 6 lines · Sam Muhammed
Quoted 5 lines · Greg KH
Quoted 1 line · Gokce Kuler

Moved to the bottom line */ for block comments

Again, you said what you did, but not why.

Quoted 8 lines
Quoted 4 lines

Also, you _added_ two new checkpatch warnings, not a good ratio :(

thanks,

Iam sorry, are we allowed to work on this driver, because i got;
WARNING: drivers/staging/hp/hp100.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.

For basic code cleanups, to learn the process, it's fine, but note that the code will be deleted from the kernel "soon", so any changes you make will not stick around.

thanks,

greg k-h

#4 lore raw
Quoted 12 lines · Greg KH
Quoted 11 lines · Sam Muhammed
Quoted 9 lines · Greg KH
Quoted 1 line · Gokce Kuler

Moved to the bottom line */ for block comments

Again, you said what you did, but not why.

Also, you _added_ two new checkpatch warnings, not a good ratio :(

thanks,

Quoted 8 lines
Quoted 3 lines

Iam sorry, are we allowed to work on this driver, because i got;
WARNING: drivers/staging/hp/hp100.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.

For basic code cleanups, to learn the process, it's fine, but note that the code will be deleted from the kernel "soon", so any changes you make will not stick around.

So outreachy-wise, would this be considered as a contribution? This driver is juicy :)

Sam

Quoted 3 lines

thanks,

greg k-h

maintainer
#5 lore raw
Quoted 17 lines · Sam Muhammed
Quoted 16 lines · Greg KH
Quoted 14 lines · Sam Muhammed
Quoted 9 lines · Greg KH
Quoted 1 line · Gokce Kuler

Moved to the bottom line */ for block comments

Again, you said what you did, but not why.

Also, you _added_ two new checkpatch warnings, not a good ratio :(

thanks,

Iam sorry, are we allowed to work on this driver, because i got;
WARNING: drivers/staging/hp/hp100.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.

Quoted 7 lines
Quoted 4 lines

For basic code cleanups, to learn the process, it's fine, but note that the code will be deleted from the kernel "soon", so any changes you make will not stick around.

So outreachy-wise, would this be considered as a contribution? This driver is juicy :)

Sure, I'll take contributions to it until Wednesday, and then I'll delete it from the tree as it's about time it needs to go.

thanks,

greg k-h