Skip to contentSkip to conversation

x86/spec-ctrl: More MSR_ARCH_CAPS enumerations

PATCH In review Andrew Cooper 3 participants 5 messages Jun 10, 2022 – Jun 13, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/spec-ctrl: More MSR_ARCH_CAPS enumerations

https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/best-practices/data-operand-independent-timing-isa-guidance.html
https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/advisory-guidance/running-average-power-limit-energy-reporting.html

---
CC: Jan Beulich <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Wei Liu <[email protected]>

The SDM also lists

  #define  ARCH_CAPS_OVERCLOCKING_STATUS      (_AC(1, ULL) << 23)

but I've got no idea what this is, nor the index of MSR_OVERCLOCKING_STATUS which is the thing allegedly enumerated by this.

---
 xen/arch/x86/include/asm/msr-index.h | 9 +++++++++
 1 file changed, 9 insertions(+)
xen/arch/x86/include/asm/msr-index.h +9 -0
index 6c250bfcadad..781584953654 100644
@@ -51,6 +51,9 @@
 #define  PPIN_ENABLE                        (_AC(1, ULL) <<  1)
 #define MSR_PPIN                            0x0000004f
 
+#define MSR_MISC_PACKAGE_CTRL               0x000000bc
+#define  PGK_CTRL_ENERGY_FILTER_EN          (_AC(1, ULL) <<  0)
+
 #define MSR_CORE_CAPABILITIES               0x000000cf
 #define  CORE_CAPS_SPLITLOCK_DETECT         (_AC(1, ULL) <<  5)
 
@@ -71,6 +74,9 @@
 #define  ARCH_CAPS_IF_PSCHANGE_MC_NO        (_AC(1, ULL) <<  6)
 #define  ARCH_CAPS_TSX_CTRL                 (_AC(1, ULL) <<  7)
 #define  ARCH_CAPS_TAA_NO                   (_AC(1, ULL) <<  8)
+#define  ARCH_CAPS_MISC_PACKAGE_CTRL        (_AC(1, ULL) << 10)
+#define  ARCH_CAPS_ENERGY_FILTERING         (_AC(1, ULL) << 11)
+#define  ARCH_CAPS_DOITM                    (_AC(1, ULL) << 12)
 #define  ARCH_CAPS_RRSBA                    (_AC(1, ULL) << 19)
 #define  ARCH_CAPS_BHI_NO                   (_AC(1, ULL) << 20)
 
@@ -149,6 +155,9 @@
 #define  PASID_PASID_MASK                   0x000fffff
 #define  PASID_VALID                        (_AC(1, ULL) << 31)
 
+#define MSR_UARCH_MISC_CTRL                 0x00001b01
+#define  UARCH_CTRL_DOITM                   (_AC(1, ULL) <<  0)
+
 #define MSR_EFER                            0xc0000080 /* Extended Feature Enable Register */
 #define  EFER_SCE                           (_AC(1, ULL) <<  0) /* SYSCALL Enable */
 #define  EFER_LME                           (_AC(1, ULL) <<  8) /* Long Mode Enable */
Signature · 1 line
2.11.0
#1 lore raw
Quoted 9 lines · Andrew Cooper

https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/best-practices/data-operand-independent-timing-isa-guidance.html
https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/advisory-guidance/running-average-power-limit-energy-reporting.html

---
CC: Jan Beulich <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Wei Liu <[email protected]>

Quoted 6 lines

The SDM also lists

  #define  ARCH_CAPS_OVERCLOCKING_STATUS      (_AC(1, ULL) << 23)

but I've got no idea what this is, nor the index of MSR_OVERCLOCKING_STATUS which is the thing allegedly enumerated by this.

Found it.  There's an OVER{C}CLOCKING typo in the SDM.  It's MSR 0x195 and new in AlderLake it seems.

~Andrew

Reviewed-by
#2 lore raw
Quoted 12 lines · Andrew Cooper
Quoted 11 lines · Andrew Cooper

https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/best-practices/data-operand-independent-timing-isa-guidance.html
https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/advisory-guidance/running-average-power-limit-energy-reporting.html

---
CC: Jan Beulich <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Wei Liu <[email protected]>

The SDM also lists

Quoted 8 lines
Quoted 4 lines
  #define  ARCH_CAPS_OVERCLOCKING_STATUS      (_AC(1, ULL) << 23)

but I've got no idea what this is, nor the index of MSR_OVERCLOCKING_STATUS which is the thing allegedly enumerated by this.

Found it.  There's an OVER{C}CLOCKING typo in the SDM.  It's MSR 0x195 and new in AlderLake it seems.

With or without bits for it added

I'd like to note though that I can't spot such a spelling mistake in version 077 of the SDM (vol 4).

Jan

#3 lore raw
Quoted 18 lines · Jan Beulich
Quoted 17 lines · Andrew Cooper
Quoted 15 lines · Andrew Cooper

https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/best-practices/data-operand-independent-timing-isa-guidance.html
https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/advisory-guidance/running-average-power-limit-energy-reporting.html

---
CC: Jan Beulich <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Wei Liu <[email protected]>

The SDM also lists

  #define  ARCH_CAPS_OVERCLOCKING_STATUS      (_AC(1, ULL) << 23)

but I've got no idea what this is, nor the index of MSR_OVERCLOCKING_STATUS which is the thing allegedly enumerated by this.

Quoted 6 lines
Quoted 2 lines

Found it.  There's an OVER{C}CLOCKING typo in the SDM.  It's MSR 0x195 and new in AlderLake it seems.

With or without bits for it added

I'd like to note though that I can't spot such a spelling mistake in version 077 of the SDM (vol 4).

That's because it's surprisingly hard to deliberately make a typo...

It was OVER LOCKING i.e. no c's rather than 2.

~Andrew

#4 lore raw
In reply to Andrew Cooper
Quoted 24 lines · Andrew Cooper

https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/best-practices/data-operand-independent-timing-isa-guidance.html
https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/advisory-guidance/running-average-power-limit-energy-reporting.html

---
CC: Jan Beulich <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Wei Liu <[email protected]>

The SDM also lists

  #define  ARCH_CAPS_OVERCLOCKING_STATUS      (_AC(1, ULL) << 23)

but I've got no idea what this is, nor the index of MSR_OVERCLOCKING_STATUS which is the thing allegedly enumerated by this.

---
 xen/arch/x86/include/asm/msr-index.h | 9 +++++++++
 1 file changed, 9 insertions(+)
xen/arch/x86/include/asm/msr-index.h +0 -0
index 6c250bfcadad..781584953654 100644

xen/arch/x86/include/asm/msr-index.h line 54

Quoted 4 lines
xen/arch/x86/include/asm/msr-index.h +1 -0
@@ -51,6 +51,9 @@
 #define  PPIN_ENABLE                        (_AC(1, ULL) <<  1)
 #define MSR_PPIN                            0x0000004f
 
+#define MSR_MISC_PACKAGE_CTRL               0x000000bc

Not sure it's worth it, but Intel names this MISC_PACKAGE_CTLS rather than CTRL, same with the bit below in ARCH_CAPABILITIES.

Thanks, Roger.