Skip to contentSkip to conversation

mmc: dw_mmc-rockchip: correct property names in debug

PATCH New John Keeping 5 participants 5 messages Mar 1, 2018 – Mar 15, 2018

Subsystems (3)
MMC, SD and SDIO Arm Rockchip Synopsys DesignWare MMC/SD/SDIO driver
lore
Share & tools
lore

John Keeping

author
#0 lore raw

PATCH 1/1 mmc: dw_mmc-rockchip: correct property names in debug

Following up the device tree fixed in commits e78c637127ee ("ARM: dts:
rockchip: Fix DWMMC clocks") and ca9eee95a2de ("arm64: dts: rockchip:
Fix DWMMC clocks", 2018-02-15), avoid confusion by using the correct property name in the debug output if clocks are not found.

Signed-off-by John Keeping <[email protected]>
---
 drivers/mmc/host/dw_mmc-rockchip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/host/dw_mmc-rockchip.c +2 -2
index 339295212935..40d7de2eea12 100644
@@ -282,11 +282,11 @@ static int dw_mci_rk3288_parse_dt(struct dw_mci *host)
 
 	priv->drv_clk = devm_clk_get(host->dev, "ciu-drive");
 	if (IS_ERR(priv->drv_clk))
-		dev_dbg(host->dev, "ciu_drv not available\n");
+		dev_dbg(host->dev, "ciu-drive not available\n");
 
 	priv->sample_clk = devm_clk_get(host->dev, "ciu-sample");
 	if (IS_ERR(priv->sample_clk))
-		dev_dbg(host->dev, "ciu_sample not available\n");
+		dev_dbg(host->dev, "ciu-sample not available\n");
 
 	host->priv = priv;
Signature · 1 line
2.16.2
maintainer
#1 lore raw

PATCH 1/1 mmc: dw_mmc-rockchip: correct property names in debug

Am Donnerstag, 1. M?rz 2018, 11:36:25 CET schrieb John Keeping:

Quoted 6 lines

Following up the device tree fixed in commits e78c637127ee ("ARM: dts:
rockchip: Fix DWMMC clocks") and ca9eee95a2de ("arm64: dts: rockchip:
Fix DWMMC clocks", 2018-02-15), avoid confusion by using the correct property name in the debug output if clocks are not found.

Signed-off-by John Keeping <[email protected]>
Reviewed-by Heiko Stuebner <[email protected]>
#2 lore raw

PATCH 1/1 mmc: dw_mmc-rockchip: correct property names in debug

In reply to John Keeping
Quoted 4 lines · John Keeping

Following up the device tree fixed in commits e78c637127ee ("ARM: dts:
rockchip: Fix DWMMC clocks") and ca9eee95a2de ("arm64: dts: rockchip:
Fix DWMMC clocks", 2018-02-15), avoid confusion by using the correct property name in the debug output if clocks are not found.

Yeah, I was lazy since this inconsistency was already present and I just wanted to make my thing work :)

Reviewed-by Robin Murphy <[email protected]>
Quoted 24 lines
Signed-off-by John Keeping <[email protected]>
---
  drivers/mmc/host/dw_mmc-rockchip.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/host/dw_mmc-rockchip.c +2 -2
index 339295212935..40d7de2eea12 100644
@@ -282,11 +282,11 @@ static int dw_mci_rk3288_parse_dt(struct dw_mci *host)
 
  	priv->drv_clk = devm_clk_get(host->dev, "ciu-drive");
  	if (IS_ERR(priv->drv_clk))
-		dev_dbg(host->dev, "ciu_drv not available\n");
+		dev_dbg(host->dev, "ciu-drive not available\n");
 
  	priv->sample_clk = devm_clk_get(host->dev, "ciu-sample");
  	if (IS_ERR(priv->sample_clk))
-		dev_dbg(host->dev, "ciu_sample not available\n");
+		dev_dbg(host->dev, "ciu-sample not available\n");
 
  	host->priv = priv;
Applied
#4 lore raw

PATCH 1/1 mmc: dw_mmc-rockchip: correct property names in debug

In reply to John Keeping
Quoted 6 lines · John Keeping

Following up the device tree fixed in commits e78c637127ee ("ARM: dts:
rockchip: Fix DWMMC clocks") and ca9eee95a2de ("arm64: dts: rockchip:
Fix DWMMC clocks", 2018-02-15), avoid confusion by using the correct property name in the debug output if clocks are not found.

Signed-off-by John Keeping <[email protected]>

Thanks, applied for next!

Kind regards
Uffe

Quoted 25 lines
---
 drivers/mmc/host/dw_mmc-rockchip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/host/dw_mmc-rockchip.c +2 -3
index 339295212935..40d7de2eea12 100644
@@ -282,11 +282,11 @@ static int dw_mci_rk3288_parse_dt(struct dw_mci *host)
 
        priv->drv_clk = devm_clk_get(host->dev, "ciu-drive");
        if (IS_ERR(priv->drv_clk))
-               dev_dbg(host->dev, "ciu_drv not available\n");
+               dev_dbg(host->dev, "ciu-drive not available\n");
 
        priv->sample_clk = devm_clk_get(host->dev, "ciu-sample");
        if (IS_ERR(priv->sample_clk))
-               dev_dbg(host->dev, "ciu_sample not available\n");
+               dev_dbg(host->dev, "ciu-sample not available\n");
 
        host->priv = priv;
 
--

2.16.2