tests/device_reset: Test device sysfs reset
PATCH 1/1 tests/device_reset: Test device sysfs reset
Device reset is initiated by writing "1" to reset sysfs file, which should initiate PCI device Function Level Reset if supported by device.
Test scenarios:
1. unbind driver from device, initiate sysfs reset, rebind driver to device
2. device reset with bound driver
v2: removed unbind-rebind (duplicates core_hotunplug@unbind-rebind)
added healthcheck to each test (Janusz)
v3: after review corrections (renamed sysfs_fds to device_fds,
corrected not closed file descriptor, removed variable length array)
v4: updated description (Martin), snprintf corrections (Janusz),
reset-bound added to blacklist as it hangs several gens of hosts (Tomi)
--- tests/device_reset.c | 281 +++++++++++++++++++++++++++++++++++ tests/intel-ci/blacklist.txt | 3 + tests/meson.build | 1 + 3 files changed, 285 insertions(+) create mode 100644 tests/device_reset.c
tests/device_reset.c new file +281 -0
@@ -0,0 +1,281 @@ +// SPDX-License-Identifier: MIT +/* +* Copyright(c) 2020 Intel Corporation. All rights reserved. +*/ +#include <fcntl.h> +#include <sys/ioctl.h> +#include <sys/stat.h> + +#include "i915/gem.h" +#include "igt.h" +#include "igt_device_scan.h" +#include "igt_sysfs.h" + +IGT_TEST_DESCRIPTION ("Examine behavior of a driver on device sysfs reset" ); + + +#define DEV_PATH_LEN 80 +#define DEV_BUS_ADDR_LEN 13/* addr has form 0000:00:00.0 */ + +/** +* Helper structure containing file descriptors +* and bus address related to tested device +*/ +struct device_fds { +struct { +int dev; +int dev_dir; +int drv_dir; + } fds; +char dev_bus_addr[DEV_BUS_ADDR_LEN ]; +}; + +static int __open_sysfs_dir (int fd,const char * path) +{ +int sysfs; + + sysfs =igt_sysfs_open (fd); +if (sysfs <0 ) { +return -1 ; + } + + fd =openat (sysfs, path,O_DIRECTORY ); +close (sysfs); +return fd; +} + +static int open_device_sysfs_dir (int fd) +{ +return __open_sysfs_dir (fd,"device" ); +} + +static int open_driver_sysfs_dir (int fd) +{ +return __open_sysfs_dir (fd,"device/driver" ); +} + +/** +* device_sysfs_path: +* @fd: opened device file descriptor +* @path: buffer to store sysfs path to device directory +* +* Returns: +* On successfull path resolution sysfs path to device directory, +* NULL otherwise +*/ +static char *device_sysfs_path (int fd,char *path) +{ +char sysfs[DEV_PATH_LEN ]; + +if (!igt_sysfs_path (fd, sysfs,sizeof (sysfs))) +return NULL ; + +if (DEV_PATH_LEN <= (strlen (sysfs) +strlen ("/device" ))) +return NULL ; + +strcat (sysfs,"/device" ); + +return realpath (sysfs, path); +} + +static void init_device_fds (struct device_fds *dev) +{ +char dev_path[PATH_MAX ]; +char *addr_pos; + +igt_debug ("open device\n" ); +/** +* As subtests must be able to close examined devices +* completely, don't use drm_open_driver() as it keeps +* a device file descriptor open for exit handler use. +*/ + dev->fds.dev =__drm_open_driver (DRIVER_ANY ); +igt_assert_fd (dev->fds.dev); +if (is_i915_device (dev->fds.dev)) +igt_require_gem (dev->fds.dev); + +igt_assert (device_sysfs_path (dev->fds.dev, dev_path)); + addr_pos =strrchr (dev_path,'/' ); +igt_assert (addr_pos); +igt_assert_eq (sizeof (dev->dev_bus_addr) -1 , +snprintf (dev->dev_bus_addr,sizeof (dev->dev_bus_addr), +"%s" , addr_pos +1 )); + + dev->fds.dev_dir =open_device_sysfs_dir (dev->fds.dev); +igt_assert_fd (dev->fds.dev_dir); + + dev->fds.drv_dir =open_driver_sysfs_dir (dev->fds.dev); +igt_assert_fd (dev->fds.drv_dir); +} + +static int close_if_opened (int *fd) +{ +int rc =0 ; + +if (fd && *fd !=-1 ) { + rc =close (*fd); + *fd =-1 ; + } +return rc; +} + +static void cleanup_device_fds (struct device_fds *dev) +{ +igt_ignore_warn (close_if_opened (&dev->fds.dev)); +igt_ignore_warn (close_if_opened (&dev->fds.dev_dir)); +igt_ignore_warn (close_if_opened (&dev->fds.drv_dir)); +} + +/** +* is_sysfs_reset_supported: +* @fd: opened device file descriptor +* +* Check if device supports reset based on sysfs file presence. +* +* Returns: +* True if device supports reset, false otherwise. +*/ +static bool is_sysfs_reset_supported (int fd) +{ +struct stat st; +int rc; +int sysfs; +int reset_fd =-1 ; + + sysfs =igt_sysfs_open (fd); + +if (sysfs >=0 ) { + reset_fd =openat (sysfs,"device/reset" ,O_WRONLY ); +close (sysfs); + } + +if (reset_fd <0 ) +return false; + + rc =fstat (reset_fd, &st); +close (reset_fd); + +if (rc || !S_ISREG (st.st_mode)) +return false; + +return true; +} + +/* Unbind the driver from the device */ +static void driver_unbind (struct device_fds *dev) +{ +igt_debug ("unbind the driver from the device\n" ); +igt_assert (igt_sysfs_set (dev->fds.drv_dir,"unbind" , + dev->dev_bus_addr)); +} + +/* Re-bind the driver to the device */ +static void driver_bind (struct device_fds *dev) +{ +igt_debug ("rebind the driver to the device\n" ); +igt_abort_on_f (!igt_sysfs_set (dev->fds.drv_dir,"bind" , + dev->dev_bus_addr),"driver rebind failed" ); +} + +/* Initiate device reset */ +static void initiate_device_reset (struct device_fds *dev) +{ +igt_debug ("reset device\n" ); +igt_assert (igt_sysfs_set (dev->fds.dev_dir,"reset" ,"1" )); +} + +static bool is_i915_wedged (int i915) +{ +int err =0 ; + +if (ioctl (i915,DRM_IOCTL_I915_GEM_THROTTLE )) + err = -errno; +return err == -EIO ; +} + +/** +* healthcheck: +* @dev: structure with device descriptor, if descriptor equals -1 +* the device is reopened +*/ +static void healthcheck (struct device_fds *dev) +{ +if (dev->fds.dev ==-1 ) { +/* refresh device list */ +igt_devices_scan (true); +igt_debug ("reopen the device\n" ); + dev->fds.dev =__drm_open_driver (DRIVER_ANY ); + } +igt_assert_fd (dev->fds.dev); + +if (is_i915_device (dev->fds.dev)) +igt_assert (!is_i915_wedged (dev->fds.dev)); +} + +/** +* set_device_filter: +* +* Sets device filter to ensure subtests always reopen the same device +* +* @dev_path: path to device under tests +*/ +static void set_device_filter (const char * dev_path) +{ +#define FILTER_PREFIX_LEN 4 +char filter[PATH_MAX +FILTER_PREFIX_LEN ]; + +igt_assert_lt (FILTER_PREFIX_LEN ,snprintf (filter,sizeof (filter), +"sys:%s" , dev_path)); +igt_device_filter_free_all (); +igt_assert_eq (igt_device_filter_add (filter),1 ); +} + +static void unbind_reset_rebind (struct device_fds *dev) +{ +igt_debug ("close the device\n" ); +close_if_opened (&dev->fds.dev); + +driver_unbind (dev); + +initiate_device_reset (dev); + +driver_bind (dev); +} + +igt_main +{ +struct device_fds dev = { .fds = {-1 ,-1 ,-1 }, .dev_bus_addr = {0 }}; + + igt_fixture { +char dev_path[PATH_MAX ]; + +igt_debug ("opening device\n" ); +init_device_fds (&dev); + +/* Make sure subtests always reopen the same device */ +igt_assert (device_sysfs_path (dev.fds.dev, dev_path)); +set_device_filter (dev_path); + +igt_skip_on (!is_sysfs_reset_supported (dev.fds.dev)); + +igt_set_timeout (60 ,"device reset tests timed out after 60s" ); + } + +igt_describe ("Unbinds driver from device, initiates reset" +" then rebinds driver to device" ); + igt_subtest("unbind-reset-rebind") { +unbind_reset_rebind (&dev); +healthcheck (&dev); + } + +igt_describe ("Resets device with bound driver" ); + igt_subtest("reset-bound") { +initiate_device_reset (&dev); +healthcheck (&dev); + } + + igt_fixture { +igt_reset_timeout (); +cleanup_device_fds (&dev); + } +}
tests/intel-ci/blacklist.txt +3 -0
@@ -121,3 +121,6 @@ igt@perf_pmu@cpu-hotplug # Currently fails and leaves the machine in a very bad state, and # causes coverage loss for other tests. igt@core_hotunplug@.* + +# hangs several gens of hosts, and has no immediate fix +igt@device_reset@reset-bound
tests/meson.build +1 -0
@@ -8,6 +8,7 @@ test_progs = [ 'core_setmaster_vs_auth', 'debugfs_test', 'dmabuf', + 'device_reset', 'drm_import_export', 'drm_mm', 'drm_read',
Signature · 13 lines
2.25.1 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Sowackiego 173 | 80-298 Gdask | Sd Rejonowy Gdask Pnoc | VII Wydzia Gospodarczy Krajowego Rejestru Sdowego - KRS 101882 | NIP 957-07-52-316 | Kapita zakadowy 200.000 PLN. Ta wiadomo wraz z zacznikami jest przeznaczona dla okrelonego adresata i moe zawiera informacje poufne. W razie przypadkowego otrzymania tej wiadomoci, prosimy o powiadomienie nadawcy oraz trwae jej usunicie; jakiekolwiek przegldanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited. _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 316 lines · Marcin Bernatowicz
Device reset is initiated by writing "1" to reset sysfs file, which should initiate PCI device Function Level Reset if supported by device.
Test scenarios:
1. unbind driver from device, initiate sysfs reset, rebind driver to device
2. device reset with bound driverv2: removed unbind-rebind (duplicates core_hotunplug@unbind-rebind)
added healthcheck to each test (Janusz)
v3: after review corrections (renamedsysfs_fdstodevice_fds,
corrected not closed file descriptor, removed variable length array)
v4: updated description (Martin), snprintf corrections (Janusz),
reset-bound added to blacklist as it hangs several gens of hosts (Tomi)Signed-off-by Marcin Bernatowicz <[email protected]>--- tests/device_reset.c | 281 +++++++++++++++++++++++++++++++++++ tests/intel-ci/blacklist.txt | 3 + tests/meson.build | 1 + 3 files changed, 285 insertions(+) create mode 100644 tests/device_reset.ctests/device_reset.c new file +281
-0@@ -0,0 +1,281 @@ +// SPDX-License-Identifier: MIT +/* +* Copyright(c) 2020 Intel Corporation. All rights reserved. +*/ +#include <fcntl.h> +#include <sys/ioctl.h> +#include <sys/stat.h> + +#include "i915/gem.h" +#include "igt.h" +#include "igt_device_scan.h" +#include "igt_sysfs.h" + +IGT_TEST_DESCRIPTION ("Examine behavior of a driver on device sysfs reset" ); + + +#define DEV_PATH_LEN 80 +#define DEV_BUS_ADDR_LEN 13/* addr has form 0000:00:00.0 */ + +/** +* Helper structure containing file descriptors +* and bus address related to tested device +*/ +struct device_fds { +struct { +int dev; +int dev_dir; +int drv_dir; + } fds; +char dev_bus_addr[DEV_BUS_ADDR_LEN ]; +}; + +static int __open_sysfs_dir (int fd,const char * path) +{ +int sysfs; + + sysfs =igt_sysfs_open (fd); +if (sysfs <0 ) { +return -1 ; + } + + fd =openat (sysfs, path,O_DIRECTORY ); +close (sysfs); +return fd; +} + +static int open_device_sysfs_dir (int fd) +{ +return __open_sysfs_dir (fd,"device" ); +} + +static int open_driver_sysfs_dir (int fd) +{ +return __open_sysfs_dir (fd,"device/driver" ); +} + +/** +* device_sysfs_path: +* @fd: opened device file descriptor +* @path: buffer to store sysfs path to device directory +* +* Returns: +* On successfull path resolution sysfs path to device directory, +* NULL otherwise +*/ +static char *device_sysfs_path (int fd,char *path) +{ +char sysfs[DEV_PATH_LEN ]; + +if (!igt_sysfs_path (fd, sysfs,sizeof (sysfs))) +return NULL ; + +if (DEV_PATH_LEN <= (strlen (sysfs) +strlen ("/device" ))) +return NULL ; + +strcat (sysfs,"/device" ); + +return realpath (sysfs, path); +} + +static void init_device_fds (struct device_fds *dev) +{ +char dev_path[PATH_MAX ]; +char *addr_pos; + +igt_debug ("open device\n" ); +/** +* As subtests must be able to close examined devices +* completely, don't use drm_open_driver() as it keeps +* a device file descriptor open for exit handler use. +*/ + dev->fds.dev =__drm_open_driver (DRIVER_ANY ); +igt_assert_fd (dev->fds.dev); +if (is_i915_device (dev->fds.dev)) +igt_require_gem (dev->fds.dev); + +igt_assert (device_sysfs_path (dev->fds.dev, dev_path)); + addr_pos =strrchr (dev_path,'/' ); +igt_assert (addr_pos); +igt_assert_eq (sizeof (dev->dev_bus_addr) -1 , +snprintf (dev->dev_bus_addr,sizeof (dev->dev_bus_addr), +"%s" , addr_pos +1 )); + + dev->fds.dev_dir =open_device_sysfs_dir (dev->fds.dev); +igt_assert_fd (dev->fds.dev_dir); + + dev->fds.drv_dir =open_driver_sysfs_dir (dev->fds.dev); +igt_assert_fd (dev->fds.drv_dir); +} + +static int close_if_opened (int *fd) +{ +int rc =0 ; + +if (fd && *fd !=-1 ) { + rc =close (*fd); + *fd =-1 ; + } +return rc; +} + +static void cleanup_device_fds (struct device_fds *dev) +{ +igt_ignore_warn (close_if_opened (&dev->fds.dev)); +igt_ignore_warn (close_if_opened (&dev->fds.dev_dir)); +igt_ignore_warn (close_if_opened (&dev->fds.drv_dir)); +} + +/** +* is_sysfs_reset_supported: +* @fd: opened device file descriptor +* +* Check if device supports reset based on sysfs file presence. +* +* Returns: +* True if device supports reset, false otherwise. +*/ +static bool is_sysfs_reset_supported (int fd) +{ +struct stat st; +int rc; +int sysfs; +int reset_fd =-1 ; + + sysfs =igt_sysfs_open (fd); + +if (sysfs >=0 ) { + reset_fd =openat (sysfs,"device/reset" ,O_WRONLY ); +close (sysfs); + } + +if (reset_fd <0 ) +return false; + + rc =fstat (reset_fd, &st); +close (reset_fd); + +if (rc || !S_ISREG (st.st_mode)) +return false; + +return true; +} + +/* Unbind the driver from the device */ +static void driver_unbind (struct device_fds *dev) +{ +igt_debug ("unbind the driver from the device\n" ); +igt_assert (igt_sysfs_set (dev->fds.drv_dir,"unbind" , + dev->dev_bus_addr)); +} + +/* Re-bind the driver to the device */ +static void driver_bind (struct device_fds *dev) +{ +igt_debug ("rebind the driver to the device\n" ); +igt_abort_on_f (!igt_sysfs_set (dev->fds.drv_dir,"bind" , + dev->dev_bus_addr),"driver rebind failed" ); +} + +/* Initiate device reset */ +static void initiate_device_reset (struct device_fds *dev) +{ +igt_debug ("reset device\n" ); +igt_assert (igt_sysfs_set (dev->fds.dev_dir,"reset" ,"1" )); +} + +static bool is_i915_wedged (int i915) +{ +int err =0 ; + +if (ioctl (i915,DRM_IOCTL_I915_GEM_THROTTLE )) + err = -errno; +return err == -EIO ; +} + +/** +* healthcheck: +* @dev: structure with device descriptor, if descriptor equals -1 +* the device is reopened +*/ +static void healthcheck (struct device_fds *dev) +{ +if (dev->fds.dev ==-1 ) { +/* refresh device list */ +igt_devices_scan (true); +igt_debug ("reopen the device\n" ); + dev->fds.dev =__drm_open_driver (DRIVER_ANY ); + } +igt_assert_fd (dev->fds.dev); + +if (is_i915_device (dev->fds.dev)) +igt_assert (!is_i915_wedged (dev->fds.dev)); +} + +/** +* set_device_filter: +* +* Sets device filter to ensure subtests always reopen the same device +* +* @dev_path: path to device under tests +*/ +static void set_device_filter (const char * dev_path) +{ +#define FILTER_PREFIX_LEN 4 +char filter[PATH_MAX +FILTER_PREFIX_LEN ]; + +igt_assert_lt (FILTER_PREFIX_LEN ,snprintf (filter,sizeof (filter), +"sys:%s" , dev_path)); +igt_device_filter_free_all (); +igt_assert_eq (igt_device_filter_add (filter),1 ); +} + +static void unbind_reset_rebind (struct device_fds *dev) +{ +igt_debug ("close the device\n" ); +close_if_opened (&dev->fds.dev); + +driver_unbind (dev); + +initiate_device_reset (dev); + +driver_bind (dev); +} + +igt_main +{ +struct device_fds dev = { .fds = {-1 ,-1 ,-1 }, .dev_bus_addr = {0 }}; + + igt_fixture { +char dev_path[PATH_MAX ]; + +igt_debug ("opening device\n" ); +init_device_fds (&dev); + +/* Make sure subtests always reopen the same device */ +igt_assert (device_sysfs_path (dev.fds.dev, dev_path)); +set_device_filter (dev_path); + +igt_skip_on (!is_sysfs_reset_supported (dev.fds.dev)); + +igt_set_timeout (60 ,"device reset tests timed out after 60s" ); + } + +igt_describe ("Unbinds driver from device, initiates reset" +" then rebinds driver to device" ); + igt_subtest("unbind-reset-rebind") { +unbind_reset_rebind (&dev); +healthcheck (&dev); + } + +igt_describe ("Resets device with bound driver" ); + igt_subtest("reset-bound") { +initiate_device_reset (&dev); +healthcheck (&dev); + } + + igt_fixture { +igt_reset_timeout (); +cleanup_device_fds (&dev); + } +}tests/intel-ci/blacklist.txt +0
-0
tests/intel-ci/blacklist.txt igt@perf_pmu@cpu-hotplug · line 126
Quoted 7 lines
tests/intel-ci/blacklist.txt +3
-0@@ -121,3 +121,6 @@ igt@perf_pmu@cpu-hotplug # Currently fails and leaves the machine in a very bad state, and # causes coverage loss for other tests. igt@core_hotunplug@.* + +# hangs several gens of hosts, and has no immediate fix +igt@device_reset@reset-bound
I'm only not sure if that missing newline will not break CI scripts, other than that, my R-b still applies.
Thanks,
Janusz
tests/meson.build test_progs = [ · line 14
Quoted 12 lines
tests/meson.build +1
-0@@ -8,6 +8,7 @@ test_progs = [ 'core_setmaster_vs_auth', 'debugfs_test', 'dmabuf', + 'device_reset', 'drm_import_export', 'drm_mm', 'drm_read',
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 328 lines · Janusz Krzysztofik
Quoted 316 lines · Marcin Bernatowicz
Device reset is initiated by writing "1" to reset sysfs file, which should initiate PCI device Function Level Reset if supported by device.
Test scenarios:
1. unbind driver from device, initiate sysfs reset, rebind driver to device
2. device reset with bound driverv2: removed unbind-rebind (duplicates core_hotunplug@unbind-rebind)
added healthcheck to each test (Janusz)
v3: after review corrections (renamedsysfs_fdstodevice_fds,
corrected not closed file descriptor, removed variable length array)
v4: updated description (Martin), snprintf corrections (Janusz),
reset-bound added to blacklist as it hangs several gens of hosts (Tomi)Signed-off-by Marcin Bernatowicz <[email protected]>--- tests/device_reset.c | 281 +++++++++++++++++++++++++++++++++++ tests/intel-ci/blacklist.txt | 3 + tests/meson.build | 1 + 3 files changed, 285 insertions(+) create mode 100644 tests/device_reset.ctests/device_reset.c new file +281
-0@@ -0,0 +1,281 @@ +// SPDX-License-Identifier: MIT +/* +* Copyright(c) 2020 Intel Corporation. All rights reserved. +*/ +#include <fcntl.h> +#include <sys/ioctl.h> +#include <sys/stat.h> + +#include "i915/gem.h" +#include "igt.h" +#include "igt_device_scan.h" +#include "igt_sysfs.h" + +IGT_TEST_DESCRIPTION ("Examine behavior of a driver on device sysfs reset" ); + + +#define DEV_PATH_LEN 80 +#define DEV_BUS_ADDR_LEN 13/* addr has form 0000:00:00.0 */ + +/** +* Helper structure containing file descriptors +* and bus address related to tested device +*/ +struct device_fds { +struct { +int dev; +int dev_dir; +int drv_dir; + } fds; +char dev_bus_addr[DEV_BUS_ADDR_LEN ]; +}; + +static int __open_sysfs_dir (int fd,const char * path) +{ +int sysfs; + + sysfs =igt_sysfs_open (fd); +if (sysfs <0 ) { +return -1 ; + } + + fd =openat (sysfs, path,O_DIRECTORY ); +close (sysfs); +return fd; +} + +static int open_device_sysfs_dir (int fd) +{ +return __open_sysfs_dir (fd,"device" ); +} + +static int open_driver_sysfs_dir (int fd) +{ +return __open_sysfs_dir (fd,"device/driver" ); +} + +/** +* device_sysfs_path: +* @fd: opened device file descriptor +* @path: buffer to store sysfs path to device directory +* +* Returns: +* On successfull path resolution sysfs path to device directory, +* NULL otherwise +*/ +static char *device_sysfs_path (int fd,char *path) +{ +char sysfs[DEV_PATH_LEN ]; + +if (!igt_sysfs_path (fd, sysfs,sizeof (sysfs))) +return NULL ; + +if (DEV_PATH_LEN <= (strlen (sysfs) +strlen ("/device" ))) +return NULL ; + +strcat (sysfs,"/device" ); + +return realpath (sysfs, path); +} + +static void init_device_fds (struct device_fds *dev) +{ +char dev_path[PATH_MAX ]; +char *addr_pos; + +igt_debug ("open device\n" ); +/** +* As subtests must be able to close examined devices +* completely, don't use drm_open_driver() as it keeps +* a device file descriptor open for exit handler use. +*/ + dev->fds.dev =__drm_open_driver (DRIVER_ANY ); +igt_assert_fd (dev->fds.dev); +if (is_i915_device (dev->fds.dev)) +igt_require_gem (dev->fds.dev); + +igt_assert (device_sysfs_path (dev->fds.dev, dev_path)); + addr_pos =strrchr (dev_path,'/' ); +igt_assert (addr_pos); +igt_assert_eq (sizeof (dev->dev_bus_addr) -1 , +snprintf (dev->dev_bus_addr,sizeof (dev->dev_bus_addr), +"%s" , addr_pos +1 )); + + dev->fds.dev_dir =open_device_sysfs_dir (dev->fds.dev); +igt_assert_fd (dev->fds.dev_dir); + + dev->fds.drv_dir =open_driver_sysfs_dir (dev->fds.dev); +igt_assert_fd (dev->fds.drv_dir); +} + +static int close_if_opened (int *fd) +{ +int rc =0 ; + +if (fd && *fd !=-1 ) { + rc =close (*fd); + *fd =-1 ; + } +return rc; +} + +static void cleanup_device_fds (struct device_fds *dev) +{ +igt_ignore_warn (close_if_opened (&dev->fds.dev)); +igt_ignore_warn (close_if_opened (&dev->fds.dev_dir)); +igt_ignore_warn (close_if_opened (&dev->fds.drv_dir)); +} + +/** +* is_sysfs_reset_supported: +* @fd: opened device file descriptor +* +* Check if device supports reset based on sysfs file presence. +* +* Returns: +* True if device supports reset, false otherwise. +*/ +static bool is_sysfs_reset_supported (int fd) +{ +struct stat st; +int rc; +int sysfs; +int reset_fd =-1 ; + + sysfs =igt_sysfs_open (fd); + +if (sysfs >=0 ) { + reset_fd =openat (sysfs,"device/reset" ,O_WRONLY ); +close (sysfs); + } + +if (reset_fd <0 ) +return false; + + rc =fstat (reset_fd, &st); +close (reset_fd); + +if (rc || !S_ISREG (st.st_mode)) +return false; + +return true; +} + +/* Unbind the driver from the device */ +static void driver_unbind (struct device_fds *dev) +{ +igt_debug ("unbind the driver from the device\n" ); +igt_assert (igt_sysfs_set (dev->fds.drv_dir,"unbind" , + dev->dev_bus_addr)); +} + +/* Re-bind the driver to the device */ +static void driver_bind (struct device_fds *dev) +{ +igt_debug ("rebind the driver to the device\n" ); +igt_abort_on_f (!igt_sysfs_set (dev->fds.drv_dir,"bind" , + dev->dev_bus_addr),"driver rebind failed" ); +} + +/* Initiate device reset */ +static void initiate_device_reset (struct device_fds *dev) +{ +igt_debug ("reset device\n" ); +igt_assert (igt_sysfs_set (dev->fds.dev_dir,"reset" ,"1" )); +} + +static bool is_i915_wedged (int i915) +{ +int err =0 ; + +if (ioctl (i915,DRM_IOCTL_I915_GEM_THROTTLE )) + err = -errno; +return err == -EIO ; +} + +/** +* healthcheck: +* @dev: structure with device descriptor, if descriptor equals -1 +* the device is reopened +*/ +static void healthcheck (struct device_fds *dev) +{ +if (dev->fds.dev ==-1 ) { +/* refresh device list */ +igt_devices_scan (true); +igt_debug ("reopen the device\n" ); + dev->fds.dev =__drm_open_driver (DRIVER_ANY ); + } +igt_assert_fd (dev->fds.dev); + +if (is_i915_device (dev->fds.dev)) +igt_assert (!is_i915_wedged (dev->fds.dev)); +} + +/** +* set_device_filter: +* +* Sets device filter to ensure subtests always reopen the same device +* +* @dev_path: path to device under tests +*/ +static void set_device_filter (const char * dev_path) +{ +#define FILTER_PREFIX_LEN 4 +char filter[PATH_MAX +FILTER_PREFIX_LEN ]; + +igt_assert_lt (FILTER_PREFIX_LEN ,snprintf (filter,sizeof (filter), +"sys:%s" , dev_path)); +igt_device_filter_free_all (); +igt_assert_eq (igt_device_filter_add (filter),1 ); +} + +static void unbind_reset_rebind (struct device_fds *dev) +{ +igt_debug ("close the device\n" ); +close_if_opened (&dev->fds.dev); + +driver_unbind (dev); + +initiate_device_reset (dev); + +driver_bind (dev); +} + +igt_main +{ +struct device_fds dev = { .fds = {-1 ,-1 ,-1 }, .dev_bus_addr = {0 }}; + + igt_fixture { +char dev_path[PATH_MAX ]; + +igt_debug ("opening device\n" ); +init_device_fds (&dev); + +/* Make sure subtests always reopen the same device */ +igt_assert (device_sysfs_path (dev.fds.dev, dev_path)); +set_device_filter (dev_path); + +igt_skip_on (!is_sysfs_reset_supported (dev.fds.dev)); + +igt_set_timeout (60 ,"device reset tests timed out after 60s" ); + } + +igt_describe ("Unbinds driver from device, initiates reset" +" then rebinds driver to device" ); + igt_subtest("unbind-reset-rebind") { +unbind_reset_rebind (&dev); +healthcheck (&dev); + } + +igt_describe ("Resets device with bound driver" ); + igt_subtest("reset-bound") { +initiate_device_reset (&dev); +healthcheck (&dev); + } + + igt_fixture { +igt_reset_timeout (); +cleanup_device_fds (&dev); + } +}tests/intel-ci/blacklist.txt +0
-0tests/intel-ci/blacklist.txt igt@perf_pmu@cpu-hotplug · line 126
Quoted 7 lines
tests/intel-ci/blacklist.txt +3
-0@@ -121,3 +121,6 @@ igt@perf_pmu@cpu-hotplug # Currently fails and leaves the machine in a very bad state, and # causes coverage loss for other tests. igt@core_hotunplug@.* + +# hangs several gens of hosts, and has no immediate fix +igt@device_reset@reset-boundI'm only not sure if that missing newline will not break CI scripts, other than that, my R-b still applies.
Quoted 4 lines
Reviewed-by Janusz Krzysztofik <[email protected]>Thanks,
Janusz
I think intel-ci scripts can deal with newlines :) Kasia
Quoted 15 lines
Quoted 7 lines
tests/meson.build +0
-0tests/meson.build test_progs = [ · line 14
Quoted 7 lines
tests/meson.build +1
-0@@ -8,6 +8,7 @@ test_progs = [ 'core_setmaster_vs_auth', 'debugfs_test', 'dmabuf', + 'device_reset', 'drm_import_export', 'drm_mm', 'drm_read',
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Rodrigo Vivi
Acked-byQuoted 315 lines · Janusz Krzysztofik
Quoted 314 lines · Marcin Bernatowicz
Device reset is initiated by writing "1" to reset sysfs file, which should initiate PCI device Function Level Reset if supported by device.
Test scenarios:
1. unbind driver from device, initiate sysfs reset, rebind driver to device
2. device reset with bound driverv2: removed unbind-rebind (duplicates core_hotunplug@unbind-rebind)
added healthcheck to each test (Janusz)
v3: after review corrections (renamedsysfs_fdstodevice_fds,
corrected not closed file descriptor, removed variable length array)
v4: updated description (Martin), snprintf corrections (Janusz),
reset-bound added to blacklist as it hangs several gens of hosts (Tomi)Signed-off-by Marcin Bernatowicz <[email protected]>--- tests/device_reset.c | 281 +++++++++++++++++++++++++++++++++++ tests/intel-ci/blacklist.txt | 3 + tests/meson.build | 1 + 3 files changed, 285 insertions(+) create mode 100644 tests/device_reset.ctests/device_reset.c new file +281
-0@@ -0,0 +1,281 @@ +// SPDX-License-Identifier: MIT +/* +* Copyright(c) 2020 Intel Corporation. All rights reserved. +*/ +#include <fcntl.h> +#include <sys/ioctl.h> +#include <sys/stat.h> + +#include "i915/gem.h" +#include "igt.h" +#include "igt_device_scan.h" +#include "igt_sysfs.h" + +IGT_TEST_DESCRIPTION ("Examine behavior of a driver on device sysfs reset" ); + + +#define DEV_PATH_LEN 80 +#define DEV_BUS_ADDR_LEN 13/* addr has form 0000:00:00.0 */ + +/** +* Helper structure containing file descriptors +* and bus address related to tested device +*/ +struct device_fds { +struct { +int dev; +int dev_dir; +int drv_dir; + } fds; +char dev_bus_addr[DEV_BUS_ADDR_LEN ]; +}; + +static int __open_sysfs_dir (int fd,const char * path) +{ +int sysfs; + + sysfs =igt_sysfs_open (fd); +if (sysfs <0 ) { +return -1 ; + } + + fd =openat (sysfs, path,O_DIRECTORY ); +close (sysfs); +return fd; +} + +static int open_device_sysfs_dir (int fd) +{ +return __open_sysfs_dir (fd,"device" ); +} + +static int open_driver_sysfs_dir (int fd) +{ +return __open_sysfs_dir (fd,"device/driver" ); +} + +/** +* device_sysfs_path: +* @fd: opened device file descriptor +* @path: buffer to store sysfs path to device directory +* +* Returns: +* On successfull path resolution sysfs path to device directory, +* NULL otherwise +*/ +static char *device_sysfs_path (int fd,char *path) +{ +char sysfs[DEV_PATH_LEN ]; + +if (!igt_sysfs_path (fd, sysfs,sizeof (sysfs))) +return NULL ; + +if (DEV_PATH_LEN <= (strlen (sysfs) +strlen ("/device" ))) +return NULL ; + +strcat (sysfs,"/device" ); + +return realpath (sysfs, path); +} + +static void init_device_fds (struct device_fds *dev) +{ +char dev_path[PATH_MAX ]; +char *addr_pos; + +igt_debug ("open device\n" ); +/** +* As subtests must be able to close examined devices +* completely, don't use drm_open_driver() as it keeps +* a device file descriptor open for exit handler use. +*/ + dev->fds.dev =__drm_open_driver (DRIVER_ANY ); +igt_assert_fd (dev->fds.dev); +if (is_i915_device (dev->fds.dev)) +igt_require_gem (dev->fds.dev); + +igt_assert (device_sysfs_path (dev->fds.dev, dev_path)); + addr_pos =strrchr (dev_path,'/' ); +igt_assert (addr_pos); +igt_assert_eq (sizeof (dev->dev_bus_addr) -1 , +snprintf (dev->dev_bus_addr,sizeof (dev->dev_bus_addr), +"%s" , addr_pos +1 )); + + dev->fds.dev_dir =open_device_sysfs_dir (dev->fds.dev); +igt_assert_fd (dev->fds.dev_dir); + + dev->fds.drv_dir =open_driver_sysfs_dir (dev->fds.dev); +igt_assert_fd (dev->fds.drv_dir); +} + +static int close_if_opened (int *fd) +{ +int rc =0 ; + +if (fd && *fd !=-1 ) { + rc =close (*fd); + *fd =-1 ; + } +return rc; +} + +static void cleanup_device_fds (struct device_fds *dev) +{ +igt_ignore_warn (close_if_opened (&dev->fds.dev)); +igt_ignore_warn (close_if_opened (&dev->fds.dev_dir)); +igt_ignore_warn (close_if_opened (&dev->fds.drv_dir)); +} + +/** +* is_sysfs_reset_supported: +* @fd: opened device file descriptor +* +* Check if device supports reset based on sysfs file presence. +* +* Returns: +* True if device supports reset, false otherwise. +*/ +static bool is_sysfs_reset_supported (int fd) +{ +struct stat st; +int rc; +int sysfs; +int reset_fd =-1 ; + + sysfs =igt_sysfs_open (fd); + +if (sysfs >=0 ) { + reset_fd =openat (sysfs,"device/reset" ,O_WRONLY ); +close (sysfs); + } + +if (reset_fd <0 ) +return false; + + rc =fstat (reset_fd, &st); +close (reset_fd); + +if (rc || !S_ISREG (st.st_mode)) +return false; + +return true; +} + +/* Unbind the driver from the device */ +static void driver_unbind (struct device_fds *dev) +{ +igt_debug ("unbind the driver from the device\n" ); +igt_assert (igt_sysfs_set (dev->fds.drv_dir,"unbind" , + dev->dev_bus_addr)); +} + +/* Re-bind the driver to the device */ +static void driver_bind (struct device_fds *dev) +{ +igt_debug ("rebind the driver to the device\n" ); +igt_abort_on_f (!igt_sysfs_set (dev->fds.drv_dir,"bind" , + dev->dev_bus_addr),"driver rebind failed" ); +} + +/* Initiate device reset */ +static void initiate_device_reset (struct device_fds *dev) +{ +igt_debug ("reset device\n" ); +igt_assert (igt_sysfs_set (dev->fds.dev_dir,"reset" ,"1" )); +} + +static bool is_i915_wedged (int i915) +{ +int err =0 ; + +if (ioctl (i915,DRM_IOCTL_I915_GEM_THROTTLE )) + err = -errno; +return err == -EIO ; +} + +/** +* healthcheck: +* @dev: structure with device descriptor, if descriptor equals -1 +* the device is reopened +*/ +static void healthcheck (struct device_fds *dev) +{ +if (dev->fds.dev ==-1 ) { +/* refresh device list */ +igt_devices_scan (true); +igt_debug ("reopen the device\n" ); + dev->fds.dev =__drm_open_driver (DRIVER_ANY ); + } +igt_assert_fd (dev->fds.dev); + +if (is_i915_device (dev->fds.dev)) +igt_assert (!is_i915_wedged (dev->fds.dev)); +} + +/** +* set_device_filter: +* +* Sets device filter to ensure subtests always reopen the same device +* +* @dev_path: path to device under tests +*/ +static void set_device_filter (const char * dev_path) +{ +#define FILTER_PREFIX_LEN 4 +char filter[PATH_MAX +FILTER_PREFIX_LEN ]; + +igt_assert_lt (FILTER_PREFIX_LEN ,snprintf (filter,sizeof (filter), +"sys:%s" , dev_path)); +igt_device_filter_free_all (); +igt_assert_eq (igt_device_filter_add (filter),1 ); +} + +static void unbind_reset_rebind (struct device_fds *dev) +{ +igt_debug ("close the device\n" ); +close_if_opened (&dev->fds.dev); + +driver_unbind (dev); + +initiate_device_reset (dev); + +driver_bind (dev); +} + +igt_main +{ +struct device_fds dev = { .fds = {-1 ,-1 ,-1 }, .dev_bus_addr = {0 }}; + + igt_fixture { +char dev_path[PATH_MAX ]; + +igt_debug ("opening device\n" ); +init_device_fds (&dev); + +/* Make sure subtests always reopen the same device */ +igt_assert (device_sysfs_path (dev.fds.dev, dev_path)); +set_device_filter (dev_path); + +igt_skip_on (!is_sysfs_reset_supported (dev.fds.dev)); + +igt_set_timeout (60 ,"device reset tests timed out after 60s" ); + } + +igt_describe ("Unbinds driver from device, initiates reset" +" then rebinds driver to device" ); + igt_subtest("unbind-reset-rebind") { +unbind_reset_rebind (&dev); +healthcheck (&dev); + } + +igt_describe ("Resets device with bound driver" ); + igt_subtest("reset-bound") { +initiate_device_reset (&dev); +healthcheck (&dev); + } + + igt_fixture { +igt_reset_timeout (); +cleanup_device_fds (&dev); + } +}tests/intel-ci/blacklist.txt +0
-1--- a/tests/intel-ci/blacklist.txt
Quoted 8 lines
tests/intel-ci/blacklist.txt igt@perf_pmu@cpu-hotplug · line 126
Quoted 8 lines
+++
b/tests/intel-ci/blacklist.txttests/intel-ci/blacklist.txt +3
-0@@ -121,3 +121,6 @@ igt@perf_pmu@cpu-hotplug # Currently fails and leaves the machine in a very bad state, and # causes coverage loss for other tests. igt@core_hotunplug@.* + +# hangs several gens of hosts, and has no immediate fix +igt@device_reset@reset-bound
I wonder if we should filter by platform?
if gen >= 12? or if dgfx?
or is it really random?
Quoted 6 lines
Quoted 1 line
\ No newline at end of file
I'm only not sure if that missing newline will not break CI scripts, other than that, my R-b still applies.
Reviewed-by Janusz Krzysztofik <[email protected]>
anyway it looks good to me
Quoted 5 lines
Thanks,
Janusz
Quoted 13 lines
tests/meson.build test_progs = [ · line 14
Quoted 12 lines
tests/meson.build +1
-0@@ -8,6 +8,7 @@ test_progs = [ 'core_setmaster_vs_auth', 'debugfs_test', 'dmabuf', + 'device_reset', 'drm_import_export', 'drm_mm', 'drm_read',
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 343 lines · Rodrigo Vivi
Quoted 330 lines · Janusz Krzysztofik
Quoted 329 lines · Marcin Bernatowicz
Device reset is initiated by writing "1" to reset sysfs file, which should initiate PCI device Function Level Reset if supported by device.
Test scenarios:
1. unbind driver from device, initiate sysfs reset, rebind driver to
device
2. device reset with bound driverv2: removed unbind-rebind (duplicates core_hotunplug@unbind-rebind)
added healthcheck to each test (Janusz)
v3: after review corrections (renamedsysfs_fdstodevice_fds,
corrected not closed file descriptor, removed variable length
array)
v4: updated description (Martin), snprintf corrections (Janusz),
reset-bound added to blacklist as it hangs several gens of
hosts (Tomi)Signed-off-by Marcin Bernatowicz <[email protected]>--- tests/device_reset.c | 281 +++++++++++++++++++++++++++++++++++ tests/intel-ci/blacklist.txt | 3 + tests/meson.build | 1 + 3 files changed, 285 insertions(+) create mode 100644 tests/device_reset.ctests/device_reset.c new file +14
-0@@ -0,0 +1,281 @@ +// SPDX-License-Identifier: MIT +/* +* Copyright(c) 2020 Intel Corporation. All rights reserved. +*/ +#include <fcntl.h> +#include <sys/ioctl.h> +#include <sys/stat.h> + +#include "i915/gem.h" +#include "igt.h" +#include "igt_device_scan.h" +#include "igt_sysfs.h" + +IGT_TEST_DESCRIPTION("Examine behavior of a driver on devicesysfs reset");
tests/device_reset.c new file +49
-0+ + +#define DEV_PATH_LEN 80 +#define DEV_BUS_ADDR_LEN 13/* addr has form 0000:00:00.0 */ + +/** +* Helper structure containing file descriptors +* and bus address related to tested device +*/ +struct device_fds { +struct { +int dev; +int dev_dir; +int drv_dir; + } fds; +char dev_bus_addr[DEV_BUS_ADDR_LEN ]; +}; + +static int __open_sysfs_dir (int fd,const char * path) +{ +int sysfs; + + sysfs =igt_sysfs_open (fd); +if (sysfs <0 ) { +return -1 ; + } + + fd =openat (sysfs, path,O_DIRECTORY ); +close (sysfs); +return fd; +} + +static int open_device_sysfs_dir (int fd) +{ +return __open_sysfs_dir (fd,"device" ); +} + +static int open_driver_sysfs_dir (int fd) +{ +return __open_sysfs_dir (fd,"device/driver" ); +} + +/** +* device_sysfs_path: +* @fd: opened device file descriptor +* @path: buffer to store sysfs path to device directory +* +* Returns: +* On successfull path resolution sysfs path to device directory,
+ * NULL otherwise
+ */tests/device_reset.c new file +36
-0+static char *device_sysfs_path (int fd,char *path) +{ +char sysfs[DEV_PATH_LEN ]; + +if (!igt_sysfs_path (fd, sysfs,sizeof (sysfs))) +return NULL ; + +if (DEV_PATH_LEN <= (strlen (sysfs) +strlen ("/device" ))) +return NULL ; + +strcat (sysfs,"/device" ); + +return realpath (sysfs, path); +} + +static void init_device_fds (struct device_fds *dev) +{ +char dev_path[PATH_MAX ]; +char *addr_pos; + +igt_debug ("open device\n" ); +/** +* As subtests must be able to close examined devices +* completely, don't use drm_open_driver() as it keeps +* a device file descriptor open for exit handler use. +*/ + dev->fds.dev =__drm_open_driver (DRIVER_ANY ); +igt_assert_fd (dev->fds.dev); +if (is_i915_device (dev->fds.dev)) +igt_require_gem (dev->fds.dev); + +igt_assert (device_sysfs_path (dev->fds.dev, dev_path)); + addr_pos =strrchr (dev_path,'/' ); +igt_assert (addr_pos); + igt_assert_eq(sizeof(dev->dev_bus_addr) - 1, + snprintf(dev->dev_bus_addr, sizeof(dev-Quoted 1 line
dev_bus_addr),tests/device_reset.c new file +117
-1+ "%s", addr_pos + 1)); + + dev->fds.dev_dir =open_device_sysfs_dir (dev->fds.dev); +igt_assert_fd (dev->fds.dev_dir); + + dev->fds.drv_dir =open_driver_sysfs_dir (dev->fds.dev); +igt_assert_fd (dev->fds.drv_dir); +} + +static int close_if_opened (int *fd) +{ +int rc =0 ; + +if (fd && *fd !=-1 ) { + rc =close (*fd); + *fd =-1 ; + } +return rc; +} + +static void cleanup_device_fds (struct device_fds *dev) +{ +igt_ignore_warn (close_if_opened (&dev->fds.dev)); +igt_ignore_warn (close_if_opened (&dev->fds.dev_dir)); +igt_ignore_warn (close_if_opened (&dev->fds.drv_dir)); +} + +/** +* is_sysfs_reset_supported: +* @fd: opened device file descriptor +* +* Check if device supports reset based on sysfs file presence. +* +* Returns: +* True if device supports reset, false otherwise. +*/ +static bool is_sysfs_reset_supported (int fd) +{ +struct stat st; +int rc; +int sysfs; +int reset_fd =-1 ; + + sysfs =igt_sysfs_open (fd); + +if (sysfs >=0 ) { + reset_fd =openat (sysfs,"device/reset" ,O_WRONLY ); +close (sysfs); + } + +if (reset_fd <0 ) +return false; + + rc =fstat (reset_fd, &st); +close (reset_fd); + +if (rc || !S_ISREG (st.st_mode)) +return false; + +return true; +} + +/* Unbind the driver from the device */ +static void driver_unbind (struct device_fds *dev) +{ +igt_debug ("unbind the driver from the device\n" ); +igt_assert (igt_sysfs_set (dev->fds.drv_dir,"unbind" , + dev->dev_bus_addr)); +} + +/* Re-bind the driver to the device */ +static void driver_bind (struct device_fds *dev) +{ +igt_debug ("rebind the driver to the device\n" ); +igt_abort_on_f (!igt_sysfs_set (dev->fds.drv_dir,"bind" , + dev->dev_bus_addr),"driver rebind failed" ); +} + +/* Initiate device reset */ +static void initiate_device_reset (struct device_fds *dev) +{ +igt_debug ("reset device\n" ); +igt_assert (igt_sysfs_set (dev->fds.dev_dir,"reset" ,"1" )); +} + +static bool is_i915_wedged (int i915) +{ +int err =0 ; + +if (ioctl (i915,DRM_IOCTL_I915_GEM_THROTTLE )) + err = -errno; +return err == -EIO ; +} + +/** +* healthcheck: +* @dev: structure with device descriptor, if descriptor equals -1 +* the device is reopened +*/ +static void healthcheck (struct device_fds *dev) +{ +if (dev->fds.dev ==-1 ) { +/* refresh device list */ +igt_devices_scan (true); +igt_debug ("reopen the device\n" ); + dev->fds.dev =__drm_open_driver (DRIVER_ANY ); + } +igt_assert_fd (dev->fds.dev); + +if (is_i915_device (dev->fds.dev)) +igt_assert (!is_i915_wedged (dev->fds.dev)); +} + +/** +* set_device_filter: +* +* Sets device filter to ensure subtests always reopen the same device
+ *
+ * @dev_path: path to device under tests
+ */tests/device_reset.c new file +6
-0+static void set_device_filter (const char * dev_path) +{ +#define FILTER_PREFIX_LEN 4 +char filter[PATH_MAX +FILTER_PREFIX_LEN ]; + + igt_assert_lt(FILTER_PREFIX_LEN, snprintf(filter,sizeof(filter),
tests/device_reset.c new file +20
-0+ "sys:%s", dev_path)); +igt_device_filter_free_all (); +igt_assert_eq (igt_device_filter_add (filter),1 ); +} + +static void unbind_reset_rebind (struct device_fds *dev) +{ +igt_debug ("close the device\n" ); +close_if_opened (&dev->fds.dev); + +driver_unbind (dev); + +initiate_device_reset (dev); + +driver_bind (dev); +} + +igt_main +{ + struct device_fds dev = { .fds = {-1, -1, -1}, .dev_bus_addr ={0}};
tests/device_reset.c new file +14
-0+ + igt_fixture { +char dev_path[PATH_MAX ]; + +igt_debug ("opening device\n" ); +init_device_fds (&dev); + +/* Make sure subtests always reopen the same device */ +igt_assert (device_sysfs_path (dev.fds.dev, dev_path)); +set_device_filter (dev_path); + +igt_skip_on (!is_sysfs_reset_supported (dev.fds.dev)); + + igt_set_timeout(60, "device reset tests timed out after60s");
tests/device_reset.c new file +20
-0+ } + +igt_describe ("Unbinds driver from device, initiates reset" +" then rebinds driver to device" ); + igt_subtest("unbind-reset-rebind") { +unbind_reset_rebind (&dev); +healthcheck (&dev); + } + +igt_describe ("Resets device with bound driver" ); + igt_subtest("reset-bound") { +initiate_device_reset (&dev); +healthcheck (&dev); + } + + igt_fixture { +igt_reset_timeout (); +cleanup_device_fds (&dev); + } +}tests/intel- renamed from tests/intel-ci/blacklist.txt +0
-0
ci/blacklist.txt
indexecbec5080..f9a57cb54100644tests/intel-ci/blacklist.txt +0
-0Quoted 8 lines
tests/intel-ci/blacklist.txt igt@perf_pmu@cpu-hotplug · line 126
Quoted 8 lines
tests/intel-ci/blacklist.txt +0
-0@@ -121,3 +121,6 @@ igt@perf_pmu@cpu-hotplug # Currently fails and leaves the machine in a very bad state,and
# causes coverage loss for other tests. igt@core_hotunplug@.*tests/intel-ci/blacklist.txt +3
-0+ +# hangs several gens of hosts, and has no immediate fix +igt@device_reset@reset-boundI wonder if we should filter by platform?
if gen >= 12? or if dgfx?
Quoted 1 line
or is it really random?
I can restrict the tests on intel platforms with
if (is_i915_device(fd))
igt_skip_on(intel_gen(intel_get_drm_devid(fd)) < 12);
Quoted 21 lines
Quoted 9 lines
Quoted 2 lines
\ No newline at end of file
I'm only not sure if that missing newline will not break CI scripts,
other than that, my R-b still applies.Reviewed-by Janusz Krzysztofik <[email protected]Quoted 1 line
anyway it looks good to me
Acked-by Rodrigo Vivi <[email protected]>Quoted 5 lines
Thanks,
Janusz
Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
tests/meson.build +0
-0Quoted 8 lines
tests/meson.build test_progs = [ · line 14
Quoted 8 lines
tests/meson.build +1
-0@@ -8,6 +8,7 @@ test_progs = [ 'core_setmaster_vs_auth', 'debugfs_test', 'dmabuf', + 'device_reset', 'drm_import_export', 'drm_mm', 'drm_read',
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Sowackiego 173 | 80-298 Gdask | Sd Rejonowy Gdask Pnoc | VII Wydzia Gospodarczy Krajowego Rejestru Sdowego - KRS 101882 | NIP 957-07-52-316 | Kapita zakadowy 200.000 PLN.
Ta wiadomo wraz z zacznikami jest przeznaczona dla okrelonego adresata i moe zawiera informacje poufne. W razie przypadkowego otrzymania tej wiadomoci, prosimy o powiadomienie nadawcy oraz trwae jej usunicie; jakiekolwiek przegldanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 344 lines · Marcin
Quoted 343 lines · Rodrigo Vivi
Quoted 330 lines · Janusz Krzysztofik
Quoted 329 lines · Marcin Bernatowicz
Device reset is initiated by writing "1" to reset sysfs file, which should initiate PCI device Function Level Reset if supported by device.
Test scenarios:
1. unbind driver from device, initiate sysfs reset, rebind driver to
device
2. device reset with bound driverv2: removed unbind-rebind (duplicates core_hotunplug@unbind-rebind)
added healthcheck to each test (Janusz)
v3: after review corrections (renamedsysfs_fdstodevice_fds,
corrected not closed file descriptor, removed variable length
array)
v4: updated description (Martin), snprintf corrections (Janusz),
reset-bound added to blacklist as it hangs several gens of
hosts (Tomi)Signed-off-by Marcin Bernatowicz <[email protected]>--- tests/device_reset.c | 281 +++++++++++++++++++++++++++++++++++ tests/intel-ci/blacklist.txt | 3 + tests/meson.build | 1 + 3 files changed, 285 insertions(+) create mode 100644 tests/device_reset.ctests/device_reset.c new file +14
-0@@ -0,0 +1,281 @@ +// SPDX-License-Identifier: MIT +/* +* Copyright(c) 2020 Intel Corporation. All rights reserved. +*/ +#include <fcntl.h> +#include <sys/ioctl.h> +#include <sys/stat.h> + +#include "i915/gem.h" +#include "igt.h" +#include "igt_device_scan.h" +#include "igt_sysfs.h" + +IGT_TEST_DESCRIPTION("Examine behavior of a driver on devicesysfs reset");
tests/device_reset.c new file +49
-0+ + +#define DEV_PATH_LEN 80 +#define DEV_BUS_ADDR_LEN 13/* addr has form 0000:00:00.0 */ + +/** +* Helper structure containing file descriptors +* and bus address related to tested device +*/ +struct device_fds { +struct { +int dev; +int dev_dir; +int drv_dir; + } fds; +char dev_bus_addr[DEV_BUS_ADDR_LEN ]; +}; + +static int __open_sysfs_dir (int fd,const char * path) +{ +int sysfs; + + sysfs =igt_sysfs_open (fd); +if (sysfs <0 ) { +return -1 ; + } + + fd =openat (sysfs, path,O_DIRECTORY ); +close (sysfs); +return fd; +} + +static int open_device_sysfs_dir (int fd) +{ +return __open_sysfs_dir (fd,"device" ); +} + +static int open_driver_sysfs_dir (int fd) +{ +return __open_sysfs_dir (fd,"device/driver" ); +} + +/** +* device_sysfs_path: +* @fd: opened device file descriptor +* @path: buffer to store sysfs path to device directory +* +* Returns: +* On successfull path resolution sysfs path to device directory,
+ * NULL otherwise
+ */tests/device_reset.c new file +36
-0+static char *device_sysfs_path (int fd,char *path) +{ +char sysfs[DEV_PATH_LEN ]; + +if (!igt_sysfs_path (fd, sysfs,sizeof (sysfs))) +return NULL ; + +if (DEV_PATH_LEN <= (strlen (sysfs) +strlen ("/device" ))) +return NULL ; + +strcat (sysfs,"/device" ); + +return realpath (sysfs, path); +} + +static void init_device_fds (struct device_fds *dev) +{ +char dev_path[PATH_MAX ]; +char *addr_pos; + +igt_debug ("open device\n" ); +/** +* As subtests must be able to close examined devices +* completely, don't use drm_open_driver() as it keeps +* a device file descriptor open for exit handler use. +*/ + dev->fds.dev =__drm_open_driver (DRIVER_ANY ); +igt_assert_fd (dev->fds.dev); +if (is_i915_device (dev->fds.dev)) +igt_require_gem (dev->fds.dev); + +igt_assert (device_sysfs_path (dev->fds.dev, dev_path)); + addr_pos =strrchr (dev_path,'/' ); +igt_assert (addr_pos); + igt_assert_eq(sizeof(dev->dev_bus_addr) - 1, + snprintf(dev->dev_bus_addr, sizeof(dev-Quoted 1 line
dev_bus_addr),tests/device_reset.c new file +117
-1+ "%s", addr_pos + 1)); + + dev->fds.dev_dir =open_device_sysfs_dir (dev->fds.dev); +igt_assert_fd (dev->fds.dev_dir); + + dev->fds.drv_dir =open_driver_sysfs_dir (dev->fds.dev); +igt_assert_fd (dev->fds.drv_dir); +} + +static int close_if_opened (int *fd) +{ +int rc =0 ; + +if (fd && *fd !=-1 ) { + rc =close (*fd); + *fd =-1 ; + } +return rc; +} + +static void cleanup_device_fds (struct device_fds *dev) +{ +igt_ignore_warn (close_if_opened (&dev->fds.dev)); +igt_ignore_warn (close_if_opened (&dev->fds.dev_dir)); +igt_ignore_warn (close_if_opened (&dev->fds.drv_dir)); +} + +/** +* is_sysfs_reset_supported: +* @fd: opened device file descriptor +* +* Check if device supports reset based on sysfs file presence. +* +* Returns: +* True if device supports reset, false otherwise. +*/ +static bool is_sysfs_reset_supported (int fd) +{ +struct stat st; +int rc; +int sysfs; +int reset_fd =-1 ; + + sysfs =igt_sysfs_open (fd); + +if (sysfs >=0 ) { + reset_fd =openat (sysfs,"device/reset" ,O_WRONLY ); +close (sysfs); + } + +if (reset_fd <0 ) +return false; + + rc =fstat (reset_fd, &st); +close (reset_fd); + +if (rc || !S_ISREG (st.st_mode)) +return false; + +return true; +} + +/* Unbind the driver from the device */ +static void driver_unbind (struct device_fds *dev) +{ +igt_debug ("unbind the driver from the device\n" ); +igt_assert (igt_sysfs_set (dev->fds.drv_dir,"unbind" , + dev->dev_bus_addr)); +} + +/* Re-bind the driver to the device */ +static void driver_bind (struct device_fds *dev) +{ +igt_debug ("rebind the driver to the device\n" ); +igt_abort_on_f (!igt_sysfs_set (dev->fds.drv_dir,"bind" , + dev->dev_bus_addr),"driver rebind failed" ); +} + +/* Initiate device reset */ +static void initiate_device_reset (struct device_fds *dev) +{ +igt_debug ("reset device\n" ); +igt_assert (igt_sysfs_set (dev->fds.dev_dir,"reset" ,"1" )); +} + +static bool is_i915_wedged (int i915) +{ +int err =0 ; + +if (ioctl (i915,DRM_IOCTL_I915_GEM_THROTTLE )) + err = -errno; +return err == -EIO ; +} + +/** +* healthcheck: +* @dev: structure with device descriptor, if descriptor equals -1 +* the device is reopened +*/ +static void healthcheck (struct device_fds *dev) +{ +if (dev->fds.dev ==-1 ) { +/* refresh device list */ +igt_devices_scan (true); +igt_debug ("reopen the device\n" ); + dev->fds.dev =__drm_open_driver (DRIVER_ANY ); + } +igt_assert_fd (dev->fds.dev); + +if (is_i915_device (dev->fds.dev)) +igt_assert (!is_i915_wedged (dev->fds.dev)); +} + +/** +* set_device_filter: +* +* Sets device filter to ensure subtests always reopen the same device
+ *
+ * @dev_path: path to device under tests
+ */tests/device_reset.c new file +6
-0+static void set_device_filter (const char * dev_path) +{ +#define FILTER_PREFIX_LEN 4 +char filter[PATH_MAX +FILTER_PREFIX_LEN ]; + + igt_assert_lt(FILTER_PREFIX_LEN, snprintf(filter,sizeof(filter),
tests/device_reset.c new file +20
-0+ "sys:%s", dev_path)); +igt_device_filter_free_all (); +igt_assert_eq (igt_device_filter_add (filter),1 ); +} + +static void unbind_reset_rebind (struct device_fds *dev) +{ +igt_debug ("close the device\n" ); +close_if_opened (&dev->fds.dev); + +driver_unbind (dev); + +initiate_device_reset (dev); + +driver_bind (dev); +} + +igt_main +{ + struct device_fds dev = { .fds = {-1, -1, -1}, .dev_bus_addr ={0}};
tests/device_reset.c new file +14
-0+ + igt_fixture { +char dev_path[PATH_MAX ]; + +igt_debug ("opening device\n" ); +init_device_fds (&dev); + +/* Make sure subtests always reopen the same device */ +igt_assert (device_sysfs_path (dev.fds.dev, dev_path)); +set_device_filter (dev_path); + +igt_skip_on (!is_sysfs_reset_supported (dev.fds.dev)); + + igt_set_timeout(60, "device reset tests timed out after60s");
tests/device_reset.c new file +20
-0+ } + +igt_describe ("Unbinds driver from device, initiates reset" +" then rebinds driver to device" ); + igt_subtest("unbind-reset-rebind") { +unbind_reset_rebind (&dev); +healthcheck (&dev); + } + +igt_describe ("Resets device with bound driver" ); + igt_subtest("reset-bound") { +initiate_device_reset (&dev); +healthcheck (&dev); + } + + igt_fixture { +igt_reset_timeout (); +cleanup_device_fds (&dev); + } +}tests/intel- renamed from tests/intel-ci/blacklist.txt +0
-0
ci/blacklist.txt
indexecbec5080..f9a57cb54100644tests/intel-ci/blacklist.txt +0
-0Quoted 8 lines
tests/intel-ci/blacklist.txt igt@perf_pmu@cpu-hotplug · line 126
Quoted 8 lines
tests/intel-ci/blacklist.txt +0
-0@@ -121,3 +121,6 @@ igt@perf_pmu@cpu-hotplug # Currently fails and leaves the machine in a very bad state,and
# causes coverage loss for other tests. igt@core_hotunplug@.*tests/intel-ci/blacklist.txt +3
-0+ +# hangs several gens of hosts, and has no immediate fix +igt@device_reset@reset-boundI wonder if we should filter by platform?
if gen >= 12? or if dgfx?
Quoted 6 lines
Quoted 1 line
or is it really random?
I can restrict the tests on intel platforms with
if (
is_i915_device(fd))igt_skip_on(intel_gen(intel_get_drm_devid(fd)) < 12);
That seems pointless to me unless igt@device_reset@reset-bound works on gen12+ while it doesn't work on platforms we don't care.
Thanks,
Janusz
Quoted 19 lines
Quoted 19 lines
Quoted 8 lines
Quoted 2 lines
\ No newline at end of file
I'm only not sure if that missing newline will not break CI scripts,
other than that, my R-b still applies.Reviewed-by Janusz Krzysztofik <[email protected]anyway it looks good to me
Acked-by Rodrigo Vivi <[email protected]>Quoted 4 lines
Thanks,
Janusz
Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
tests/meson.build +0
-0Quoted 8 lines
Quoted 8 lines
tests/meson.build test_progs = [ · line 14
Quoted 8 lines
tests/meson.build +1
-0@@ -8,6 +8,7 @@ test_progs = [ 'core_setmaster_vs_auth', 'debugfs_test', 'dmabuf', + 'device_reset', 'drm_import_export', 'drm_mm', 'drm_read',
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 351 lines · Janusz Krzysztofik
Quoted 346 lines · Marcin
Quoted 344 lines · Rodrigo Vivi
Quoted 330 lines · Janusz Krzysztofik
Quoted 329 lines · Marcin Bernatowicz
Device reset is initiated by writing "1" to reset sysfs file, which should initiate PCI device Function Level Reset if supported by device.
Test scenarios:
1. unbind driver from device, initiate sysfs reset, rebind driver to
device
2. device reset with bound driverv2: removed unbind-rebind (duplicates core_hotunplug@unbind-rebind)
added healthcheck to each test (Janusz)
v3: after review corrections (renamedsysfs_fdstodevice_fds,
corrected not closed file descriptor, removed variable length
array)
v4: updated description (Martin), snprintf corrections (Janusz),
reset-bound added to blacklist as it hangs several gens of
hosts (Tomi)Signed-off-by Marcin Bernatowicz <[email protected]>---
tests/device_reset.c| 281
+++++++++++++++++++++++++++++++++++tests/intel-ci/blacklist.txt | 3 + tests/meson.build | 1 + 3 files changed, 285 insertions(+)create mode 100644
tests/device_reset.ctests/device_reset.c new file +14
-0@@ -0,0 +1,281 @@ +// SPDX-License-Identifier: MIT +/* +* Copyright(c) 2020 Intel Corporation. All rights reserved. +*/ +#include <fcntl.h> +#include <sys/ioctl.h> +#include <sys/stat.h> + +#include "i915/gem.h" +#include "igt.h" +#include "igt_device_scan.h" +#include "igt_sysfs.h" + +IGT_TEST_DESCRIPTION("Examine behavior of a driver on devicesysfs reset");
tests/device_reset.c new file +49
-0+ + +#define DEV_PATH_LEN 80 +#define DEV_BUS_ADDR_LEN 13/* addr has form 0000:00:00.0 */ + +/** +* Helper structure containing file descriptors +* and bus address related to tested device +*/ +struct device_fds { +struct { +int dev; +int dev_dir; +int drv_dir; + } fds; +char dev_bus_addr[DEV_BUS_ADDR_LEN ]; +}; + +static int __open_sysfs_dir (int fd,const char * path) +{ +int sysfs; + + sysfs =igt_sysfs_open (fd); +if (sysfs <0 ) { +return -1 ; + } + + fd =openat (sysfs, path,O_DIRECTORY ); +close (sysfs); +return fd; +} + +static int open_device_sysfs_dir (int fd) +{ +return __open_sysfs_dir (fd,"device" ); +} + +static int open_driver_sysfs_dir (int fd) +{ +return __open_sysfs_dir (fd,"device/driver" ); +} + +/** +* device_sysfs_path: +* @fd: opened device file descriptor +* @path: buffer to store sysfs path to device directory +* +* Returns: +* On successfull path resolution sysfs path to device directory,
+ * NULL otherwise
+ */tests/device_reset.c new file +36
-0+static char *device_sysfs_path (int fd,char *path) +{ +char sysfs[DEV_PATH_LEN ]; + +if (!igt_sysfs_path (fd, sysfs,sizeof (sysfs))) +return NULL ; + +if (DEV_PATH_LEN <= (strlen (sysfs) +strlen ("/device" ))) +return NULL ; + +strcat (sysfs,"/device" ); + +return realpath (sysfs, path); +} + +static void init_device_fds (struct device_fds *dev) +{ +char dev_path[PATH_MAX ]; +char *addr_pos; + +igt_debug ("open device\n" ); +/** +* As subtests must be able to close examined devices +* completely, don't use drm_open_driver() as it keeps +* a device file descriptor open for exit handler use. +*/ + dev->fds.dev =__drm_open_driver (DRIVER_ANY ); +igt_assert_fd (dev->fds.dev); +if (is_i915_device (dev->fds.dev)) +igt_require_gem (dev->fds.dev); + +igt_assert (device_sysfs_path (dev->fds.dev, dev_path)); + addr_pos =strrchr (dev_path,'/' ); +igt_assert (addr_pos); + igt_assert_eq(sizeof(dev->dev_bus_addr) - 1, + snprintf(dev->dev_bus_addr, sizeof(dev-Quoted 1 line
dev_bus_addr),tests/device_reset.c new file +117
-1+ "%s", addr_pos + 1)); + + dev->fds.dev_dir =open_device_sysfs_dir (dev->fds.dev); +igt_assert_fd (dev->fds.dev_dir); + + dev->fds.drv_dir =open_driver_sysfs_dir (dev->fds.dev); +igt_assert_fd (dev->fds.drv_dir); +} + +static int close_if_opened (int *fd) +{ +int rc =0 ; + +if (fd && *fd !=-1 ) { + rc =close (*fd); + *fd =-1 ; + } +return rc; +} + +static void cleanup_device_fds (struct device_fds *dev) +{ +igt_ignore_warn (close_if_opened (&dev->fds.dev)); +igt_ignore_warn (close_if_opened (&dev->fds.dev_dir)); +igt_ignore_warn (close_if_opened (&dev->fds.drv_dir)); +} + +/** +* is_sysfs_reset_supported: +* @fd: opened device file descriptor +* +* Check if device supports reset based on sysfs file presence. +* +* Returns: +* True if device supports reset, false otherwise. +*/ +static bool is_sysfs_reset_supported (int fd) +{ +struct stat st; +int rc; +int sysfs; +int reset_fd =-1 ; + + sysfs =igt_sysfs_open (fd); + +if (sysfs >=0 ) { + reset_fd =openat (sysfs,"device/reset" ,O_WRONLY ); +close (sysfs); + } + +if (reset_fd <0 ) +return false; + + rc =fstat (reset_fd, &st); +close (reset_fd); + +if (rc || !S_ISREG (st.st_mode)) +return false; + +return true; +} + +/* Unbind the driver from the device */ +static void driver_unbind (struct device_fds *dev) +{ +igt_debug ("unbind the driver from the device\n" ); +igt_assert (igt_sysfs_set (dev->fds.drv_dir,"unbind" , + dev->dev_bus_addr)); +} + +/* Re-bind the driver to the device */ +static void driver_bind (struct device_fds *dev) +{ +igt_debug ("rebind the driver to the device\n" ); +igt_abort_on_f (!igt_sysfs_set (dev->fds.drv_dir,"bind" , + dev->dev_bus_addr),"driver rebind failed" ); +} + +/* Initiate device reset */ +static void initiate_device_reset (struct device_fds *dev) +{ +igt_debug ("reset device\n" ); +igt_assert (igt_sysfs_set (dev->fds.dev_dir,"reset" ,"1" )); +} + +static bool is_i915_wedged (int i915) +{ +int err =0 ; + +if (ioctl (i915,DRM_IOCTL_I915_GEM_THROTTLE )) + err = -errno; +return err == -EIO ; +} + +/** +* healthcheck: +* @dev: structure with device descriptor, if descriptor equals -1 +* the device is reopened +*/ +static void healthcheck (struct device_fds *dev) +{ +if (dev->fds.dev ==-1 ) { +/* refresh device list */ +igt_devices_scan (true); +igt_debug ("reopen the device\n" ); + dev->fds.dev =__drm_open_driver (DRIVER_ANY ); + } +igt_assert_fd (dev->fds.dev); + +if (is_i915_device (dev->fds.dev)) +igt_assert (!is_i915_wedged (dev->fds.dev)); +} + +/** +* set_device_filter: +* +* Sets device filter to ensure subtests always reopen the same device
+ *
+ * @dev_path: path to device under tests
+ */tests/device_reset.c new file +6
-0+static void set_device_filter (const char * dev_path) +{ +#define FILTER_PREFIX_LEN 4 +char filter[PATH_MAX +FILTER_PREFIX_LEN ]; + + igt_assert_lt(FILTER_PREFIX_LEN, snprintf(filter,sizeof(filter),
tests/device_reset.c new file +20
-0+ "sys:%s", dev_path)); +igt_device_filter_free_all (); +igt_assert_eq (igt_device_filter_add (filter),1 ); +} + +static void unbind_reset_rebind (struct device_fds *dev) +{ +igt_debug ("close the device\n" ); +close_if_opened (&dev->fds.dev); + +driver_unbind (dev); + +initiate_device_reset (dev); + +driver_bind (dev); +} + +igt_main +{ + struct device_fds dev = { .fds = {-1, -1, -1}, .dev_bus_addr ={0}};
tests/device_reset.c new file +14
-0+ + igt_fixture { +char dev_path[PATH_MAX ]; + +igt_debug ("opening device\n" ); +init_device_fds (&dev); + +/* Make sure subtests always reopen the same device */ +igt_assert (device_sysfs_path (dev.fds.dev, dev_path)); +set_device_filter (dev_path); + +igt_skip_on (!is_sysfs_reset_supported (dev.fds.dev)); + + igt_set_timeout(60, "device reset tests timed out after60s");
tests/device_reset.c new file +20
-0+ } + +igt_describe ("Unbinds driver from device, initiates reset" +" then rebinds driver to device" ); + igt_subtest("unbind-reset-rebind") { +unbind_reset_rebind (&dev); +healthcheck (&dev); + } + +igt_describe ("Resets device with bound driver" ); + igt_subtest("reset-bound") { +initiate_device_reset (&dev); +healthcheck (&dev); + } + + igt_fixture { +igt_reset_timeout (); +cleanup_device_fds (&dev); + } +}tests/intel- renamed from tests/intel-ci/blacklist.txt +0
-0
ci/blacklist.txt
indexecbec5080..f9a57cb54100644tests/intel-ci/blacklist.txt +0
-0Quoted 8 lines
tests/intel-ci/blacklist.txt igt@perf_pmu@cpu-hotplug · line 126
Quoted 8 lines
tests/intel-ci/blacklist.txt +0
-0@@ -121,3 +121,6 @@ igt@perf_pmu@cpu-hotplug # Currently fails and leaves the machine in a very bad state,and
# causes coverage loss for other tests. igt@core_hotunplug@.*tests/intel-ci/blacklist.txt +3
-0+ +# hangs several gens of hosts, and has no immediate fix +igt@device_reset@reset-boundI wonder if we should filter by platform?
if gen >= 12? or if dgfx?or is it really random?
Quoted 7 lines
Quoted 4 lines
I can restrict the tests on intel platforms with
if (
is_i915_device(fd))
igt_skip_on(intel_gen(intel_get_drm_devid(fd)) < 12);That seems pointless to me unless igt@device_reset@reset-bound works on gen12+ while it doesn't work on platforms we don't care.
I see your point....
But I was thinking that maybe with this check we don't need to add this to the blacklist and we would have some CI coverage at least on the platforms that we know that it is currently working.
If this is on blacklist we will never have CI.
Quoted 24 lines
Thanks,
JanuszQuoted 19 lines
Quoted 19 lines
Quoted 8 lines
Quoted 2 lines
\ No newline at end of file
I'm only not sure if that missing newline will not break CI scripts,
other than that, my R-b still applies.Reviewed-by Janusz Krzysztofik <[email protected]anyway it looks good to me
Acked-by Rodrigo Vivi <[email protected]>Quoted 4 lines
Thanks,
Janusz
Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
tests/meson.build +0
-0Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
tests/meson.build test_progs = [ · line 14
Quoted 8 lines
tests/meson.build +1
-0@@ -8,6 +8,7 @@ test_progs = [ 'core_setmaster_vs_auth', 'debugfs_test', 'dmabuf', + 'device_reset', 'drm_import_export', 'drm_mm', 'drm_read',
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for tests/device_reset: Test device sysfs reset (rev4)
In reply to Marcin Bernatowicz== Series Details ==
== Series Details ==
Series: tests/device_reset: Test device sysfs reset (rev4)
URL : https://patchwork.freedesktop.org/series/78849/
State : success
== Summary ==
CI Bug Log - changes from IGT_5727 -> IGTPW_4745
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/index.html
Known issues
------------
Here are the changes found in IGTPW_4745 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/fi-tgl-y/igt@debugfs_test@read_all_entries.html
* igt@gem_flink_basic@basic:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/fi-tgl-y/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/fi-tgl-y/igt@[email protected]
* igt@i915_pm_backlight@basic-brightness:
- fi-whl-u: [PASS][5] -> [DMESG-WARN][6] ([i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/fi-whl-u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/fi-whl-u/igt@[email protected]
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [PASS][7] -> [DMESG-WARN][8] ([i915#62] / [i915#92] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/fi-kbl-x1275/igt@kms_busy@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/fi-kbl-x1275/igt@kms_busy@[email protected]
#### Possible fixes ####
* igt@gem_exec_store@basic:
- fi-tgl-y: [DMESG-WARN][9] ([i915#402]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/fi-tgl-y/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/fi-tgl-y/igt@[email protected]
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [FAIL][11] ([i915#1888]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/fi-tgl-u2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/fi-tgl-u2/igt@[email protected]
* igt@i915_pm_rpm@basic-pci-d3-state:
- {fi-tgl-dsi}: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/fi-tgl-dsi/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/fi-tgl-dsi/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-icl-u2: [INCOMPLETE][15] ([i915#1580] / [i915#1684]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/fi-icl-u2/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/fi-icl-u2/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@gem_contexts:
- fi-tgl-u2: [INCOMPLETE][17] ([i915#1932] / [i915#2045]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/fi-tgl-u2/igt@i915_selftest@live@gem_contexts.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/fi-tgl-u2/igt@i915_selftest@live@gem_contexts.html
#### Warnings ####
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][19] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][20] ([i915#62] / [i915#92]) +4 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/fi-kbl-x1275/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/fi-kbl-x1275/igt@[email protected]
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][21] ([i915#62] / [i915#92]) -> [DMESG-WARN][22] ([i915#62] / [i915#92] / [i915#95]) +6 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/fi-kbl-x1275/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1580]: https://gitlab.freedesktop.org/drm/intel/issues/1580
[i915#1684]: https://gitlab.freedesktop.org/drm/intel/issues/1684
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1932]: https://gitlab.freedesktop.org/drm/intel/issues/1932
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2045]: https://gitlab.freedesktop.org/drm/intel/issues/2045
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (42 -> 36)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5727 -> IGTPW_4745
CI-20190529: 20190529
CI_DRM_8710: 274a7b2cbc164c0381a28cb30fd5d3ab93a36dee @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4745: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/index.html
IGT_5727: 90254c14f4e68bec9d4a114ddf039075f3c1a30c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@device_reset@reset-bound
+igt@device_reset@unbind-reset-rebind
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for tests/device_reset: Test device sysfs reset (rev4)
In reply to Marcin Bernatowicz== Series Details ==
== Series Details ==
Series: tests/device_reset: Test device sysfs reset (rev4)
URL : https://patchwork.freedesktop.org/series/78849/
State : success
== Summary ==
CI Bug Log - changes from IGT_5727_full -> IGTPW_4745_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/index.html
New tests
---------
New tests have been introduced between IGT_5727_full and IGTPW_4745_full:
### New IGT tests (1) ###
* igt@device_reset@unbind-reset-rebind:
- Statuses : 7 pass(s)
- Exec time: [0.33, 2.02] s
Known issues
------------
Here are the changes found in IGTPW_4745_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([i915#180]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl3/igt@gem_ctx_isolation@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl7/igt@gem_ctx_isolation@[email protected]
* igt@gem_exec_fence@parallel@vecs0:
- shard-glk: [PASS][3] -> [DMESG-WARN][4] ([i915#118] / [i915#95]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-glk2/igt@gem_exec_fence@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-glk2/igt@gem_exec_fence@[email protected]
* igt@gem_exec_fence@syncobj-unused-fence:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([i915#1635] / [i915#95]) +30 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl4/igt@[email protected]
* igt@kms_big_fb@linear-16bpp-rotate-180:
- shard-kbl: [PASS][7] -> [DMESG-FAIL][8] ([i915#95]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl7/igt@[email protected]
- shard-apl: [PASS][9] -> [DMESG-FAIL][10] ([i915#1635] / [i915#95])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl1/igt@[email protected]
* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- shard-glk: [PASS][11] -> [DMESG-FAIL][12] ([i915#118] / [i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-glk3/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-glk8/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-c-256x256-left-edge:
- shard-glk: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-glk8/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-glk7/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-untiled:
- shard-kbl: [PASS][15] -> [DMESG-FAIL][16] ([i915#54] / [i915#95])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl7/igt@[email protected]
- shard-apl: [PASS][17] -> [DMESG-FAIL][18] ([i915#1635] / [i915#54] / [i915#95])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl1/igt@[email protected]
* igt@kms_flip@flip-vs-absolute-wf_vblank@a-dp1:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([i915#1982])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl7/igt@kms_flip@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#49])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([i915#1982])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-tglb: [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][27] -> [INCOMPLETE][28] ([i915#155])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl4/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl4/igt@[email protected]
* igt@kms_plane_cursor@pipe-a-primary-size-128:
- shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([i915#93] / [i915#95]) +37 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl4/igt@[email protected]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109642] / [fdo#111068])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-iclb2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-iclb7/igt@[email protected]
* igt@kms_psr@psr2_suspend:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-iclb2/igt@kms_psr@psr2_suspend.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-iclb4/igt@kms_psr@psr2_suspend.html
* igt@perf_pmu@module-unload:
- shard-tglb: [PASS][35] -> [DMESG-WARN][36] ([i915#402])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-tglb8/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-tglb8/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_reloc@basic-concurrent0:
- shard-glk: [FAIL][37] ([i915#1930]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-glk5/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-glk8/igt@[email protected]
* igt@gem_exec_whisper@basic-contexts-forked:
- shard-glk: [DMESG-WARN][39] ([i915#118] / [i915#95]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-glk5/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-glk8/igt@[email protected]
* igt@gen9_exec_parse@allowed-all:
- shard-kbl: [DMESG-WARN][41] ([i915#1436] / [i915#716]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl3/igt@[email protected]
* igt@kms_big_fb@linear-64bpp-rotate-180:
- shard-apl: [DMESG-WARN][43] ([i915#1982]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl3/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl6/igt@[email protected]
* igt@kms_big_fb@x-tiled-8bpp-rotate-0:
- shard-kbl: [DMESG-WARN][45] ([i915#1982]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl6/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
- shard-kbl: [FAIL][47] ([i915#54]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl7/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl4/igt@[email protected]
- shard-apl: [FAIL][49] ([i915#54]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl1/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl3/igt@[email protected]
- shard-glk: [FAIL][51] ([i915#54]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-glk6/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-glk8/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen:
- shard-kbl: [DMESG-FAIL][53] ([i915#54] / [i915#95]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl1/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [FAIL][55] ([i915#72]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-glk3/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-glk4/igt@[email protected]
* igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][57] ([i915#1982] / [i915#93] / [i915#95]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl4/igt@kms_flip@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][59] ([i915#180]) -> [PASS][60] +8 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl7/igt@kms_flip@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl6/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render:
- shard-glk: [FAIL][61] ([i915#49]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-glk6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-glk6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
- shard-iclb: [FAIL][63] ([i915#49]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite:
- shard-tglb: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66] +3 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-tglb2/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-tglb1/igt@[email protected]
* igt@kms_plane_cursor@pipe-a-overlay-size-64:
- shard-apl: [DMESG-FAIL][67] ([i915#1635] / [i915#95]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl8/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl1/igt@[email protected]
- shard-kbl: [DMESG-FAIL][69] ([i915#95]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl4/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl7/igt@[email protected]
* igt@kms_plane_cursor@pipe-a-viewport-size-128:
- shard-glk: [FAIL][71] ([i915#1559]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-glk6/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-glk9/igt@[email protected]
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [SKIP][73] ([fdo#109441]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_cpu.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_vblank@pipe-a-query-forked:
- shard-hsw: [TIMEOUT][75] ([i915#1958] / [i915#2119]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-hsw4/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-hsw1/igt@[email protected]
- shard-snb: [TIMEOUT][77] ([i915#1958] / [i915#2119]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-snb5/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-snb2/igt@[email protected]
* igt@kms_vblank@pipe-a-ts-continuation-modeset-hang:
- shard-kbl: [DMESG-WARN][79] ([i915#93] / [i915#95]) -> [PASS][80] +42 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl2/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl1/igt@[email protected]
* igt@syncobj_wait@multi-wait-for-submit-submitted-signaled:
- shard-tglb: [DMESG-WARN][81] ([i915#402]) -> [PASS][82] +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-tglb1/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-tglb8/igt@[email protected]
* igt@syncobj_wait@multi-wait-signaled:
- shard-apl: [DMESG-WARN][83] ([i915#1635] / [i915#95]) -> [PASS][84] +37 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl3/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl3/igt@[email protected]
#### Warnings ####
* igt@gem_exec_reloc@basic-concurrent16:
- shard-snb: [TIMEOUT][85] ([i915#1958] / [i915#2119]) -> [FAIL][86] ([i915#1930])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-snb5/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-snb5/igt@[email protected]
* igt@gem_render_copy@y-tiled-ccs-to-y-tiled-ccs:
- shard-hsw: [SKIP][87] ([fdo#109271]) -> [TIMEOUT][88] ([i915#1958] / [i915#2119])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-hsw6/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-hsw1/igt@[email protected]
* igt@gem_workarounds@suspend-resume:
- shard-kbl: [DMESG-WARN][89] ([i915#180]) -> [DMESG-WARN][90] ([i915#93] / [i915#95])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl7/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl7/igt@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][91] ([i915#588]) -> [SKIP][92] ([i915#658])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-iclb2/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-iclb7/igt@[email protected]
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-apl: [SKIP][93] ([fdo#109271]) -> [SKIP][94] ([fdo#109271] / [i915#1635]) +16 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl6/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl8/igt@[email protected]
* igt@i915_suspend@forcewake:
- shard-kbl: [DMESG-WARN][95] ([i915#93] / [i915#95]) -> [DMESG-WARN][96] ([i915#180])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl1/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl6/igt@[email protected]
* igt@kms_big_fb@x-tiled-64bpp-rotate-270:
- shard-hsw: [TIMEOUT][97] ([i915#1958] / [i915#2119]) -> [SKIP][98] ([fdo#109271]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-hsw4/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-hsw4/igt@[email protected]
* igt@kms_chamelium@hdmi-audio-edid:
- shard-apl: [SKIP][99] ([fdo#109271] / [fdo#111827] / [i915#1635]) -> [SKIP][100] ([fdo#109271] / [fdo#111827]) +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl6/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl8/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-ctm-green-to-red:
- shard-apl: [SKIP][101] ([fdo#109271] / [fdo#111827]) -> [SKIP][102] ([fdo#109271] / [fdo#111827] / [i915#1635]) +2 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl4/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl7/igt@[email protected]
* igt@kms_content_protection@atomic:
- shard-kbl: [TIMEOUT][103] ([i915#1319] / [i915#1958] / [i915#2119]) -> [TIMEOUT][104] ([i915#1319] / [i915#2119])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl7/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl7/igt@[email protected]
* igt@kms_content_protection@srm:
- shard-apl: [FAIL][105] ([fdo#110321]) -> [DMESG-FAIL][106] ([fdo#110321] / [i915#1635] / [i915#95])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl7/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl8/igt@[email protected]
* igt@kms_content_protection@uevent:
- shard-kbl: [DMESG-FAIL][107] ([i915#95]) -> [FAIL][108] ([i915#2105])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl4/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl1/igt@[email protected]
- shard-apl: [DMESG-FAIL][109] ([i915#1635] / [i915#95]) -> [FAIL][110] ([i915#2105])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl8/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl6/igt@[email protected]
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-snb: [TIMEOUT][111] ([i915#1958] / [i915#2119]) -> [SKIP][112] ([fdo#109271]) +3 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-snb5/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-snb4/igt@[email protected]
* igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1:
- shard-tglb: [DMESG-FAIL][113] ([i915#1982]) -> [FAIL][114] ([i915#2122]) +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-tglb2/igt@kms_flip@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-tglb1/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][115] ([i915#93] / [i915#95]) -> [DMESG-WARN][116] ([i915#1982] / [i915#93] / [i915#95])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl1/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl1/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-blt:
- shard-apl: [SKIP][117] ([fdo#109271] / [i915#1635]) -> [SKIP][118] ([fdo#109271]) +14 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl4/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: [FAIL][119] ([fdo#108145] / [i915#265]) -> [DMESG-FAIL][120] ([fdo#108145] / [i915#95])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl7/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl2/igt@[email protected]
- shard-apl: [FAIL][121] ([fdo#108145] / [i915#265]) -> [DMESG-FAIL][122] ([fdo#108145] / [i915#1635] / [i915#95])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl1/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-kbl: [FAIL][123] ([i915#265]) -> [DMESG-FAIL][124] ([i915#95])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl2/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl1/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][125], [FAIL][126]) ([fdo#109271] / [i915#1436] / [i915#1784] / [i915#2110] / [i915#716]) -> [FAIL][127] ([i915#1436] / [i915#1784] / [i915#2110])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl7/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-kbl1/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-kbl4/igt@[email protected]
- shard-apl: ([FAIL][128], [FAIL][129], [FAIL][130]) ([i915#1610] / [i915#1635] / [i915#2110]) -> [FAIL][131] ([i915#1635] / [i915#2110])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl3/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl8/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5727/shard-apl6/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/shard-apl8/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1559]: https://gitlab.freedesktop.org/drm/intel/issues/1559
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1784]: https://gitlab.freedesktop.org/drm/intel/issues/1784
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110
[i915#2119]: https://gitlab.freedesktop.org/drm/intel/issues/2119
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (8 -> 8)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5727 -> IGTPW_4745
CI-20190529: 20190529
CI_DRM_8710: 274a7b2cbc164c0381a28cb30fd5d3ab93a36dee @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4745: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/index.html
IGT_5727: 90254c14f4e68bec9d4a114ddf039075f3c1a30c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4745/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev