Skip to contentSkip to conversation

crypto:space required before the open brace '{'

PATCH NAK [email protected] 2 participants 2 messages Jul 13, 2023 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 crypto:space required before the open brace '{'

Maintain code readability and style consistency

---
 arch/arm64/crypto/ghash-ce-glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/crypto/ghash-ce-glue.c +1 -1
index 97331b454ea8..cb1cd161c022 100644
@@ -241,7 +241,7 @@ static int gcm_aes_setkey(struct crypto_aead *tfm, const u8 *inkey,
     if (ret)
         return -EINVAL;
 
-    aes_encrypt(&ctx->aes_key, key, (u8[AES_BLOCK_SIZE]){});
+    aes_encrypt(&ctx->aes_key, key, (u8[AES_BLOCK_SIZE]) {});
 
     /* needed for the fallback */
     memcpy(&ctx->ghash_key.k, key, GHASH_BLOCK_SIZE);
#2 lore raw
Quoted 4 lines · On Thu, 13 Jul 2023 at 10:59, <[email protected]> wrote:

Maintain code readability and style consistency

NAK

This is a cast operation, which doesn't require a trailing space.

If the tool you are using misidentifies this, please fix the tool instead.

Quoted 19 lines
---
  arch/arm64/crypto/ghash-ce-glue.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/crypto/ghash-ce-glue.c +1 -1
index 97331b454ea8..cb1cd161c022 100644
@@ -241,7 +241,7 @@ static int gcm_aes_setkey(struct crypto_aead *tfm,
 const u8 *inkey,
      if (ret)
          return -EINVAL;
 
-    aes_encrypt(&ctx->aes_key, key, (u8[AES_BLOCK_SIZE]){});
+    aes_encrypt(&ctx->aes_key, key, (u8[AES_BLOCK_SIZE]) {});
 
      /* needed for the fallback */
      memcpy(&ctx->ghash_key.k, key, GHASH_BLOCK_SIZE);