Skip to contentSkip to conversation

Add NSS clock controller support for IPQ9574

PATCH In review Devi Priya 7 participants 27 messages Jun 26, 2024 – Oct 9, 2024

Subsystems (8)
lore
Share & tools
lore

Devi Priya

author
#0 lore raw

v5 cover Add NSS clock controller support for IPQ9574

Add bindings, driver and devicetree node for networking sub system clock controller on IPQ9574. Also add support for NSS Huayra type alpha PLL and add support for gpll0_out_aux clock which serves as the parent for some nss clocks.

This series depends on the below patch series which adds support for Interconnect driver
https://lore.kernel.org/linux-arm-msm/[email protected]/

Changes in V5:
- Detailed change logs are added to the respective patches.

V4 can be found at:
https://lore.kernel.org/linux-arm-msm/[email protected]/

V3 can be found at:
https://lore.kernel.org/linux-arm-msm/[email protected]/

V2 can be found at:
https://lore.kernel.org/linux-arm-msm/[email protected]/

Devi Priya (7):
clk: qcom: clk-alpha-pll: Add NSS HUAYRA ALPHA PLL support for ipq9574
dt-bindings: clock: gcc-ipq9574: Add definition for GPLL0_OUT_AUX
clk: qcom: gcc-ipq9574: Add support for gpll0_out_aux clock
dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions
clk: qcom: Add NSS clock Controller driver for IPQ9574
arm64: dts: qcom: ipq9574: Add support for nsscc node
arm64: defconfig: Build NSS Clock Controller driver for IPQ9574

 .../bindings/clock/qcom,ipq9574-nsscc.yaml    |   74 +
 arch/arm64/boot/dts/qcom/ipq9574.dtsi         |   41 +
 arch/arm64/configs/defconfig                  |    1 +
 drivers/clk/qcom/Kconfig                      |    7 +
 drivers/clk/qcom/Makefile                     |    1 +
 drivers/clk/qcom/clk-alpha-pll.c              |   11 +
 drivers/clk/qcom/clk-alpha-pll.h              |    1 +
 drivers/clk/qcom/gcc-ipq9574.c                |   15 +
 drivers/clk/qcom/nsscc-ipq9574.c              | 3096 +++++++++++++++++
 include/dt-bindings/clock/qcom,ipq9574-gcc.h  |    1 +
 .../dt-bindings/clock/qcom,ipq9574-nsscc.h    |  152 +
 .../dt-bindings/reset/qcom,ipq9574-nsscc.h    |  134 +
 12 files changed, 3534 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
 create mode 100644 drivers/clk/qcom/nsscc-ipq9574.c
 create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h
 create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH v5 1/7 clk: qcom: clk-alpha-pll: Add NSS HUAYRA ALPHA PLL support for ipq9574

Add support for NSS Huayra alpha pll found on ipq9574 SoCs. Programming sequence is the same as that of Huayra type Alpha PLL, so we can re-use the same.

---
Changes in V5:
- No change

 drivers/clk/qcom/clk-alpha-pll.c | 11 +++++++++++
 drivers/clk/qcom/clk-alpha-pll.h |  1 +
 2 files changed, 12 insertions(+)
drivers/clk/qcom/clk-alpha-pll.c +11 -0
index d87314042528..b0471d4cf5e7 100644
@@ -266,6 +266,17 @@ const u8 clk_alpha_pll_regs[][PLL_OFF_MAX_REGS] = {
 		[PLL_OFF_OPMODE] = 0x30,
 		[PLL_OFF_STATUS] = 0x3c,
 	},
+	[CLK_ALPHA_PLL_TYPE_NSS_HUAYRA] =  {
+		[PLL_OFF_L_VAL] = 0x04,
+		[PLL_OFF_ALPHA_VAL] = 0x08,
+		[PLL_OFF_TEST_CTL] = 0x0c,
+		[PLL_OFF_TEST_CTL_U] = 0x10,
+		[PLL_OFF_USER_CTL] = 0x14,
+		[PLL_OFF_CONFIG_CTL] = 0x18,
+		[PLL_OFF_CONFIG_CTL_U] = 0x1c,
+		[PLL_OFF_STATUS] = 0x20,
+	},
+
 };
 EXPORT_SYMBOL_GPL(clk_alpha_pll_regs);
 
drivers/clk/qcom/clk-alpha-pll.h +1 -0
index df8f0fe15531..8f754057d9e1 100644
@@ -31,6 +31,7 @@ enum {
 	CLK_ALPHA_PLL_TYPE_BRAMMO_EVO,
 	CLK_ALPHA_PLL_TYPE_STROMER,
 	CLK_ALPHA_PLL_TYPE_STROMER_PLUS,
+	CLK_ALPHA_PLL_TYPE_NSS_HUAYRA,
 	CLK_ALPHA_PLL_TYPE_MAX,
 };
 
Signature · 1 line
2.34.1
author
#2 lore raw

PATCH v5 2/7 dt-bindings: clock: gcc-ipq9574: Add definition for GPLL0_OUT_AUX

In reply to Devi Priya

Add the definition for GPLL0_OUT_AUX clock.

---
Changes in V5:
- No change

 include/dt-bindings/clock/qcom,ipq9574-gcc.h | 1 +
 1 file changed, 1 insertion(+)
include/dt-bindings/clock/qcom,ipq9574-gcc.h +1 -0
index 52123c5a09fa..05ef3074c9da 100644
@@ -220,4 +220,5 @@
 #define GCC_PCIE1_PIPE_CLK				211
 #define GCC_PCIE2_PIPE_CLK				212
 #define GCC_PCIE3_PIPE_CLK				213
+#define GPLL0_OUT_AUX					214
 #endif
Signature · 1 line
2.34.1
author
#3 lore raw

PATCH v5 3/7 clk: qcom: gcc-ipq9574: Add support for gpll0_out_aux clock

In reply to Devi Priya

Add support for gpll0_out_aux clock which acts as the parent for certain networking subsystem (nss) clocks.

---
Changes in V5:
- No change

 drivers/clk/qcom/gcc-ipq9574.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
drivers/clk/qcom/gcc-ipq9574.c +15 -0
index 80fc94d705a0..5dac3facc3a5 100644
@@ -108,6 +108,20 @@ static struct clk_alpha_pll_postdiv gpll0 = {
 	},
 };
 
+static struct clk_alpha_pll_postdiv gpll0_out_aux = {
+	.offset = 0x20000,
+	.regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_DEFAULT],
+	.width = 4,
+	.clkr.hw.init = &(const struct clk_init_data) {
+		.name = "gpll0_out_aux",
+		.parent_hws = (const struct clk_hw *[]) {
+			&gpll0_main.clkr.hw
+		},
+		.num_parents = 1,
+		.ops = &clk_alpha_pll_postdiv_ro_ops,
+	},
+};
+
 static struct clk_alpha_pll gpll4_main = {
 	.offset = 0x22000,
 	.regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_DEFAULT],
@@ -4222,6 +4236,7 @@ static struct clk_regmap *gcc_ipq9574_clks[] = {
 	[GCC_PCIE1_PIPE_CLK] = &gcc_pcie1_pipe_clk.clkr,
 	[GCC_PCIE2_PIPE_CLK] = &gcc_pcie2_pipe_clk.clkr,
 	[GCC_PCIE3_PIPE_CLK] = &gcc_pcie3_pipe_clk.clkr,
+	[GPLL0_OUT_AUX] = &gpll0_out_aux.clkr,
 };
 
 static const struct qcom_reset_map gcc_ipq9574_resets[] = {
Signature · 1 line
2.34.1
Reviewed-by on v5 3/7
#4 lore raw

Re: [PATCH V5 3/7] clk: qcom: gcc-ipq9574: Add support for gpll0_out_aux clock

Quoted 11 lines · Devi Priya

Add support for gpll0_out_aux clock which acts as the parent for certain networking subsystem (nss) clocks.

---
Changes in V5:
- No change

 drivers/clk/qcom/gcc-ipq9574.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Signature · 2 lines
With best wishes
Dmitry
author
#5 lore raw

PATCH v5 4/7 dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions

In reply to Devi Priya

Add NSSCC clock and reset definitions for ipq9574.

---
Changes in V5:
- Dropped interconnects and added interconnect-cells to NSS clock provider so that it can be used as icc provider.

 .../bindings/clock/qcom,ipq9574-nsscc.yaml    |  74 +++++++++
 .../dt-bindings/clock/qcom,ipq9574-nsscc.h    | 152 ++++++++++++++++++
 .../dt-bindings/reset/qcom,ipq9574-nsscc.h    | 134 +++++++++++++++
 3 files changed, 360 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
 create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h
 create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h
Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml new file +74 -0
new file mode 100644
index 000000000000..5a6a097b3036
@@ -0,0 +1,74 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/qcom,ipq9574-nsscc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Networking Sub System Clock & Reset Controller on IPQ9574
+
+maintainers:
+  - Bjorn Andersson <[email protected]>
+  - Anusha Rao <[email protected]>
+
+description: |
+  Qualcomm networking sub system clock control module provides the clocks,
+  resets and power domains on IPQ9574
+
+  See also::
+    include/dt-bindings/clock/qcom,ipq9574-nsscc.h
+    include/dt-bindings/reset/qcom,ipq9574-nsscc.h
+
+properties:
+  compatible:
+    const: qcom,ipq9574-nsscc
+
+  clocks:
+    items:
+      - description: Board XO source
+      - description: Bias PLL cc clock source
+      - description: Bias PLL nss noc clock source
+      - description: Bias PLL ubi nc clock source
+      - description: GCC GPLL0 OUT AUX clock source
+      - description: Uniphy0 NSS Rx clock source
+      - description: Uniphy0 NSS Tx clock source
+      - description: Uniphy1 NSS Rx clock source
+      - description: Uniphy1 NSS Tx clock source
+      - description: Uniphy2 NSS Rx clock source
+      - description: Uniphy2 NSS Tx clock source
+      - description: GCC NSSCC clock source
+
+  '#interconnect-cells':
+    const: 1
+
+required:
+  - compatible
+  - clocks
+
+allOf:
+  - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/qcom,ipq9574-gcc.h>
+    clock-controller@39b00000 {
+      compatible = "qcom,ipq9574-nsscc";
+      reg = <0x39b00000 0x80000>;
+      clocks = <&xo_board_clk>,
+               <&bias_pll_cc_clk>,
+               <&bias_pll_nss_noc_clk>,
+               <&bias_pll_ubi_nc_clk>,
+               <&gcc GPLL0_OUT_AUX>,
+               <&uniphy 0>,
+               <&uniphy 1>,
+               <&uniphy 2>,
+               <&uniphy 3>,
+               <&uniphy 4>,
+               <&uniphy 5>,
+               <&gcc GCC_NSSCC_CLK>;
+      #clock-cells = <1>;
+      #reset-cells = <1>;
+      #power-domain-cells = <1>;
+    };
+...
include/dt-bindings/clock/qcom,ipq9574-nsscc.h new file +152 -0

152 lines not on this page · raw message

include/dt-bindings/reset/qcom,ipq9574-nsscc.h new file +134 -0

134 lines not on this page · raw message

Signature · 1 line
2.34.1
#6 lore raw

Re: [PATCH V5 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions

Quoted 9 lines · Devi Priya

Add NSSCC clock and reset definitions for ipq9574.

---
Changes in V5:
- Dropped interconnects and added interconnect-cells to NSS clock provider so that it can be used as icc provider.

Quoted 8 lines
 .../bindings/clock/qcom,ipq9574-nsscc.yaml    |  74 +++++++++
 .../dt-bindings/clock/qcom,ipq9574-nsscc.h    | 152 ++++++++++++++++++
 .../dt-bindings/reset/qcom,ipq9574-nsscc.h    | 134 +++++++++++++++
 3 files changed, 360 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
 create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h
 create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.

#7 lore raw

Re: [PATCH V5 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions

Quoted 20 lines · Rob Herring (Arm)
Quoted 9 lines · Devi Priya

Add NSSCC clock and reset definitions for ipq9574.

---
Changes in V5:
- Dropped interconnects and added interconnect-cells to NSS clock provider so that it can be used as icc provider.

Quoted 8 lines
 .../bindings/clock/qcom,ipq9574-nsscc.yaml    |  74 +++++++++
 .../dt-bindings/clock/qcom,ipq9574-nsscc.h    | 152 ++++++++++++++++++
 .../dt-bindings/reset/qcom,ipq9574-nsscc.h    | 134 +++++++++++++++
 3 files changed, 360 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
 create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h
 create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h
Quoted 7 lines

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error FATAL ERROR: Unable to parse input tree

Hi Devi

Version 4 of these patches had the same exact problem. There was not an email explaining it is a false positive etc, so i have to assume it is a real error. So why has it not been fixed?

Qualcomm patches are under a microscope at the moment because of how bad things went a couple of months ago with patches. You cannot ignore things like this, because the damage to Qualcomm reputation is going to make it impossible to get patches merged soon.

Andrew

author
#8 lore raw

Re: [PATCH V5 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions

Quoted 31 lines · Andrew Lunn
Quoted 20 lines · Rob Herring (Arm)
Quoted 9 lines · Devi Priya

Add NSSCC clock and reset definitions for ipq9574.

---
Changes in V5:
- Dropped interconnects and added interconnect-cells to NSS clock provider so that it can be used as icc provider.

Quoted 8 lines
  .../bindings/clock/qcom,ipq9574-nsscc.yaml    |  74 +++++++++
  .../dt-bindings/clock/qcom,ipq9574-nsscc.h    | 152 ++++++++++++++++++
  .../dt-bindings/reset/qcom,ipq9574-nsscc.h    | 134 +++++++++++++++
  3 files changed, 360 insertions(+)

create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h

Quoted 7 lines

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error FATAL ERROR: Unable to parse input tree

Hi Devi

Quoted 9 lines

Version 4 of these patches had the same exact problem. There was not an email explaining it is a false positive etc, so i have to assume it is a real error. So why has it not been fixed?

Qualcomm patches are under a microscope at the moment because of how bad things went a couple of months ago with patches. You cannot ignore things like this, because the damage to Qualcomm reputation is going to make it impossible to get patches merged soon.

Hi Andrew,
Very sorry for the inconvenience.
I had run dt_binding_check locally on V4 patches and did not face any errors. I somehow missed to notice the binding check error that was reported on V4. Thus I went ahead and posted the same in V5. Will ensure such things are not repeated henceforth.

Thanks,
Devi Priya

Quoted 1 line

Andrew

#9 lore raw

Re: [PATCH V5 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions

Quoted 43 lines · Devi Priya
Quoted 31 lines · Andrew Lunn
Quoted 20 lines · Rob Herring (Arm)
Quoted 9 lines · Devi Priya

Add NSSCC clock and reset definitions for ipq9574.

---
Changes in V5:
- Dropped interconnects and added interconnect-cells to NSS clock provider so that it can be used as icc provider.

Quoted 8 lines
  .../bindings/clock/qcom,ipq9574-nsscc.yaml    |  74 +++++++++
  .../dt-bindings/clock/qcom,ipq9574-nsscc.h    | 152 ++++++++++++++++++
  .../dt-bindings/reset/qcom,ipq9574-nsscc.h    | 134 +++++++++++++++
  3 files changed, 360 insertions(+)

create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h

Quoted 7 lines

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error FATAL ERROR: Unable to parse input tree

Hi Devi

Quoted 9 lines

Version 4 of these patches had the same exact problem. There was not an email explaining it is a false positive etc, so i have to assume it is a real error. So why has it not been fixed?

Qualcomm patches are under a microscope at the moment because of how bad things went a couple of months ago with patches. You cannot ignore things like this, because the damage to Qualcomm reputation is going to make it impossible to get patches merged soon.

Quoted 6 lines

Hi Andrew,
Very sorry for the inconvenience.
I had run dt_binding_check locally on V4 patches and did not face any errors. I somehow missed to notice the binding check error that was reported on V4. Thus I went ahead and posted the same in V5. Will ensure such things are not repeated henceforth.

If the warning is expected, e.g. due to missing patches, it's beneficial to mention this in the changelog (---). Otherwise all maintainers my ignore your patch because you have issues reported by automation.

Anyway, up to you.

Best regards,
Krzysztof

author
#10 lore raw

Re: [PATCH V5 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions

Quoted 51 lines · Krzysztof Kozlowski
Quoted 43 lines · Devi Priya
Quoted 31 lines · Andrew Lunn
Quoted 20 lines · Rob Herring (Arm)
Quoted 9 lines · Devi Priya

Add NSSCC clock and reset definitions for ipq9574.

---
Changes in V5:
- Dropped interconnects and added interconnect-cells to NSS clock provider so that it can be used as icc provider.

Quoted 8 lines
   .../bindings/clock/qcom,ipq9574-nsscc.yaml    |  74 +++++++++
   .../dt-bindings/clock/qcom,ipq9574-nsscc.h    | 152 ++++++++++++++++++
   .../dt-bindings/reset/qcom,ipq9574-nsscc.h    | 134 +++++++++++++++
   3 files changed, 360 insertions(+)

create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h

Quoted 7 lines

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error FATAL ERROR: Unable to parse input tree

Hi Devi

Quoted 9 lines

Version 4 of these patches had the same exact problem. There was not an email explaining it is a false positive etc, so i have to assume it is a real error. So why has it not been fixed?

Qualcomm patches are under a microscope at the moment because of how bad things went a couple of months ago with patches. You cannot ignore things like this, because the damage to Qualcomm reputation is going to make it impossible to get patches merged soon.

Quoted 6 lines

Hi Andrew,
Very sorry for the inconvenience.
I had run dt_binding_check locally on V4 patches and did not face any errors. I somehow missed to notice the binding check error that was reported on V4. Thus I went ahead and posted the same in V5. Will ensure such things are not repeated henceforth.

Quoted 4 lines

If the warning is expected, e.g. due to missing patches, it's beneficial to mention this in the changelog (---). Otherwise all maintainers my ignore your patch because you have issues reported by automation.

Sure, got it

Thanks,
Devi Priya

Quoted 5 lines

Anyway, up to you.

Best regards,
Krzysztof

author
#11 lore raw

Re: [PATCH V5 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions

In reply to Rob Herring (Arm)
Quoted 43 lines · Rob Herring (Arm)
Quoted 9 lines · Devi Priya

Add NSSCC clock and reset definitions for ipq9574.

---
Changes in V5:
- Dropped interconnects and added interconnect-cells to NSS clock provider so that it can be used as icc provider.

Quoted 8 lines
  .../bindings/clock/qcom,ipq9574-nsscc.yaml    |  74 +++++++++
  .../dt-bindings/clock/qcom,ipq9574-nsscc.h    | 152 ++++++++++++++++++
  .../dt-bindings/reset/qcom,ipq9574-nsscc.h    | 134 +++++++++++++++
  3 files changed, 360 insertions(+)

create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

Quoted 6 lines

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. Hi Rob,

We tried running dt_binding_check on linux-next and we do not face any sort of errors.

However in case of v6.10-rc1, patch[1] failed to apply as the dependent patch[2] is not available on rc1.

[1] https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/

[2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20240531&id=475beea0b9f631656b5cc39429a39696876af613

Patch [2] does not hold any functional dependency on this series but has a patch rebase dependency.

The Bot has went ahead and tried running the dt_binding_check on patch https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/
which is dependent on patch [1] and hence the issue was reported.

Is this the expected behaviour?

Thanks & Regards,
Devi Priya

Quoted 1 line
#12 lore raw

Re: [PATCH V5 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions

Quoted 65 lines · Devi Priya
Quoted 43 lines · Rob Herring (Arm)
Quoted 9 lines · Devi Priya

Add NSSCC clock and reset definitions for ipq9574.

---
Changes in V5:
- Dropped interconnects and added interconnect-cells to NSS clock provider so that it can be used as icc provider.

Quoted 8 lines
  .../bindings/clock/qcom,ipq9574-nsscc.yaml    |  74 +++++++++
  .../dt-bindings/clock/qcom,ipq9574-nsscc.h    | 152 ++++++++++++++++++
  .../dt-bindings/reset/qcom,ipq9574-nsscc.h    | 134 +++++++++++++++
  3 files changed, 360 insertions(+)

create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

Quoted 6 lines

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. Hi Rob,

We tried running dt_binding_check on linux-next and we do not face any sort of errors.

However in case of v6.10-rc1, patch[1] failed to apply as the dependent patch[2] is not available on rc1.

[1]
https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/

[2]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20240531&id=475beea0b9f631656b5cc39429a39696876af613

Quoted 8 lines

Patch [2] does not hold any functional dependency on this series but has a patch rebase dependency.

The Bot has went ahead and tried running the dt_binding_check on patch
https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/
which is dependent on patch [1] and hence the issue was reported.

Is this the expected behaviour?

If you expect your patch not to be ignored after such feedback, explain briefly missing dependency in changelog. I think Rob told it many times already.

Otherwise you will get this message *every time* and maintainers might ignore your patch, due to unresolved reports from automation.

Best regards,
Krzysztof

author
#13 lore raw

Re: [PATCH V5 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions

Quoted 73 lines · Krzysztof Kozlowski
Quoted 72 lines · Devi Priya
Quoted 43 lines · Rob Herring (Arm)
Quoted 9 lines · Devi Priya

Add NSSCC clock and reset definitions for ipq9574.

---
Changes in V5:
- Dropped interconnects and added interconnect-cells to NSS clock provider so that it can be used as icc provider.

Quoted 8 lines
   .../bindings/clock/qcom,ipq9574-nsscc.yaml    |  74 +++++++++
   .../dt-bindings/clock/qcom,ipq9574-nsscc.h    | 152 ++++++++++++++++++
   .../dt-bindings/reset/qcom,ipq9574-nsscc.h    | 134 +++++++++++++++
   3 files changed, 360 insertions(+)

create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

Quoted 6 lines

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. Hi Rob,

We tried running dt_binding_check on linux-next and we do not face any sort of errors.

However in case of v6.10-rc1, patch[1] failed to apply as the dependent patch[2] is not available on rc1.

[1]
https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/

[2]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20240531&id=475beea0b9f631656b5cc39429a39696876af613

Patch [2] does not hold any functional dependency on this series but has a patch rebase dependency.

The Bot has went ahead and tried running the dt_binding_check on patch
https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/
which is dependent on patch [1] and hence the issue was reported.

Quoted 8 lines
Quoted 1 line

Is this the expected behaviour?

If you expect your patch not to be ignored after such feedback, explain briefly missing dependency in changelog. I think Rob told it many times already.

Otherwise you will get this message *every time* and maintainers might ignore your patch, due to unresolved reports from automation.

Hi Krzysztof,

We posted our patches based on linux-next and the bot was trying to run
the dt_binding_checks on rc1 wherein patch [1] failed to apply as
patch [2] was missing on rc1 but was available on linux-next. The patch
application failure on rc1 was the reason behind the binding error and there were no dependencies on linux-next.

Thanks & Regards,
Devi Priya

Quoted 4 lines

Best regards,
Krzysztof

author
#14 lore raw

PATCH v5 5/7 clk: qcom: Add NSS clock Controller driver for IPQ9574

In reply to Devi Priya

Add Networking Sub System Clock Controller(NSSCC) driver for ipq9574 based devices.

---
Changes in V5:
- Use icc-clk support to enable few NoC clocks via interconnect

 drivers/clk/qcom/Kconfig         |    7 +
 drivers/clk/qcom/Makefile        |    1 +
 drivers/clk/qcom/nsscc-ipq9574.c | 3096 ++++++++++++++++++++++++++++++
 3 files changed, 3104 insertions(+)
 create mode 100644 drivers/clk/qcom/nsscc-ipq9574.c
drivers/clk/qcom/Kconfig +7 -0
index cb524c5f46e2..78a9d7a1810e 100644
@@ -255,6 +255,13 @@ config IPQ_GCC_9574
 	  i2c, USB, SD/eMMC, etc. Select this for the root clock
 	  of ipq9574.
 
+config IPQ_NSSCC_9574
+        tristate "IPQ9574 NSS Clock Controller"
+        depends on ARM64 || COMPILE_TEST
+        depends on IPQ_GCC_9574
+        help
+          Support for NSS clock controller on ipq9574 devices.
+
 config IPQ_NSSCC_QCA8K
 	tristate "QCA8K(QCA8386 or QCA8084) NSS Clock Controller"
 	depends on MDIO_BUS
drivers/clk/qcom/Makefile +1 -0
index d52c04f35e74..c39f4eab69da 100644
@@ -36,6 +36,7 @@ obj-$(CONFIG_IPQ_GCC_6018) += gcc-ipq6018.o
 obj-$(CONFIG_IPQ_GCC_806X) += gcc-ipq806x.o
 obj-$(CONFIG_IPQ_GCC_8074) += gcc-ipq8074.o
 obj-$(CONFIG_IPQ_GCC_9574) += gcc-ipq9574.o
+obj-$(CONFIG_IPQ_NSSCC_9574)	+= nsscc-ipq9574.o
 obj-$(CONFIG_IPQ_LCC_806X) += lcc-ipq806x.o
 obj-$(CONFIG_IPQ_NSSCC_QCA8K) += nsscc-qca8k.o
 obj-$(CONFIG_MDM_GCC_9607) += gcc-mdm9607.o
drivers/clk/qcom/nsscc-ipq9574.c new file +3096 -0

2,980 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.34.1

Part of the diff is not shown here. View the raw message.

#15 lore raw

Re: [PATCH V5 5/7] clk: qcom: Add NSS clock Controller driver for IPQ9574

Quoted 6 lines · Devi Priya

Add Networking Sub System Clock Controller(NSSCC) driver for ipq9574 based devices.

---

[...]

drivers/clk/qcom/nsscc-ipq9574.c line 3073

Quoted 13 lines
drivers/clk/qcom/nsscc-ipq9574.c new file +13 -0
+	struct regmap *regmap;
+	struct qcom_cc_desc nsscc_ipq9574_desc = nss_cc_ipq9574_desc;
+	struct clk *nsscc_clk;
+	struct device_node *np = (&pdev->dev)->of_node;
+	int ret;
+
+	nsscc_clk = of_clk_get(np, 11);
+	if (IS_ERR(nsscc_clk))
+		return PTR_ERR(nsscc_clk);
+
+	ret = clk_prepare_enable(nsscc_clk);
+	if (ret)
+		clk_disable_unprepare(nsscc_clk);

No changes to be seen..

Konrad

#16 lore raw

Re: [PATCH V5 5/7] clk: qcom: Add NSS clock Controller driver for IPQ9574

Quoted 10 lines · Konrad Dybcio
Quoted 6 lines · Devi Priya

Add Networking Sub System Clock Controller(NSSCC) driver for ipq9574 based devices.

---

[...]

Quoted 16 lines

drivers/clk/qcom/nsscc-ipq9574.c line 3073

Quoted 13 lines
drivers/clk/qcom/nsscc-ipq9574.c new file +13 -0
+	struct regmap *regmap;
+	struct qcom_cc_desc nsscc_ipq9574_desc = nss_cc_ipq9574_desc;
+	struct clk *nsscc_clk;
+	struct device_node *np = (&pdev->dev)->of_node;
+	int ret;
+
+	nsscc_clk = of_clk_get(np, 11);
+	if (IS_ERR(nsscc_clk))
+		return PTR_ERR(nsscc_clk);
+
+	ret = clk_prepare_enable(nsscc_clk);
+	if (ret)
+		clk_disable_unprepare(nsscc_clk);

No changes to be seen..

Hi Konrad,

Sorry for the delayed response.

The ethernet node will subscribe to GCC_NSSCC_CLK and enable it. Hence, it need not be obtained and setup here. Will drop this.

Thanks & Regards,
Manikanta.

Quoted 1 line

Konrad

author
#17 lore raw

PATCH v5 6/7 arm64: dts: qcom: ipq9574: Add support for nsscc node

In reply to Devi Priya

Add a node for the nss clock controller found on ipq9574 based devices.

---
Changes in V5:
- Dropped interconnects from nsscc node and added interconnect-cells to NSS clock provider so that it can be used as icc provider.

 arch/arm64/boot/dts/qcom/ipq9574.dtsi | 41 +++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)
arch/arm64/boot/dts/qcom/ipq9574.dtsi +41 -0
index 48dfafea46a7..b6f8800bf63c 100644
@@ -11,6 +11,8 @@
 #include <dt-bindings/interconnect/qcom,ipq9574.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/reset/qcom,ipq9574-gcc.h>
+#include <dt-bindings/clock/qcom,ipq9574-nsscc.h>
+#include <dt-bindings/reset/qcom,ipq9574-nsscc.h>
 #include <dt-bindings/thermal/thermal.h>
 
 / {
@@ -19,6 +21,24 @@ / {
 	#size-cells = <2>;
 
 	clocks {
+		bias_pll_cc_clk: bias-pll-cc-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <1200000000>;
+			#clock-cells = <0>;
+		};
+
+		bias_pll_nss_noc_clk: bias-pll-nss-noc-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <461500000>;
+			#clock-cells = <0>;
+		};
+
+		bias_pll_ubi_nc_clk: bias-pll-ubi-nc-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <353000000>;
+			#clock-cells = <0>;
+		};
+
 		sleep_clk: sleep-clk {
 			compatible = "fixed-clock";
 			#clock-cells = <0>;
@@ -756,6 +776,27 @@ frame@b128000 {
 				status = "disabled";
 			};
 		};
+
+		nsscc: clock-controller@39b00000 {
+			compatible = "qcom,ipq9574-nsscc";
+			reg = <0x39b00000 0x80000>;
+			clocks = <&xo_board_clk>,
+				 <&bias_pll_cc_clk>,
+				 <&bias_pll_nss_noc_clk>,
+				 <&bias_pll_ubi_nc_clk>,
+				 <&gcc GPLL0_OUT_AUX>,
+				 <0>,
+				 <0>,
+				 <0>,
+				 <0>,
+				 <0>,
+				 <0>,
+				 <&gcc GCC_NSSCC_CLK>;
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+			#power-domain-cells = <1>;
+			#interconnect-cells = <1>;
+		};
 	};
 
 	thermal-zones {
Signature · 1 line
2.34.1
#18 lore raw

Re: [PATCH V5 6/7] arm64: dts: qcom: ipq9574: Add support for nsscc node

Quoted 36 lines · Devi Priya

Add a node for the nss clock controller found on ipq9574 based devices.

---
Changes in V5:
- Dropped interconnects from nsscc node and added interconnect-cells to NSS clock provider so that it can be used as icc provider.

 arch/arm64/boot/dts/qcom/ipq9574.dtsi | 41 +++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)
arch/arm64/boot/dts/qcom/ipq9574.dtsi +9 -0
index 48dfafea46a7..b6f8800bf63c 100644
@@ -11,6 +11,8 @@
 #include <dt-bindings/interconnect/qcom,ipq9574.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/reset/qcom,ipq9574-gcc.h>
+#include <dt-bindings/clock/qcom,ipq9574-nsscc.h>
+#include <dt-bindings/reset/qcom,ipq9574-nsscc.h>
 #include <dt-bindings/thermal/thermal.h>
 
 / {
@@ -19,6 +21,24 @@ / {
 	#size-cells = <2>;
 
 	clocks {
+		bias_pll_cc_clk: bias-pll-cc-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <1200000000>;
+			#clock-cells = <0>;
+		};
+
+		bias_pll_nss_noc_clk: bias-pll-nss-noc-clk {

arch/arm64/boot/dts/qcom/ipq9574.dtsi / { · line 40

Quoted 10 lines
arch/arm64/boot/dts/qcom/ipq9574.dtsi +10 -0
+			compatible = "fixed-clock";
+			clock-frequency = <461500000>;
+			#clock-cells = <0>;
+		};
+
+		bias_pll_ubi_nc_clk: bias-pll-ubi-nc-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <353000000>;
+			#clock-cells = <0>;
+		};

What is the source for these clocks? Is it really an on-board crystal?

arch/arm64/boot/dts/qcom/ipq9574.dtsi / { · line 44

Quoted 4 lines
arch/arm64/boot/dts/qcom/ipq9574.dtsi +1 -0
+
 		sleep_clk: sleep-clk {
 			compatible = "fixed-clock";
 			#clock-cells = <0>;

d

Signature · 2 lines
With best wishes
Dmitry
#19 lore raw

Re: [PATCH V5 6/7] arm64: dts: qcom: ipq9574: Add support for nsscc node

Quoted 41 lines · Dmitry Baryshkov
Quoted 40 lines · Devi Priya

Add a node for the nss clock controller found on ipq9574 based devices.

---
Changes in V5:
- Dropped interconnects from nsscc node and added interconnect-cells to NSS clock provider so that it can be used as icc provider.

 arch/arm64/boot/dts/qcom/ipq9574.dtsi | 41 +++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)
arch/arm64/boot/dts/qcom/ipq9574.dtsi +13 -0
index 48dfafea46a7..b6f8800bf63c 100644
@@ -11,6 +11,8 @@
 #include <dt-bindings/interconnect/qcom,ipq9574.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/reset/qcom,ipq9574-gcc.h>
+#include <dt-bindings/clock/qcom,ipq9574-nsscc.h>
+#include <dt-bindings/reset/qcom,ipq9574-nsscc.h>
 #include <dt-bindings/thermal/thermal.h>
 
 / {
@@ -19,6 +21,24 @@ / {
 	#size-cells = <2>;
 
 	clocks {
+		bias_pll_cc_clk: bias-pll-cc-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <1200000000>;
+			#clock-cells = <0>;
+		};
+
+		bias_pll_nss_noc_clk: bias-pll-nss-noc-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <461500000>;
+			#clock-cells = <0>;
+		};
Quoted 9 lines

arch/arm64/boot/dts/qcom/ipq9574.dtsi / { · line 40

Quoted 6 lines
arch/arm64/boot/dts/qcom/ipq9574.dtsi +6 -0
+
+		bias_pll_ubi_nc_clk: bias-pll-ubi-nc-clk {
+			compatible = "fixed-clock";
+			clock-frequency = <353000000>;
+			#clock-cells = <0>;
+		};

What is the source for these clocks? Is it really an on-board crystal?

Hi Dmitry,

Sorry for the delayed response.

No, the CMN PLL [1] is the source for these clocks. Will remove these nodes and set these entries to 0 in the nsscc node until the CMN PLL driver posted with these clocks.

1: https://lore.kernel.org/lkml/[email protected]/

Thanks & Regards,
Manikanta.

Reviewed-by on v5 6/7
#20 lore raw

Re: [PATCH V5 6/7] arm64: dts: qcom: ipq9574: Add support for nsscc node

In reply to Devi Priya
Quoted 4 lines · Devi Priya

Add a node for the nss clock controller found on ipq9574 based devices.

---

Title: s/support for//

You're adding the node, not the support for it.

The nodes look good. Looking at the driver, the interconnect paths that will be sync_state'd away due to no consumers don't seem to be super critical for the system, so I'm assuming this doesn't crash

So, with the title fixed:

Konrad

#21 lore raw

Re: [PATCH V5 6/7] arm64: dts: qcom: ipq9574: Add support for nsscc node

Quoted 8 lines · Konrad Dybcio
Quoted 4 lines · Devi Priya

Add a node for the nss clock controller found on ipq9574 based devices.

---

Title: s/support for//

Quoted 8 lines

You're adding the node, not the support for it.

The nodes look good. Looking at the driver, the interconnect paths that will be sync_state'd away due to no consumers don't seem to be super critical for the system, so I'm assuming this doesn't crash

So, with the title fixed:

Hi Konrad,

Sorry for the delayed response.

Okay, sure. Will fix the title.

Thanks & Regards,
Manikanta.

author
#22 lore raw

PATCH v5 7/7 arm64: defconfig: Build NSS Clock Controller driver for IPQ9574

In reply to Devi Priya

NSSCC driver is needed to enable the ethernet interfaces and not necessary for the bootup of the SoC, hence build it as a module.

---
Changes in V5:
- No change

 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
index dfaec2d4052c..40a5ea212518 100644
@@ -1300,6 +1300,7 @@ CONFIG_IPQ_GCC_5332=y
 CONFIG_IPQ_GCC_6018=y
 CONFIG_IPQ_GCC_8074=y
 CONFIG_IPQ_GCC_9574=y
+CONFIG_IPQ_NSSCC_9574=m
 CONFIG_MSM_GCC_8916=y
 CONFIG_MSM_MMCC_8994=m
 CONFIG_MSM_GCC_8994=y
Signature · 1 line
2.34.1
#23 lore raw

Re: [PATCH V5 7/7] arm64: defconfig: Build NSS Clock Controller driver for IPQ9574

Quoted 2 lines · Devi Priya

NSSCC driver is needed to enable the ethernet interfaces and not necessary for the bootup of the SoC, hence build it as a module.

It is used on this-and-that device.

Quoted 24 lines

---
Changes in V5:
- No change

 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
index dfaec2d4052c..40a5ea212518 100644
@@ -1300,6 +1300,7 @@ CONFIG_IPQ_GCC_5332=y
 CONFIG_IPQ_GCC_6018=y
 CONFIG_IPQ_GCC_8074=y
 CONFIG_IPQ_GCC_9574=y
+CONFIG_IPQ_NSSCC_9574=m
 CONFIG_MSM_GCC_8916=y
 CONFIG_MSM_MMCC_8994=m
 CONFIG_MSM_GCC_8994=y
Signature · 1 line
2.34.1
Signature · 2 lines
With best wishes
Dmitry
#24 lore raw

Re: [PATCH V5 7/7] arm64: defconfig: Build NSS Clock Controller driver for IPQ9574

Quoted 6 lines · Dmitry Baryshkov
Quoted 2 lines · Devi Priya

NSSCC driver is needed to enable the ethernet interfaces and not necessary for the bootup of the SoC, hence build it as a module.

It is used on this-and-that device.

Hi Dmitry,

Sorry for the delayed response.

NSSCC driver is needed to enable the ethernet interfaces present in RDP433 based on IPQ9574. Since this is not necessary for bootup enabling it as a module.

Thanks & Regards,
Manikanta.

Quoted 25 lines
Quoted 24 lines

---
Changes in V5:
- No change

 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
index dfaec2d4052c..40a5ea212518 100644
@@ -1300,6 +1300,7 @@ CONFIG_IPQ_GCC_5332=y
 CONFIG_IPQ_GCC_6018=y
 CONFIG_IPQ_GCC_8074=y
 CONFIG_IPQ_GCC_9574=y
+CONFIG_IPQ_NSSCC_9574=m
 CONFIG_MSM_GCC_8916=y
 CONFIG_MSM_MMCC_8994=m
 CONFIG_MSM_GCC_8994=y
Signature · 1 line
2.34.1
#25 lore raw

Re: [PATCH V5 7/7] arm64: defconfig: Build NSS Clock Controller driver for IPQ9574

Quoted 10 lines · Manikanta Mylavarapu
Quoted 6 lines · Dmitry Baryshkov
Quoted 2 lines · Devi Priya

NSSCC driver is needed to enable the ethernet interfaces and not necessary for the bootup of the SoC, hence build it as a module.

It is used on this-and-that device.

Quoted 7 lines

Hi Dmitry,

Sorry for the delayed response.

NSSCC driver is needed to enable the ethernet interfaces present in RDP433 based on IPQ9574. Since this is not necessary for bootup enabling it as a module.

Commit message, please.

Quoted 30 lines

Thanks & Regards,
Manikanta.

Quoted 25 lines
Quoted 24 lines

---
Changes in V5:
- No change

 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
index dfaec2d4052c..40a5ea212518 100644
@@ -1300,6 +1300,7 @@ CONFIG_IPQ_GCC_5332=y
 CONFIG_IPQ_GCC_6018=y
 CONFIG_IPQ_GCC_8074=y
 CONFIG_IPQ_GCC_9574=y
+CONFIG_IPQ_NSSCC_9574=m
 CONFIG_MSM_GCC_8916=y
 CONFIG_MSM_MMCC_8994=m
 CONFIG_MSM_GCC_8994=y
Signature · 1 line
2.34.1
Signature · 2 lines
With best wishes
Dmitry
#26 lore raw

Re: [PATCH V5 7/7] arm64: defconfig: Build NSS Clock Controller driver for IPQ9574

Quoted 13 lines · Dmitry Baryshkov
Quoted 12 lines · Manikanta Mylavarapu
Quoted 6 lines · Dmitry Baryshkov
Quoted 2 lines · Devi Priya

NSSCC driver is needed to enable the ethernet interfaces and not necessary for the bootup of the SoC, hence build it as a module.

It is used on this-and-that device.

Hi Dmitry,

Quoted 8 lines
Quoted 5 lines

Sorry for the delayed response.

NSSCC driver is needed to enable the ethernet interfaces present in RDP433 based on IPQ9574. Since this is not necessary for bootup enabling it as a module.

Commit message, please.

Hi Dmitry,

Okay, sure.

Thanks & Regards,
Manikanta.