Skip to contentSkip to conversation

mm/memblock: Fix the typo on comments.

PATCH In review Levi Yun 3 participants 5 messages Jan 20, 2021 – Jan 21, 2021

Subsystems (2)
lore
Share & tools
lore

Levi Yun

author
#0 lore raw

PATCH 1/1 mm/memblock: Fix the typo on comments.

memblock_phys_alloc_try_nid function's comments has typo NUMA as MUMA. Correct this typo.

---
 mm/memblock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memblock.c +1 -1
index d24bcfa88d2f..1eaaec1e7687 100644
@@ -1427,7 +1427,7 @@ phys_addr_t __init memblock_phys_alloc_range(phys_addr_t size,
 }
 
 /**
- * memblock_phys_alloc_try_nid - allocate a memory block from specified MUMA node
+ * memblock_phys_alloc_try_nid - allocate a memory block from specified NUMA node
  * @size: size of memory block to be allocated in bytes
  * @align: alignment of the region and block's size
  * @nid: nid of the free area to find, %NUMA_NO_NODE for any node
Signature · 1 line
2.29.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Levi Yun

memblock_phys_alloc_try_nid function's comments has typo NUMA as MUMA. Correct this typo.

subject would be clearer as something like

"mm/memblock: Fix typo in comment of memblock_phys_alloc_try_nid()"

Quoted 20 lines
---
 mm/memblock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memblock.c +1 -1
index d24bcfa88d2f..1eaaec1e7687 100644
@@ -1427,7 +1427,7 @@ phys_addr_t __init memblock_phys_alloc_range(phys_addr_t size,
 }
 
 /**
- * memblock_phys_alloc_try_nid - allocate a memory block from specified MUMA node
+ * memblock_phys_alloc_try_nid - allocate a memory block from specified NUMA node
  * @size: size of memory block to be allocated in bytes
  * @align: alignment of the region and block's size
  * @nid: nid of the free area to find, %NUMA_NO_NODE for any node
Signature · 3 lines
Thanks,

David / dhildenb
author
#2 lore raw
Quoted 5 lines

subject would be clearer as something like

"mm/memblock: Fix typo in comment of memblock_phys_alloc_try_nid()"

Thanks. Then, should I resend this patch with suggested subject with Reviewed-by tag?

maintainer
#3 lore raw
Quoted 8 lines · Yun Levi
Quoted 5 lines

subject would be clearer as something like

"mm/memblock: Fix typo in comment of memblock_phys_alloc_try_nid()"

Thanks. Then, should I resend this patch with suggested subject with Reviewed-by tag?

In general, yes. When there are minor review comments and Reviewed-by tag, you should send v2 version of a patch that addresses the comments and has the Reviewed-by tag.

Since this is a small patch and a small update, I've applied the patch with the subject David suggested to memblock/fixes branch.

Signature · 2 lines
Sincerely yours,
Mike.
author
#4 lore raw
Quoted 6 lines

In general, yes. When there are minor review comments and Reviewed-by tag, you should send v2 version of a patch that addresses the comments and has the Reviewed-by tag.

Since this is a small patch and a small update, I've applied the patch with the subject David suggested to memblock/fixes branch.

I got it. Thanks.