Skip to contentSkip to conversation

arm64: dts: imx8mp: Improve VPU clock configuration

PATCH In review Marek Vasut 3 participants 5 messages Aug 10, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: imx8mp: Improve VPU clock configuration

Update VPU clock according to reference manual to improve performance. i.MX 8M Plus Applications Processor Reference Manual, Rev. 1, 06/2021

Table 5-1. Clock Root Table (continued) reads as follows:
Clock Root ............... Max Freq (MHz) VPU_BUS_CLK_ROOT ......... 800
VPU_G1_CLK_ROOT .......... 800
VPU_G2_CLK_ROOT .......... 700

5.1.5.1 Input Clocks
Input Clock .............. Frequency (MHz)
VPU_PLL_CLK .............. 800

The VPU G1 and VPU bus is now supplied from PLL1 which provides 800 MHz on one of its outputs, the VPU G2 is supplied from VPU PLL with 700 MHz which is a perfect fit for this setup. This also matches the NXP kernel fork configuration.

---
Cc: Adam Ford <[email protected]>
Cc: Alexander Stein <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frank Li <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Richard Cochran <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/freescale/imx8mp.dtsi +6 -6
index 6f2f50e1639c3..77974bd6da63a 100644
@@ -1928,8 +1928,8 @@ vpu_g1: video-codec@38300000 {
 			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>;
 			assigned-clocks = <&clk IMX8MP_CLK_VPU_G1>;
-			assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>;
-			assigned-clock-rates = <600000000>;
+			assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
+			assigned-clock-rates = <800000000>;
 			power-domains = <&vpumix_blk_ctrl IMX8MP_VPUBLK_PD_G1>;
 		};
 
@@ -1939,8 +1939,8 @@ vpu_g2: video-codec@38310000 {
 			interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>;
 			assigned-clocks = <&clk IMX8MP_CLK_VPU_G2>;
-			assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>;
-			assigned-clock-rates = <500000000>;
+			assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>;
+			assigned-clock-rates = <700000000>;
 			power-domains = <&vpumix_blk_ctrl IMX8MP_VPUBLK_PD_G2>;
 		};
 
@@ -1956,8 +1956,8 @@ vpumix_blk_ctrl: blk-ctrl@38330000 {
 				 <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
 			clock-names = "g1", "g2", "vc8000e";
 			assigned-clocks = <&clk IMX8MP_CLK_VPU_BUS>, <&clk IMX8MP_VPU_PLL>;
-			assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>;
-			assigned-clock-rates = <600000000>, <600000000>;
+			assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
+			assigned-clock-rates = <800000000>, <700000000>;
 			interconnects = <&noc IMX8MP_ICM_VPU_G1 &noc IMX8MP_ICN_VIDEO>,
 					<&noc IMX8MP_ICM_VPU_G2 &noc IMX8MP_ICN_VIDEO>,
 					<&noc IMX8MP_ICM_VPU_H1 &noc IMX8MP_ICN_VIDEO>;
Signature · 1 line
2.40.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Marek Vasut

Update VPU clock according to reference manual to improve performance. i.MX 8M Plus Applications Processor Reference Manual, Rev. 1, 06/2021

Table 5-1. Clock Root Table (continued) reads as follows:
Clock Root ............... Max Freq (MHz) VPU_BUS_CLK_ROOT ......... 800
VPU_G1_CLK_ROOT .......... 800
VPU_G2_CLK_ROOT .......... 700

5.1.5.1 Input Clocks
Input Clock .............. Frequency (MHz)
VPU_PLL_CLK .............. 800

Quoted 6 lines

The VPU G1 and VPU bus is now supplied from PLL1 which provides 800 MHz on one of its outputs, the VPU G2 is supplied from VPU PLL with 700 MHz which is a perfect fit for this setup. This also matches the NXP kernel fork configuration.

LGTM.

adam

Quoted 63 lines

---
Cc: Adam Ford <[email protected]>
Cc: Alexander Stein <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frank Li <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Richard Cochran <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/freescale/imx8mp.dtsi +6 -7
index 6f2f50e1639c3..77974bd6da63a 100644
@@ -1928,8 +1928,8 @@ vpu_g1: video-codec@38300000 {
                        interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
                        clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>;
                        assigned-clocks = <&clk IMX8MP_CLK_VPU_G1>;
-                       assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>;
-                       assigned-clock-rates = <600000000>;
+                       assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
+                       assigned-clock-rates = <800000000>;
                        power-domains = <&vpumix_blk_ctrl IMX8MP_VPUBLK_PD_G1>;
                };
 
@@ -1939,8 +1939,8 @@ vpu_g2: video-codec@38310000 {
                        interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
                        clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>;
                        assigned-clocks = <&clk IMX8MP_CLK_VPU_G2>;
-                       assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>;
-                       assigned-clock-rates = <500000000>;
+                       assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>;
+                       assigned-clock-rates = <700000000>;
                        power-domains = <&vpumix_blk_ctrl IMX8MP_VPUBLK_PD_G2>;
                };
 
@@ -1956,8 +1956,8 @@ vpumix_blk_ctrl: blk-ctrl@38330000 {
                                 <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
                        clock-names = "g1", "g2", "vc8000e";
                        assigned-clocks = <&clk IMX8MP_CLK_VPU_BUS>, <&clk IMX8MP_VPU_PLL>;
-                       assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>;
-                       assigned-clock-rates = <600000000>, <600000000>;
+                       assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
+                       assigned-clock-rates = <800000000>, <700000000>;
                        interconnects = <&noc IMX8MP_ICM_VPU_G1 &noc IMX8MP_ICN_VIDEO>,
                                        <&noc IMX8MP_ICM_VPU_G2 &noc IMX8MP_ICN_VIDEO>,
                                        <&noc IMX8MP_ICM_VPU_H1 &noc IMX8MP_ICN_VIDEO>;
--

2.40.1

#2 lore raw
In reply to Marek Vasut

Hi Marek,

Quoted 9 lines · Marek Vasut

Update VPU clock according to reference manual to improve performance. i.MX 8M Plus Applications Processor Reference Manual, Rev. 1, 06/2021

Table 5-1. Clock Root Table (continued) reads as follows:
Clock Root ............... Max Freq (MHz) VPU_BUS_CLK_ROOT ......... 800
VPU_G1_CLK_ROOT .......... 800
VPU_G2_CLK_ROOT .......... 700

Quoted 3 lines

5.1.5.1 Input Clocks
Input Clock .............. Frequency (MHz)
VPU_PLL_CLK .............. 800

Acoording the datasheet not the reference manual, this would be the overdrive mode now. Can we ensure that VDD_SOC is in overdrive state?

Regards,
Marco

Quoted 71 lines

The VPU G1 and VPU bus is now supplied from PLL1 which provides 800 MHz on one of its outputs, the VPU G2 is supplied from VPU PLL with 700 MHz which is a perfect fit for this setup. This also matches the NXP kernel fork configuration.

---
Cc: Adam Ford <[email protected]>
Cc: Alexander Stein <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frank Li <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Richard Cochran <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/freescale/imx8mp.dtsi +6 -6
index 6f2f50e1639c3..77974bd6da63a 100644
@@ -1928,8 +1928,8 @@ vpu_g1: video-codec@38300000 {
 			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>;
 			assigned-clocks = <&clk IMX8MP_CLK_VPU_G1>;
-			assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>;
-			assigned-clock-rates = <600000000>;
+			assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
+			assigned-clock-rates = <800000000>;
 			power-domains = <&vpumix_blk_ctrl IMX8MP_VPUBLK_PD_G1>;
 		};
 
@@ -1939,8 +1939,8 @@ vpu_g2: video-codec@38310000 {
 			interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>;
 			assigned-clocks = <&clk IMX8MP_CLK_VPU_G2>;
-			assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>;
-			assigned-clock-rates = <500000000>;
+			assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>;
+			assigned-clock-rates = <700000000>;
 			power-domains = <&vpumix_blk_ctrl IMX8MP_VPUBLK_PD_G2>;
 		};
 
@@ -1956,8 +1956,8 @@ vpumix_blk_ctrl: blk-ctrl@38330000 {
 				 <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
 			clock-names = "g1", "g2", "vc8000e";
 			assigned-clocks = <&clk IMX8MP_CLK_VPU_BUS>, <&clk IMX8MP_VPU_PLL>;
-			assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>;
-			assigned-clock-rates = <600000000>, <600000000>;
+			assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
+			assigned-clock-rates = <800000000>, <700000000>;
 			interconnects = <&noc IMX8MP_ICM_VPU_G1 &noc IMX8MP_ICN_VIDEO>,
 					<&noc IMX8MP_ICM_VPU_G2 &noc IMX8MP_ICN_VIDEO>,
 					<&noc IMX8MP_ICM_VPU_H1 &noc IMX8MP_ICN_VIDEO>;
Signature · 1 line
2.40.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw
Quoted 13 lines · Marco Felsch

Hi Marek,

Quoted 9 lines · Marek Vasut

Update VPU clock according to reference manual to improve performance. i.MX 8M Plus Applications Processor Reference Manual, Rev. 1, 06/2021

Table 5-1. Clock Root Table (continued) reads as follows:
Clock Root ............... Max Freq (MHz) VPU_BUS_CLK_ROOT ......... 800
VPU_G1_CLK_ROOT .......... 800
VPU_G2_CLK_ROOT .......... 700

Quoted 6 lines
Quoted 3 lines

5.1.5.1 Input Clocks
Input Clock .............. Frequency (MHz)
VPU_PLL_CLK .............. 800

Acoording the datasheet not the reference manual, this would be the overdrive mode now. Can we ensure that VDD_SOC is in overdrive state?

Shoot, I explicitly searched the TRM for overdrive, because I remember this coming before with either the 8MQ or 8MM, but I couldn't remember. I forgot all about the actual datasheet.

The operating-points for the various voltage rails would have to increase to get this into overdrive mode. I think this would have to be done on a per-board basis if memory serves when this came up before. :-(

adam

Quoted 75 lines

Regards,
Marco

Quoted 71 lines

The VPU G1 and VPU bus is now supplied from PLL1 which provides 800 MHz on one of its outputs, the VPU G2 is supplied from VPU PLL with 700 MHz which is a perfect fit for this setup. This also matches the NXP kernel fork configuration.

---
Cc: Adam Ford <[email protected]>
Cc: Alexander Stein <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Frank Li <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Richard Cochran <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/freescale/imx8mp.dtsi +6 -7
index 6f2f50e1639c3..77974bd6da63a 100644
@@ -1928,8 +1928,8 @@ vpu_g1: video-codec@38300000 {
                      interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
                      clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>;
                      assigned-clocks = <&clk IMX8MP_CLK_VPU_G1>;
-                     assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>;
-                     assigned-clock-rates = <600000000>;
+                     assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
+                     assigned-clock-rates = <800000000>;
                      power-domains = <&vpumix_blk_ctrl IMX8MP_VPUBLK_PD_G1>;
              };
 
@@ -1939,8 +1939,8 @@ vpu_g2: video-codec@38310000 {
                      interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
                      clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>;
                      assigned-clocks = <&clk IMX8MP_CLK_VPU_G2>;
-                     assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>;
-                     assigned-clock-rates = <500000000>;
+                     assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>;
+                     assigned-clock-rates = <700000000>;
                      power-domains = <&vpumix_blk_ctrl IMX8MP_VPUBLK_PD_G2>;
              };
 
@@ -1956,8 +1956,8 @@ vpumix_blk_ctrl: blk-ctrl@38330000 {
                               <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
                      clock-names = "g1", "g2", "vc8000e";
                      assigned-clocks = <&clk IMX8MP_CLK_VPU_BUS>, <&clk IMX8MP_VPU_PLL>;
-                     assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>;
-                     assigned-clock-rates = <600000000>, <600000000>;
+                     assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
+                     assigned-clock-rates = <800000000>, <700000000>;
                      interconnects = <&noc IMX8MP_ICM_VPU_G1 &noc IMX8MP_ICN_VIDEO>,
                                      <&noc IMX8MP_ICM_VPU_G2 &noc IMX8MP_ICN_VIDEO>,
                                      <&noc IMX8MP_ICM_VPU_H1 &noc IMX8MP_ICN_VIDEO>;
--

2.40.1

#4 lore raw
Quoted 18 lines · Adam Ford
Quoted 17 lines · Marco Felsch

Hi Marek,

Quoted 12 lines · Marek Vasut

Update VPU clock according to reference manual to improve performance. i.MX 8M Plus Applications Processor Reference Manual, Rev. 1, 06/2021

Table 5-1. Clock Root Table (continued) reads as follows:
Clock Root ............... Max Freq (MHz) VPU_BUS_CLK_ROOT ......... 800
VPU_G1_CLK_ROOT .......... 800
VPU_G2_CLK_ROOT .......... 700

5.1.5.1 Input Clocks
Input Clock .............. Frequency (MHz)
VPU_PLL_CLK .............. 800

Quoted 6 lines
Quoted 2 lines

Acoording the datasheet not the reference manual, this would be the overdrive mode now. Can we ensure that VDD_SOC is in overdrive state?

Shoot, I explicitly searched the TRM for overdrive, because I remember this coming before with either the 8MQ or 8MM, but I couldn't remember. I forgot all about the actual datasheet.

Same here, I vaguely recall there might've been a reason why those lower freqs, but I couldn't find it either.

Quoted 4 lines

The operating-points for the various voltage rails would have to increase to get this into overdrive mode. I think this would have to be done on a per-board basis if memory serves when this came up before. :-(

I don't mind doing it per board. Actually, I don't mind dropping this patch, since the decoding performance increase is not even an issue in any of the use cases I care about.

I guess the general agreement here is to go with the "nominal mode" by default and enable "overdrive mode" per-board , while the NXP downstream goes full "overdrive mode" all the time ?