Skip to contentSkip to conversation

drm/amd/display: bypass stereo programming

PATCH In review Liu, Aaron 3 participants 4 messages Sep 4, 2019 2 messages not in the archive

Subsystems (3)
lore
Share & tools
lore

Liu, Aaron

author
#0 lore raw

PATCH 1/2 drm/amd/display: bypass stereo programming

From: Roman Li <[email protected]>

hack to avoid crash on renoir
should be resolved after upcoming gpio refactoring promotion

---
 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c +6 -0
index 5b9dd16..ee2186c 100644
@@ -2844,6 +2844,12 @@ static void dcn10_setup_stereo(struct pipe_ctx *pipe_ctx, struct dc *dc)
 {
 	struct crtc_stereo_flags flags = { 0 };
 	struct dc_stream_state *stream = pipe_ctx->stream;
+#ifdef CONFIG_DRM_AMD_DC_DCN2_1
+/* TODO: remove after gpio refactor gets promoted
+*        otherwise it causing crash on Renoir
+*/
+	return;
+#endif
 
 	dcn10_config_stereo_parameters(stream, &flags);
 
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1567577166-18064-1-git-send-email-aaron.liu-5C7GfCeVMHo@public.gmane.org

author
#2 lore raw

PATCH 2/2 drm/amd/display: update renoir_ip_offset.h

This patch updates MP1_BASE in renoir_ip_offset.h

---
 drivers/gpu/drm/amd/include/renoir_ip_offset.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/include/renoir_ip_offset.h +1 -1
index 554714c..094648c 100644
@@ -155,7 +155,7 @@ static const struct IP_BASE MP0_BASE ={ { { { 0x00016000, 0x0243FC00, 0x00DC0000
                                         { { 0, 0, 0, 0, 0 } },
                                         { { 0, 0, 0, 0, 0 } },
                                         { { 0, 0, 0, 0, 0 } } } };
-static const struct IP_BASE MP1_BASE ={ { { { 0x00016200, 0x02400400, 0x00E80000, 0x00EC0000, 0x00F00000 } },
+static const struct IP_BASE MP1_BASE ={ { { { 0x00016000, 0x02400400, 0x00E80000, 0x00EC0000, 0x00F00000 } },
                                         { { 0, 0, 0, 0, 0 } },
                                         { { 0, 0, 0, 0, 0 } },
                                         { { 0, 0, 0, 0, 0 } },
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1567577166-18064-2-git-send-email-aaron.liu-5C7GfCeVMHo@public.gmane.org

Acked-by Roman Li
#4 lore raw

RE: [PATCH 2/2] drm/amd/display: update renoir_ip_offset.h

-----Original Message-----
From: Liu, Aaron <[email protected]>
Sent: Wednesday, September 4, 2019 2:07 AM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Huang, Ray <[email protected]>; Li, Roman <[email protected]>; Liu, Aaron <[email protected]>
Subject: [PATCH 2/2] drm/amd/display: update renoir_ip_offset.h

This patch updates MP1_BASE in renoir_ip_offset.h

---
 drivers/gpu/drm/amd/include/renoir_ip_offset.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/include/renoir_ip_offset.h +2 -0
index 554714c..094648c 100644
@@ -155,7 +155,7 @@ static const struct IP_BASE MP0_BASE ={ { { { 0x00016000, 0x0243FC00, 0x00DC0000
                                         { { 0, 0, 0, 0, 0 } },
                                         { { 0, 0, 0, 0, 0 } },
                                         { { 0, 0, 0, 0, 0 } } } }; -static const struct IP_BASE MP1_BASE ={ { { { 0x00016200, 0x02400400, 0x00E80000, 0x00EC0000, 0x00F00000 } },
+static const struct IP_BASE MP1_BASE ={ { { { 0x00016000, 0x02400400, 
+0x00E80000, 0x00EC0000, 0x00F00000 } },
                                         { { 0, 0, 0, 0, 0 } },
                                         { { 0, 0, 0, 0, 0 } },
                                         { { 0, 0, 0, 0, 0 } },

--
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#5 lore raw
In reply to a message not in the archive
Quoted 6 lines · Aaron

From: Roman Li <[email protected]>

hack to avoid crash on renoir
should be resolved after upcoming gpio refactoring promotion

Nack. This is not the right way to do this upstream. We shouldn't use compile time guard to change ASIC behavior. This is a bringup-branch change and needs to be revisited for amd-stg.

Harry

Quoted 12 lines
---
 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c +0 -0
index 5b9dd16..ee2186c 100644
@@ -2844,6 +2844,12 @@ static void dcn10_setup_stereo(struct pipe_ctx *pipe_ctx, struct dc *dc)
 {
 	struct crtc_stereo_flags flags = { 0 };

drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c static void dcn10_setup_stereo(struct pipe_ctx *pipe_ctx, struct dc *dc) · line 2855

Quoted 10 lines
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c +6 -0
 	struct dc_stream_state *stream = pipe_ctx->stream;
+#ifdef CONFIG_DRM_AMD_DC_DCN2_1
+/* TODO: remove after gpio refactor gets promoted
+*        otherwise it causing crash on Renoir
+*/
+	return;
+#endif
 
 	dcn10_config_stereo_parameters(stream, &flags);
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx