usb: chipidea: udc: Use usb_endpoint_is_isoc_in() rather than duplicating its implementation
Subsystems (3)
PATCH 1/1 usb: chipidea: udc: Use usb_endpoint_is_isoc_in() rather than duplicating its implementation
From: Markus Elfring <[email protected]>
Date: Tue, 24 Jun 2025 17:30:52 +0200
Reuse existing functionality from usb_endpoint_is_isoc_in() instead of keeping duplicate source code.
The source code was transformed by using the Coccinelle software.
--- drivers/usb/chipidea/udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/chipidea/udc.c +1 -1
@@ -1992,7 +1992,7 @@ static struct usb_ep *ci_udc_match_ep(struct usb_gadget *gadget, struct ci_hdrc *ci = container_of(gadget, struct ci_hdrc, gadget);struct usb_ep *ep; -if (usb_endpoint_xfer_isoc (desc) &&usb_endpoint_dir_in (desc)) { +if (usb_endpoint_is_isoc_in (desc)) {list_for_each_entry_reverse (ep, &ci->gadget.ep_list, ep_list) {if (ep->caps.dir_in && !ep->claimed)return ep;
Signature · 1 line
2.50.0
Quoted 18 lines · Markus Elfring
From: Markus Elfring <[email protected]>
Date: Tue, 24 Jun 2025 17:30:52 +0200Reuse existing functionality from
usb_endpoint_is_isoc_in()instead of keeping duplicate source code.The source code was transformed by using the Coccinelle software.
Signed-off-by Markus Elfring <[email protected]>--- drivers/usb/chipidea/udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/chipidea/udc.c +0
-0
drivers/usb/chipidea/udc.c static struct usb_ep *ci_udc_match_ep(struct usb_gadget *gadget, · line 1998
Quoted 8 lines
drivers/usb/chipidea/udc.c +1
-1@@ -1992,7 +1992,7 @@ static struct usb_ep *ci_udc_match_ep(struct usb_gadget *gadget, struct ci_hdrc *ci = container_of(gadget, struct ci_hdrc, gadget);struct usb_ep *ep; -if (usb_endpoint_xfer_isoc (desc) &&usb_endpoint_dir_in (desc)) { +if (usb_endpoint_is_isoc_in (desc)) {list_for_each_entry_reverse (ep, &ci->gadget.ep_list, ep_list) {if (ep->caps.dir_in && !ep->claimed)return ep;
Ok for me.
Quoted 3 lines
Signature · 1 line
2.50.0
Quoted 9 lines · Markus Elfring
From: Markus Elfring <[email protected]>
Date: Tue, 24 Jun 2025 17:30:52 +0200Reuse existing functionality from
usb_endpoint_is_isoc_in()instead of keeping duplicate source code.The source code was transformed by using the Coccinelle software.
Signed-off-by Markus Elfring <[email protected]>
Peter
Quoted 20 lines
--- drivers/usb/chipidea/udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/chipidea/udc.c +1
-1@@ -1992,7 +1992,7 @@ static struct usb_ep *ci_udc_match_ep(struct usb_gadget *gadget, struct ci_hdrc *ci = container_of(gadget, struct ci_hdrc, gadget);struct usb_ep *ep; -if (usb_endpoint_xfer_isoc (desc) &&usb_endpoint_dir_in (desc)) { +if (usb_endpoint_is_isoc_in (desc)) {list_for_each_entry_reverse (ep, &ci->gadget.ep_list, ep_list) {if (ep->caps.dir_in && !ep->claimed)return ep;Signature · 1 line
2.50.0
Signature · 2 lines
Best regards, Peter