staging: rtl8723bs: remove residual 5 Ghz code and more code cleaning
cover staging: rtl8723bs: remove residual 5 Ghz code and more code cleaning
This patchset removes some residual 5 Ghz dead code, left undeleted from recent patches intended for this aim.
Done some code cleaning as well (mainly camel case fixes)
Fabio Aiuto (16):
staging: rtl8723bs: simplify function selecting channel group
staging: rtl8723bs: fix camel case inside function
staging: rtl8723bs: convert function name to snake case
staging: rtl8723bs: add spaces around operator
staging: rtl8723bs: remove 5Ghz code blocks
staging: rtl8723bs: remove commented out condition
staging: rtl8723bs: fix camel case in struct wlan_bssid_ex
staging: rtl8723bs: fix camel case in struct ndis_802_11_conf
staging: rtl8723bs: remove struct ndis_802_11_conf_fh
staging: rtl8723bs: fix camel case in struct ndis_802_11_ssid
staging: rtl8723bs: fix camel case in struct wlan_phy_info
staging: rtl8723bs: fix camel case in struct wlan_bcn_info
staging: rtl8723bs: fix camel case in IE structures
staging: rtl8723bs: remove unused struct ndis_802_11_ai_reqfi
staging: rtl8723bs: remove unused struct ndis_801_11_ai_resfi
staging: rtl8723bs: fix camel case in struct ndis_802_11_wep
drivers/staging/rtl8723bs/core/rtw_ap.c | 124 ++++---- drivers/staging/rtl8723bs/core/rtw_cmd.c | 54 ++-- .../staging/rtl8723bs/core/rtw_ieee80211.c | 80 ++--- .../staging/rtl8723bs/core/rtw_ioctl_set.c | 28 +- drivers/staging/rtl8723bs/core/rtw_mlme.c | 214 +++++++------ drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 287 +++++++++--------- .../staging/rtl8723bs/core/rtw_wlan_util.c | 102 +++---- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +- drivers/staging/rtl8723bs/hal/hal_com.c | 2 +- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 22 +- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 64 +--- drivers/staging/rtl8723bs/include/rtw_mlme.h | 6 +- .../staging/rtl8723bs/include/wlan_bssdef.h | 90 +++--- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 92 +++--- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 190 ++++++------ drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 +- 16 files changed, 641 insertions(+), 720 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/16 staging: rtl8723bs: simplify function selecting channel group
simplify function Hal_GetChnlGroup8723B(). It returns an unused and unnecessary bool value telling which band the device works on. Since we work only on 2.4Ghz band and the useful return value is the second function argument we convert the return type to void.
remove 5Ghz dead code either (for channel > 14).
--- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 62 ++++--------------- 1 file changed, 12 insertions(+), 50 deletions(-)
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +12 -50
@@ -2061,56 +2061,18 @@ s32 rtl8723b_InitLLTTable(struct adapter *padapter)return ret; } -static bool Hal_GetChnlGroup8723B (u8 Channel,u8 *pGroup) -{ -bool bIn24G = true; - -if (Channel <=14 ) { - bIn24G = true; - -if (1 <= Channel && Channel <=2 ) - *pGroup =0 ; -else if (3 <= Channel && Channel <=5 ) - *pGroup =1 ; -else if (6 <= Channel && Channel <=8 ) - *pGroup =2 ; -else if (9 <= Channel && Channel <=11 ) - *pGroup =3 ; -else if (12 <= Channel && Channel <=14 ) - *pGroup =4 ; - }else { - bIn24G = false; - -if (36 <= Channel && Channel <=42 ) - *pGroup =0 ; -else if (44 <= Channel && Channel <=48 ) - *pGroup =1 ; -else if (50 <= Channel && Channel <=58 ) - *pGroup =2 ; -else if (60 <= Channel && Channel <=64 ) - *pGroup =3 ; -else if (100 <= Channel && Channel <=106 ) - *pGroup =4 ; -else if (108 <= Channel && Channel <=114 ) - *pGroup =5 ; -else if (116 <= Channel && Channel <=122 ) - *pGroup =6 ; -else if (124 <= Channel && Channel <=130 ) - *pGroup =7 ; -else if (132 <= Channel && Channel <=138 ) - *pGroup =8 ; -else if (140 <= Channel && Channel <=144 ) - *pGroup =9 ; -else if (149 <= Channel && Channel <=155 ) - *pGroup =10 ; -else if (157 <= Channel && Channel <=161 ) - *pGroup =11 ; -else if (165 <= Channel && Channel <=171 ) - *pGroup =12 ; -else if (173 <= Channel && Channel <=177 ) - *pGroup =13 ; - } -return bIn24G; +static void Hal_GetChnlGroup8723B (u8 Channel,u8 *pGroup) +{ +if (1 <= Channel && Channel <=2 ) + *pGroup =0 ; +else if (3 <= Channel && Channel <=5 ) + *pGroup =1 ; +else if (6 <= Channel && Channel <=8 ) + *pGroup =2 ; +else if (9 <= Channel && Channel <=11 ) + *pGroup =3 ; +else if (12 <= Channel && Channel <=14 ) + *pGroup =4 ; }void Hal_InitPGData (struct adapter *padapter,u8 *PROMContent)
Signature · 1 line
2.20.1
PATCH 2/16 staging: rtl8723bs: fix camel case inside function
In reply to Fabio Aiutofix camel case inside function Hal_GetChnlGroup8723B()
--- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +12 -12
@@ -2061,18 +2061,18 @@ s32 rtl8723b_InitLLTTable(struct adapter *padapter)return ret; } -static void Hal_GetChnlGroup8723B (u8 Channel,u8 *pGroup) -{ -if (1 <= Channel && Channel <=2 ) - *pGroup =0 ; -else if (3 <= Channel && Channel <=5 ) - *pGroup =1 ; -else if (6 <= Channel && Channel <=8 ) - *pGroup =2 ; -else if (9 <= Channel && Channel <=11 ) - *pGroup =3 ; -else if (12 <= Channel && Channel <=14 ) - *pGroup =4 ; +static void Hal_GetChnlGroup8723B (u8 channel,u8 *group) +{ +if (1 <= channel && channel <=2 ) + *group =0 ; +else if (3 <= channel && channel <=5 ) + *group =1 ; +else if (6 <= channel && channel <=8 ) + *group =2 ; +else if (9 <= channel && channel <=11 ) + *group =3 ; +else if (12 <= channel && channel <=14 ) + *group =4 ; }void Hal_InitPGData (struct adapter *padapter,u8 *PROMContent)
Signature · 1 line
2.20.1
PATCH 3/16 staging: rtl8723bs: convert function name to snake case
In reply to Fabio Aiutoconvert Hal_GetChnlGroup8723B() function name to snake case.
--- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +2 -2
@@ -2061,7 +2061,7 @@ s32 rtl8723b_InitLLTTable(struct adapter *padapter)return ret; } -static void Hal_GetChnlGroup8723B (u8 channel,u8 *group) +static void hal_get_chnl_group_8723b (u8 channel,u8 *group) {if (1 <= channel && channel <=2 ) *group =0 ;
@@ -2235,7 +2235,7 @@ void Hal_EfuseParseTxPowerInfo_8723B(for (ch =0 ; ch <CHANNEL_MAX_NUMBER ; ch++) {u8 group =0 ; -Hal_GetChnlGroup8723B (ch+1 , &group); +hal_get_chnl_group_8723b (ch+1 , &group);if (ch ==14 -1 ) { pHalData->Index24G_CCK_Base[rfPath][ch] = pwrInfo24G.IndexCCK_Base[rfPath][5 ];
Signature · 1 line
2.20.1
PATCH 4/16 staging: rtl8723bs: add spaces around operator
In reply to Fabio Aiutofix the following post-commit hook checkpatch warning:
CHECK: spaces preferred around that '+' (ctx:VxV)
29: FILE: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:2238:
+ hal_get_chnl_group_8723b(ch+1, &group);
--- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +1 -1
@@ -2235,7 +2235,7 @@ void Hal_EfuseParseTxPowerInfo_8723B(for (ch =0 ; ch <CHANNEL_MAX_NUMBER ; ch++) {u8 group =0 ; -hal_get_chnl_group_8723b (ch+1 , &group); +hal_get_chnl_group_8723b (ch +1 , &group);if (ch ==14 -1 ) { pHalData->Index24G_CCK_Base[rfPath][ch] = pwrInfo24G.IndexCCK_Base[rfPath][5 ];
Signature · 1 line
2.20.1
PATCH 5/16 staging: rtl8723bs: remove 5Ghz code blocks
In reply to Fabio Aiutoremove 5 Ghz code blocks, related to networks
working over channel numbers above 14.
--- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 7 ++----- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 20 +++---------------- 2 files changed, 5 insertions(+), 22 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +2 -5
@@ -3708,7 +3708,7 @@ static void issue_action_BSSCoexistPacket(struct adapter *padapter) p =rtw_get_ie (pbss_network->IEs + _FIXED_IE_LENGTH_,WLAN_EID_HT_CAPABILITY , &len, pbss_network->IELength - _FIXED_IE_LENGTH_);if ((p ==NULL ) || (len ==0 )) {/* non-HT */ -if ((pbss_network->Configuration.DSConfig <=0 ) || (pbss_network->Configuration.DSConfig >14 )) +if (pbss_network->Configuration.DSConfig <=0 )continue ;ICS [0 ][pbss_network->Configuration.DSConfig] =1 ;
@@ -5428,10 +5428,7 @@ u8 join_cmd_hdl(struct adapter *padapter, u8 *pbuf) {struct HT_info_element *pht_info = (struct HT_info_element *)(pIE->data); -if (pnetwork->Configuration.DSConfig >14 ) { -if ((pregpriv->bw_mode >>4 ) >CHANNEL_WIDTH_20 ) - cbw40_enable =1 ; - }else { +if (pnetwork->Configuration.DSConfig <=14 ) {if ((pregpriv->bw_mode &0x0f ) >CHANNEL_WIDTH_20 ) cbw40_enable =1 ; }
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +3 -17
@@ -129,14 +129,7 @@ static char *translate_scan(struct adapter *padapter,else snprintf (iwe.u.name,IFNAMSIZ ,"IEEE 802.11bg" ); }else { -if (pnetwork->network.Configuration.DSConfig >14 ) { -if (vht_cap) -snprintf (iwe.u.name,IFNAMSIZ ,"IEEE 802.11AC" ); -else if (ht_cap) -snprintf (iwe.u.name,IFNAMSIZ ,"IEEE 802.11an" ); -else -snprintf (iwe.u.name,IFNAMSIZ ,"IEEE 802.11a" ); - }else { +if (pnetwork->network.Configuration.DSConfig <=14 ) {if (ht_cap)snprintf (iwe.u.name,IFNAMSIZ ,"IEEE 802.11gn" );else
@@ -683,7 +676,7 @@ static int rtw_wx_get_name(struct net_device *dev,struct adapter *padapter =rtw_netdev_priv (dev);u32 ht_ielen =0 ;char *p; -u8 ht_cap = false, vht_cap = false; +u8 ht_cap = false;struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;NDIS_802_11_RATES_EX *prates =NULL ;
@@ -707,14 +700,7 @@ static int rtw_wx_get_name(struct net_device *dev,else snprintf (wrqu->name,IFNAMSIZ ,"IEEE 802.11bg" ); }else { -if (pcur_bss->Configuration.DSConfig >14 ) { -if (vht_cap) -snprintf (wrqu->name,IFNAMSIZ ,"IEEE 802.11AC" ); -else if (ht_cap) -snprintf (wrqu->name,IFNAMSIZ ,"IEEE 802.11an" ); -else -snprintf (wrqu->name,IFNAMSIZ ,"IEEE 802.11a" ); - }else { +if (pcur_bss->Configuration.DSConfig <=14 ) {if (ht_cap)snprintf (wrqu->name,IFNAMSIZ ,"IEEE 802.11gn" );else
Signature · 1 line
2.20.1
PATCH 6/16 staging: rtl8723bs: remove commented out condition
In reply to Fabio Aiutoremove commented out condition checking channel > 14.
--- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +1 -1
@@ -159,7 +159,7 @@ static char *translate_scan(struct adapter *padapter, start =iwe_stream_add_event (info, start, stop, &iwe,IW_EV_UINT_LEN ); } -if (pnetwork->network.Configuration.DSConfig <1 /*|| pnetwork->network.Configuration.DSConfig > 14*/ ) +if (pnetwork->network.Configuration.DSConfig <1 ) pnetwork->network.Configuration.DSConfig =1 ;/* Add frequency/channel */
Signature · 1 line
2.20.1
PATCH 7/16 staging: rtl8723bs: fix camel case in struct wlan_bssid_ex
In reply to Fabio Aiutofix camel case in struct wlan_bssid_ex.
--- drivers/staging/rtl8723bs/core/rtw_ap.c | 124 ++++----- drivers/staging/rtl8723bs/core/rtw_cmd.c | 50 ++-- .../staging/rtl8723bs/core/rtw_ieee80211.c | 52 ++-- .../staging/rtl8723bs/core/rtw_ioctl_set.c | 12 +- drivers/staging/rtl8723bs/core/rtw_mlme.c | 216 +++++++-------- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 248 +++++++++--------- .../staging/rtl8723bs/core/rtw_wlan_util.c | 58 ++-- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +- drivers/staging/rtl8723bs/hal/hal_com.c | 2 +- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 22 +- drivers/staging/rtl8723bs/include/rtw_mlme.h | 6 +- .../staging/rtl8723bs/include/wlan_bssdef.h | 30 +-- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 64 ++--- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 104 ++++---- 14 files changed, 495 insertions(+), 495 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +62 -62
@@ -56,7 +56,7 @@ static void update_BCNTIM(struct adapter *padapter)struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;struct wlan_bssid_ex *pnetwork_mlmeext = &pmlmeinfo->network; -unsigned char *pie = pnetwork_mlmeext->IEs; +unsigned char *pie = pnetwork_mlmeext->ies;/* update TIM IE */ u8 *p, *dst_ie, *premainder_ie =NULL , *pbackup_remainder_ie =NULL ;
@@ -68,7 +68,7 @@ static void update_BCNTIM(struct adapter *padapter) p =rtw_get_ie (pie + _FIXED_IE_LENGTH_,WLAN_EID_TIM , &tim_ielen, - pnetwork_mlmeext->IELength - _FIXED_IE_LENGTH_ + pnetwork_mlmeext->ie_length - _FIXED_IE_LENGTH_ );if (p && tim_ielen >0 ) { tim_ielen +=2 ;
@@ -77,7 +77,7 @@ static void update_BCNTIM(struct adapter *padapter) tim_ie_offset = (signed int )(p - pie); - remainder_ielen = pnetwork_mlmeext->IELength - tim_ie_offset - tim_ielen; + remainder_ielen = pnetwork_mlmeext->ie_length - tim_ie_offset - tim_ielen;/* append TIM IE from dst_ie offset */ dst_ie = p;
@@ -91,7 +91,7 @@ static void update_BCNTIM(struct adapter *padapter) p =rtw_get_ie (pie + _BEACON_IE_OFFSET_,WLAN_EID_SSID , &tmp_len, - (pnetwork_mlmeext->IELength - _BEACON_IE_OFFSET_) + (pnetwork_mlmeext->ie_length - _BEACON_IE_OFFSET_) );if (p) offset += tmp_len +2 ;
@@ -99,7 +99,7 @@ static void update_BCNTIM(struct adapter *padapter)/* get supported rates len */ p =rtw_get_ie (pie + _BEACON_IE_OFFSET_,WLAN_EID_SUPP_RATES , &tmp_len, - (pnetwork_mlmeext->IELength - _BEACON_IE_OFFSET_) + (pnetwork_mlmeext->ie_length - _BEACON_IE_OFFSET_) );if (p) offset += tmp_len +2 ;
@@ -109,7 +109,7 @@ static void update_BCNTIM(struct adapter *padapter) premainder_ie = pie + offset; - remainder_ielen = pnetwork_mlmeext->IELength - offset - tim_ielen; + remainder_ielen = pnetwork_mlmeext->ie_length - offset - tim_ielen;/* append TIM IE from offset */ dst_ie = pie + offset;
@@ -161,7 +161,7 @@ static void update_BCNTIM(struct adapter *padapter) } offset = (uint)(dst_ie - pie); - pnetwork_mlmeext->IELength = offset + remainder_ielen; + pnetwork_mlmeext->ie_length = offset + remainder_ielen; }static u8 chk_sta_is_alive (struct sta_info *psta)
@@ -340,7 +340,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level) shortGIrate =query_ra_short_GI (psta); -if (pcur_network->Configuration.DSConfig >14 ) { +if (pcur_network->configuration.DSConfig >14 ) { sta_band |=WIRELESS_INVALID ; }else {if (tx_ra_bitmap &0xffff000 )
@@ -397,16 +397,16 @@ void update_bmc_sta(struct adapter *padapter)/* psta->dot118021XPrivacy = _NO_PRIVACY_;//!!! remove it, because it has been set before this. */ /* prepare for add_RATid */ - supportRateNum =rtw_get_rateset_len ((u8 *)&pcur_network->SupportedRates); - network_type =rtw_check_network_type ((u8 *)&pcur_network->SupportedRates, + supportRateNum =rtw_get_rateset_len ((u8 *)&pcur_network->supported_rates); + network_type =rtw_check_network_type ((u8 *)&pcur_network->supported_rates, supportRateNum, - pcur_network->Configuration.DSConfig + pcur_network->configuration.DSConfig );if (is_supported_tx_cck (network_type)) { network_type =WIRELESS_11B ; }else if (network_type ==WIRELESS_INVALID ) {/* error handling */ -if (pcur_network->Configuration.DSConfig >14 ) +if (pcur_network->configuration.DSConfig >14 ) network_type =WIRELESS_INVALID ;else network_type =WIRELESS_11B ;
@@ -572,8 +572,8 @@ static void update_ap_info(struct adapter *padapter, struct sta_info *psta) psta->wireless_mode = pmlmeext->cur_wireless_mode; - psta->bssratelen =rtw_get_rateset_len (pnetwork->SupportedRates); -memcpy (psta->bssrateset, pnetwork->SupportedRates, psta->bssratelen); + psta->bssratelen =rtw_get_rateset_len (pnetwork->supported_rates); +memcpy (psta->bssrateset, pnetwork->supported_rates, psta->bssratelen);/* HT related cap */ if (phtpriv_ap->ht_option) {
@@ -656,16 +656,16 @@ void start_bss_network(struct adapter *padapter)struct HT_info_element *pht_info =NULL ;u8 cbw40_enable =0 ; - bcn_interval = (u16 )pnetwork->Configuration.BeaconPeriod; - cur_channel = pnetwork->Configuration.DSConfig; + bcn_interval = (u16 )pnetwork->configuration.BeaconPeriod; + cur_channel = pnetwork->configuration.DSConfig; cur_bwmode =CHANNEL_WIDTH_20 ; cur_ch_offset =HAL_PRIME_CHNL_OFFSET_DONT_CARE ;/* check if there is wps ie, */ /* if there is wpsie in beacon, the hostapd will update beacon twice when stating hostapd, */ /* and at first time the security ie (RSN/WPA IE) will not include in beacon. */ -if (!rtw_get_wps_ie (pnetwork->IEs + _FIXED_IE_LENGTH_, - pnetwork->IELength - _FIXED_IE_LENGTH_,NULL ,NULL )) +if (!rtw_get_wps_ie (pnetwork->ies + _FIXED_IE_LENGTH_, + pnetwork->ie_length - _FIXED_IE_LENGTH_,NULL ,NULL )) pmlmeext->bstart_bss = true;/* todo: update wmm, ht cap */
@@ -694,7 +694,7 @@ void start_bss_network(struct adapter *padapter)Set_MSR (padapter, _HW_STATE_AP_);/* Set BSSID REG */ -rtw_hal_set_hwreg (padapter,HW_VAR_BSSID , pnetwork->MacAddress); +rtw_hal_set_hwreg (padapter,HW_VAR_BSSID , pnetwork->mac_address);/* Set EDCA param reg */ acparm =0x002F3217 ;/* VO */
@@ -734,10 +734,10 @@ void start_bss_network(struct adapter *padapter) }/* set channel, bwmode */ - p =rtw_get_ie ((pnetwork->IEs +sizeof (struct ndis_802_11_fix_ie )), + p =rtw_get_ie ((pnetwork->ies +sizeof (struct ndis_802_11_fix_ie )),WLAN_EID_HT_OPERATION , &ie_len, - (pnetwork->IELength -sizeof (struct ndis_802_11_fix_ie )) + (pnetwork->ie_length -sizeof (struct ndis_802_11_fix_ie )) );if (p && ie_len) { pht_info = (struct HT_info_element *)(p +2 );
@@ -780,14 +780,14 @@ void start_bss_network(struct adapter *padapter) pmlmeext->cur_wireless_mode = pmlmepriv->cur_network.network_type;/* let pnetwork_mlmeext == pnetwork_mlme. */ -memcpy (pnetwork_mlmeext, pnetwork, pnetwork->Length); +memcpy (pnetwork_mlmeext, pnetwork, pnetwork->length);/* update cur_wireless_mode */ update_wireless_mode (padapter);/* update RRSR after set channel and bandwidth */ -UpdateBrateTbl (padapter, pnetwork->SupportedRates); -rtw_hal_set_hwreg (padapter,HW_VAR_BASIC_RATE , pnetwork->SupportedRates); +UpdateBrateTbl (padapter, pnetwork->supported_rates); +rtw_hal_set_hwreg (padapter,HW_VAR_BASIC_RATE , pnetwork->supported_rates);/* update capability after cur_wireless_mode updated */ update_capinfo(
@@ -827,7 +827,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);struct wlan_bssid_ex *pbss_network = (struct wlan_bssid_ex *)&pmlmepriv->cur_network.network; -u8 *ie = pbss_network->IEs; +u8 *ie = pbss_network->ies;if (!check_fwstate (pmlmepriv,WIFI_AP_STATE ))return _FAIL;
@@ -835,23 +835,23 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)if (len <0 || len >MAX_IE_SZ )return _FAIL; - pbss_network->IELength = len; + pbss_network->ie_length = len;memset (ie,0 ,MAX_IE_SZ ); -memcpy (ie, pbuf, pbss_network->IELength); +memcpy (ie, pbuf, pbss_network->ie_length); -if (pbss_network->InfrastructureMode != Ndis802_11APMode) +if (pbss_network->infrastructure_mode != Ndis802_11APMode)return _FAIL; - pbss_network->Rssi =0 ; + pbss_network->rssi =0 ; -memcpy (pbss_network->MacAddress,myid (&(padapter->eeprompriv)),ETH_ALEN ); +memcpy (pbss_network->mac_address,myid (&(padapter->eeprompriv)),ETH_ALEN );/* beacon interval */ p =rtw_get_beacon_interval_from_ie (ie);/* ie + 8; 8: TimeStamp, 2: Beacon Interval 2:Capability */ -/* pbss_network->Configuration.BeaconPeriod = le16_to_cpu(*(unsigned short*)p); */ - pbss_network->Configuration.BeaconPeriod =get_unaligned_le16 (p); +/* pbss_network->configuration.BeaconPeriod = le16_to_cpu(*(unsigned short*)p); */ + pbss_network->configuration.BeaconPeriod =get_unaligned_le16 (p);/* capability */ /* cap = *(unsigned short *)rtw_get_capability_from_ie(ie); */
@@ -863,26 +863,26 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) ie + _BEACON_IE_OFFSET_,WLAN_EID_SSID , &ie_len, - (pbss_network->IELength - _BEACON_IE_OFFSET_) + (pbss_network->ie_length - _BEACON_IE_OFFSET_) );if (p && ie_len >0 ) { -memset (&pbss_network->Ssid,0 ,sizeof (struct ndis_802_11_ssid )); -memcpy (pbss_network->Ssid.Ssid, (p +2 ), ie_len); - pbss_network->Ssid.SsidLength = ie_len; +memset (&pbss_network->ssid,0 ,sizeof (struct ndis_802_11_ssid )); +memcpy (pbss_network->ssid.Ssid, (p +2 ), ie_len); + pbss_network->ssid.SsidLength = ie_len; }/* channel */ channel =0 ; - pbss_network->Configuration.Length =0 ; + pbss_network->configuration.Length =0 ; p =rtw_get_ie ( ie + _BEACON_IE_OFFSET_,WLAN_EID_DS_PARAMS , &ie_len, - (pbss_network->IELength - _BEACON_IE_OFFSET_) + (pbss_network->ie_length - _BEACON_IE_OFFSET_) );if (p && ie_len >0 ) channel = *(p +2 ); - pbss_network->Configuration.DSConfig = channel; + pbss_network->configuration.DSConfig = channel;memset (supportRate,0 ,NDIS_802_11_LENGTH_RATES_EX );/* get supported rates */
@@ -890,7 +890,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) ie + _BEACON_IE_OFFSET_,WLAN_EID_SUPP_RATES , &ie_len, - (pbss_network->IELength - _BEACON_IE_OFFSET_) + (pbss_network->ie_length - _BEACON_IE_OFFSET_) );if (p !=NULL ) {memcpy (supportRate, p +2 , ie_len);
@@ -902,7 +902,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) ie + _BEACON_IE_OFFSET_,WLAN_EID_EXT_SUPP_RATES , &ie_len, - pbss_network->IELength - _BEACON_IE_OFFSET_ + pbss_network->ie_length - _BEACON_IE_OFFSET_ );if (p !=NULL ) {memcpy (supportRate + supportRateNum, p +2 , ie_len);
@@ -911,23 +911,23 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) network_type =rtw_check_network_type (supportRate, supportRateNum, channel); -rtw_set_supported_rate (pbss_network->SupportedRates, network_type); +rtw_set_supported_rate (pbss_network->supported_rates, network_type);/* parsing ERP_IE */ p =rtw_get_ie ( ie + _BEACON_IE_OFFSET_,WLAN_EID_ERP_INFO , &ie_len, - (pbss_network->IELength - _BEACON_IE_OFFSET_) + (pbss_network->ie_length - _BEACON_IE_OFFSET_) );if (p && ie_len >0 )ERP_IE_handler (padapter, (struct ndis_80211_var_ie *)p);/* update privacy/security */ if (cap &BIT (4 )) - pbss_network->Privacy =1 ; + pbss_network->privacy =1 ;else - pbss_network->Privacy =0 ; + pbss_network->privacy =0 ; psecuritypriv->wpa_psk =0 ;
@@ -939,7 +939,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) ie + _BEACON_IE_OFFSET_,WLAN_EID_RSN , &ie_len, - (pbss_network->IELength - _BEACON_IE_OFFSET_) + (pbss_network->ie_length - _BEACON_IE_OFFSET_) );if (p && ie_len >0 ) { if (rtw_parse_wpa2_ie(
@@ -969,7 +969,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) p,WLAN_EID_VENDOR_SPECIFIC , &ie_len, - (pbss_network->IELength - _BEACON_IE_OFFSET_ - (ie_len +2 )) + (pbss_network->ie_length - _BEACON_IE_OFFSET_ - (ie_len +2 )) );if ((p) && (!memcmp (p +2 ,OUI1 ,4 ))) { if (rtw_parse_wpa_ie(
@@ -1005,7 +1005,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) p,WLAN_EID_VENDOR_SPECIFIC , &ie_len, - (pbss_network->IELength - _BEACON_IE_OFFSET_ - (ie_len +2 )) + (pbss_network->ie_length - _BEACON_IE_OFFSET_ - (ie_len +2 )) );if ((p) && !memcmp (p +2 ,WMM_PARA_IE ,6 )) { pmlmepriv->qospriv.qos_option =1 ;
@@ -1032,7 +1032,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) ie + _BEACON_IE_OFFSET_,WLAN_EID_HT_CAPABILITY , &ie_len, - (pbss_network->IELength - _BEACON_IE_OFFSET_) + (pbss_network->ie_length - _BEACON_IE_OFFSET_) );if (p && ie_len >0 ) {u8 rf_type =0 ;
@@ -1095,23 +1095,23 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) ie + _BEACON_IE_OFFSET_,WLAN_EID_HT_OPERATION , &ie_len, - (pbss_network->IELength - _BEACON_IE_OFFSET_) + (pbss_network->ie_length - _BEACON_IE_OFFSET_) );if (p && ie_len >0 ) pHT_info_ie = p;switch (network_type) {case WIRELESS_11B : - pbss_network->NetworkTypeInUse = Ndis802_11DS; + pbss_network->network_type_in_use = Ndis802_11DS;break ;case WIRELESS_11G :case WIRELESS_11BG :case WIRELESS_11G_24N :case WIRELESS_11BG_24N : - pbss_network->NetworkTypeInUse = Ndis802_11OFDM24; + pbss_network->network_type_in_use = Ndis802_11OFDM24;break ;default : - pbss_network->NetworkTypeInUse = Ndis802_11OFDM24; + pbss_network->network_type_in_use = Ndis802_11OFDM24;break ; }
@@ -1138,7 +1138,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)HT_info_handler (padapter, (struct ndis_80211_var_ie *)pHT_info_ie); } - pbss_network->Length =get_wlan_bssid_ex_sz ( + pbss_network->length =get_wlan_bssid_ex_sz ( (struct wlan_bssid_ex *)pbss_network );
@@ -1147,9 +1147,9 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)rtw_startbss_cmd (padapter,RTW_CMDF_WAIT_ACK );/* alloc sta_info for ap itself */ - psta =rtw_get_stainfo (&padapter->stapriv, pbss_network->MacAddress); + psta =rtw_get_stainfo (&padapter->stapriv, pbss_network->mac_address);if (!psta) { - psta =rtw_alloc_stainfo (&padapter->stapriv, pbss_network->MacAddress); + psta =rtw_alloc_stainfo (&padapter->stapriv, pbss_network->mac_address);if (psta ==NULL )return _FAIL; }
@@ -1405,7 +1405,7 @@ static void update_bcn_erpinfo_ie(struct adapter *padapter)struct mlme_ext_priv *pmlmeext = &(padapter->mlmeextpriv);struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);struct wlan_bssid_ex *pnetwork = &(pmlmeinfo->network); -unsigned char *p, *ie = pnetwork->IEs; +unsigned char *p, *ie = pnetwork->ies;u32 len =0 ;if (!pmlmeinfo->ERP_enable)
@@ -1416,7 +1416,7 @@ static void update_bcn_erpinfo_ie(struct adapter *padapter) ie + _BEACON_IE_OFFSET_,WLAN_EID_ERP_INFO , &len, - (pnetwork->IELength - _BEACON_IE_OFFSET_) + (pnetwork->ie_length - _BEACON_IE_OFFSET_) );if (p && len >0 ) {struct ndis_80211_var_ie *pIE = (struct ndis_80211_var_ie *)p;
@@ -1469,8 +1469,8 @@ static void update_bcn_wps_ie(struct adapter *padapter)struct mlme_ext_priv *pmlmeext = &(padapter->mlmeextpriv);struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);struct wlan_bssid_ex *pnetwork = &(pmlmeinfo->network); -unsigned char *ie = pnetwork->IEs; -u32 ielen = pnetwork->IELength; +unsigned char *ie = pnetwork->ies; +u32 ielen = pnetwork->ie_length; pwps_ie = rtw_get_wps_ie( ie + _FIXED_IE_LENGTH_,
@@ -1506,8 +1506,8 @@ static void update_bcn_wps_ie(struct adapter *padapter)if (pbackup_remainder_ie)memcpy (pwps_ie, pbackup_remainder_ie, remainder_ielen); -/* update IELength */ - pnetwork->IELength = wps_offset + (wps_ielen +2 ) + remainder_ielen; +/* update ie_length */ + pnetwork->ie_length = wps_offset + (wps_ielen +2 ) + remainder_ielen; }kfree (pbackup_remainder_ie);
drivers/staging/rtl8723bs/core/rtw_cmd.c +25 -25
127 lines not on this page · raw message
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +26 -26
153 lines not on this page · raw message
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +6 -6
@@ -93,9 +93,9 @@ u8 rtw_do_join(struct adapter *padapter) pmlmepriv->fw_state =WIFI_ADHOC_MASTER_STATE ; - pibss = padapter->registrypriv.dev_network.MacAddress; + pibss = padapter->registrypriv.dev_network.mac_address; -memcpy (&pdev_network->Ssid, &pmlmepriv->assoc_ssid,sizeof (struct ndis_802_11_ssid )); +memcpy (&pdev_network->ssid, &pmlmepriv->assoc_ssid,sizeof (struct ndis_802_11_ssid ));rtw_update_registrypriv_dev_network (padapter);
@@ -158,7 +158,7 @@ u8 rtw_set_802_11_bssid(struct adapter *padapter, u8 *bssid) goto release_mlme_lock;if (check_fwstate (pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE ) == true) { -if (!memcmp (&pmlmepriv->cur_network.network.MacAddress, bssid,ETH_ALEN )) { +if (!memcmp (&pmlmepriv->cur_network.network.mac_address, bssid,ETH_ALEN )) {if (check_fwstate (pmlmepriv,WIFI_STATION_STATE ) == false) goto release_mlme_lock;/* it means driver is in WIFI_ADHOC_MASTER_STATE, we needn't create bss again. */ }else {
@@ -354,7 +354,7 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *padapter, {struct mlme_priv *pmlmepriv = &padapter->mlmepriv;struct wlan_network *cur_network = &pmlmepriv->cur_network; -enum ndis_802_11_network_infrastructure *pold_state = &(cur_network->network.InfrastructureMode); +enum ndis_802_11_network_infrastructure *pold_state = &(cur_network->network.infrastructure_mode);if (*pold_state != networktype) {if (*pold_state == Ndis802_11APMode) {
@@ -562,8 +562,8 @@ u16 rtw_get_cur_max_rate(struct adapter *adapter) short_GI, psta->htpriv.ht_cap.mcs.rx_mask); }else { -while ((pcur_bss->SupportedRates[i] !=0 ) && (pcur_bss->SupportedRates[i] !=0xFF )) { - rate = pcur_bss->SupportedRates[i]&0x7F ; +while ((pcur_bss->supported_rates[i] !=0 ) && (pcur_bss->supported_rates[i] !=0xFF )) { + rate = pcur_bss->supported_rates[i]&0x7F ;if (rate > max_rate) max_rate = rate; i++;
drivers/staging/rtl8723bs/core/rtw_mlme.c +108 -108
549 lines not on this page · raw message
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +124 -124
676 lines not on this page · raw message
drivers/staging/rtl8723bs/core/rtw_wlan_util.c +29 -29
158 lines not on this page · raw message
drivers/staging/rtl8723bs/hal/hal_btcoex.c +1 -1
@@ -580,7 +580,7 @@ static u8 halbtcoutsrc_Set(void *pBtcContext, u8 setType, void *pInBuf)struct wlan_bssid_ex *cur_network; cur_network = &padapter->mlmeextpriv.mlmext_info.network; - psta =rtw_get_stainfo (&padapter->stapriv, cur_network->MacAddress); + psta =rtw_get_stainfo (&padapter->stapriv, cur_network->mac_address);rtw_hal_update_ra_mask (psta,0 ); }break ;
drivers/staging/rtl8723bs/hal/hal_com.c +1 -1
@@ -923,7 +923,7 @@ u8 GetHalDefVar( pmlmepriv = &adapter->mlmepriv; pstapriv = &adapter->stapriv; - psta =rtw_get_stainfo (pstapriv, pmlmepriv->cur_network.network.MacAddress); + psta =rtw_get_stainfo (pstapriv, pmlmepriv->cur_network.network.mac_address);if (psta) *((int *)value) = psta->rssi_stat.UndecoratedSmoothedPWDB; }
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +11 -11
@@ -136,20 +136,20 @@ static void ConstructBeacon(struct adapter *padapter, u8 *pframe, u32 *pLength) pktlen +=8 ;/* beacon interval: 2 bytes */ -memcpy (pframe, (unsigned char *)(rtw_get_beacon_interval_from_ie (cur_network->IEs)),2 ); +memcpy (pframe, (unsigned char *)(rtw_get_beacon_interval_from_ie (cur_network->ies)),2 ); pframe +=2 ; pktlen +=2 ;/* capability info: 2 bytes */ -memcpy (pframe, (unsigned char *)(rtw_get_capability_from_ie (cur_network->IEs)),2 ); +memcpy (pframe, (unsigned char *)(rtw_get_capability_from_ie (cur_network->ies)),2 ); pframe +=2 ; pktlen +=2 ;if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_AP_STATE ) { - pktlen += cur_network->IELength -sizeof (struct ndis_802_11_fix_ie ); -memcpy (pframe, cur_network->IEs+sizeof (struct ndis_802_11_fix_ie ), pktlen); + pktlen += cur_network->ie_length -sizeof (struct ndis_802_11_fix_ie ); +memcpy (pframe, cur_network->ies+sizeof (struct ndis_802_11_fix_ie ), pktlen); goto _ConstructBeacon; }
@@ -157,19 +157,19 @@ static void ConstructBeacon(struct adapter *padapter, u8 *pframe, u32 *pLength)/* below for ad-hoc mode */ /* SSID */ - pframe =rtw_set_ie (pframe,WLAN_EID_SSID , cur_network->Ssid.SsidLength, cur_network->Ssid.Ssid, &pktlen); + pframe =rtw_set_ie (pframe,WLAN_EID_SSID , cur_network->ssid.SsidLength, cur_network->ssid.Ssid, &pktlen);/* supported rates... */ - rate_len =rtw_get_rateset_len (cur_network->SupportedRates); - pframe =rtw_set_ie (pframe,WLAN_EID_SUPP_RATES , ((rate_len >8 ) ?8 : rate_len), cur_network->SupportedRates, &pktlen); + rate_len =rtw_get_rateset_len (cur_network->supported_rates); + pframe =rtw_set_ie (pframe,WLAN_EID_SUPP_RATES , ((rate_len >8 ) ?8 : rate_len), cur_network->supported_rates, &pktlen);/* DS parameter set */ - pframe =rtw_set_ie (pframe,WLAN_EID_DS_PARAMS ,1 , (unsigned char *)&(cur_network->Configuration.DSConfig), &pktlen); + pframe =rtw_set_ie (pframe,WLAN_EID_DS_PARAMS ,1 , (unsigned char *)&(cur_network->configuration.DSConfig), &pktlen);if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_ADHOC_STATE ) {u32 ATIMWindow;/* IBSS Parameter Set... */ -/* ATIMWindow = cur->Configuration.ATIMWindow; */ +/* ATIMWindow = cur->configuration.ATIMWindow; */ ATIMWindow =0 ; pframe =rtw_set_ie (pframe,WLAN_EID_IBSS_PARAMS ,2 , (unsigned char *)(&ATIMWindow), &pktlen); }
@@ -180,7 +180,7 @@ static void ConstructBeacon(struct adapter *padapter, u8 *pframe, u32 *pLength)/* EXTERNDED SUPPORTED RATE */ if (rate_len >8 ) - pframe =rtw_set_ie (pframe,WLAN_EID_EXT_SUPP_RATES , (rate_len -8 ), (cur_network->SupportedRates +8 ), &pktlen); + pframe =rtw_set_ie (pframe,WLAN_EID_EXT_SUPP_RATES , (rate_len -8 ), (cur_network->supported_rates +8 ), &pktlen);/* todo:HT for adhoc */
@@ -247,7 +247,7 @@ static void ConstructNullFunctionData(if (bForcePowerSave)SetPwrMgt (fctrl); -switch (cur_network->network.InfrastructureMode) { +switch (cur_network->network.infrastructure_mode) {case Ndis802_11Infrastructure:SetToDs (fctrl);memcpy (pwlanhdr->addr1,get_my_bssid (&(pmlmeinfo->network)),ETH_ALEN );
drivers/staging/rtl8723bs/include/rtw_mlme.h +3 -3
@@ -445,9 +445,9 @@ extern signed int rtw_set_key(struct adapter *adapter, struct security_priv *pseextern signed int rtw_set_auth (struct adapter *adapter,struct security_priv *psecuritypriv);static inline u8 *get_bssid (struct mlme_priv *pmlmepriv) -{/* if sta_mode:pmlmepriv->cur_network.network.MacAddress => bssid */ -/* if adhoc_mode:pmlmepriv->cur_network.network.MacAddress => ibss mac address */ -return pmlmepriv->cur_network.network.MacAddress; +{/* if sta_mode:pmlmepriv->cur_network.network.mac_address => bssid */ +/* if adhoc_mode:pmlmepriv->cur_network.network.mac_address => ibss mac address */ +return pmlmepriv->cur_network.network.mac_address; }static inline signed int check_fwstate (struct mlme_priv *pmlmepriv,signed int state)
drivers/staging/rtl8723bs/include/wlan_bssdef.h +15 -15
@@ -75,9 +75,9 @@ struct ndis_80211_var_ie {* sizeof (NDIS_802_11_MAC_ADDRESS) + 2 + * sizeof (struct ndis_802_11_ssid) + sizeof (u32) + * sizeof (long) + sizeof (enum ndis_802_11_network_type) + -* sizeof (struct ndis_802_11_conf) + sizeof (NDIS_802_11_RATES_EX) + IELength +* sizeof (struct ndis_802_11_conf) + sizeof (NDIS_802_11_RATES_EX) + ie_length * -* Except for IELength, all other fields are fixed length. Therefore, we can +* Except for ie_length, all other fields are fixed length. Therefore, we can * define a macro to present the partial sum. */ enum ndis_802_11_authentication_mode {
@@ -174,24 +174,24 @@ struct wlan_bcn_info {* struct wlan_bssid_ex and get_wlan_bssid_ex_sz() */ struct wlan_bssid_ex { -u32 Length; -NDIS_802_11_MAC_ADDRESS MacAddress; +u32 length; +NDIS_802_11_MAC_ADDRESS mac_address;u8 Reserved[2 ];/* 0]: IS beacon frame */ -struct ndis_802_11_ssid Ssid; -u32 Privacy; -long Rssi;/* in dBM, raw data , get from PHY) */ -enum ndis_802_11_network_type NetworkTypeInUse; -struct ndis_802_11_conf Configuration; -enum ndis_802_11_network_infrastructure InfrastructureMode; -NDIS_802_11_RATES_EX SupportedRates; -struct wlan_phy_info PhyInfo; -u32 IELength; -u8 IEs[MAX_IE_SZ ];/* timestamp, beacon interval, and capability information) */ +struct ndis_802_11_ssid ssid; +u32 privacy; +long rssi;/* in dBM, raw data , get from PHY) */ +enum ndis_802_11_network_type network_type_in_use; +struct ndis_802_11_conf configuration; +enum ndis_802_11_network_infrastructure infrastructure_mode; +NDIS_802_11_RATES_EX supported_rates; +struct wlan_phy_info phy_info; +u32 ie_length; +u8 ies[MAX_IE_SZ ];/* timestamp, beacon interval, and capability information) */ } __packed;static inline uint get_wlan_bssid_ex_sz (struct wlan_bssid_ex *bss) { -return (sizeof (struct wlan_bssid_ex ) -MAX_IE_SZ + bss->IELength); +return (sizeof (struct wlan_bssid_ex ) -MAX_IE_SZ + bss->ie_length); }struct wlan_network {
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +32 -32
191 lines not on this page · raw message
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +52 -52
285 lines not on this page · raw message
Signature · 1 line
2.20.1
PATCH 8/16 staging: rtl8723bs: fix camel case in struct ndis_802_11_conf
In reply to Fabio Aiutofix camel case in struct ndis_802_11_conf
--- drivers/staging/rtl8723bs/core/rtw_ap.c | 18 +++++----- drivers/staging/rtl8723bs/core/rtw_cmd.c | 6 ++-- .../staging/rtl8723bs/core/rtw_ieee80211.c | 6 ++-- drivers/staging/rtl8723bs/core/rtw_mlme.c | 20 +++++------ drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 34 +++++++++---------- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 +- .../staging/rtl8723bs/include/wlan_bssdef.h | 10 +++--- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 10 +++--- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 20 +++++------ 9 files changed, 63 insertions(+), 63 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +9 -9
@@ -340,7 +340,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level) shortGIrate =query_ra_short_GI (psta); -if (pcur_network->configuration.DSConfig >14 ) { +if (pcur_network->configuration.ds_config >14 ) { sta_band |=WIRELESS_INVALID ; }else {if (tx_ra_bitmap &0xffff000 )
@@ -400,13 +400,13 @@ void update_bmc_sta(struct adapter *padapter) supportRateNum =rtw_get_rateset_len ((u8 *)&pcur_network->supported_rates); network_type =rtw_check_network_type ((u8 *)&pcur_network->supported_rates, supportRateNum, - pcur_network->configuration.DSConfig + pcur_network->configuration.ds_config );if (is_supported_tx_cck (network_type)) { network_type =WIRELESS_11B ; }else if (network_type ==WIRELESS_INVALID ) {/* error handling */ -if (pcur_network->configuration.DSConfig >14 ) +if (pcur_network->configuration.ds_config >14 ) network_type =WIRELESS_INVALID ;else network_type =WIRELESS_11B ;
@@ -656,8 +656,8 @@ void start_bss_network(struct adapter *padapter)struct HT_info_element *pht_info =NULL ;u8 cbw40_enable =0 ; - bcn_interval = (u16 )pnetwork->configuration.BeaconPeriod; - cur_channel = pnetwork->configuration.DSConfig; + bcn_interval = (u16 )pnetwork->configuration.beacon_period; + cur_channel = pnetwork->configuration.ds_config; cur_bwmode =CHANNEL_WIDTH_20 ; cur_ch_offset =HAL_PRIME_CHNL_OFFSET_DONT_CARE ;
@@ -850,8 +850,8 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)/* beacon interval */ p =rtw_get_beacon_interval_from_ie (ie);/* ie + 8; 8: TimeStamp, 2: Beacon Interval 2:Capability */ -/* pbss_network->configuration.BeaconPeriod = le16_to_cpu(*(unsigned short*)p); */ - pbss_network->configuration.BeaconPeriod =get_unaligned_le16 (p); +/* pbss_network->configuration.beacon_period = le16_to_cpu(*(unsigned short*)p); */ + pbss_network->configuration.beacon_period =get_unaligned_le16 (p);/* capability */ /* cap = *(unsigned short *)rtw_get_capability_from_ie(ie); */
@@ -873,7 +873,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)/* channel */ channel =0 ; - pbss_network->configuration.Length =0 ; + pbss_network->configuration.length =0 ; p = rtw_get_ie( ie + _BEACON_IE_OFFSET_, WLAN_EID_DS_PARAMS, &ie_len,
@@ -882,7 +882,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)if (p && ie_len >0 ) channel = *(p +2 ); - pbss_network->configuration.DSConfig = channel; + pbss_network->configuration.ds_config = channel;memset (supportRate,0 ,NDIS_802_11_LENGTH_RATES_EX );/* get supported rates */
drivers/staging/rtl8723bs/core/rtw_cmd.c +3 -3
@@ -810,7 +810,7 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct wlan_network *pnetwork)/* rtw_restructure_ht_ie */ rtw_restructure_ht_ie (padapter, &pnetwork->network.ies[12 ], &psecnetwork->ies[0 ], pnetwork->network.ie_length-12 , &psecnetwork->ie_length, - pnetwork->network.configuration.DSConfig); + pnetwork->network.configuration.ds_config); } }
@@ -2004,8 +2004,8 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)/* copy pdev_network information to pmlmepriv->cur_network */ memcpy (&tgt_network->network, pnetwork, (get_wlan_bssid_ex_sz (pnetwork))); -/* reset DSConfig */ -/* tgt_network->network.configuration.DSConfig = (u32)rtw_ch2freq(pnetwork->configuration.DSConfig); */ +/* reset ds_config */ +/* tgt_network->network.configuration.ds_config = (u32)rtw_ch2freq(pnetwork->configuration.ds_config); */ _clr_fwstate_ (pmlmepriv, _FW_UNDER_LINKING);
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +3 -3
@@ -298,7 +298,7 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv) ie += sz;/* beacon interval : 2bytes */ - *(__le16 *)ie =cpu_to_le16 ((u16 )pdev_network->configuration.BeaconPeriod);/* BCN_INTERVAL; */ + *(__le16 *)ie =cpu_to_le16 ((u16 )pdev_network->configuration.beacon_period);/* BCN_INTERVAL; */ sz +=2 ; ie +=2 ;
@@ -334,11 +334,11 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv) }/* DS parameter set */ - ie =rtw_set_ie (ie,WLAN_EID_DS_PARAMS ,1 , (u8 *)&(pdev_network->configuration.DSConfig), &sz); + ie =rtw_set_ie (ie,WLAN_EID_DS_PARAMS ,1 , (u8 *)&(pdev_network->configuration.ds_config), &sz);/* IBSS Parameter Set */ - ie =rtw_set_ie (ie,WLAN_EID_IBSS_PARAMS ,2 , (u8 *)&(pdev_network->configuration.ATIMWindow), &sz); + ie =rtw_set_ie (ie,WLAN_EID_IBSS_PARAMS ,2 , (u8 *)&(pdev_network->configuration.atim_window), &sz);if (rateLen >8 ) { ie =rtw_set_ie (ie,WLAN_EID_EXT_SUPP_RATES , (rateLen -8 ), (pdev_network->supported_rates +8 ), &sz);
drivers/staging/rtl8723bs/core/rtw_mlme.c +10 -10
@@ -396,7 +396,7 @@ int is_same_network(struct wlan_bssid_ex *src, struct wlan_bssid_ex *dst, u8 fea d_cap =le16_to_cpu (tmpd);return (src->ssid.SsidLength == dst->ssid.SsidLength) && -/* (src->configuration.DSConfig == dst->configuration.DSConfig) && */ +/* (src->configuration.ds_config == dst->configuration.ds_config) && */ ((!memcmp (src->mac_address, dst->mac_address,ETH_ALEN ))) && ((!memcmp(src->ssid.Ssid, dst->ssid.Ssid, src->ssid.SsidLength))) && ((s_cap & WLAN_CAPABILITY_IBSS) ==
@@ -1148,7 +1148,7 @@ static void rtw_joinbss_update_network(struct adapter *padapter, struct wlan_netrtw_update_protection (padapter, (cur_network->network.ies) +sizeof (struct ndis_802_11_fix_ie ), (cur_network->network.ie_length)); -rtw_update_ht_cap (padapter, cur_network->network.ies, cur_network->network.ie_length, (u8 ) cur_network->network.configuration.DSConfig); +rtw_update_ht_cap (padapter, cur_network->network.ies, cur_network->network.ie_length, (u8 ) cur_network->network.configuration.ds_config); }/* Notes: the function could be > passive_level (the same context as Rx tasklet) */
@@ -2152,12 +2152,12 @@ void rtw_init_registrypriv_dev_network(struct adapter *adapter)memcpy (&pdev_network->ssid, &pregistrypriv->ssid,sizeof (struct ndis_802_11_ssid )); - pdev_network->configuration.Length =sizeof (struct ndis_802_11_conf ); - pdev_network->configuration.BeaconPeriod =100 ; - pdev_network->configuration.FHConfig.Length =0 ; - pdev_network->configuration.FHConfig.HopPattern =0 ; - pdev_network->configuration.FHConfig.HopSet =0 ; - pdev_network->configuration.FHConfig.DwellTime =0 ; + pdev_network->configuration.length =sizeof (struct ndis_802_11_conf ); + pdev_network->configuration.beacon_period =100 ; + pdev_network->configuration.fh_config.Length =0 ; + pdev_network->configuration.fh_config.HopPattern =0 ; + pdev_network->configuration.fh_config.HopSet =0 ; + pdev_network->configuration.fh_config.DwellTime =0 ; }void rtw_update_registrypriv_dev_network (struct adapter *adapter)
@@ -2189,10 +2189,10 @@ void rtw_update_registrypriv_dev_network(struct adapter *adapter)break ; } - pdev_network->configuration.DSConfig = (pregistrypriv->channel); + pdev_network->configuration.ds_config = (pregistrypriv->channel);if (cur_network->network.infrastructure_mode == Ndis802_11IBSS) - pdev_network->configuration.ATIMWindow = (0 ); + pdev_network->configuration.atim_window = (0 ); pdev_network->infrastructure_mode = (cur_network->network.infrastructure_mode);
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +17 -17
@@ -2237,7 +2237,7 @@ void issue_beacon(struct adapter *padapter, int timeout_ms) pframe =rtw_set_ie (pframe,WLAN_EID_SUPP_RATES , ((rate_len >8 ) ?8 : rate_len), cur_network->supported_rates, &pattrib->pktlen);/* DS parameter set */ - pframe =rtw_set_ie (pframe,WLAN_EID_DS_PARAMS ,1 , (unsigned char *)&(cur_network->configuration.DSConfig), &pattrib->pktlen); + pframe =rtw_set_ie (pframe,WLAN_EID_DS_PARAMS ,1 , (unsigned char *)&(cur_network->configuration.ds_config), &pattrib->pktlen);/* if ((pmlmeinfo->state&0x03) == WIFI_FW_ADHOC_STATE) */ {
@@ -2440,7 +2440,7 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p pframe =rtw_set_ie (pframe,WLAN_EID_SUPP_RATES , ((rate_len >8 ) ?8 : rate_len), cur_network->supported_rates, &pattrib->pktlen);/* DS parameter set */ - pframe =rtw_set_ie (pframe,WLAN_EID_DS_PARAMS ,1 , (unsigned char *)&(cur_network->configuration.DSConfig), &pattrib->pktlen); + pframe =rtw_set_ie (pframe,WLAN_EID_DS_PARAMS ,1 , (unsigned char *)&(cur_network->configuration.ds_config), &pattrib->pktlen);if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_ADHOC_STATE ) {u8 erpinfo =0 ;
@@ -3708,10 +3708,10 @@ static void issue_action_BSSCoexistPacket(struct adapter *padapter) p =rtw_get_ie (pbss_network->ies + _FIXED_IE_LENGTH_,WLAN_EID_HT_CAPABILITY , &len, pbss_network->ie_length - _FIXED_IE_LENGTH_);if ((p ==NULL ) || (len ==0 )) {/* non-HT */ -if (pbss_network->configuration.DSConfig <=0 ) +if (pbss_network->configuration.ds_config <=0 )continue ; -ICS [0 ][pbss_network->configuration.DSConfig] =1 ; +ICS [0 ][pbss_network->configuration.ds_config] =1 ;if (ICS [0 ][0 ] ==0 )ICS [0 ][0 ] =1 ;
@@ -4038,14 +4038,14 @@ u8 collect_bss_info(struct adapter *padapter, union recv_frame *precv_frame, strif (bssid->ie_length <12 )return _FAIL; -/* Checking for DSConfig */ +/* Checking for ds_config */ p =rtw_get_ie (bssid->ies + ie_offset,WLAN_EID_DS_PARAMS , &len, bssid->ie_length - ie_offset); - bssid->configuration.DSConfig =0 ; - bssid->configuration.Length =0 ; + bssid->configuration.ds_config =0 ; + bssid->configuration.length =0 ;if (p) { - bssid->configuration.DSConfig = *(p +2 ); + bssid->configuration.ds_config = *(p +2 ); }else {/* In 5G, some ap do not have DSSET IE */ /* checking HT info for channel */
@@ -4053,14 +4053,14 @@ u8 collect_bss_info(struct adapter *padapter, union recv_frame *precv_frame, strif (p) {struct HT_info_element *HT_info = (struct HT_info_element *)(p +2 ); - bssid->configuration.DSConfig = HT_info->primary_channel; + bssid->configuration.ds_config = HT_info->primary_channel; }else {/* use current channel */ - bssid->configuration.DSConfig =rtw_get_oper_ch (padapter); + bssid->configuration.ds_config =rtw_get_oper_ch (padapter); } }memcpy (&le32_tmp,rtw_get_beacon_interval_from_ie (bssid->ies),2 ); - bssid->configuration.BeaconPeriod =le32_to_cpu (le32_tmp); + bssid->configuration.beacon_period =le32_to_cpu (le32_tmp); val16 =rtw_get_capability ((struct wlan_bssid_ex *)bssid);
@@ -4077,7 +4077,7 @@ u8 collect_bss_info(struct adapter *padapter, union recv_frame *precv_frame, strelse bssid->privacy =0 ; - bssid->configuration.ATIMWindow =0 ; + bssid->configuration.atim_window =0 ;/* 20/40 BSS Coexistence check */ if ((pregistrypriv->wifi_spec ==1 ) && (false == pmlmeinfo->bwmode_updated)) {
@@ -4096,7 +4096,7 @@ u8 collect_bss_info(struct adapter *padapter, union recv_frame *precv_frame, str }/* mark bss info receiving from nearby channel as SignalQuality 101 */ -if (bssid->configuration.DSConfig !=rtw_get_oper_ch (padapter)) +if (bssid->configuration.ds_config !=rtw_get_oper_ch (padapter)) bssid->phy_info.SignalQuality =101 ;return _SUCCESS;
@@ -4111,7 +4111,7 @@ void start_create_ibss(struct adapter *padapter)struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);struct wlan_bssid_ex *pnetwork = (struct wlan_bssid_ex *)(&(pmlmeinfo->network)); - pmlmeext->cur_channel = (u8 )pnetwork->configuration.DSConfig; + pmlmeext->cur_channel = (u8 )pnetwork->configuration.ds_config; pmlmeinfo->bcn_interval =get_beacon_interval (pnetwork);/* update wireless mode */
@@ -4409,7 +4409,7 @@ static void process_80211d(struct adapter *padapter, struct wlan_bssid_ex *bssid }/* If channel is used by AP, set channel scan type to active */ - channel = bssid->configuration.DSConfig; + channel = bssid->configuration.ds_config; chplan_new = pmlmeext->channel_set; i =0 ;while ((i <MAX_CHANNEL_NUM ) && (chplan_new[i].ChannelNum !=0 )) {
@@ -5401,7 +5401,7 @@ u8 join_cmd_hdl(struct adapter *padapter, u8 *pbuf)memcpy (pnetwork->ies, ((struct wlan_bssid_ex *)pbuf)->ies, pnetwork->ie_length); - pmlmeext->cur_channel = (u8 )pnetwork->configuration.DSConfig; + pmlmeext->cur_channel = (u8 )pnetwork->configuration.ds_config; pmlmeinfo->bcn_interval =get_beacon_interval (pnetwork);/* Check AP vendor to move rtw_joinbss_cmd() */
@@ -5428,7 +5428,7 @@ u8 join_cmd_hdl(struct adapter *padapter, u8 *pbuf) {struct HT_info_element *pht_info = (struct HT_info_element *)(pIE->data); -if (pnetwork->configuration.DSConfig <=14 ) { +if (pnetwork->configuration.ds_config <=14 ) {if ((pregpriv->bw_mode &0x0f ) >CHANNEL_WIDTH_20 ) cbw40_enable =1 ; }
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +1 -1
@@ -164,7 +164,7 @@ static void ConstructBeacon(struct adapter *padapter, u8 *pframe, u32 *pLength) pframe =rtw_set_ie (pframe,WLAN_EID_SUPP_RATES , ((rate_len >8 ) ?8 : rate_len), cur_network->supported_rates, &pktlen);/* DS parameter set */ - pframe =rtw_set_ie (pframe,WLAN_EID_DS_PARAMS ,1 , (unsigned char *)&(cur_network->configuration.DSConfig), &pktlen); + pframe =rtw_set_ie (pframe,WLAN_EID_DS_PARAMS ,1 , (unsigned char *)&(cur_network->configuration.ds_config), &pktlen);if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_ADHOC_STATE ) {u32 ATIMWindow;
drivers/staging/rtl8723bs/include/wlan_bssdef.h +5 -5
@@ -44,11 +44,11 @@ struct ndis_802_11_conf_fh {ODI Handler will convert the channel number to freq. number. */ struct ndis_802_11_conf { -u32 Length;/* Length of structure */ -u32 BeaconPeriod;/* units are Kusec */ -u32 ATIMWindow;/* units are Kusec */ -u32 DSConfig;/* Frequency, units are kHz */ -struct ndis_802_11_conf_fh FHConfig; +u32 length;/* Length of structure */ +u32 beacon_period;/* units are Kusec */ +u32 atim_window;/* units are Kusec */ +u32 ds_config;/* Frequency, units are kHz */ +struct ndis_802_11_conf_fh fh_config; };enum ndis_802_11_network_infrastructure {
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +5 -5
@@ -278,7 +278,7 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct adapter *padapter, struct wl/* spin_unlock_bh(&pwdev_priv->scan_req_lock); */ - channel = pnetwork->network.configuration.DSConfig; + channel = pnetwork->network.configuration.ds_config; freq =rtw_ieee80211_channel_to_frequency (channel,NL80211_BAND_2GHZ ); notify_channel =ieee80211_get_channel (wiphy, freq);
@@ -355,7 +355,7 @@ int rtw_cfg80211_check_bss(struct adapter *padapter)if (!(pnetwork) || !(padapter->rtw_wdev))return false; - freq =rtw_ieee80211_channel_to_frequency (pnetwork->configuration.DSConfig,NL80211_BAND_2GHZ ); + freq =rtw_ieee80211_channel_to_frequency (pnetwork->configuration.ds_config,NL80211_BAND_2GHZ ); notify_channel =ieee80211_get_channel (padapter->rtw_wdev->wiphy, freq); bss = cfg80211_get_bss(padapter->rtw_wdev->wiphy, notify_channel,
@@ -374,7 +374,7 @@ void rtw_cfg80211_ibss_indicate_connect(struct adapter *padapter)struct wlan_network *cur_network = &(pmlmepriv->cur_network);struct wireless_dev *pwdev = padapter->rtw_wdev;struct wiphy *wiphy = pwdev->wiphy; -int freq = (int )cur_network->network.configuration.DSConfig; +int freq = (int )cur_network->network.configuration.ds_config;struct ieee80211_channel *chan;if (pwdev->iftype !=NL80211_IFTYPE_ADHOC )
@@ -458,7 +458,7 @@ void rtw_cfg80211_indicate_connect(struct adapter *padapter)struct wiphy *wiphy = pwdev->wiphy;struct ieee80211_channel *notify_channel;u32 freq; -u16 channel = cur_network->network.configuration.DSConfig; +u16 channel = cur_network->network.configuration.ds_config;struct cfg80211_roam_info roam_info = {}; freq =rtw_ieee80211_channel_to_frequency (channel,NL80211_BAND_2GHZ );
@@ -1266,7 +1266,7 @@ void rtw_cfg80211_surveydone_event_callback(struct adapter *padapter) pnetwork = list_entry(plist, struct wlan_network, list);/* report network only if the current channel set contains the channel to which this network belongs */ -if (rtw_ch_set_search_ch (padapter->mlmeextpriv.channel_set, pnetwork->network.configuration.DSConfig) >=0 +if (rtw_ch_set_search_ch (padapter->mlmeextpriv.channel_set, pnetwork->network.configuration.ds_config) >=0 && true ==rtw_validate_ssid (&(pnetwork->network.ssid)) ) {
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +10 -10
@@ -129,7 +129,7 @@ static char *translate_scan(struct adapter *padapter,else snprintf (iwe.u.name,IFNAMSIZ ,"IEEE 802.11bg" ); }else { -if (pnetwork->network.configuration.DSConfig <=14 ) { +if (pnetwork->network.configuration.ds_config <=14 ) {if (ht_cap)snprintf (iwe.u.name,IFNAMSIZ ,"IEEE 802.11gn" );else
@@ -159,14 +159,14 @@ static char *translate_scan(struct adapter *padapter, start =iwe_stream_add_event (info, start, stop, &iwe,IW_EV_UINT_LEN ); } -if (pnetwork->network.configuration.DSConfig <1 ) - pnetwork->network.configuration.DSConfig =1 ; +if (pnetwork->network.configuration.ds_config <1 ) + pnetwork->network.configuration.ds_config =1 ;/* Add frequency/channel */ iwe.cmd =SIOCGIWFREQ ; - iwe.u.freq.m =rtw_ch2freq (pnetwork->network.configuration.DSConfig) *100000 ; + iwe.u.freq.m =rtw_ch2freq (pnetwork->network.configuration.ds_config) *100000 ; iwe.u.freq.e =1 ; - iwe.u.freq.i = pnetwork->network.configuration.DSConfig; + iwe.u.freq.i = pnetwork->network.configuration.ds_config; start =iwe_stream_add_event (info, start, stop, &iwe,IW_EV_FREQ_LEN );/* Add encryption capability */
@@ -700,7 +700,7 @@ static int rtw_wx_get_name(struct net_device *dev,else snprintf (wrqu->name,IFNAMSIZ ,"IEEE 802.11bg" ); }else { -if (pcur_bss->configuration.DSConfig <=14 ) { +if (pcur_bss->configuration.ds_config <=14 ) {if (ht_cap)snprintf (wrqu->name,IFNAMSIZ ,"IEEE 802.11gn" );else
@@ -731,10 +731,10 @@ static int rtw_wx_get_freq(struct net_device *dev,struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;if (check_fwstate (pmlmepriv, _FW_LINKED) == true) { -/* wrqu->freq.m = ieee80211_wlan_frequencies[pcur_bss->configuration.DSConfig-1] * 100000; */ - wrqu->freq.m =rtw_ch2freq (pcur_bss->configuration.DSConfig) *100000 ; +/* wrqu->freq.m = ieee80211_wlan_frequencies[pcur_bss->configuration.ds_config-1] * 100000; */ + wrqu->freq.m =rtw_ch2freq (pcur_bss->configuration.ds_config) *100000 ; wrqu->freq.e =1 ; - wrqu->freq.i = pcur_bss->configuration.DSConfig; + wrqu->freq.i = pcur_bss->configuration.ds_config; }else { wrqu->freq.m =rtw_ch2freq (padapter->mlmeextpriv.cur_channel) *100000 ;
@@ -1290,7 +1290,7 @@ static int rtw_wx_get_scan(struct net_device *dev, struct iw_request_info *a, pnetwork = list_entry(plist, struct wlan_network, list);/* report network only if the current channel set contains the channel to which this network belongs */ -if (rtw_ch_set_search_ch (padapter->mlmeextpriv.channel_set, pnetwork->network.configuration.DSConfig) >=0 +if (rtw_ch_set_search_ch (padapter->mlmeextpriv.channel_set, pnetwork->network.configuration.ds_config) >=0 && true ==rtw_validate_ssid (&(pnetwork->network.ssid))) { ev =translate_scan (padapter, a, pnetwork, ev, stop);
Signature · 1 line
2.20.1
PATCH 9/16 staging: rtl8723bs: remove struct ndis_802_11_conf_fh
In reply to Fabio Aiutoall members of struct ndis_802_11_conf_fh fh_config in struct ndis_802_11_conf are set to zero and their values are never used. So remove struct ndis_802_11_conf_fh.
--- drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ---- drivers/staging/rtl8723bs/include/wlan_bssdef.h | 8 -------- 2 files changed, 12 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme.c +0 -4
@@ -2154,10 +2154,6 @@ void rtw_init_registrypriv_dev_network(struct adapter *adapter) pdev_network->configuration.length =sizeof (struct ndis_802_11_conf ); pdev_network->configuration.beacon_period =100 ; - pdev_network->configuration.fh_config.Length =0 ; - pdev_network->configuration.fh_config.HopPattern =0 ; - pdev_network->configuration.fh_config.HopSet =0 ; - pdev_network->configuration.fh_config.DwellTime =0 ; }void rtw_update_registrypriv_dev_network (struct adapter *adapter)
drivers/staging/rtl8723bs/include/wlan_bssdef.h +0 -8
@@ -32,13 +32,6 @@ enum ndis_802_11_network_type { Ndis802_11NetworkTypeMax /* not a real type, defined as an upper bound */ }; -struct ndis_802_11_conf_fh { -u32 Length;/* Length of structure */ -u32 HopPattern;/* As defined by 802.11, MSB set */ -u32 HopSet;/* to one if non-802.11 */ -u32 DwellTime;/* units are Kusec */ -}; -/* FW will only save the channel number in DSConfig. ODI Handler will convert the channel number to freq. number.
@@ -48,7 +41,6 @@ struct ndis_802_11_conf {u32 beacon_period;/* units are Kusec */ u32 atim_window;/* units are Kusec */ u32 ds_config;/* Frequency, units are kHz */ -struct ndis_802_11_conf_fh fh_config; };enum ndis_802_11_network_infrastructure {
Signature · 1 line
2.20.1
PATCH 10/16 staging: rtl8723bs: fix camel case in struct ndis_802_11_ssid
In reply to Fabio Aiutofix camel case in struct ndis_802_11_ssid all over the driver.
--- drivers/staging/rtl8723bs/core/rtw_ap.c | 4 +- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- .../staging/rtl8723bs/core/rtw_ieee80211.c | 2 +- .../staging/rtl8723bs/core/rtw_ioctl_set.c | 8 ++-- drivers/staging/rtl8723bs/core/rtw_mlme.c | 18 ++++----- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 38 +++++++++---------- .../staging/rtl8723bs/core/rtw_wlan_util.c | 12 +++--- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 +- .../staging/rtl8723bs/include/wlan_bssdef.h | 4 +- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 32 ++++++++-------- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 38 +++++++++---------- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 +- 12 files changed, 82 insertions(+), 82 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +2 -2
@@ -867,8 +867,8 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) );if (p && ie_len >0 ) {memset (&pbss_network->ssid,0 ,sizeof (struct ndis_802_11_ssid )); -memcpy (pbss_network->ssid.Ssid, (p +2 ), ie_len); - pbss_network->ssid.SsidLength = ie_len; +memcpy (pbss_network->ssid.ssid, (p +2 ), ie_len); + pbss_network->ssid.ssid_length = ie_len; }/* channel */
drivers/staging/rtl8723bs/core/rtw_cmd.c +1 -1
@@ -567,7 +567,7 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct ndis_802_11_ssid *ssid,int i;for (i =0 ; i < ssid_num && i <RTW_SSID_SCAN_AMOUNT ; i++) { -if (ssid[i].SsidLength) { +if (ssid[i].ssid_length) {memcpy (&psurveyPara->ssid[i], &ssid[i],sizeof (struct ndis_802_11_ssid )); psurveyPara->ssid_num++; }
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +1 -1
@@ -317,7 +317,7 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv) ie +=2 ;/* SSID */ - ie =rtw_set_ie (ie,WLAN_EID_SSID , pdev_network->ssid.SsidLength, pdev_network->ssid.Ssid, &sz); + ie =rtw_set_ie (ie,WLAN_EID_SSID , pdev_network->ssid.ssid_length, pdev_network->ssid.ssid, &sz);/* supported rates */ wireless_mode = pregistrypriv->wireless_mode;
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +4 -4
@@ -27,7 +27,7 @@ u8 rtw_validate_ssid(struct ndis_802_11_ssid *ssid) {u8 ret = true; -if (ssid->SsidLength >32 ) { +if (ssid->ssid_length >32 ) { ret = false; goto exit; }
@@ -207,7 +207,7 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct ndis_802_11_ssid *ssid)struct wlan_network *pnetwork = &pmlmepriv->cur_network;netdev_dbg (padapter->pnetdev,"set ssid [%s] fw_state = 0x%08x\n" , - ssid->Ssid,get_fwstate (pmlmepriv)); + ssid->ssid,get_fwstate (pmlmepriv));if (padapter->hw_init_completed == false) { status = _FAIL;
@@ -222,8 +222,8 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct ndis_802_11_ssid *ssid) goto release_mlme_lock;if (check_fwstate (pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE ) == true) { -if ((pmlmepriv->assoc_ssid.SsidLength == ssid->SsidLength) && - (!memcmp (&pmlmepriv->assoc_ssid.Ssid, ssid->Ssid, ssid->SsidLength))) { +if ((pmlmepriv->assoc_ssid.ssid_length == ssid->ssid_length) && + (!memcmp (&pmlmepriv->assoc_ssid.ssid, ssid->ssid, ssid->ssid_length))) {if ((check_fwstate (pmlmepriv,WIFI_STATION_STATE ) == false)) {if (rtw_is_same_ibss (padapter, pnetwork) == false) {/* if in WIFI_ADHOC_MASTER_STATE | WIFI_ADHOC_STATE, create bss or rejoin again */
drivers/staging/rtl8723bs/core/rtw_mlme.c +9 -9
@@ -377,8 +377,8 @@ int rtw_is_same_ibss(struct adapter *adapter, struct wlan_network *pnetwork)inline int is_same_ess (struct wlan_bssid_ex *a,struct wlan_bssid_ex *b) { -return (a->ssid.SsidLength == b->ssid.SsidLength) - && !memcmp (a->ssid.Ssid, b->ssid.Ssid, a->ssid.SsidLength); +return (a->ssid.ssid_length == b->ssid.ssid_length) + && !memcmp (a->ssid.ssid, b->ssid.ssid, a->ssid.ssid_length); }int is_same_network (struct wlan_bssid_ex *src,struct wlan_bssid_ex *dst,u8 feature)
@@ -395,10 +395,10 @@ int is_same_network(struct wlan_bssid_ex *src, struct wlan_bssid_ex *dst, u8 fea s_cap =le16_to_cpu (tmps); d_cap =le16_to_cpu (tmpd); -return (src->ssid.SsidLength == dst->ssid.SsidLength) && +return (src->ssid.ssid_length == dst->ssid.ssid_length) &&/* (src->configuration.ds_config == dst->configuration.ds_config) && */ ((!memcmp (src->mac_address, dst->mac_address,ETH_ALEN ))) && - ((!memcmp (src->ssid.Ssid, dst->ssid.Ssid, src->ssid.SsidLength))) && + ((!memcmp (src->ssid.ssid, dst->ssid.ssid, src->ssid.ssid_length))) && ((s_cap &WLAN_CAPABILITY_IBSS ) == (d_cap & WLAN_CAPABILITY_IBSS)) && ((s_cap & WLAN_CAPABILITY_ESS) ==
@@ -728,8 +728,8 @@ void rtw_survey_event_callback(struct adapter *adapter, u8 *pbuf)/* lock pmlmepriv->lock when you accessing network_q */ if ((check_fwstate (pmlmepriv, _FW_UNDER_LINKING)) == false) { -if (pnetwork->ssid.Ssid[0 ] ==0 ) - pnetwork->ssid.SsidLength =0 ; +if (pnetwork->ssid.ssid[0 ] ==0 ) + pnetwork->ssid.ssid_length =0 ;rtw_add_network (adapter, pnetwork); }
@@ -1804,9 +1804,9 @@ static int rtw_check_join_candidate(struct mlme_priv *mlme }/* check ssid, if needed */ -if (mlme->assoc_ssid.Ssid[0 ] && mlme->assoc_ssid.SsidLength) { -if (competitor->network.ssid.SsidLength != mlme->assoc_ssid.SsidLength - ||memcmp (competitor->network.ssid.Ssid, mlme->assoc_ssid.Ssid, mlme->assoc_ssid.SsidLength) +if (mlme->assoc_ssid.ssid[0 ] && mlme->assoc_ssid.ssid_length) { +if (competitor->network.ssid.ssid_length != mlme->assoc_ssid.ssid_length + ||memcmp (competitor->network.ssid.ssid, mlme->assoc_ssid.ssid, mlme->assoc_ssid.ssid_length) ) goto exit; }
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +19 -19
@@ -538,7 +538,7 @@ unsigned int OnProbeReq(struct adapter *padapter, union recv_frame *precv_frame)if (is_valid_p2p_probereq) goto _issue_probersp; -if ((ielen !=0 && false == !memcmp ((void *)(p+2 ), (void *)cur->ssid.Ssid, cur->ssid.SsidLength)) +if ((ielen !=0 && false == !memcmp ((void *)(p+2 ), (void *)cur->ssid.ssid, cur->ssid.ssid_length)) || (ielen ==0 && pmlmeinfo->hidden_ssid_mode) )return _SUCCESS;
@@ -1022,10 +1022,10 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame) goto OnAssocReqFail; }else {/* check if ssid match */ -if (memcmp ((void *)(p+2 ), cur->ssid.Ssid, cur->ssid.SsidLength)) +if (memcmp ((void *)(p+2 ), cur->ssid.ssid, cur->ssid.ssid_length)) status =WLAN_STATUS_CHALLENGE_FAIL ; -if (ie_len != cur->ssid.SsidLength) +if (ie_len != cur->ssid.ssid_length) status =WLAN_STATUS_CHALLENGE_FAIL ; }
@@ -2230,7 +2230,7 @@ void issue_beacon(struct adapter *padapter, int timeout_ms) pattrib->pktlen +=2 ;/* SSID */ - pframe =rtw_set_ie (pframe,WLAN_EID_SSID , cur_network->ssid.SsidLength, cur_network->ssid.Ssid, &pattrib->pktlen); + pframe =rtw_set_ie (pframe,WLAN_EID_SSID , cur_network->ssid.ssid_length, cur_network->ssid.ssid, &pattrib->pktlen);/* supported rates... */ rate_len =rtw_get_rateset_len (cur_network->supported_rates);
@@ -2385,9 +2385,9 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p ssid_ie =rtw_get_ie (ies+_FIXED_IE_LENGTH_,WLAN_EID_SSID , &ssid_ielen, (pframe-ies)-_FIXED_IE_LENGTH_); - ssid_ielen_diff = cur_network->ssid.SsidLength - ssid_ielen; + ssid_ielen_diff = cur_network->ssid.ssid_length - ssid_ielen; -if (ssid_ie && cur_network->ssid.SsidLength) { +if (ssid_ie && cur_network->ssid.ssid_length) {uint remainder_ielen;u8 *remainder_ie;
@@ -2403,8 +2403,8 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2pmemcpy (buf, remainder_ie, remainder_ielen);memcpy (remainder_ie+ssid_ielen_diff, buf, remainder_ielen); - *(ssid_ie+1 ) = cur_network->ssid.SsidLength; -memcpy (ssid_ie+2 , cur_network->ssid.Ssid, cur_network->ssid.SsidLength); + *(ssid_ie+1 ) = cur_network->ssid.ssid_length; +memcpy (ssid_ie+2 , cur_network->ssid.ssid, cur_network->ssid.ssid_length); pframe += ssid_ielen_diff; pattrib->pktlen += ssid_ielen_diff;
@@ -2433,7 +2433,7 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p/* below for ad-hoc mode */ /* SSID */ - pframe =rtw_set_ie (pframe,WLAN_EID_SSID , cur_network->ssid.SsidLength, cur_network->ssid.Ssid, &pattrib->pktlen); + pframe =rtw_set_ie (pframe,WLAN_EID_SSID , cur_network->ssid.ssid_length, cur_network->ssid.ssid, &pattrib->pktlen);/* supported rates... */ rate_len =rtw_get_rateset_len (cur_network->supported_rates);
@@ -2530,7 +2530,7 @@ static int _issue_probereq(struct adapter *padapter, pattrib->pktlen =sizeof (struct ieee80211_hdr_3addr );if (pssid) - pframe =rtw_set_ie (pframe,WLAN_EID_SSID , pssid->SsidLength, pssid->Ssid, &(pattrib->pktlen)); + pframe =rtw_set_ie (pframe,WLAN_EID_SSID , pssid->ssid_length, pssid->ssid, &(pattrib->pktlen));else pframe =rtw_set_ie (pframe,WLAN_EID_SSID ,0 ,NULL , &(pattrib->pktlen));
@@ -2923,7 +2923,7 @@ void issue_assocreq(struct adapter *padapter) pattrib->pktlen +=2 ;/* SSID */ - pframe =rtw_set_ie (pframe,WLAN_EID_SSID , pmlmeinfo->network.ssid.SsidLength, pmlmeinfo->network.ssid.Ssid, &(pattrib->pktlen)); + pframe =rtw_set_ie (pframe,WLAN_EID_SSID , pmlmeinfo->network.ssid.ssid_length, pmlmeinfo->network.ssid.ssid, &(pattrib->pktlen));/* supported rate & extended supported rate */
@@ -3876,7 +3876,7 @@ void site_survey(struct adapter *padapter)int i;for (i =0 ; i <RTW_SSID_SCAN_AMOUNT ; i++) { -if (pmlmeext->sitesurvey_res.ssid[i].SsidLength) { +if (pmlmeext->sitesurvey_res.ssid[i].ssid_length) {/* IOT issue, When wifi_spec is not set, send one probe req without WPS IE. */ if (padapter->registrypriv.wifi_spec)issue_probereq (padapter, &(pmlmeext->sitesurvey_res.ssid[i]),NULL );
@@ -4007,10 +4007,10 @@ u8 collect_bss_info(struct adapter *padapter, union recv_frame *precv_frame, strif (len >NDIS_802_11_LENGTH_SSID )return _FAIL; -memcpy (bssid->ssid.Ssid, (p +2 ), *(p +1 )); - bssid->ssid.SsidLength = *(p +1 ); +memcpy (bssid->ssid.ssid, (p +2 ), *(p +1 )); + bssid->ssid.ssid_length = *(p +1 ); }else - bssid->ssid.SsidLength =0 ; + bssid->ssid.ssid_length =0 ;memset (bssid->supported_rates,0 ,NDIS_802_11_LENGTH_RATES_EX );
@@ -5589,11 +5589,11 @@ u8 sitesurvey_cmd_hdl(struct adapter *padapter, u8 *pbuf) pmlmeext->sitesurvey_res.channel_idx =0 ;for (i =0 ; i <RTW_SSID_SCAN_AMOUNT ; i++) { -if (pparm->ssid[i].SsidLength) { -memcpy (pmlmeext->sitesurvey_res.ssid[i].Ssid, pparm->ssid[i].Ssid,IW_ESSID_MAX_SIZE ); - pmlmeext->sitesurvey_res.ssid[i].SsidLength = pparm->ssid[i].SsidLength; +if (pparm->ssid[i].ssid_length) { +memcpy (pmlmeext->sitesurvey_res.ssid[i].ssid, pparm->ssid[i].ssid,IW_ESSID_MAX_SIZE ); + pmlmeext->sitesurvey_res.ssid[i].ssid_length = pparm->ssid[i].ssid_length; }else { - pmlmeext->sitesurvey_res.ssid[i].SsidLength =0 ; + pmlmeext->sitesurvey_res.ssid[i].ssid_length =0 ; } }
drivers/staging/rtl8723bs/core/rtw_wlan_util.c +6 -6
@@ -1283,13 +1283,13 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *pframe, u32 packet_len)if (ssid_len >NDIS_802_11_LENGTH_SSID ) ssid_len =0 ; } -memcpy (bssid->ssid.Ssid, (p +2 ), ssid_len); - bssid->ssid.SsidLength = ssid_len; +memcpy (bssid->ssid.ssid, (p +2 ), ssid_len); + bssid->ssid.ssid_length = ssid_len; -if (memcmp (bssid->ssid.Ssid, cur_network->network.ssid.Ssid,32 ) || - bssid->ssid.SsidLength != cur_network->network.ssid.SsidLength) -if (bssid->ssid.Ssid[0 ] !='\0' && - bssid->ssid.SsidLength !=0 )/* not hidden ssid */ +if (memcmp (bssid->ssid.ssid, cur_network->network.ssid.ssid,32 ) || + bssid->ssid.ssid_length != cur_network->network.ssid.ssid_length) +if (bssid->ssid.ssid[0 ] !='\0' && + bssid->ssid.ssid_length !=0 )/* not hidden ssid */ goto _mismatch;/* check encryption info */
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +1 -1
@@ -157,7 +157,7 @@ static void ConstructBeacon(struct adapter *padapter, u8 *pframe, u32 *pLength)/* below for ad-hoc mode */ /* SSID */ - pframe =rtw_set_ie (pframe,WLAN_EID_SSID , cur_network->ssid.SsidLength, cur_network->ssid.Ssid, &pktlen); + pframe =rtw_set_ie (pframe,WLAN_EID_SSID , cur_network->ssid.ssid_length, cur_network->ssid.ssid, &pktlen);/* supported rates... */ rate_len =rtw_get_rateset_len (cur_network->supported_rates);
drivers/staging/rtl8723bs/include/wlan_bssdef.h +2 -2
@@ -20,8 +20,8 @@ typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES]; /*typedef unsigned char NDIS_802_11_RATES_EX [NDIS_802_11_LENGTH_RATES_EX ];/* Set of 16 data rates */ struct ndis_802_11_ssid { -u32 SsidLength; -u8 Ssid[32 ]; +u32 ssid_length; +u8 ssid[32 ]; };enum ndis_802_11_network_type {
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +16 -16
@@ -266,8 +266,8 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct adapter *padapter, struct wlif (request->n_ssids ==1 && request->n_channels ==1 )/* it means under processing WPS */ {if (ssids[0 ].ssid_len !=0 && - (pssid->SsidLength != ssids[0 ].ssid_len || -memcmp (pssid->Ssid, ssids[0 ].ssid, ssids[0 ].ssid_len))) + (pssid->ssid_length != ssids[0 ].ssid_len || +memcmp (pssid->ssid, ssids[0 ].ssid, ssids[0 ].ssid_len))) {if (psr) *psr =0 ;/* clear sr */
@@ -359,8 +359,8 @@ int rtw_cfg80211_check_bss(struct adapter *padapter) notify_channel =ieee80211_get_channel (padapter->rtw_wdev->wiphy, freq); bss =cfg80211_get_bss (padapter->rtw_wdev->wiphy, notify_channel, - pnetwork->mac_address, pnetwork->ssid.Ssid, - pnetwork->ssid.SsidLength, + pnetwork->mac_address, pnetwork->ssid.ssid, + pnetwork->ssid.ssid_length,WLAN_CAPABILITY_ESS ,WLAN_CAPABILITY_ESS );cfg80211_put_bss (padapter->rtw_wdev->wiphy, bss);
@@ -1241,8 +1241,8 @@ void rtw_cfg80211_unlink_bss(struct adapter *padapter, struct wlan_network *pnetstruct wlan_bssid_ex *select_network = &pnetwork->network; bss =cfg80211_get_bss (wiphy,NULL /*notify_channel*/ , - select_network->mac_address, select_network->ssid.Ssid, - select_network->ssid.SsidLength,0 /*WLAN_CAPABILITY_ESS*/ , + select_network->mac_address, select_network->ssid.ssid, + select_network->ssid.ssid_length,0 /*WLAN_CAPABILITY_ESS*/ ,0 /*WLAN_CAPABILITY_ESS*/ );if (bss) {
@@ -1398,8 +1398,8 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy/* parsing request ssids, n_ssids */ for (i =0 ; i < request->n_ssids && i <RTW_SSID_SCAN_AMOUNT ; i++) { -memcpy (ssid[i].Ssid, ssids[i].ssid, ssids[i].ssid_len); - ssid[i].SsidLength = ssids[i].ssid_len; +memcpy (ssid[i].ssid, ssids[i].ssid, ssids[i].ssid_len); + ssid[i].ssid_length = ssids[i].ssid_len; }/* parsing channels, n_channels */
@@ -1730,8 +1730,8 @@ static int cfg80211_rtw_join_ibss(struct wiphy *wiphy, struct net_device *ndev, }memset (&ndis_ssid,0 ,sizeof (struct ndis_802_11_ssid )); - ndis_ssid.SsidLength = params->ssid_len; -memcpy (ndis_ssid.Ssid, (u8 *)params->ssid, params->ssid_len); + ndis_ssid.ssid_length = params->ssid_len; +memcpy (ndis_ssid.ssid, (u8 *)params->ssid, params->ssid_len); psecuritypriv->ndisencryptstatus = Ndis802_11EncryptionDisabled; psecuritypriv->dot11PrivacyAlgrthm = _NO_PRIVACY_;
@@ -1822,8 +1822,8 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, struct net_device *ndev, }memset (&ndis_ssid,0 ,sizeof (struct ndis_802_11_ssid )); - ndis_ssid.SsidLength = sme->ssid_len; -memcpy (ndis_ssid.Ssid, (u8 *)sme->ssid, sme->ssid_len); + ndis_ssid.ssid_length = sme->ssid_len; +memcpy (ndis_ssid.ssid, (u8 *)sme->ssid, sme->ssid_len);if (check_fwstate (pmlmepriv, _FW_UNDER_LINKING) == true) { ret = -EBUSY ;
@@ -2466,10 +2466,10 @@ static int cfg80211_rtw_start_ap(struct wiphy *wiphy, struct net_device *ndev,struct wlan_bssid_ex *pbss_network = &adapter->mlmepriv.cur_network.network;struct wlan_bssid_ex *pbss_network_ext = &adapter->mlmeextpriv.mlmext_info.network; -memcpy (pbss_network->ssid.Ssid, (void *)settings->ssid, settings->ssid_len); - pbss_network->ssid.SsidLength = settings->ssid_len; -memcpy (pbss_network_ext->ssid.Ssid, (void *)settings->ssid, settings->ssid_len); - pbss_network_ext->ssid.SsidLength = settings->ssid_len; +memcpy (pbss_network->ssid.ssid, (void *)settings->ssid, settings->ssid_len); + pbss_network->ssid.ssid_length = settings->ssid_len; +memcpy (pbss_network_ext->ssid.ssid, (void *)settings->ssid, settings->ssid_len); + pbss_network_ext->ssid.ssid_length = settings->ssid_len; }return ret;
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +19 -19
@@ -98,8 +98,8 @@ static char *translate_scan(struct adapter *padapter,/* Add the ESSID */ iwe.cmd =SIOCGIWESSID ; iwe.u.data.flags =1 ; - iwe.u.data.length =min ((u16 )pnetwork->network.ssid.SsidLength, (u16 )32 ); - start =iwe_stream_add_point (info, start, stop, &iwe, pnetwork->network.ssid.Ssid); + iwe.u.data.length =min ((u16 )pnetwork->network.ssid.ssid_length, (u16 )32 ); + start =iwe_stream_add_point (info, start, stop, &iwe, pnetwork->network.ssid.ssid);/* parsing HT_CAP_IE */ if (pnetwork->network.Reserved[0 ] ==2 ) {/* Probe Request */
@@ -176,7 +176,7 @@ static char *translate_scan(struct adapter *padapter,else iwe.u.data.flags =IW_ENCODE_DISABLED ; iwe.u.data.length =0 ; - start =iwe_stream_add_point (info, start, stop, &iwe, pnetwork->network.ssid.Ssid); + start =iwe_stream_add_point (info, start, stop, &iwe, pnetwork->network.ssid.ssid);/*Add basic and extended rates */ max_rate =0 ;
@@ -1177,8 +1177,8 @@ static int rtw_wx_set_scan(struct net_device *dev, struct iw_request_info *a,if (wrqu->data.flags &IW_SCAN_THIS_ESSID ) {int len =min ((int )req->essid_len,IW_ESSID_MAX_SIZE ); -memcpy (ssid[0 ].Ssid, req->essid, len); - ssid[0 ].SsidLength = len; +memcpy (ssid[0 ].ssid, req->essid, len); + ssid[0 ].ssid_length = len;spin_lock_bh (&pmlmepriv->lock);
@@ -1209,8 +1209,8 @@ static int rtw_wx_set_scan(struct net_device *dev, struct iw_request_info *a, sec_len = *(pos++); len -=1 ;if (sec_len >0 && sec_len <= len) { - ssid[ssid_index].SsidLength = sec_len; -memcpy (ssid[ssid_index].Ssid, pos, ssid[ssid_index].SsidLength); + ssid[ssid_index].ssid_length = sec_len; +memcpy (ssid[ssid_index].ssid, pos, ssid[ssid_index].ssid_length); ssid_index++; }
@@ -1355,9 +1355,9 @@ static int rtw_wx_set_essid(struct net_device *dev, len = (wrqu->essid.length <IW_ESSID_MAX_SIZE ) ? wrqu->essid.length :IW_ESSID_MAX_SIZE ;memset (&ndis_ssid,0 ,sizeof (struct ndis_802_11_ssid )); - ndis_ssid.SsidLength = len; -memcpy (ndis_ssid.Ssid, extra, len); - src_ssid = ndis_ssid.Ssid; + ndis_ssid.ssid_length = len; +memcpy (ndis_ssid.ssid, extra, len); + src_ssid = ndis_ssid.ssid;spin_lock_bh (&queue->lock); phead =get_list_head (queue);
@@ -1365,10 +1365,10 @@ static int rtw_wx_set_essid(struct net_device *dev, pnetwork =list_entry (pmlmepriv->pscanned, struct wlan_network, list); - dst_ssid = pnetwork->network.ssid.Ssid; + dst_ssid = pnetwork->network.ssid.ssid; -if ((!memcmp (dst_ssid, src_ssid, ndis_ssid.SsidLength)) && - (pnetwork->network.ssid.SsidLength == ndis_ssid.SsidLength)) { +if ((!memcmp (dst_ssid, src_ssid, ndis_ssid.ssid_length)) && + (pnetwork->network.ssid.ssid_length == ndis_ssid.ssid_length)) {if (check_fwstate (pmlmepriv,WIFI_ADHOC_STATE ) == true) {if (pnetwork->network.infrastructure_mode != pmlmepriv->cur_network.network.infrastructure_mode)continue ;
@@ -1410,11 +1410,11 @@ static int rtw_wx_get_essid(struct net_device *dev,if ((check_fwstate (pmlmepriv, _FW_LINKED) == true) || (check_fwstate (pmlmepriv,WIFI_ADHOC_MASTER_STATE ) == true)) { - len = pcur_bss->ssid.SsidLength; + len = pcur_bss->ssid.ssid_length; wrqu->essid.length = len; -memcpy (extra, pcur_bss->ssid.Ssid, len); +memcpy (extra, pcur_bss->ssid.ssid, len); wrqu->essid.flags =1 ; }else {
@@ -3530,10 +3530,10 @@ static int rtw_set_hidden_ssid(struct net_device *dev, struct ieee_param *param,memcpy (ssid, ssid_ie+2 , ssid_len); ssid[ssid_len] =0x0 ; -memcpy (pbss_network->ssid.Ssid, (void *)ssid, ssid_len); - pbss_network->ssid.SsidLength = ssid_len; -memcpy (pbss_network_ext->ssid.Ssid, (void *)ssid, ssid_len); - pbss_network_ext->ssid.SsidLength = ssid_len; +memcpy (pbss_network->ssid.ssid, (void *)ssid, ssid_len); + pbss_network->ssid.ssid_length = ssid_len; +memcpy (pbss_network_ext->ssid.ssid, (void *)ssid, ssid_len); + pbss_network_ext->ssid.ssid_length = ssid_len; }return ret;
drivers/staging/rtl8723bs/os_dep/os_intfs.c +2 -2
@@ -205,8 +205,8 @@ static void loadparam(struct adapter *padapter, struct net_device *pnetdev)/* registry_par->hci = (u8)hci; */ registry_par->network_mode = (u8 )rtw_network_mode; -memcpy (registry_par->ssid.Ssid,"ANY" ,3 ); - registry_par->ssid.SsidLength =3 ; +memcpy (registry_par->ssid.ssid,"ANY" ,3 ); + registry_par->ssid.ssid_length =3 ; registry_par->channel = (u8 )rtw_channel; registry_par->wireless_mode = (u8 )rtw_wireless_mode;
Signature · 1 line
2.20.1
PATCH 11/16 staging: rtl8723bs: fix camel case in struct wlan_phy_info
In reply to Fabio Aiutofix camel case in struct wlan_phy_info all over the driver.
--- drivers/staging/rtl8723bs/core/rtw_mlme.c | 30 +++++++++---------- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 8 ++--- .../staging/rtl8723bs/include/wlan_bssdef.h | 8 ++--- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 4 +-- 5 files changed, 26 insertions(+), 26 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme.c +15 -15
@@ -452,7 +452,7 @@ void update_network(struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src, {long rssi_ori = dst->rssi; -u8 sq_smp = src->phy_info.SignalQuality; +u8 sq_smp = src->phy_info.signal_quality;u8 ss_final;u8 sq_final;
@@ -470,13 +470,13 @@ void update_network(struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src, rssi_final = rssi_ori; }else {if (sq_smp !=101 ) {/* from the right channel */ - ss_final = ((u32)(src->phy_info.SignalStrength)+(u32)(dst->phy_info.SignalStrength)*4 )/5 ; - sq_final = ((u32)(src->phy_info.SignalQuality)+(u32)(dst->phy_info.SignalQuality)*4 )/5 ; + ss_final = ((u32)(src->phy_info.signal_strength)+(u32)(dst->phy_info.signal_strength)*4 )/5 ; + sq_final = ((u32)(src->phy_info.signal_quality)+(u32)(dst->phy_info.signal_quality)*4 )/5 ; rssi_final = (src->rssi+dst->rssi*4 )/5 ; }else {/* bss info not receiving from the right channel, use the original RX signal infos */ - ss_final = dst->phy_info.SignalStrength; - sq_final = dst->phy_info.SignalQuality; + ss_final = dst->phy_info.signal_strength; + sq_final = dst->phy_info.signal_quality; rssi_final = dst->rssi; }
@@ -488,8 +488,8 @@ void update_network(struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src,memcpy ((u8 *)dst, (u8 *)src,get_wlan_bssid_ex_sz (src)); } - dst->phy_info.SignalStrength = ss_final; - dst->phy_info.SignalQuality = sq_final; + dst->phy_info.signal_strength = ss_final; + dst->phy_info.signal_quality = sq_final; dst->rssi = rssi_final; }
@@ -568,8 +568,8 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t pnetwork->join_res =0 ;/* bss info not receiving from the right channel */ -if (pnetwork->network.phy_info.SignalQuality ==101 ) - pnetwork->network.phy_info.SignalQuality =0 ; +if (pnetwork->network.phy_info.signal_quality ==101 ) + pnetwork->network.phy_info.signal_quality =0 ; }else {/* Otherwise just pull from the free list */
@@ -585,8 +585,8 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t pnetwork->last_scanned = jiffies;/* bss info not receiving from the right channel */ -if (pnetwork->network.phy_info.SignalQuality ==101 ) - pnetwork->network.phy_info.SignalQuality =0 ; +if (pnetwork->network.phy_info.signal_quality ==101 ) + pnetwork->network.phy_info.signal_quality =0 ;list_add_tail (&(pnetwork->list), &(queue->queue));
@@ -1120,10 +1120,10 @@ static void rtw_joinbss_update_network(struct adapter *padapter, struct wlan_netrtw_set_signal_stat_timer (&padapter->recvpriv); - padapter->recvpriv.signal_strength = ptarget_wlan->network.phy_info.SignalStrength; - padapter->recvpriv.signal_qual = ptarget_wlan->network.phy_info.SignalQuality; -/* the ptarget_wlan->network.rssi is raw data, we use ptarget_wlan->network.phy_info.SignalStrength instead (has scaled) */ - padapter->recvpriv.rssi =translate_percentage_to_dbm (ptarget_wlan->network.phy_info.SignalStrength); + padapter->recvpriv.signal_strength = ptarget_wlan->network.phy_info.signal_strength; + padapter->recvpriv.signal_qual = ptarget_wlan->network.phy_info.signal_quality; +/* the ptarget_wlan->network.rssi is raw data, we use ptarget_wlan->network.phy_info.signal_strength instead (has scaled) */ + padapter->recvpriv.rssi =translate_percentage_to_dbm (ptarget_wlan->network.phy_info.signal_strength);rtw_set_signal_stat_timer (&padapter->recvpriv);
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +4 -4
@@ -3995,8 +3995,8 @@ u8 collect_bss_info(struct adapter *padapter, union recv_frame *precv_frame, str/* get the signal strength */ bssid->rssi = precv_frame->u.hdr.attrib.phy_info.RecvSignalPower;/* in dBM.raw data */ - bssid->phy_info.SignalQuality = precv_frame->u.hdr.attrib.phy_info.SignalQuality;/* in percentage */ - bssid->phy_info.SignalStrength = precv_frame->u.hdr.attrib.phy_info.SignalStrength;/* in percentage */ + bssid->phy_info.signal_quality = precv_frame->u.hdr.attrib.phy_info.SignalQuality;/* in percentage */ + bssid->phy_info.signal_strength = precv_frame->u.hdr.attrib.phy_info.SignalStrength;/* in percentage */ /* checking SSID */ p =rtw_get_ie (bssid->ies + ie_offset,WLAN_EID_SSID , &len, bssid->ie_length - ie_offset);
@@ -4095,9 +4095,9 @@ u8 collect_bss_info(struct adapter *padapter, union recv_frame *precv_frame, str pmlmepriv->num_sta_no_ht++; } -/* mark bss info receiving from nearby channel as SignalQuality 101 */ +/* mark bss info receiving from nearby channel as signal_quality 101 */ if (bssid->configuration.ds_config !=rtw_get_oper_ch (padapter)) - bssid->phy_info.SignalQuality =101 ; + bssid->phy_info.signal_quality =101 ;return _SUCCESS; }
drivers/staging/rtl8723bs/include/wlan_bssdef.h +4 -4
@@ -143,10 +143,10 @@ struct ndis_802_11_wep {#endif struct wlan_phy_info { -u8 SignalStrength;/* in percentage) */ -u8 SignalQuality;/* in percentage) */ -u8 Optimum_antenna;/* for Antenna diversity */ -u8 Reserved_0; +u8 signal_strength;/* in percentage) */ +u8 signal_quality;/* in percentage) */ +u8 optimum_antenna;/* for Antenna diversity */ +u8 reserved_0; };struct wlan_bcn_info {
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +1 -1
@@ -290,7 +290,7 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct adapter *padapter, struct wl is_same_network(&pmlmepriv->cur_network.network, &pnetwork->network, 0)) { notify_signal = 100*translate_percentage_to_dbm(padapter->recvpriv.signal_strength);/* dbm */ } else { - notify_signal =100 *translate_percentage_to_dbm (pnetwork->network.phy_info.SignalStrength);/* dbm */ + notify_signal =100 *translate_percentage_to_dbm (pnetwork->network.phy_info.signal_strength);/* dbm */ } buf =kzalloc (MAX_BSSINFO_LEN ,GFP_ATOMIC );
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +2 -2
@@ -303,8 +303,8 @@ static char *translate_scan(struct adapter *padapter, ss = padapter->recvpriv.signal_strength; sq = padapter->recvpriv.signal_qual; }else { - ss = pnetwork->network.phy_info.SignalStrength; - sq = pnetwork->network.phy_info.SignalQuality; + ss = pnetwork->network.phy_info.signal_strength; + sq = pnetwork->network.phy_info.signal_quality; }
Signature · 1 line
2.20.1
PATCH 12/16 staging: rtl8723bs: fix camel case in struct wlan_bcn_info
In reply to Fabio Aiutofix camel case in struct wlan_bcn_info all over the driver.
--- .../staging/rtl8723bs/core/rtw_ieee80211.c | 28 +++++++++---------- .../staging/rtl8723bs/core/rtw_wlan_util.c | 16 +++++------ .../staging/rtl8723bs/include/wlan_bssdef.h | 2 +- 3 files changed, 23 insertions(+), 23 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +14 -14
@@ -1034,9 +1034,9 @@ static int rtw_get_cipher_info(struct wlan_network *pnetwork)if (pbuf && (wpa_ielen >0 )) {if (_SUCCESS ==rtw_parse_wpa_ie (pbuf, wpa_ielen+2 , &group_cipher, &pairwise_cipher, &is8021x)) { - pnetwork->BcnInfo.pairwise_cipher = pairwise_cipher; - pnetwork->BcnInfo.group_cipher = group_cipher; - pnetwork->BcnInfo.is_8021x = is8021x; + pnetwork->bcn_info.pairwise_cipher = pairwise_cipher; + pnetwork->bcn_info.group_cipher = group_cipher; + pnetwork->bcn_info.is_8021x = is8021x; ret = _SUCCESS; } }else {
@@ -1044,9 +1044,9 @@ static int rtw_get_cipher_info(struct wlan_network *pnetwork)if (pbuf && (wpa_ielen >0 )) {if (_SUCCESS ==rtw_parse_wpa2_ie (pbuf, wpa_ielen+2 , &group_cipher, &pairwise_cipher, &is8021x)) { - pnetwork->BcnInfo.pairwise_cipher = pairwise_cipher; - pnetwork->BcnInfo.group_cipher = group_cipher; - pnetwork->BcnInfo.is_8021x = is8021x; + pnetwork->bcn_info.pairwise_cipher = pairwise_cipher; + pnetwork->bcn_info.group_cipher = group_cipher; + pnetwork->bcn_info.is_8021x = is8021x; ret = _SUCCESS; } }
@@ -1073,17 +1073,17 @@ void rtw_get_bcn_info(struct wlan_network *pnetwork) bencrypt =1 ; pnetwork->network.privacy =1 ; }else { - pnetwork->BcnInfo.encryp_protocol =ENCRYP_PROTOCOL_OPENSYS ; + pnetwork->bcn_info.encryp_protocol =ENCRYP_PROTOCOL_OPENSYS ; }rtw_get_sec_ie (pnetwork->network.ies, pnetwork->network.ie_length,NULL , &rsn_len,NULL , &wpa_len);if (rsn_len >0 ) { - pnetwork->BcnInfo.encryp_protocol =ENCRYP_PROTOCOL_WPA2 ; + pnetwork->bcn_info.encryp_protocol =ENCRYP_PROTOCOL_WPA2 ; }else if (wpa_len >0 ) { - pnetwork->BcnInfo.encryp_protocol =ENCRYP_PROTOCOL_WPA ; + pnetwork->bcn_info.encryp_protocol =ENCRYP_PROTOCOL_WPA ; }else {if (bencrypt) - pnetwork->BcnInfo.encryp_protocol =ENCRYP_PROTOCOL_WEP ; + pnetwork->bcn_info.encryp_protocol =ENCRYP_PROTOCOL_WEP ; }rtw_get_cipher_info (pnetwork);
@@ -1092,17 +1092,17 @@ void rtw_get_bcn_info(struct wlan_network *pnetwork) p =rtw_get_ie (pnetwork->network.ies + _FIXED_IE_LENGTH_,WLAN_EID_HT_CAPABILITY , &len, pnetwork->network.ie_length - _FIXED_IE_LENGTH_);if (p && len >0 ) { pht_cap = (struct ieee80211_ht_cap *)(p +2 ); - pnetwork->BcnInfo.ht_cap_info =le16_to_cpu (pht_cap->cap_info); + pnetwork->bcn_info.ht_cap_info =le16_to_cpu (pht_cap->cap_info); }else { - pnetwork->BcnInfo.ht_cap_info =0 ; + pnetwork->bcn_info.ht_cap_info =0 ; }/* parsing HT_INFO_IE */ p =rtw_get_ie (pnetwork->network.ies + _FIXED_IE_LENGTH_,WLAN_EID_HT_OPERATION , &len, pnetwork->network.ie_length - _FIXED_IE_LENGTH_);if (p && len >0 ) { pht_info = (struct HT_info_element *)(p +2 ); - pnetwork->BcnInfo.ht_info_infos_0 = pht_info->infos[0 ]; + pnetwork->bcn_info.ht_info_infos_0 = pht_info->infos[0 ]; }else { - pnetwork->BcnInfo.ht_info_infos_0 =0 ; + pnetwork->bcn_info.ht_info_infos_0 =0 ; } }
drivers/staging/rtl8723bs/core/rtw_wlan_util.c +8 -8
@@ -1248,12 +1248,12 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *pframe, u32 packet_len) }else { ht_info_infos_0 =0 ; } -if (ht_cap_info != cur_network->BcnInfo.ht_cap_info || - ((ht_info_infos_0&0x03 ) != (cur_network->BcnInfo.ht_info_infos_0&0x03 ))) { +if (ht_cap_info != cur_network->bcn_info.ht_cap_info || + ((ht_info_infos_0&0x03 ) != (cur_network->bcn_info.ht_info_infos_0&0x03 ))) { {/* bcn_info_update */ - cur_network->BcnInfo.ht_cap_info = ht_cap_info; - cur_network->BcnInfo.ht_info_infos_0 = ht_info_infos_0; + cur_network->bcn_info.ht_cap_info = ht_cap_info; + cur_network->bcn_info.ht_info_infos_0 = ht_info_infos_0;/* to do : need to check that whether modify related register of BB or not */ }/* goto _mismatch; */
@@ -1313,7 +1313,7 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *pframe, u32 packet_len)if (bssid->privacy) encryp_protocol =ENCRYP_PROTOCOL_WEP ; -if (cur_network->BcnInfo.encryp_protocol != encryp_protocol) +if (cur_network->bcn_info.encryp_protocol != encryp_protocol) goto _mismatch;if (encryp_protocol ==ENCRYP_PROTOCOL_WPA || encryp_protocol ==ENCRYP_PROTOCOL_WPA2 ) {
@@ -1329,11 +1329,11 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *pframe, u32 packet_len) &pairwise_cipher, &is_8021x); } -if (pairwise_cipher != cur_network->BcnInfo.pairwise_cipher || - group_cipher != cur_network->BcnInfo.group_cipher) +if (pairwise_cipher != cur_network->bcn_info.pairwise_cipher || + group_cipher != cur_network->bcn_info.group_cipher) goto _mismatch; -if (is_8021x != cur_network->BcnInfo.is_8021x) +if (is_8021x != cur_network->bcn_info.is_8021x) goto _mismatch; }
drivers/staging/rtl8723bs/include/wlan_bssdef.h +1 -1
@@ -194,7 +194,7 @@ struct wlan_network {int aid;/* will only be valid when a BSS is joinned. */ int join_res;struct wlan_bssid_ex network;/* must be the last item */ -struct wlan_bcn_info BcnInfo; +struct wlan_bcn_info bcn_info; };enum {
Signature · 1 line
2.20.1
PATCH 13/16 staging: rtl8723bs: fix camel case in IE structures
In reply to Fabio Aiutofix camel case in IE structures all over the driver.
--- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 20 ++++++------- .../staging/rtl8723bs/core/rtw_wlan_util.c | 28 +++++++++---------- .../staging/rtl8723bs/include/wlan_bssdef.h | 10 +++---- 3 files changed, 29 insertions(+), 29 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +10 -10
@@ -1428,7 +1428,7 @@ unsigned int OnAssocRsp(struct adapter *padapter, union recv_frame *precv_frame)for (i = (6 +WLAN_HDR_A3_LEN ); i < pkt_len;) { pIE = (struct ndis_80211_var_ie *)(pframe + i); -switch (pIE->ElementID) { +switch (pIE->element_id) {case WLAN_EID_VENDOR_SPECIFIC :if (!memcmp (pIE->data,WMM_PARA_OUI ,6 ))/* WMM */ WMM_param_handler (padapter, pIE);
@@ -1450,7 +1450,7 @@ unsigned int OnAssocRsp(struct adapter *padapter, union recv_frame *precv_frame)break ; } - i += (pIE->Length +2 ); + i += (pIE->length +2 ); } pmlmeinfo->state &= (~WIFI_FW_ASSOC_STATE );
@@ -2980,12 +2980,12 @@ void issue_assocreq(struct adapter *padapter)for (i =sizeof (struct ndis_802_11_fix_ie ); i < pmlmeinfo->network.ie_length;) { pIE = (struct ndis_80211_var_ie *)(pmlmeinfo->network.ies + i); -switch (pIE->ElementID) { +switch (pIE->element_id) {case WLAN_EID_VENDOR_SPECIFIC :if ((!memcmp (pIE->data,RTW_WPA_OUI ,4 )) || (!memcmp (pIE->data,WMM_OUI ,4 )) || (!memcmp (pIE->data,WPS_OUI ,4 ))) { - vs_ie_length = pIE->Length; + vs_ie_length = pIE->length;if ((!padapter->registrypriv.wifi_spec) && (!memcmp (pIE->data,WPS_OUI ,4 ))) {/* Commented by Kurt 20110629 * In some older APs, WPS handshake
@@ -3001,26 +3001,26 @@ void issue_assocreq(struct adapter *padapter)break ;case WLAN_EID_RSN : - pframe =rtw_set_ie (pframe,WLAN_EID_RSN , pIE->Length, pIE->data, &(pattrib->pktlen)); + pframe =rtw_set_ie (pframe,WLAN_EID_RSN , pIE->length, pIE->data, &(pattrib->pktlen));break ;case WLAN_EID_HT_CAPABILITY :if (padapter->mlmepriv.htpriv.ht_option) {if (!(is_ap_in_tkip (padapter))) {memcpy (&(pmlmeinfo->HT_caps), pIE->data,sizeof (struct HT_caps_element )); - pframe =rtw_set_ie (pframe,WLAN_EID_HT_CAPABILITY , pIE->Length, (u8 *)(&(pmlmeinfo->HT_caps)), &(pattrib->pktlen)); + pframe =rtw_set_ie (pframe,WLAN_EID_HT_CAPABILITY , pIE->length, (u8 *)(&(pmlmeinfo->HT_caps)), &(pattrib->pktlen)); } }break ;case WLAN_EID_EXT_CAPABILITY :if (padapter->mlmepriv.htpriv.ht_option) - pframe =rtw_set_ie (pframe,WLAN_EID_EXT_CAPABILITY , pIE->Length, pIE->data, &(pattrib->pktlen)); + pframe =rtw_set_ie (pframe,WLAN_EID_EXT_CAPABILITY , pIE->length, pIE->data, &(pattrib->pktlen));break ;default :break ; } - i += (pIE->Length +2 ); + i += (pIE->length +2 ); }if (pmlmeinfo->assoc_AP_vendor ==HT_IOT_PEER_REALTEK )
@@ -5411,7 +5411,7 @@ u8 join_cmd_hdl(struct adapter *padapter, u8 *pbuf)for (i = _FIXED_IE_LENGTH_; i < pnetwork->ie_length;) { pIE = (struct ndis_80211_var_ie *)(pnetwork->ies + i); -switch (pIE->ElementID) { +switch (pIE->element_id) {case WLAN_EID_VENDOR_SPECIFIC :/* Get WMM IE. */ if (!memcmp (pIE->data,WMM_OUI ,4 ))WMM_param_handler (padapter, pIE);
@@ -5457,7 +5457,7 @@ u8 join_cmd_hdl(struct adapter *padapter, u8 *pbuf)break ; } - i += (pIE->Length +2 ); + i += (pIE->length +2 ); }/* check channel, bandwidth, offset and switch */
drivers/staging/rtl8723bs/core/rtw_wlan_util.c +14 -14
@@ -909,7 +909,7 @@ static void bwmode_update_check(struct adapter *padapter, struct ndis_80211_var_if (phtpriv->ht_option == false)return ; -if (pIE->Length >sizeof (struct HT_info_element )) +if (pIE->length >sizeof (struct HT_info_element ))return ; pHT_info = (struct HT_info_element *)pIE->data;
@@ -1001,7 +1001,7 @@ void HT_caps_handler(struct adapter *padapter, struct ndis_80211_var_ie *pIE) pmlmeinfo->HT_caps_enable =1 ; -for (i =0 ; i < (pIE->Length); i++) { +for (i =0 ; i < (pIE->length); i++) {if (i !=2 ) {/* Commented by Albert 2010/07/12 */ /* Got the endian issue here. */
@@ -1075,11 +1075,11 @@ void HT_info_handler(struct adapter *padapter, struct ndis_80211_var_ie *pIE)if (phtpriv->ht_option == false)return ; -if (pIE->Length >sizeof (struct HT_info_element )) +if (pIE->length >sizeof (struct HT_info_element ))return ; pmlmeinfo->HT_info_enable =1 ; -memcpy (&(pmlmeinfo->HT_info), pIE->data, pIE->Length); +memcpy (&(pmlmeinfo->HT_info), pIE->data, pIE->length); }void HTOnAssocRsp (struct adapter *padapter)
@@ -1117,11 +1117,11 @@ void ERP_IE_handler(struct adapter *padapter, struct ndis_80211_var_ie *pIE)struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info); -if (pIE->Length >1 ) +if (pIE->length >1 )return ; pmlmeinfo->ERP_enable =1 ; -memcpy (&(pmlmeinfo->ERP_IE), pIE->data, pIE->Length); +memcpy (&(pmlmeinfo->ERP_IE), pIE->data, pIE->length); }void VCS_update (struct adapter *padapter,struct sta_info *psta)
@@ -1369,10 +1369,10 @@ void update_beacon_info(struct adapter *padapter, u8 *pframe, uint pkt_len, strufor (i =0 ; i < len;) { pIE = (struct ndis_80211_var_ie *)(pframe + (_BEACON_IE_OFFSET_ +WLAN_HDR_A3_LEN ) + i); -switch (pIE->ElementID) { +switch (pIE->element_id) {case WLAN_EID_VENDOR_SPECIFIC :/* to update WMM parameter set while receiving beacon */ -if (!memcmp (pIE->data,WMM_PARA_OUI ,6 ) && pIE->Length ==WLAN_WMM_LEN )/* WMM */ +if (!memcmp (pIE->data,WMM_PARA_OUI ,6 ) && pIE->length ==WLAN_WMM_LEN )/* WMM */ if (WMM_param_handler (padapter, pIE))report_wmm_edca_update (padapter);
@@ -1392,7 +1392,7 @@ void update_beacon_info(struct adapter *padapter, u8 *pframe, uint pkt_len, strubreak ; } - i += (pIE->Length +2 ); + i += (pIE->length +2 ); } }
@@ -1408,7 +1408,7 @@ unsigned int is_ap_in_tkip(struct adapter *padapter)for (i =sizeof (struct ndis_802_11_fix_ie ); i < pmlmeinfo->network.ie_length;) { pIE = (struct ndis_80211_var_ie *)(pmlmeinfo->network.ies + i); -switch (pIE->ElementID) { +switch (pIE->element_id) {case WLAN_EID_VENDOR_SPECIFIC :if ((!memcmp (pIE->data,RTW_WPA_OUI ,4 )) && (!memcmp ((pIE->data +12 ),WPA_TKIP_CIPHER ,4 )))return true;
@@ -1424,7 +1424,7 @@ unsigned int is_ap_in_tkip(struct adapter *padapter)break ; } - i += (pIE->Length +2 ); + i += (pIE->length +2 ); }return false;
@@ -1480,7 +1480,7 @@ static u32 get_realtek_assoc_AP_vender(struct ndis_80211_var_ie *pIE) {u32 Vender =HT_IOT_PEER_REALTEK ; -if (pIE->Length >=5 ) { +if (pIE->length >=5 ) {if (pIE->data[4 ] ==1 )/* if (pIE->data[5] & RT_HT_CAP_USE_LONG_PREAMBLE) */ /* bssDesc->BssHT.RT2RT_HT_Mode |= RT_HT_CAP_USE_LONG_PREAMBLE; */
@@ -1511,7 +1511,7 @@ unsigned char check_assoc_AP(u8 *pframe, uint len)for (i =sizeof (struct ndis_802_11_fix_ie ); i < len;) { pIE = (struct ndis_80211_var_ie *)(pframe + i); -switch (pIE->ElementID) { +switch (pIE->element_id) {case WLAN_EID_VENDOR_SPECIFIC :if ((!memcmp (pIE->data,ARTHEROS_OUI1 ,3 )) || (!memcmp (pIE->data,ARTHEROS_OUI2 ,3 )))return HT_IOT_PEER_ATHEROS ;
@@ -1536,7 +1536,7 @@ unsigned char check_assoc_AP(u8 *pframe, uint len)break ; } - i += (pIE->Length +2 ); + i += (pIE->length +2 ); }return HT_IOT_PEER_UNKNOWN ;
drivers/staging/rtl8723bs/include/wlan_bssdef.h +5 -5
@@ -52,14 +52,14 @@ enum ndis_802_11_network_infrastructure { };struct ndis_802_11_fix_ie { -u8 Timestamp[8 ]; -u16 BeaconInterval; -u16 Capabilities; +u8 time_stamp[8 ]; +u16 beacon_interval; +u16 capabilities; };struct ndis_80211_var_ie { -u8 ElementID; -u8 Length; +u8 element_id; +u8 length;u8 data[]; };
Signature · 1 line
2.20.1
PATCH 14/16 staging: rtl8723bs: remove unused struct ndis_802_11_ai_reqfi
In reply to Fabio Aiutoremove unused struct ndis_802_11_ai_reqfi.
--- drivers/staging/rtl8723bs/include/wlan_bssdef.h | 6 ------ 1 file changed, 6 deletions(-)
drivers/staging/rtl8723bs/include/wlan_bssdef.h +0 -6
@@ -107,12 +107,6 @@ enum {#define NDIS_802_11_AI_RESFI_STATUSCODE 2#define NDIS_802_11_AI_RESFI_ASSOCIATIONID 4 -struct ndis_802_11_ai_reqfi { -u16 Capabilities; -u16 ListenInterval; -NDIS_802_11_MAC_ADDRESS CurrentAPAddress; -}; -struct ndis_801_11_ai_resfi {u16 Capabilities;u16 StatusCode;
Signature · 1 line
2.20.1
PATCH 15/16 staging: rtl8723bs: remove unused struct ndis_801_11_ai_resfi
In reply to Fabio Aiutoremove unused struct ndis_801_11_ai_resfi.
--- drivers/staging/rtl8723bs/include/wlan_bssdef.h | 6 ------ 1 file changed, 6 deletions(-)
drivers/staging/rtl8723bs/include/wlan_bssdef.h +0 -6
@@ -107,12 +107,6 @@ enum {#define NDIS_802_11_AI_RESFI_STATUSCODE 2#define NDIS_802_11_AI_RESFI_ASSOCIATIONID 4 -struct ndis_801_11_ai_resfi { -u16 Capabilities; -u16 StatusCode; -u16 AssociationId; -}; -/* Key mapping keys require a BSSID */ struct ndis_802_11_wep {
Signature · 1 line
2.20.1
PATCH 16/16 staging: rtl8723bs: fix camel case in struct ndis_802_11_wep
In reply to Fabio Aiutofix camel case in struct ndis_802_11_wep all over the driver.
--- .../staging/rtl8723bs/core/rtw_ioctl_set.c | 8 +-- .../staging/rtl8723bs/include/wlan_bssdef.h | 8 +-- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 12 ++--- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 54 +++++++++---------- 4 files changed, 41 insertions(+), 41 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +4 -4
@@ -494,14 +494,14 @@ u8 rtw_set_802_11_add_wep(struct adapter *padapter, struct ndis_802_11_wep *wep)struct security_priv *psecuritypriv = &(padapter->securitypriv);u8 ret = _SUCCESS; - keyid = wep->KeyIndex &0x3fffffff ; + keyid = wep->key_index &0x3fffffff ;if (keyid >=4 ) { ret = false; goto exit; } -switch (wep->KeyLength) { +switch (wep->key_length) {case 5 : psecuritypriv->dot11PrivacyAlgrthm = _WEP40_;break ;
@@ -513,9 +513,9 @@ u8 rtw_set_802_11_add_wep(struct adapter *padapter, struct ndis_802_11_wep *wep)break ; } -memcpy (&(psecuritypriv->dot11DefKey[keyid].skey[0 ]), &(wep->KeyMaterial), wep->KeyLength); +memcpy (&(psecuritypriv->dot11DefKey[keyid].skey[0 ]), &(wep->key_material), wep->key_length); - psecuritypriv->dot11DefKeylen[keyid] = wep->KeyLength; + psecuritypriv->dot11DefKeylen[keyid] = wep->key_length; psecuritypriv->dot11PrivacyKeyIndex = keyid;
drivers/staging/rtl8723bs/include/wlan_bssdef.h +4 -4
@@ -110,10 +110,10 @@ enum {/* Key mapping keys require a BSSID */ struct ndis_802_11_wep { -u32 Length;/* Length of this structure */ -u32 KeyIndex;/* 0 is the per-client key, 1-N are the global keys */ -u32 KeyLength;/* length of key in bytes */ -u8 KeyMaterial[16 ];/* variable length depending on above field */ +u32 length;/* Length of this structure */ +u32 key_index;/* 0 is the per-client key, 1-N are the global keys */ +u32 key_length;/* length of key in bytes */ +u8 key_material[16 ];/* variable length depending on above field */ };/* mask for authentication/integrity fields */
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +6 -6
@@ -1874,7 +1874,7 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, struct net_device *ndev,if (wep_key_len >0 ) { wep_key_len = wep_key_len <=5 ?5 :13 ; - wep_total_len = wep_key_len + FIELD_OFFSET(struct ndis_802_11_wep, KeyMaterial); + wep_total_len = wep_key_len + FIELD_OFFSET(struct ndis_802_11_wep, key_material); pwep =rtw_malloc (wep_total_len);if (pwep ==NULL ) { ret = -ENOMEM ;
@@ -1883,8 +1883,8 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, struct net_device *ndev,memset (pwep,0 , wep_total_len); - pwep->KeyLength = wep_key_len; - pwep->Length = wep_total_len; + pwep->key_length = wep_key_len; + pwep->length = wep_total_len;if (wep_key_len ==13 ) { padapter->securitypriv.dot11PrivacyAlgrthm = _WEP104_;
@@ -1895,10 +1895,10 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, struct net_device *ndev, goto exit; } - pwep->KeyIndex = wep_key_idx; - pwep->KeyIndex |=0x80000000 ; + pwep->key_index = wep_key_idx; + pwep->key_index |=0x80000000 ; -memcpy (pwep->KeyMaterial, (void *)sme->key, pwep->KeyLength); +memcpy (pwep->key_material, (void *)sme->key, pwep->key_length);if (rtw_set_802_11_add_wep (padapter, pwep) == (u8 )_FAIL) ret = -EOPNOTSUPP ;
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +27 -27
130 lines not on this page · raw message
Signature · 1 line
2.20.1