Skip to contentSkip to conversation

mtd: Fix compilation warnings in drivers/mtd/nand/cs553x_nand.c

PATCH In review Manish Katiyar 1 participant 3 messages Oct 14, 2008 – Oct 19, 2008

Subsystems (3)
Kernel janitors Memory technology devices (MTD) NAND flash
lore
Share & tools
lore

Manish Katiyar

author
#0 lore raw

PATCH 1/1 mtd: Fix compilation warnings in drivers/mtd/nand/cs553x_nand.c

Below patch fixes the following compilation warnings. drivers/mtd/nand/cs553x_nand.c:293: warning: unused variable 'mtd_parts' drivers/mtd/nand/cs553x_nand.c:292: warning: unused variable 'mtd_parts_nb'

Signed-off-by Manish Katiyar <[email protected]>
---
 drivers/mtd/nand/cs553x_nand.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mtd/nand/cs553x_nand.c +2 -0
index 3370a80..9f1b451 100644
@@ -289,8 +289,10 @@ static int __init cs553x_init(void)
 	int i;
 	uint64_t val;
 
+#ifdef CONFIG_MTD_PARTITIONS
 	int mtd_parts_nb = 0;
 	struct mtd_partition *mtd_parts = NULL;
+#endif
 
 	/* If the CPU isn't a Geode GX or LX, abort */
 	if (!is_geode())
Signature · 4 lines
1.5.4.3

Thanks -
Manish
author
#1 lore raw
Quoted 3 lines · Manish Katiyar

Below patch fixes the following compilation warnings. drivers/mtd/nand/cs553x_nand.c:293: warning: unused variable 'mtd_parts' drivers/mtd/nand/cs553x_nand.c:292: warning: unused variable 'mtd_parts_nb'

Any ack/nack on this ??

Thanks -
Manish

Quoted 29 lines
Signed-off-by Manish Katiyar <[email protected]>
---
 drivers/mtd/nand/cs553x_nand.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mtd/nand/cs553x_nand.c +2 -1
index 3370a80..9f1b451 100644
@@ -289,8 +289,10 @@ static int __init cs553x_init(void)
       int i;
       uint64_t val;
 
+#ifdef CONFIG_MTD_PARTITIONS
       int mtd_parts_nb = 0;
       struct mtd_partition *mtd_parts = NULL;
+#endif
 
       /* If the CPU isn't a Geode GX or LX, abort */
       if (!is_geode())
--

1.5.4.3

Thanks -
Manish

author
#2 lore raw
In reply to Manish Katiyar
Quoted 27 lines · Manish Katiyar

Below patch fixes the following compilation warnings. drivers/mtd/nand/cs553x_nand.c:293: warning: unused variable 'mtd_parts' drivers/mtd/nand/cs553x_nand.c:292: warning: unused variable 'mtd_parts_nb'

Signed-off-by Manish Katiyar <[email protected]>
---
 drivers/mtd/nand/cs553x_nand.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mtd/nand/cs553x_nand.c +2 -1
index 3370a80..9f1b451 100644
@@ -289,8 +289,10 @@ static int __init cs553x_init(void)
       int i;
       uint64_t val;
 
+#ifdef CONFIG_MTD_PARTITIONS
       int mtd_parts_nb = 0;
       struct mtd_partition *mtd_parts = NULL;
+#endif
 
       /* If the CPU isn't a Geode GX or LX, abort */
       if (!is_geode())
--
Quoted 2 lines

1.5.4.3

Resending it adding kernel-janitors, since I didn't get any response from the linux-mtd list.

Thanks -
Manish

Quoted 3 lines

Thanks -
Manish