Skip to contentSkip to conversation

dlm: use DEFINE_MUTEX() for mutex lock

PATCH In review Ye Bin 2 participants 2 messages Apr 9, 2021

Subsystems (2)
lore
Share & tools
lore

Ye Bin

author
#0 lore raw

PATCH 1/1 dlm: use DEFINE_MUTEX() for mutex lock

mutex lock can be initialized automatically with DEFINE_MUTEX() rather than explicitly calling mutex_init().

---
 fs/dlm/lockspace.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/dlm/lockspace.c +1 -2
index c14cf2b7faab..fa3ae801aa43 100644
@@ -26,7 +26,7 @@
 #include "ast.h"
 
 static int			ls_count;
-static struct mutex		ls_lock;
+static DEFINE_MUTEX(ls_lock);
 static struct list_head		lslist;
 static spinlock_t		lslist_lock;
 static struct task_struct *	scand_task;
@@ -231,7 +231,6 @@ static const struct kset_uevent_ops dlm_uevent_ops = {
 int __init dlm_lockspace_init(void)
 {
 	ls_count = 0;
-	mutex_init(&ls_lock);
 	INIT_LIST_HEAD(&lslist);
 	spin_lock_init(&lslist_lock);
 
#1 lore raw

???????????

? 2021/4/9 17:51, Ye Bin ??:

Quoted 31 lines

mutex lock can be initialized automatically with DEFINE_MUTEX() rather than explicitly calling mutex_init().

---
  fs/dlm/lockspace.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
fs/dlm/lockspace.c +1 -2
index c14cf2b7faab..fa3ae801aa43 100644
@@ -26,7 +26,7 @@
  #include "ast.h"
 
  static int			ls_count;
-static struct mutex		ls_lock;
+static DEFINE_MUTEX(ls_lock);
  static struct list_head		lslist;
  static spinlock_t		lslist_lock;
  static struct task_struct *	scand_task;
@@ -231,7 +231,6 @@ static const struct kset_uevent_ops dlm_uevent_ops = {
  int __init dlm_lockspace_init(void)
  {
  	ls_count = 0;
-	mutex_init(&ls_lock);
  	INIT_LIST_HEAD(&lslist);
  	spin_lock_init(&lslist_lock);