Skip to contentSkip to conversation

hw/scsi: remove dead code

PATCH In review Elena Afanasova 2 participants 2 messages Oct 12, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/scsi: remove dead code

Since MEGASAS_MAX_SGE is defined to be 128 the following if statement can be removed. Spotted by PVS-Studio.

---
 hw/scsi/megasas.c | 2 --
 1 file changed, 2 deletions(-)
hw/scsi/megasas.c +0 -2
index e24c12d7ee..6dcaad55fa 100644
@@ -2393,8 +2393,6 @@ static void megasas_scsi_realize(PCIDevice *dev, Error **errp)
     }
     if (s->fw_sge >= MEGASAS_MAX_SGE - MFI_PASS_FRAME_SIZE) {
         s->fw_sge = MEGASAS_MAX_SGE - MFI_PASS_FRAME_SIZE;
-    } else if (s->fw_sge >= 128 - MFI_PASS_FRAME_SIZE) {
-        s->fw_sge = 128 - MFI_PASS_FRAME_SIZE;
     } else {
         s->fw_sge = 64 - MFI_PASS_FRAME_SIZE;
     }
Signature · 1 line
2.25.1
#1 lore raw

Hi Elena,

Quoted 13 lines · Elena Afanasova

Since MEGASAS_MAX_SGE is defined to be 128 the following if statement can be removed. Spotted by PVS-Studio.

---
  hw/scsi/megasas.c | 2 --
  1 file changed, 2 deletions(-)
hw/scsi/megasas.c +0 -0
index e24c12d7ee..6dcaad55fa 100644

hw/scsi/megasas.c static void megasas_scsi_realize(PCIDevice *dev, Error **errp) · line 2397

Quoted 5 lines
hw/scsi/megasas.c +0 -2
@@ -2393,8 +2393,6 @@ static void megasas_scsi_realize(PCIDevice *dev, Error **errp)
      }
      if (s->fw_sge >= MEGASAS_MAX_SGE - MFI_PASS_FRAME_SIZE) {
          s->fw_sge = MEGASAS_MAX_SGE - MFI_PASS_FRAME_SIZE;
-    } else if (s->fw_sge >= 128 - MFI_PASS_FRAME_SIZE) {
-        s->fw_sge = 128 - MFI_PASS_FRAME_SIZE;

See previous discussion:
https://www.mail-archive.com/[email protected]/msg668850.html

Quoted 4 lines
hw/scsi/megasas.c +0 -0
      } else {
          s->fw_sge = 64 - MFI_PASS_FRAME_SIZE;
      }