clk: meson: axg-audio: do not print error on defer
Jerome Brunet
maintainerPATCH 1/1 clk: meson: axg-audio: do not print error on defer
Do not print an error if we are just waiting for the reset controller to come up.
--- drivers/clk/meson/axg-audio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/clk/meson/axg-audio.c +2 -1
@@ -1811,7 +1811,8 @@ static int axg_audio_clkc_probe(struct platform_device *pdev) ret =device_reset (dev);if (ret) { -dev_err (dev,"failed to reset device\n" ); +if (ret != -EPROBE_DEFER ) +dev_err (dev,"failed to reset device\n" );return ret; }
Signature · 1 line
2.31.1
Quoted 14 lines · Jerome Brunet
Do not print an error if we are just waiting for the reset controller to come up.
Signed-off-by Jerome Brunet <[email protected]>--- drivers/clk/meson/axg-audio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/clk/meson/axg-audio.c +0
-0
drivers/clk/meson/axg-audio.c static int axg_audio_clkc_probe(struct platform_device *pdev) · line 1818
Quoted 9 lines
drivers/clk/meson/axg-audio.c +2
-1@@ -1811,7 +1811,8 @@ static int axg_audio_clkc_probe(struct platform_device *pdev) ret =device_reset (dev);if (ret) { -dev_err (dev,"failed to reset device\n" ); +if (ret != -EPROBE_DEFER ) +dev_err (dev,"failed to reset device\n" );return ret; }
_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
Martin Blumenstingl
reviewerHi Jerome,
On Thu, Apr 29, 2021 at 11:06 AM Jerome Brunet <[email protected]> wrote:
[...]
drivers/clk/meson/axg-audio.c static int axg_audio_clkc_probe(struct platform_device *pdev) · line 1815
Quoted 11 lines
drivers/clk/meson/axg-audio.c +2
-1@@ -1811,7 +1811,8 @@ static int axg_audio_clkc_probe(struct platform_device *pdev) ret =device_reset (dev);if (ret) { -dev_err (dev,"failed to reset device\n" ); +if (ret != -EPROBE_DEFER ) +dev_err (dev,"failed to reset device\n" );
many drivers are switching to dev_err_probe nowadays According to it's documentation:
In case of -EPROBE_DEFER it sets also defer probe reason, which can be checked later by reading devices_deferred debugfs attribute.
so I think it makes sense to use dev_err_probe here as well
Best regards,
Martin
Stephen Boyd
maintainerQuoting Martin Blumenstingl (2021-04-29 13:49:54)
Quoted 20 lines
Hi Jerome,
On Thu, Apr 29, 2021 at 11:06 AM Jerome Brunet <[email protected]> wrote:
[...]drivers/clk/meson/axg-audio.c static int axg_audio_clkc_probe(struct platform_device *pdev) · line 1815
Quoted 11 lines
drivers/clk/meson/axg-audio.c +2
-1@@ -1811,7 +1811,8 @@ static int axg_audio_clkc_probe(struct platform_device *pdev) ret =device_reset (dev);if (ret) { -dev_err (dev,"failed to reset device\n" ); +if (ret != -EPROBE_DEFER ) +dev_err (dev,"failed to reset device\n" );many drivers are switching to
dev_err_probenowadays According to it's documentation:
In case of -EPROBE_DEFER it sets also defer probe reason, which can be checked later by readingdevices_deferreddebugfs attribute.
Quoted 3 lines
so I think it makes sense to use
dev_err_probehere as well
Yes please use dev_err_probe()
Jerome Brunet
maintainerQuoted 20 lines · Martin Blumenstingl
Hi Jerome,
On Thu, Apr 29, 2021 at 11:06 AM Jerome Brunet <[email protected]> wrote:
[...]drivers/clk/meson/axg-audio.c static int axg_audio_clkc_probe(struct platform_device *pdev) · line 1815
Quoted 11 lines
drivers/clk/meson/axg-audio.c +2
-1@@ -1811,7 +1811,8 @@ static int axg_audio_clkc_probe(struct platform_device *pdev) ret =device_reset (dev);if (ret) { -dev_err (dev,"failed to reset device\n" ); +if (ret != -EPROBE_DEFER ) +dev_err (dev,"failed to reset device\n" );many drivers are switching to
dev_err_probenowadays According to it's documentation:
In case of -EPROBE_DEFER it sets also defer probe reason, which can be checked later by readingdevices_deferreddebugfs attribute.
Quoted 1 line
so I think it makes sense to use
dev_err_probehere as well
Old habits ;) thanks for pointing this out. Will do
Quoted 4 lines
Best regards,
Martin