Skip to contentSkip to conversation

scsi: Convert snprintf to scnprintf

PATCH New [email protected] 1 participant 1 message Jul 17, 2023 1 message not in the archive SCSI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 scsi: Convert snprintf to scnprintf

Fix the coccicheck warnings:

./drivers/scsi/scsi_transport_fc.c:1967:9-17: WARNING: use scnprintf or sprintf ./drivers/scsi/scsi_transport_fc.c:1891:9-17: WARNING: use scnprintf or sprintf ./drivers/scsi/scsi_transport_fc.c:1915:9-17: WARNING: use scnprintf or sprintf ./drivers/scsi/scsi_transport_fc.c:2000:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/scsi_transport_fc.c:1304:9-17: WARNING: use scnprintf or sprintf ./drivers/scsi/scsi_transport_fc.c:1286:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/scsi_transport_fc.c:1218:10-18: WARNING: use scnprintf or sprintf ./drivers/scsi/scsi_transport_fc.c:1123:9-17: WARNING: use scnprintf or sprintf ./drivers/scsi/scsi_transport_fc.c:1665:9-17: WARNING: use scnprintf or sprintf

---
 drivers/scsi/scsi_transport_fc.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/scsi/scsi_transport_fc.c +5 -5
index 64ff2629eaf9..493bcfd0b5e1 100644
@@ -1120,7 +1120,7 @@ show_fc_rport_supported_classes (struct device *dev,
 {
     struct fc_rport *rport = transport_class_to_rport(dev);
     if (rport->supported_classes == FC_COS_UNSPECIFIED)
-        return snprintf(buf, 20, "unspecified\n");
+        return scnprintf(buf, 20, "unspecified\n");
     return get_fc_cos_names(rport->supported_classes, buf);
 }
 static FC_DEVICE_ATTR(rport, supported_classes, S_IRUGO,
@@ -1215,7 +1215,7 @@ show_fc_rport_roles (struct device *dev, struct device_attribute *attr,
                     FC_WELLKNOWN_PORTID_MASK) {
         switch (rport->port_id & FC_WELLKNOWN_ROLE_MASK) {
         case FC_FPORT_PORTID:
-            return snprintf(buf, 30, "Fabric Port\n");
+            return scnprintf(buf, 30, "Fabric Port\n");
         case FC_FABCTLR_PORTID:
             return snprintf(buf, 30, "Fabric Controller\n");
         case FC_DIRSRVR_PORTID:
@@ -1283,7 +1283,7 @@ show_fc_rport_port_state(struct device *dev,
     if (!name)
         return -EINVAL;
 
-    return snprintf(buf, 20, "%s\n", name);
+    return scnprintf(buf, 20, "%s\n", name);
 }
 
 static FC_DEVICE_ATTR(rport, port_state, 0444 | 0200,
@@ -1301,7 +1301,7 @@ show_fc_rport_fast_io_fail_tmo (struct device *dev,
     struct fc_rport *rport = transport_class_to_rport(dev);
 
     if (rport->fast_io_fail_tmo == -1)
-        return snprintf(buf, 5, "off\n");
+        return scnprintf(buf, 5, "off\n");
     return snprintf(buf, 20, "%d\n", rport->fast_io_fail_tmo);
 }
 
@@ -1662,7 +1662,7 @@ show_fc_vport_roles (struct device *dev, struct device_attribute *attr,
     struct fc_vport *vport = transport_class_to_vport(dev);
 
     if (vport->roles == FC_PORT_ROLE_UNKNOWN)
-        return snprintf(buf, 20, "unknown\n");
+        return scnprintf(buf, 20, "unknown\n");
     return get_fc_port_roles_names(vport->roles, buf);
 }
 static FC_DEVICE_ATTR(vport, roles, S_IRUGO, show_fc_vport_roles, 

NULL);
@@ -1888,7 +1888,7 @@ show_fc_host_supported_classes (struct device *dev,

     struct Scsi_Host *shost = transport_class_to_shost(dev);

     if (fc_host_supported_classes(shost) == FC_COS_UNSPECIFIED)

- return snprintf(buf, 20, "unspecified\n");
+ return scnprintf(buf, 20, "unspecified\n");

     return get_fc_cos_names(fc_host_supported_classes(shost), buf);
 }
@@ -1912,7 +1912,7 @@ show_fc_host_supported_speeds (struct device *dev,
     struct Scsi_Host *shost = transport_class_to_shost(dev);

     if (fc_host_supported_speeds(shost) == FC_PORTSPEED_UNKNOWN)

- return snprintf(buf, 20, "unknown\n");
+ return scnprintf(buf, 20, "unknown\n");

return get_fc_port_speed_names(fc_host_supported_speeds(shost),
buf);
}
@@ -1964,7 +1964,7 @@ show_fc_host_speed (struct device *dev,

         i->f->get_host_speed(shost);

     if (fc_host_speed(shost) == FC_PORTSPEED_UNKNOWN)

- return snprintf(buf, 20, "unknown\n");
+ return scnprintf(buf, 20, "unknown\n");

     return get_fc_port_speed_names(fc_host_speed(shost), buf);
 }
@@ -1997,7 +1997,7 @@ show_fc_private_host_tgtid_bind_type(struct device *dev,
     name = get_fc_tgtid_bind_type_name(fc_host_tgtid_bind_type(shost));
     if (!name)
         return -EINVAL;

- return snprintf(buf, FC_BINDTYPE_MAX_NAMELEN, "%s\n", name);
+ return scnprintf(buf, FC_BINDTYPE_MAX_NAMELEN, "%s\n", name);
}

#define get_list_head_entry(pos, head, member) \