Skip to contentSkip to conversation

platform/x86: asus-wmi: adjust screenpad power/brightness handling — regression on non-DUO ScreenPad (ASUS ZenBook UX435EG)

PATCH Denis Benato 1 participant 1 message Aug 2 1 message not in the archive x86 platform drivers

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CAOXykpggnwupch416dT4_pPygtb8CHjc7c21FGA+JQ--W7roZA@mail.gmail.com

#1 lore raw
Quoted 9 lines · Manuel A. R. de Orúe Ríos

Hi Denis, Luke,

I'm following up on this patch series (commit 034f5efd362fb87a3970d61eaf982664f84e6c5a, merged for kernel 7.0.10) — I believe I've found and confirmed a regression it introduces on non-DUO ScreenPad hardware.

Hardware: ASUS ZenBook UX435EG (BIOS UX435EG.315), single ScreenPad model (not ScreenPad Plus / DUO).

Hello Manuel,

Thanks for the report and additional information. Quite recently there has been another user with yet another model reporting a regression in this field:
https://lore.kernel.org/all/[email protected]/
and hopefully this is the same bug.

Quoted 10 lines

Symptom: after upgrading past kernel-7.0.9-205 to kernel-7.0.10-200 (and confirmed still present in 7.1.5), the ScreenPad stops functioning as a secondary display entirely — it still works as a touchpad (separate i2c-hid digitizer), but the panel itself never lights up as a screen.

I bisected this cleanly across official Fedora kernel builds:
  kernel-7.0.9-205.fc44   -> works kernel-7.0.10-200.fc44  -> broken kernel-7.1.5-201.fc44   -> still broken

Quoted 5 lines

Root cause, as far as I can tell: in update_screenpad_bl_status(), the new logic branches on bd->props.power being truthy/falsy, but in the backlight framework convention, props.power == 0 means ON (FB_BLANK_UNBLANK) and any non-zero value means OFF. The new code appears to have this inverted:

I don't think any non-zero value is meant to mean OFF but perhaps the kernel simply checks in various places !props.power for the status (?) I have found this:

#define BACKLIGHT_POWER_ON              (0)
#define BACKLIGHT_POWER_OFF             (4)

and that clears my question on "why 4 and not 1 if it's a simple bool?".

Quoted 17 lines

    if (ctrl_param >= 0 && bd->props.power) {
        err = asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, 1, NULL); // turns ON
        ...
    }
    if (!bd->props.power) {
        err = asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, 0, NULL); // turns OFF }

On my hardware, sysfs reports bl_power = 0 (which the kernel considers "ON"), but that's exactly the condition that triggers the branch sending SCREENPAD_POWER = 0 (off) via WMI — so the panel ends up physically powered off as a display, while sysfs still reports it as on at full brightness.

I confirmed this empirically: manually writing bl_power = 4 (which the framework considers "off") reliably turns the panel back on as a display on my hardware:

Quoted 7 lines

    echo 4 > /sys/class/backlight/asus_screenpad/bl_power

I understand from the review thread that this series was tested specifically on a ZenBook DUO — it's very possible the DUO's ScreenPad firmware/EC behaves differently enough that the polarity works out correctly there, while it's inverted on this single-ScreenPad model.

Honestly I am not that sure about the inversion: it looks like a mistake from me simplifying the Luke's original code and I highly hope this is the case or I will need to branch what gets set depending on the DMI.

Quoted 4 lines

Happy to test any proposed fix on this hardware, or provide more DMI/ACPI/ debug info if useful. I'm currently working around this with a udev-triggered script forcing bl_power=4 on boot, but would obviously prefer a proper fix.

Do you want a patch or are you fine with small edits?

My understanding is that switching in the two if:

bd->props.power with (bd->props.power == BACKLIGHT_POWER_ON)

and

!bd->props.power with (bd->props.power == BACKLIGHT_POWER_OFF)

the hardware should return working fine again.

Very likely I assumed "not power" as... "not power" when it was a shorthand for writing "power on".

Quoted 7 lines

Kernel/hardware details:
DMI: ASUSTeK COMPUTER INC. ZenBook UX435EG_UX435EG/UX435EG, BIOS UX435EG.315 04/22/2022
Distro: Fedora Linux 44 (KDE Plasma)

Thanks for the work on this — I know these ScreenPad quirks are a pain to get right across the different hardware variants.

Worry not, I will make it working again: I just need a few hints on these mystical objects.

Best regards,
Denis

Quoted 2 lines

Best,
___________________________