MAINTAINERS: Add Python scripts

PATCH In review Eduardo Habkost 3 participants 4 messages Sep 15, 2017 – Sep 18, 2017

lore

Share & tools

lore

Eduardo Habkost

author

2017-09-15 23:07 UTC #0 lore raw

PATCH 1/1 MAINTAINERS: Add Python scripts

Cleber and I are volunteering to review and queue patches for the Python scripts and modules in scripts/.

I'm setting "M: Odd fixes" because not all scripts are actively maintained.

Signed-off-by Eduardo Habkost <[email protected]>

---
Even before this patch is merged, I plan to send a pull request including some patches for the Python code soon.

---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

MAINTAINERS +7 -0

index 2c333aba21..2c3b8ecde7 100644
@@ -1390,6 +1390,13 @@ S: Maintained
 F: include/sysemu/cryptodev*.h
 F: backends/cryptodev*.c
 
+Python scripts
+M: Eduardo Habkost <[email protected]>
+M: Cleber Rosa <[email protected]>
+S: Odd fixes
+F: scripts/qmp/*
+F: scripts/*.py
+
 QAPI
 M: Markus Armbruster <[email protected]>
 M: Michael Roth <[email protected]>

Signature · 1 line

2.13.5

John Snow

2017-09-16 00:17 UTC #1 lore raw

Quoted 23 lines · Eduardo Habkost

Cleber and I are volunteering to review and queue patches for the Python scripts and modules in scripts/.
I'm setting "M: Odd fixes" because not all scripts are actively maintained.
Signed-off-by Eduardo Habkost <[email protected]>
---
Even before this patch is merged, I plan to send a pull request including some patches for the Python code soon.
---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)
MAINTAINERS +0 -0
index 2c333aba21..2c3b8ecde7 100644
@@ -1390,6 +1390,13 @@ S: Maintained
 F: include/sysemu/cryptodev*.h
 F: backends/cryptodev*.c
 

MAINTAINERS S: Maintained · line 1402

Quoted 10 lines

MAINTAINERS +7 -0

+Python scripts
+M: Eduardo Habkost <[email protected]>
+M: Cleber Rosa <[email protected]>
+S: Odd fixes
+F: scripts/qmp/*
+F: scripts/*.py
+
 QAPI
 M: Markus Armbruster <[email protected]>
 M: Michael Roth <[email protected]>

I rather like the thought of having dedicated Python maintainers who can review python code with an eye for what is idiomatic. I am fairly certain the python I write is functional, but I'm rarely sure it's what a python programmer would do.

I suppose you are intentionally omitting any python that exists as part of the test infrastructure, however?

John

Eduardo Habkost

author

2017-09-16 00:38 UTC #2 lore raw

Quoted 42 lines · John Snow

Quoted 23 lines · Eduardo Habkost
Cleber and I are volunteering to review and queue patches for the Python scripts and modules in scripts/.
I'm setting "M: Odd fixes" because not all scripts are actively maintained.
Signed-off-by Eduardo Habkost <[email protected]>
---
Even before this patch is merged, I plan to send a pull request including some patches for the Python code soon.
---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)
MAINTAINERS +0 -0
index 2c333aba21..2c3b8ecde7 100644
@@ -1390,6 +1390,13 @@ S: Maintained
 F: include/sysemu/cryptodev*.h
 F: backends/cryptodev*.c
 
MAINTAINERS S: Maintained · line 1402
Quoted 10 lines
MAINTAINERS +7 -0
+Python scripts
+M: Eduardo Habkost <[email protected]>
+M: Cleber Rosa <[email protected]>
+S: Odd fixes
+F: scripts/qmp/*
+F: scripts/*.py
+
 QAPI
 M: Markus Armbruster <[email protected]>
 M: Michael Roth <[email protected]>
I rather like the thought of having dedicated Python maintainers who can review python code with an eye for what is idiomatic. I am fairly certain the python I write is functional, but I'm rarely sure it's what a python programmer would do.

Quoted 2 lines

I suppose you are intentionally omitting any python that exists as part of the test infrastructure, however?

Initially, yes. I was trying to include only the stuff we were actively maintaining. But later I decided to use "S: Odd fixes" instead of "S: Maintained", so I guess it won't hurt to include this:

---

MAINTAINERS +2 -0

index 2c3b8ecde7..876ac0df99 100644
@@ -1396,6 +1396,8 @@ M: Cleber Rosa <[email protected]>
 S: Odd fixes
 F: scripts/qmp/*
 F: scripts/*.py
+F: tests/*.py
+K: #!.*python
 
 QAPI
 M: Markus Armbruster <[email protected]>

Signature · 1 line

Eduardo

Stefan Hajnoczi

Reviewed-by

2017-09-18 09:41 UTC #3 lore raw

Quoted 43 lines · Eduardo Habkost

Quoted 42 lines · John Snow
Quoted 23 lines · Eduardo Habkost
Cleber and I are volunteering to review and queue patches for the Python scripts and modules in scripts/.
I'm setting "M: Odd fixes" because not all scripts are actively maintained.
Signed-off-by Eduardo Habkost <[email protected]>
---
Even before this patch is merged, I plan to send a pull request including some patches for the Python code soon.
---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)
MAINTAINERS +0 -0
index 2c333aba21..2c3b8ecde7 100644
@@ -1390,6 +1390,13 @@ S: Maintained
 F: include/sysemu/cryptodev*.h
 F: backends/cryptodev*.c
 
MAINTAINERS S: Maintained · line 1402
Quoted 10 lines
MAINTAINERS +7 -0
+Python scripts
+M: Eduardo Habkost <[email protected]>
+M: Cleber Rosa <[email protected]>
+S: Odd fixes
+F: scripts/qmp/*
+F: scripts/*.py
+
 QAPI
 M: Markus Armbruster <[email protected]>
 M: Michael Roth <[email protected]>
I rather like the thought of having dedicated Python maintainers who can review python code with an eye for what is idiomatic. I am fairly certain the python I write is functional, but I'm rarely sure it's what a python programmer would do.

Quoted 8 lines

Quoted 2 lines
I suppose you are intentionally omitting any python that exists as part of the test infrastructure, however?
Initially, yes. I was trying to include only the stuff we were actively maintaining. But later I decided to use "S: Odd fixes" instead of "S: Maintained", so I guess it won't hurt to include this:

Reviewed-by Stefan Hajnoczi <[email protected]>