Skip to contentSkip to conversation

fbdev: modedb: Add a 1920x1080 at 60 Hz video mode

PATCH In review Helge Deller 2 participants 3 messages Apr 22, 2023 – May 12, 2023

Subsystems (2)
lore
Share & tools
lore

Helge Deller

author maintainer
#0 lore raw

PATCH 1/1 fbdev: modedb: Add a 1920x1080 at 60 Hz video mode

Add typical resolution for Full-HD monitors.

drivers/video/fbdev/core/modedb.c +4 -0
index 6473e0dfe146..90915a4caac6 100644
@@ -257,6 +257,10 @@ static const struct fb_videomode modedb[] = {
 	{ NULL, 72, 480, 300, 33386, 40, 24, 11, 19, 80, 3, 0,
 		FB_VMODE_DOUBLE },
 
+	/* 1920x1080 @ 60 Hz, 67.3 kHz hsync */
+	{ NULL, 60, 1920, 1080, 6734, 148, 88, 63, 4, 44, 5, 0,
+		FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT },
+
 	/* 1920x1200 @ 60 Hz, 74.5 Khz hsync */
 	{ NULL, 60, 1920, 1200, 5177, 128, 336, 1, 38, 208, 3,
 		FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
#1 lore raw

Hi Helge,

drivers/video/fbdev/core/modedb.c static const struct fb_videomode modedb[] = { · line 262

Quoted 13 lines · Helge Deller

Add typical resolution for Full-HD monitors.

drivers/video/fbdev/core/modedb.c +3 -0
@@ -257,6 +257,10 @@ static const struct fb_videomode modedb[] = {
        { NULL, 72, 480, 300, 33386, 40, 24, 11, 19, 80, 3, 0,
                FB_VMODE_DOUBLE },
 
+       /* 1920x1080 @ 60 Hz, 67.3 kHz hsync */
+       { NULL, 60, 1920, 1080, 6734, 148, 88, 63, 4, 44, 5, 0,
+               FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT },

This matches [1], except for the "63", which looks like a typo for "36" (total number of lines should be 1125, not 1152).

drivers/video/fbdev/core/modedb.c static const struct fb_videomode modedb[] = { · line 266

Quoted 4 lines
drivers/video/fbdev/core/modedb.c +1 -0
+
        /* 1920x1200 @ 60 Hz, 74.5 Khz hsync */
        { NULL, 60, 1920, 1200, 5177, 128, 336, 1, 38, 208, 3,
                FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,

[1] https://projectf.io/posts/video-timings-vga-720p-1080p/#hd-1920x1080-60-hz

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
author maintainer
#2 lore raw
Quoted 13 lines · Geert Uytterhoeven

Hi Helge,

Quoted 10 lines · Helge Deller

Add typical resolution for Full-HD monitors.

drivers/video/fbdev/core/modedb.c +0 -0
@@ -257,6 +257,10 @@ static const struct fb_videomode modedb[] = {
         { NULL, 72, 480, 300, 33386, 40, 24, 11, 19, 80, 3, 0,
                 FB_VMODE_DOUBLE },
 
Quoted 6 lines

drivers/video/fbdev/core/modedb.c static const struct fb_videomode modedb[] = { · line 262

Quoted 3 lines
drivers/video/fbdev/core/modedb.c +3 -0
+       /* 1920x1080 @ 60 Hz, 67.3 kHz hsync */
+       { NULL, 60, 1920, 1080, 6734, 148, 88, 63, 4, 44, 5, 0,
+               FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT },

This matches [1], except for the "63", which looks like a typo for "36" (total number of lines should be 1125, not 1152).

Thanks Geert!

I fixed it in the git tree.

Helge

Quoted 12 lines

drivers/video/fbdev/core/modedb.c static const struct fb_videomode modedb[] = { · line 266

Quoted 5 lines
drivers/video/fbdev/core/modedb.c +1 -0
+
         /* 1920x1200 @ 60 Hz, 74.5 Khz hsync */
         { NULL, 60, 1920, 1200, 5177, 128, 336, 1, 38, 208, 3,
                 FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,

[1] https://projectf.io/posts/video-timings-vga-720p-1080p/#hd-1920x1080-60-hz

Gr{oetje,eeting}s,

Geert