Disable K3_SYSTEM_CONTROLLER on K3 Arm64 cores
cover Disable K3_SYSTEM_CONTROLLER on K3 Arm64 cores
Hi Lokesh, Tom,
The K3 System Controller remoteproc driver is only needed on R5 SPL, and need not be enabled or built for the K3 Arm64 U-Boot/SPL targets. The following 2 patches are minor cleanup patches disabling the same for K3 Arm64 U-boot/SPL targets on both AM65x and J721E SoCs.
regards
Suman
Suman Anna (2):
configs: am65x_evm_a53: Disable K3_SYSTEM_CONTROLLER
configs: j721e_evm_a72: Disable K3_SYSTEM_CONTROLLER
configs/am65x_evm_a53_defconfig | 3 --- configs/am65x_hs_evm_a53_defconfig | 3 --- configs/j721e_evm_a72_defconfig | 3 --- 3 files changed, 9 deletions(-)
Signature · 1 line
2.22.0
PATCH 1/2 configs: am65x_evm_a53: Disable K3_SYSTEM_CONTROLLER
The K3 System Controller driver is used for loading and starting the System Firmware, and is used only on R5 SPL. It need not be enabled and built for the A53 U-Boot and SPL, so disable it from both the GP and HS AM65x A53 defconfigs.
While at this, also remove the unneeded CONFIG_SPL_REMOTEPROC and CONFIG_CMD_REMOTEPROC as no remoteprocs are now loaded from A53 SPL.
--- configs/am65x_evm_a53_defconfig | 3 --- configs/am65x_hs_evm_a53_defconfig | 3 --- 2 files changed, 6 deletions(-)
configs/am65x_evm_a53_defconfig +0 -3
@@ -28,14 +28,12 @@ CONFIG_SPL_I2C_SUPPORT=y CONFIG_SPL_DM_MAILBOX=y CONFIG_SPL_DM_RESET=y CONFIG_SPL_POWER_DOMAIN=y -CONFIG_SPL_REMOTEPROC=y CONFIG_SPL_YMODEM_SUPPORT=y CONFIG_CMD_ASKENV=y # CONFIG_CMD_FLASH is not set CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y -CONFIG_CMD_REMOTEPROC=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_TIME=y # CONFIG_ISO_PARTITION is not set
@@ -79,7 +77,6 @@ CONFIG_SPL_PINCTRL=y CONFIG_PINCTRL_SINGLE=y CONFIG_POWER_DOMAIN=y CONFIG_TI_SCI_POWER_DOMAIN=y -CONFIG_K3_SYSTEM_CONTROLLER=y CONFIG_DM_RESET=y CONFIG_RESET_TI_SCI=y CONFIG_DM_SERIAL=y
configs/am65x_hs_evm_a53_defconfig +0 -3
@@ -31,13 +31,11 @@ CONFIG_SPL_I2C_SUPPORT=y CONFIG_SPL_DM_MAILBOX=y CONFIG_SPL_DM_RESET=y CONFIG_SPL_POWER_DOMAIN=y -CONFIG_SPL_REMOTEPROC=y CONFIG_SPL_YMODEM_SUPPORT=y CONFIG_CMD_ASKENV=y # CONFIG_CMD_FLASH is not set CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y -CONFIG_CMD_REMOTEPROC=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_TIME=y # CONFIG_ISO_PARTITION is not set
@@ -76,7 +74,6 @@ CONFIG_SPL_PINCTRL=y CONFIG_PINCTRL_SINGLE=y CONFIG_POWER_DOMAIN=y CONFIG_TI_SCI_POWER_DOMAIN=y -CONFIG_K3_SYSTEM_CONTROLLER=y CONFIG_DM_RESET=y CONFIG_RESET_TI_SCI=y CONFIG_DM_SERIAL=y
Signature · 1 line
2.22.0
PATCH 1/2 configs: am65x_evm_a53: Disable K3_SYSTEM_CONTROLLER
Quoted 20 lines · Suman Anna
The K3 System Controller driver is used for loading and starting the System Firmware, and is used only on R5 SPL. It need not be enabled and built for the A53 U-Boot and SPL, so disable it from both the GP and HS AM65x A53 defconfigs.
While at this, also remove the unneeded
CONFIG_SPL_REMOTEPROCandCONFIG_CMD_REMOTEPROCas no remoteprocs are now loaded from A53 SPL.Signed-off-by Suman Anna <[email protected]>--- configs/am65x_evm_a53_defconfig | 3 --- configs/am65x_hs_evm_a53_defconfig | 3 --- 2 files changed, 6 deletions(-)configs/am65x_evm_a53_defconfig +0
-0@@ -28,14 +28,12 @@ CONFIG_SPL_I2C_SUPPORT=y CONFIG_SPL_DM_MAILBOX=y
configs/am65x_evm_a53_defconfig CONFIG_SPL_I2C_SUPPORT=y · line 38
Quoted 10 lines
configs/am65x_evm_a53_defconfig +0
-2CONFIG_SPL_DM_RESET=y CONFIG_SPL_POWER_DOMAIN=y -CONFIG_SPL_REMOTEPROC=y CONFIG_SPL_YMODEM_SUPPORT=y CONFIG_CMD_ASKENV=y # CONFIG_CMD_FLASH is not set CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y -CONFIG_CMD_REMOTEPROC=y
CMD_REMOTEPROC will definitely be used in very near future. Please retain this. Rest looks good to me.
Thanks and regards,
Lokesh
Quoted 38 lines
configs/am65x_evm_a53_defconfig +0
-1# CONFIG_CMD_SETEXPR is not set CONFIG_CMD_TIME=y # CONFIG_ISO_PARTITION is not set@@ -79,7 +77,6 @@ CONFIG_SPL_PINCTRL=y CONFIG_PINCTRL_SINGLE=y CONFIG_POWER_DOMAIN=y CONFIG_TI_SCI_POWER_DOMAIN=y -CONFIG_K3_SYSTEM_CONTROLLER=y CONFIG_DM_RESET=y CONFIG_RESET_TI_SCI=y CONFIG_DM_SERIAL=yconfigs/am65x_hs_evm_a53_defconfig +0
-3@@ -31,13 +31,11 @@ CONFIG_SPL_I2C_SUPPORT=y CONFIG_SPL_DM_MAILBOX=y CONFIG_SPL_DM_RESET=y CONFIG_SPL_POWER_DOMAIN=y -CONFIG_SPL_REMOTEPROC=y CONFIG_SPL_YMODEM_SUPPORT=y CONFIG_CMD_ASKENV=y # CONFIG_CMD_FLASH is not set CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y -CONFIG_CMD_REMOTEPROC=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_TIME=y # CONFIG_ISO_PARTITION is not set@@ -76,7 +74,6 @@ CONFIG_SPL_PINCTRL=y CONFIG_PINCTRL_SINGLE=y CONFIG_POWER_DOMAIN=y CONFIG_TI_SCI_POWER_DOMAIN=y -CONFIG_K3_SYSTEM_CONTROLLER=y CONFIG_DM_RESET=y CONFIG_RESET_TI_SCI=y CONFIG_DM_SERIAL=y
PATCH 1/2 configs: am65x_evm_a53: Disable K3_SYSTEM_CONTROLLER
Hi Lokesh,
Quoted 28 lines · Lokesh Vutla
Quoted 25 lines · Suman Anna
The K3 System Controller driver is used for loading and starting the System Firmware, and is used only on R5 SPL. It need not be enabled and built for the A53 U-Boot and SPL, so disable it from both the GP and HS AM65x A53 defconfigs.
While at this, also remove the unneeded
CONFIG_SPL_REMOTEPROCandCONFIG_CMD_REMOTEPROCas no remoteprocs are now loaded from A53 SPL.Signed-off-by Suman Anna <[email protected]>--- configs/am65x_evm_a53_defconfig | 3 --- configs/am65x_hs_evm_a53_defconfig | 3 --- 2 files changed, 6 deletions(-)configs/am65x_evm_a53_defconfig +0
-1@@ -28,14 +28,12 @@ CONFIG_SPL_I2C_SUPPORT=y CONFIG_SPL_DM_MAILBOX=y CONFIG_SPL_DM_RESET=y CONFIG_SPL_POWER_DOMAIN=y -CONFIG_SPL_REMOTEPROC=y CONFIG_SPL_YMODEM_SUPPORT=y CONFIG_CMD_ASKENV=y
Quoted 8 lines
configs/am65x_evm_a53_defconfig CONFIG_SPL_I2C_SUPPORT=y · line 38
Quoted 5 lines
configs/am65x_evm_a53_defconfig +0
-1# CONFIG_CMD_FLASH is not set CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y -CONFIG_CMD_REMOTEPROC=y
CMD_REMOTEPROCwill definitely be used in very near future. Please retain this. Rest looks good to me.
This is a result of using savedefconfig, I prefer it this way since it allows other developers adding options to do it cleanly. If and when a REMOTEPROC is enabled, the savedefconfig with corresponding options should automatically bring this back.
regards
Suman
Quoted 42 lines
Thanks and regards,
LokeshQuoted 38 lines
configs/am65x_evm_a53_defconfig +0
-1# CONFIG_CMD_SETEXPR is not set CONFIG_CMD_TIME=y # CONFIG_ISO_PARTITION is not set@@ -79,7 +77,6 @@ CONFIG_SPL_PINCTRL=y CONFIG_PINCTRL_SINGLE=y CONFIG_POWER_DOMAIN=y CONFIG_TI_SCI_POWER_DOMAIN=y -CONFIG_K3_SYSTEM_CONTROLLER=y CONFIG_DM_RESET=y CONFIG_RESET_TI_SCI=y CONFIG_DM_SERIAL=yconfigs/am65x_hs_evm_a53_defconfig +0
-3@@ -31,13 +31,11 @@ CONFIG_SPL_I2C_SUPPORT=y CONFIG_SPL_DM_MAILBOX=y CONFIG_SPL_DM_RESET=y CONFIG_SPL_POWER_DOMAIN=y -CONFIG_SPL_REMOTEPROC=y CONFIG_SPL_YMODEM_SUPPORT=y CONFIG_CMD_ASKENV=y # CONFIG_CMD_FLASH is not set CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y -CONFIG_CMD_REMOTEPROC=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_TIME=y # CONFIG_ISO_PARTITION is not set@@ -76,7 +74,6 @@ CONFIG_SPL_PINCTRL=y CONFIG_PINCTRL_SINGLE=y CONFIG_POWER_DOMAIN=y CONFIG_TI_SCI_POWER_DOMAIN=y -CONFIG_K3_SYSTEM_CONTROLLER=y CONFIG_DM_RESET=y CONFIG_RESET_TI_SCI=y CONFIG_DM_SERIAL=y
PATCH 1/2 configs: am65x_evm_a53: Disable K3_SYSTEM_CONTROLLER
Quoted 40 lines · Suman Anna
Hi Lokesh,
Quoted 28 lines · Lokesh Vutla
Quoted 25 lines · Suman Anna
The K3 System Controller driver is used for loading and starting the System Firmware, and is used only on R5 SPL. It need not be enabled and built for the A53 U-Boot and SPL, so disable it from both the GP and HS AM65x A53 defconfigs.
While at this, also remove the unneeded
CONFIG_SPL_REMOTEPROCandCONFIG_CMD_REMOTEPROCas no remoteprocs are now loaded from A53 SPL.Signed-off-by Suman Anna <[email protected]>--- configs/am65x_evm_a53_defconfig | 3 --- configs/am65x_hs_evm_a53_defconfig | 3 --- 2 files changed, 6 deletions(-)configs/am65x_evm_a53_defconfig +0
-1@@ -28,14 +28,12 @@ CONFIG_SPL_I2C_SUPPORT=y CONFIG_SPL_DM_MAILBOX=y CONFIG_SPL_DM_RESET=y CONFIG_SPL_POWER_DOMAIN=y -CONFIG_SPL_REMOTEPROC=y CONFIG_SPL_YMODEM_SUPPORT=y CONFIG_CMD_ASKENV=yQuoted 8 lines
configs/am65x_evm_a53_defconfig CONFIG_SPL_I2C_SUPPORT=y · line 38
Quoted 5 lines
configs/am65x_evm_a53_defconfig +0
-1# CONFIG_CMD_FLASH is not set CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y -CONFIG_CMD_REMOTEPROC=y
CMD_REMOTEPROCwill definitely be used in very near future. Please retain this. Rest looks good to me.
Quoted 4 lines
This is a result of using savedefconfig, I prefer it this way since it allows other developers adding options to do it cleanly. If and when a REMOTEPROC is enabled, the savedefconfig with corresponding options should automatically bring this back.
Indeed, if savedefconfig is taking it out, it's not being built today OR it's already default y and being built.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190730/dfbd5887/attachment.sig>
PATCH 1/2 configs: am65x_evm_a53: Disable K3_SYSTEM_CONTROLLER
Quoted 41 lines · Tom Rini
Quoted 40 lines · Suman Anna
Hi Lokesh,
Quoted 36 lines · Lokesh Vutla
Quoted 20 lines · Suman Anna
The K3 System Controller driver is used for loading and starting the System Firmware, and is used only on R5 SPL. It need not be enabled and built for the A53 U-Boot and SPL, so disable it from both the GP and HS AM65x A53 defconfigs.
While at this, also remove the unneeded
CONFIG_SPL_REMOTEPROCandCONFIG_CMD_REMOTEPROCas no remoteprocs are now loaded from A53 SPL.Signed-off-by Suman Anna <[email protected]>--- configs/am65x_evm_a53_defconfig | 3 --- configs/am65x_hs_evm_a53_defconfig | 3 --- 2 files changed, 6 deletions(-)configs/am65x_evm_a53_defconfig +0
-0@@ -28,14 +28,12 @@ CONFIG_SPL_I2C_SUPPORT=y CONFIG_SPL_DM_MAILBOX=yconfigs/am65x_evm_a53_defconfig CONFIG_SPL_I2C_SUPPORT=y · line 38
Quoted 10 lines
configs/am65x_evm_a53_defconfig +0
-2CONFIG_SPL_DM_RESET=y CONFIG_SPL_POWER_DOMAIN=y -CONFIG_SPL_REMOTEPROC=y CONFIG_SPL_YMODEM_SUPPORT=y CONFIG_CMD_ASKENV=y # CONFIG_CMD_FLASH is not set CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y -CONFIG_CMD_REMOTEPROC=y
CMD_REMOTEPROCwill definitely be used in very near future. Please retain this. Rest looks good to me.
Quoted 8 lines
Quoted 4 lines
This is a result of using savedefconfig, I prefer it this way since it allows other developers adding options to do it cleanly. If and when a REMOTEPROC is enabled, the savedefconfig with corresponding options should automatically bring this back.
Indeed, if savedefconfig is taking it out, it's not being built today OR it's already default y and being built.
ohh okay. I didn't know it was a result of savedefconfig as you mentioned it is explicitly removed. Patch as such looks good to me.
Thanks and regards,
Lokesh
PATCH 1/2 configs: am65x_evm_a53: Disable K3_SYSTEM_CONTROLLER
In reply to Suman AnnaQuoted 10 lines · Suman Anna
The K3 System Controller driver is used for loading and starting the System Firmware, and is used only on R5 SPL. It need not be enabled and built for the A53 U-Boot and SPL, so disable it from both the GP and HS AM65x A53 defconfigs.
While at this, also remove the unneeded
CONFIG_SPL_REMOTEPROCandCONFIG_CMD_REMOTEPROCas no remoteprocs are now loaded from A53 SPL.Signed-off-by Suman Anna <[email protected]>Reviewed-by Lokesh Vutla <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190731/b4725eb7/attachment.sig>
PATCH 2/2 configs: j721e_evm_a72: Disable K3_SYSTEM_CONTROLLER
In reply to Suman AnnaThe K3 System Controller driver is used for loading and starting the System Firmware, and is used only on R5 SPL. It need not be enabled and built for the A72 U-Boot and SPL, so disable it from the j721e_evm_a72 defconfig.
While at this, also remove the unneeded CONFIG_SPL_REMOTEPROC and CONFIG_CMD_REMOTEPROC as no remoteprocs are now loaded from A72 SPL.
--- configs/j721e_evm_a72_defconfig | 3 --- 1 file changed, 3 deletions(-)
configs/j721e_evm_a72_defconfig +0 -3
@@ -28,13 +28,11 @@ CONFIG_SPL_DM_MAILBOX=y CONFIG_SPL_DM_RESET=y CONFIG_SPL_POWER_SUPPORT=y CONFIG_SPL_POWER_DOMAIN=y -CONFIG_SPL_REMOTEPROC=y CONFIG_SPL_SPI_LOAD=y CONFIG_SPL_YMODEM_SUPPORT=y CONFIG_CMD_ASKENV=y # CONFIG_CMD_FLASH is not set CONFIG_CMD_MMC=y -CONFIG_CMD_REMOTEPROC=y CONFIG_CMD_SF=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_TIME=y
@@ -73,7 +71,6 @@ CONFIG_SPL_PINCTRL=y CONFIG_PINCTRL_SINGLE=y CONFIG_POWER_DOMAIN=y CONFIG_TI_SCI_POWER_DOMAIN=y -CONFIG_K3_SYSTEM_CONTROLLER=y CONFIG_DM_RESET=y CONFIG_RESET_TI_SCI=y CONFIG_DM_SERIAL=y
Signature · 1 line
2.22.0
PATCH 2/2 configs: j721e_evm_a72: Disable K3_SYSTEM_CONTROLLER
Quoted 9 lines · Suman Anna
The K3 System Controller driver is used for loading and starting the System Firmware, and is used only on R5 SPL. It need not be enabled and built for the A72 U-Boot and SPL, so disable it from the
j721e_evm_a72defconfig.While at this, also remove the unneeded
CONFIG_SPL_REMOTEPROCandCONFIG_CMD_REMOTEPROCas no remoteprocs are now loaded from A72 SPL.Signed-off-by Suman Anna <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190731/8eb6b8cc/attachment.sig>