Skip to contentSkip to conversation

drop memory-hotplug on superH

DISCUSSION Oscar Salvador 3 participants 3 messages May 16, 2024 – May 17, 2024 SuperH

lore
Share & tools
lore
#0 lore raw

Hi,

After talking to Adrian Glaubitz about superH and memory-hotplug, he mentioned that currently superH runs only on 32bits (there was a 64bit version but no is longer supported?).
The thing is that since the below commit

commit 7ec58a2b941ed88986694d037e38012738323171
Author: David Hildenbrand <[email protected]>
Date: Fri Nov 5 13:44:28 2021 -0700

mm/memory_hotplug: restrict CONFIG_MEMORY_HOTPLUG to 64 bit

we no longer support memory-hotplug on 32bit platforms, so let us drop the memory-hotplug code for superH because it is a no-op at the moment. If there is ever a 64bit platform again, we shall re-implement it, and we shall do it on CONFIG_SPARSEMEM_VMEMMAP, since we plan do make memory-hotplug dependant on that, and drop support for CONFIG_SPARSEMEM && !CONFIG_SPARSEMEM_VMEMMAP environments.

I prepared two patches at [1] that drop the code and the CONFIG_MEMORY_HOTPLUG_foo from the Kconfigs.

Let me know if you are fine with that and I shall send it.

Thanks

[1] https://github.com/leberus/linux/tree/deprecate-memhotplug-sh

Signature · 2 lines
Oscar Salvador
SUSE Labs
#1 lore raw
Quoted 22 lines · Oscar Salvador

Hi,

After talking to Adrian Glaubitz about superH and memory-hotplug, he mentioned that currently superH runs only on 32bits (there was a 64bit version but no is longer supported?).
The thing is that since the below commit

commit 7ec58a2b941ed88986694d037e38012738323171
Author: David Hildenbrand <[email protected]>
Date: Fri Nov 5 13:44:28 2021 -0700

mm/memory_hotplug: restrict CONFIG_MEMORY_HOTPLUG to 64 bit

we no longer support memory-hotplug on 32bit platforms, so let us drop the memory-hotplug code for superH because it is a no-op at the moment. If there is ever a 64bit platform again, we shall re-implement it, and we shall do it on CONFIG_SPARSEMEM_VMEMMAP, since we plan do make memory-hotplug dependant on that, and drop support for CONFIG_SPARSEMEM && !CONFIG_SPARSEMEM_VMEMMAP environments.

Quoted 5 lines

I prepared two patches at [1] that drop the code and the CONFIG_MEMORY_HOTPLUG_foo from the Kconfigs.

Let me know if you are fine with that and I shall send it.

Sounds good, let's rip it out.

Thanks!

Signature · 3 lines
Cheers,

David / dhildenb
#2 lore raw
In reply to Oscar Salvador

On May 17, 2024, at 05:25, Oscar Salvador <[email protected]> wrote:

Agree

Quoted 6 lines

we no longer support memory-hotplug on 32bit platforms, so let us drop the memory-hotplug code for superH because it is a no-op at the moment. If there is ever a 64bit platform again, we shall re-implement it, and we shall do it on CONFIG_SPARSEMEM_VMEMMAP, since we plan do make memory-hotplug dependant on that, and drop support for CONFIG_SPARSEMEM && !CONFIG_SPARSEMEM_VMEMMAP environments.