Skip to contentSkip to conversation

selftests: forwarding: skip if kernel not support setting bridge fdb learning limit

PATCH Applied Hangbin Liu 5 participants 6 messages Jul 23, 2024 – Jul 24, 2024

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests: forwarding: skip if kernel not support setting bridge fdb learning limit

If the testing kernel doesn't support setting fdb_max_learned or show fdb_n_learned, just skip it. Or we will get errors like

./bridge_fdb_learning_limit.sh: line 218: [: null: integer expression expected ./bridge_fdb_learning_limit.sh: line 225: [: null: integer expression expected

Fixes 6f84090333bb ("selftests: forwarding: bridge_fdb_learning_limit: Add a new selftest")
---
 .../forwarding/bridge_fdb_learning_limit.sh    | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
tools/testing/selftests/net/forwarding/bridge_fdb_learning_limit.sh +18 -0
index 0760a34b7114..a21b7085da2e 100755
@@ -178,6 +178,22 @@ fdb_del()
 	check_err $? "Failed to remove a FDB entry of type ${type}"
 }
 
+check_fdb_n_learned_support()
+{
+	if ! ip link help bridge 2>&1 | grep -q "fdb_max_learned"; then
+		echo "SKIP: iproute2 too old, missing bridge max learned support"
+		exit $ksft_skip
+	fi
+
+	ip link add dev br0 type bridge
+	local learned=$(fdb_get_n_learned)
+	ip link del dev br0
+	if [ "$learned" == "null" ]; then
+		echo "SKIP: kernel too old; bridge fdb_n_learned feature not supported."
+		exit $ksft_skip
+	fi
+}
+
 check_accounting_one_type()
 {
 	local type=$1 is_counted=$2 overrides_learned=$3
@@ -274,6 +290,8 @@ check_limit()
 	done
 }
 
+check_fdb_n_learned_support
+
 trap cleanup EXIT
 
 setup_prepare
Signature · 1 line
2.45.0
#1 lore raw
Quoted 40 lines · Hangbin Liu

If the testing kernel doesn't support setting fdb_max_learned or show fdb_n_learned, just skip it. Or we will get errors like

./bridge_fdb_learning_limit.sh: line 218: [: null: integer expression expected ./bridge_fdb_learning_limit.sh: line 225: [: null: integer expression expected

Fixes 6f84090333bb ("selftests: forwarding: bridge_fdb_learning_limit: Add a new selftest")
---
 .../forwarding/bridge_fdb_learning_limit.sh    | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
tools/testing/selftests/net/forwarding/bridge_fdb_learning_limit.sh +16 -0
index 0760a34b7114..a21b7085da2e 100755
@@ -178,6 +178,22 @@ fdb_del()
 	check_err $? "Failed to remove a FDB entry of type ${type}"
 }
 
+check_fdb_n_learned_support()
+{
+	if ! ip link help bridge 2>&1 | grep -q "fdb_max_learned"; then
+		echo "SKIP: iproute2 too old, missing bridge max learned support"
+		exit $ksft_skip
+	fi
+
+	ip link add dev br0 type bridge
+	local learned=$(fdb_get_n_learned)
+	ip link del dev br0
+	if [ "$learned" == "null" ]; then
+		echo "SKIP: kernel too old; bridge fdb_n_learned feature not supported."
+		exit $ksft_skip
+	fi
+}
+
 check_accounting_one_type()
 {
 	local type=$1 is_counted=$2 overrides_learned=$3

tools/testing/selftests/net/forwarding/bridge_fdb_learning_limit.sh check_limit() · line 297

Quoted 8 lines
tools/testing/selftests/net/forwarding/bridge_fdb_learning_limit.sh +2 -0
@@ -274,6 +290,8 @@ check_limit()
 	done
 }
 
+check_fdb_n_learned_support
+
 trap cleanup EXIT
 
 setup_prepare

Isn't the selftest supposed to be added after the feature was included?

I don't understand why this one is special, we should have the same issue with all new features.

maintainer
#2 lore raw
Quoted 48 lines · Nikolay Aleksandrov
Quoted 47 lines · Hangbin Liu

If the testing kernel doesn't support setting fdb_max_learned or show fdb_n_learned, just skip it. Or we will get errors like

./bridge_fdb_learning_limit.sh: line 218: [: null: integer expression expected ./bridge_fdb_learning_limit.sh: line 225: [: null: integer expression expected

Fixes 6f84090333bb ("selftests: forwarding: bridge_fdb_learning_limit: Add a new selftest")
---
  .../forwarding/bridge_fdb_learning_limit.sh    | 18 ++++++++++++++++++
  1 file changed, 18 insertions(+)
tools/testing/selftests/net/forwarding/bridge_fdb_learning_limit.sh +18 -0
index 0760a34b7114..a21b7085da2e 100755
@@ -178,6 +178,22 @@ fdb_del()
  	check_err $? "Failed to remove a FDB entry of type ${type}"
  }
 
+check_fdb_n_learned_support()
+{
+	if ! ip link help bridge 2>&1 | grep -q "fdb_max_learned"; then
+		echo "SKIP: iproute2 too old, missing bridge max learned support"
+		exit $ksft_skip
+	fi
+
+	ip link add dev br0 type bridge
+	local learned=$(fdb_get_n_learned)
+	ip link del dev br0
+	if [ "$learned" == "null" ]; then
+		echo "SKIP: kernel too old; bridge fdb_n_learned feature not supported."
+		exit $ksft_skip
+	fi
+}
+
  check_accounting_one_type()
  {
  	local type=$1 is_counted=$2 overrides_learned=$3
@@ -274,6 +290,8 @@ check_limit()
  	done
  }
 
+check_fdb_n_learned_support
+
  trap cleanup EXIT
 
Quoted 6 lines

tools/testing/selftests/net/forwarding/bridge_fdb_learning_limit.sh check_limit() · line 297

Quoted 1 line
tools/testing/selftests/net/forwarding/bridge_fdb_learning_limit.sh +0 -0
  setup_prepare

Isn't the selftest supposed to be added after the feature was included?

I don't understand why this one is special, we should have the same issue with all new features.

I must admit I was surprised when I learned the fact, but the stable team routinely runs up2date upstream self-tests on top of stable/older kernels:

https://lore.kernel.org/mptcp/[email protected]/

The expected self-test design is to probe the tested feature and skip if not available in the running kernel. The self-test should not break when run on an older kernel not offering such feature.

I understand some (most?) of the self-tests do not cope with the above perfectly, but we can improve ;).

Thanks,

Paolo

#3 lore raw
Quoted 59 lines · Paolo Abeni
Quoted 49 lines · Nikolay Aleksandrov
Quoted 39 lines · Hangbin Liu

If the testing kernel doesn't support setting fdb_max_learned or show fdb_n_learned, just skip it. Or we will get errors like

./bridge_fdb_learning_limit.sh: line 218: [: null: integer expression expected ./bridge_fdb_learning_limit.sh: line 225: [: null: integer expression expected

Fixes 6f84090333bb ("selftests: forwarding: bridge_fdb_learning_limit: Add a new selftest")

---
  .../forwarding/bridge_fdb_learning_limit.sh    | 18 ++++++++++++++++++

  1 file changed, 18 insertions(+)
tools/testing/selftests/net/forwarding/bridge_fdb_learning_limit.sh +0 -0
index 0760a34b7114..a21b7085da2e 100755
@@ -178,6 +178,22 @@ fdb_del()

      check_err $? "Failed to remove a FDB entry of type ${type}" }
  +check_fdb_n_learned_support()

tools/testing/selftests/net/forwarding/bridge_fdb_learning_limit.sh +15 -0
+{
+    if ! ip link help bridge 2>&1 | grep -q "fdb_max_learned"; then
+        echo "SKIP: iproute2 too old, missing bridge max learned support"
+        exit $ksft_skip
+    fi
+
+    ip link add dev br0 type bridge
+    local learned=$(fdb_get_n_learned)
+    ip link del dev br0
+    if [ "$learned" == "null" ]; then
+        echo "SKIP: kernel too old; bridge fdb_n_learned feature not supported."
+        exit $ksft_skip
+    fi
+}
+

  check_accounting_one_type()
  {
      local type=$1 is_counted=$2 overrides_learned=$3

tools/testing/selftests/net/forwarding/bridge_fdb_learning_limit.sh +0 -0
@@ -274,6 +290,8 @@ check_limit()
Quoted 6 lines

      done
  }
  +check_fdb_n_learned_support
+
  trap cleanup EXIT
    setup_prepare

Isn't the selftest supposed to be added after the feature was included?

Quoted 2 lines

I don't understand why this one is special, we should have the same issue with all new features.

I must admit I was surprised when I learned the fact, but the stable team routinely runs up2date upstream self-tests on top of stable/older kernels:

https://lore.kernel.org/mptcp/[email protected]/

Quoted 9 lines

The expected self-test design is to probe the tested feature and skip if not available in the running kernel. The self-test should not break when run on an older kernel not offering such feature.

I understand some (most?) of the self-tests do not cope with the above perfectly, but we can improve ;).

Thanks,

Paolo

Interesting, and unexpected at least for me. :) But okay, I'll keep it in mind when sending/reviewing patches.

Thanks!

For the patch:

Reviewed-by on v1 1/1
#4 lore raw
In reply to Hangbin Liu
Quoted 50 lines · Hangbin Liu

If the testing kernel doesn't support setting fdb_max_learned or show fdb_n_learned, just skip it. Or we will get errors like

./bridge_fdb_learning_limit.sh: line 218: [: null: integer expression expected ./bridge_fdb_learning_limit.sh: line 225: [: null: integer expression expected

Fixes 6f84090333bb ("selftests: forwarding: bridge_fdb_learning_limit: Add a new selftest")
---
 .../forwarding/bridge_fdb_learning_limit.sh    | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
tools/testing/selftests/net/forwarding/bridge_fdb_learning_limit.sh +18 -0
index 0760a34b7114..a21b7085da2e 100755
@@ -178,6 +178,22 @@ fdb_del()
 	check_err $? "Failed to remove a FDB entry of type ${type}"
 }
 
+check_fdb_n_learned_support()
+{
+	if ! ip link help bridge 2>&1 | grep -q "fdb_max_learned"; then
+		echo "SKIP: iproute2 too old, missing bridge max learned support"
+		exit $ksft_skip
+	fi
+
+	ip link add dev br0 type bridge
+	local learned=$(fdb_get_n_learned)
+	ip link del dev br0
+	if [ "$learned" == "null" ]; then
+		echo "SKIP: kernel too old; bridge fdb_n_learned feature not supported."
+		exit $ksft_skip
+	fi
+}
+
 check_accounting_one_type()
 {
 	local type=$1 is_counted=$2 overrides_learned=$3
@@ -274,6 +290,8 @@ check_limit()
 	done
 }
 
+check_fdb_n_learned_support
+
 trap cleanup EXIT
 
 setup_prepare
Signature · 1 line
2.45.0

Thanks for the fix. I also assumed that it's fine to depend on new features after trying to find out how those feature tests are usually done from the surrounding tests and their history.

The code looks right to me, and seems to behave as expected when feeding it data with and without fdb_n_learned.

#5 lore raw
In reply to Hangbin Liu
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

Quoted 10 lines · On Tue, 23 Jul 2024 16:22:52 +0800 you wrote:

If the testing kernel doesn't support setting fdb_max_learned or show fdb_n_learned, just skip it. Or we will get errors like

./bridge_fdb_learning_limit.sh: line 218: [: null: integer expression expected ./bridge_fdb_learning_limit.sh: line 225: [: null: integer expression expected

Fixes 6f84090333bb ("selftests: forwarding: bridge_fdb_learning_limit: Add a new selftest")

[...]

Here is the summary with links:
- [net] selftests: forwarding: skip if kernel not support setting bridge fdb learning limit

    https://git.kernel.org/netdev/net/c/863ff546fb62

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html