Skip to contentSkip to conversation

iommu: simplify init function

PATCH In review Heiner Kallweit 1 participant 1 message Jun 28, 2016 IOMMU

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 iommu: simplify init function

iommu_group_ida and iommu_group_mutex can be initialized statically. There's no need to do this dynamically in the init function.

---
 drivers/iommu/iommu.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/iommu/iommu.c +2 -5
index 3000051..debce45 100644
@@ -34,8 +34,8 @@
 #include <trace/events/iommu.h>
 
 static struct kset *iommu_group_kset;
-static struct ida iommu_group_ida;
-static struct mutex iommu_group_mutex;
+static DEFINE_IDA(iommu_group_ida);
+static DEFINE_MUTEX(iommu_group_mutex);
 
 struct iommu_callback_data {
 	const struct iommu_ops *ops;
@@ -1483,9 +1483,6 @@ static int __init iommu_init(void)
 {
 	iommu_group_kset = kset_create_and_add("iommu_groups",
 					       NULL, kernel_kobj);
-	ida_init(&iommu_group_ida);
-	mutex_init(&iommu_group_mutex);
-
 	BUG_ON(!iommu_group_kset);
 
 	return 0;
Signature · 1 line
2.9.0