Skip to contentSkip to conversation

Add support for PolarFire SoC's musb controller

PATCH In review Conor Dooley 2 participants 10 messages Jun 13, 2022 – Jun 21, 2022

Subsystems (4)
lore
Share & tools
lore

Conor Dooley

author maintainer
#0 lore raw

v2 cover Add support for PolarFire SoC's musb controller

Hey Bin, Greg,
Short series here adding support for USB on Microchip PolarFire SoC FPGAs. The kconfig dependency for INVENTRA_DMA has become a bit of a mouthful, is there a better way of dealing with that?
Thanks,
Conor.

Changes since v1:
- Drop unneeded resource copying as per Rob's changes to the other drivers
- Drop the dts patch

Conor Dooley (2):
usb: musb: Add support for PolarFire SoC's musb controller
MAINTAINERS: add musb to PolarFire SoC entry

 MAINTAINERS               |   1 +
 drivers/usb/musb/Kconfig  |  13 +-
 drivers/usb/musb/Makefile |   1 +
 drivers/usb/musb/mpfs.c   | 265 ++++++++++++++++++++++++++++++++++++++
 4 files changed, 279 insertions(+), 1 deletion(-)
 create mode 100644 drivers/usb/musb/mpfs.c

base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56

Signature · 7 lines
2.36.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
author maintainer
#1 lore raw

PATCH v2 1/2 usb: musb: Add support for PolarFire SoC's musb controller

Add support for Microchips's PolarFire SoC's musb controller in host, peripheral and otg mode.

---
 drivers/usb/musb/Kconfig  |  13 +-
 drivers/usb/musb/Makefile |   1 +
 drivers/usb/musb/mpfs.c   | 265 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 278 insertions(+), 1 deletion(-)
 create mode 100644 drivers/usb/musb/mpfs.c
drivers/usb/musb/Kconfig +12 -1
index 4d61df6a9b5c..f906dfd360d3 100644
@@ -123,6 +123,17 @@ config USB_MUSB_MEDIATEK
 	select GENERIC_PHY
 	select USB_ROLE_SWITCH
 
+config USB_MUSB_POLARFIRE_SOC
+	tristate "Microchip PolarFire SoC platforms"
+	depends on SOC_MICROCHIP_POLARFIRE || COMPILE_TEST
+	depends on NOP_USB_XCEIV
+	select USB_MUSB_DUAL_ROLE
+	help
+	  Say Y here to enable support for USB on Microchip's PolarFire SoC.
+
+	  This support is also available as a module.  If so, the module
+	  will be called mpfs.
+
 comment "MUSB DMA mode"
 
 config MUSB_PIO_ONLY
@@ -146,7 +157,7 @@ config USB_UX500_DMA
 
 config USB_INVENTRA_DMA
 	bool 'Inventra'
-	depends on USB_MUSB_OMAP2PLUS || USB_MUSB_MEDIATEK || USB_MUSB_JZ4740
+	depends on USB_MUSB_OMAP2PLUS || USB_MUSB_MEDIATEK || USB_MUSB_JZ4740 || USB_MUSB_POLARFIRE_SOC
 	help
 	  Enable DMA transfers using Mentor's engine.
 
drivers/usb/musb/Makefile +1 -0
index 932247360a9f..51dd54a8de49 100644
@@ -25,6 +25,7 @@ obj-$(CONFIG_USB_MUSB_UX500)			+= ux500.o
 obj-$(CONFIG_USB_MUSB_JZ4740)			+= jz4740.o
 obj-$(CONFIG_USB_MUSB_SUNXI)			+= sunxi.o
 obj-$(CONFIG_USB_MUSB_MEDIATEK)      		+= mediatek.o
+obj-$(CONFIG_USB_MUSB_POLARFIRE_SOC)		+= mpfs.o
 
 # the kconfig must guarantee that only one of the
 # possible I/O schemes will be enabled at a time ...
drivers/usb/musb/mpfs.c new file +265 -0

265 lines not on this page · raw message

Signature · 7 lines
2.36.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
author maintainer
#2 lore raw

PATCH v2 2/2 MAINTAINERS: add musb to PolarFire SoC entry

In reply to Conor Dooley

Add the newly introduced musb driver to the existing PolarFire SoC entry.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index a6d3bd9d2a8d..b07b2cfa3567 100644
@@ -17143,6 +17143,7 @@ S:	Supported
 F:	arch/riscv/boot/dts/microchip/
 F:	drivers/mailbox/mailbox-mpfs.c
 F:	drivers/soc/microchip/
+F:	drivers/usb/musb/mpfs.c
 F:	include/soc/microchip/mpfs.h
 
 RNBD BLOCK DRIVERS
Signature · 7 lines
2.36.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
author maintainer
#3 lore raw
In reply to Conor Dooley
Quoted 6 lines · Conor Dooley

Hey Bin, Greg,
Short series here adding support for USB on Microchip PolarFire SoC FPGAs. The kconfig dependency for INVENTRA_DMA has become a bit of a mouthful, is there a better way of dealing with that?
Thanks,
Conor.

Ah, damn - forgot to mention the 3 sets of changes to the MAINTAINERS entry again. There's a change already in spi-next & another change in my patchset sent for pwm.

Quoted 14 lines

Changes since v1:
- Drop unneeded resource copying as per Rob's changes to the other drivers
- Drop the dts patch

Conor Dooley (2):
usb: musb: Add support for PolarFire SoC's musb controller
MAINTAINERS: add musb to PolarFire SoC entry

  MAINTAINERS               |   1 +
  drivers/usb/musb/Kconfig  |  13 +-
  drivers/usb/musb/Makefile |   1 +
  drivers/usb/musb/mpfs.c   | 265 ++++++++++++++++++++++++++++++++++++++
  4 files changed, 279 insertions(+), 1 deletion(-)
Quoted 4 lines

create mode 100644 drivers/usb/musb/mpfs.c

base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#4 lore raw
In reply to Conor Dooley
Quoted 23 lines · Conor Dooley

Hey Bin, Greg,
Short series here adding support for USB on Microchip PolarFire SoC FPGAs. The kconfig dependency for INVENTRA_DMA has become a bit of a mouthful, is there a better way of dealing with that?
Thanks,
Conor.

Changes since v1:
- Drop unneeded resource copying as per Rob's changes to the other drivers
- Drop the dts patch

Conor Dooley (2):
usb: musb: Add support for PolarFire SoC's musb controller
MAINTAINERS: add musb to PolarFire SoC entry

 MAINTAINERS               |   1 +
 drivers/usb/musb/Kconfig  |  13 +-
 drivers/usb/musb/Makefile |   1 +
 drivers/usb/musb/mpfs.c   | 265 ++++++++++++++++++++++++++++++++++++++
 4 files changed, 279 insertions(+), 1 deletion(-)
 create mode 100644 drivers/usb/musb/mpfs.c
Quoted 4 lines

base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56

Signature · 1 line
2.36.1

Any chance you can get your company to fix up their email settings:

Grabbing thread from lore.kernel.org/all/20220613114642.1615292-1-conor.dooley%40microchip.com/t.mbox.gz Analyzing 4 messages in the thread
Checking attestation on all messages, may take a moment...
---
✗ [PATCH v2 1/2] usb: musb: Add support for PolarFire SoC's musb controller
✗ [PATCH v2 2/2] MAINTAINERS: add musb to PolarFire SoC entry
---
✗ BADSIG: DKIM/microchip.com
---
Total patches: 2

If I didn't know better, I would think you were spoofing the address...

thanks,

greg k-h

author maintainer
#5 lore raw
Quoted 42 lines · Greg Kroah-Hartman
Quoted 23 lines · Conor Dooley

Hey Bin, Greg,
Short series here adding support for USB on Microchip PolarFire SoC FPGAs. The kconfig dependency for INVENTRA_DMA has become a bit of a mouthful, is there a better way of dealing with that?
Thanks,
Conor.

Changes since v1:
- Drop unneeded resource copying as per Rob's changes to the other drivers
- Drop the dts patch

Conor Dooley (2):
usb: musb: Add support for PolarFire SoC's musb controller
MAINTAINERS: add musb to PolarFire SoC entry

 MAINTAINERS               |   1 +
 drivers/usb/musb/Kconfig  |  13 +-
 drivers/usb/musb/Makefile |   1 +
 drivers/usb/musb/mpfs.c   | 265 ++++++++++++++++++++++++++++++++++++++
 4 files changed, 279 insertions(+), 1 deletion(-)
 create mode 100644 drivers/usb/musb/mpfs.c
Quoted 4 lines

base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56

Signature · 1 line
2.36.1

Any chance you can get your company to fix up their email settings:

Grabbing thread from lore.kernel.org/all/20220613114642.1615292-1-conor.dooley%40microchip.com/t.mbox.gz Analyzing 4 messages in the thread
Checking attestation on all messages, may take a moment...
---
✗ [PATCH v2 1/2] usb: musb: Add support for PolarFire SoC's musb controller
✗ [PATCH v2 2/2] MAINTAINERS: add musb to PolarFire SoC entry
---
✗ BADSIG: DKIM/microchip.com
---
Total patches: 2

Quoted 1 line

If I didn't know better, I would think you were spoofing the address...

Great, thanks. I was honestly hoping you would make this complaint. I brought it up with our IT before & nothing has happened yet. At least now I have the direct complaint to forward :)

I can resend from an account that does pass DKIM if you like...

Thanks,
Conor.

Quoted 4 lines

thanks,

greg k-h

maintainer
#7 lore raw
In reply to [email protected]
Quoted 45 lines · On Tue, Jun 21, 2022 at 03:16:49PM +0000, [email protected] wrote:
Quoted 42 lines · Greg Kroah-Hartman
Quoted 23 lines · Conor Dooley

Hey Bin, Greg,
Short series here adding support for USB on Microchip PolarFire SoC FPGAs. The kconfig dependency for INVENTRA_DMA has become a bit of a mouthful, is there a better way of dealing with that?
Thanks,
Conor.

Changes since v1:
- Drop unneeded resource copying as per Rob's changes to the other drivers
- Drop the dts patch

Conor Dooley (2):
usb: musb: Add support for PolarFire SoC's musb controller
MAINTAINERS: add musb to PolarFire SoC entry

 MAINTAINERS               |   1 +
 drivers/usb/musb/Kconfig  |  13 +-
 drivers/usb/musb/Makefile |   1 +
 drivers/usb/musb/mpfs.c   | 265 ++++++++++++++++++++++++++++++++++++++
 4 files changed, 279 insertions(+), 1 deletion(-)
 create mode 100644 drivers/usb/musb/mpfs.c
Quoted 4 lines

base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56

Signature · 1 line
2.36.1

Any chance you can get your company to fix up their email settings:

Grabbing thread from lore.kernel.org/all/20220613114642.1615292-1-conor.dooley%40microchip.com/t.mbox.gz Analyzing 4 messages in the thread
Checking attestation on all messages, may take a moment...
---
✗ [PATCH v2 1/2] usb: musb: Add support for PolarFire SoC's musb controller
✗ [PATCH v2 2/2] MAINTAINERS: add musb to PolarFire SoC entry
---
✗ BADSIG: DKIM/microchip.com
---
Total patches: 2

Quoted 4 lines
Quoted 1 line

If I didn't know better, I would think you were spoofing the address...

Great, thanks. I was honestly hoping you would make this complaint. I brought it up with our IT before & nothing has happened yet.

It's amazing that your company emails are even making it to many systems these days with that broken.

Quoted 1 line

At least now I have the direct complaint to forward :)

Please do, and tell them that in the future, some of us will probably start requiring this to pass as I doubt they want just anyone to spoof patches from your domain :)

thanks,

greg k-h

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

author maintainer
#8 lore raw
Quoted 46 lines · Greg KH
Quoted 45 lines · On Tue, Jun 21, 2022 at 03:16:49PM +0000, [email protected] wrote:
Quoted 42 lines · Greg Kroah-Hartman
Quoted 23 lines · Conor Dooley

Hey Bin, Greg,
Short series here adding support for USB on Microchip PolarFire SoC FPGAs. The kconfig dependency for INVENTRA_DMA has become a bit of a mouthful, is there a better way of dealing with that?
Thanks,
Conor.

Changes since v1:
- Drop unneeded resource copying as per Rob's changes to the other drivers
- Drop the dts patch

Conor Dooley (2):
usb: musb: Add support for PolarFire SoC's musb controller
MAINTAINERS: add musb to PolarFire SoC entry

 MAINTAINERS               |   1 +
 drivers/usb/musb/Kconfig  |  13 +-
 drivers/usb/musb/Makefile |   1 +
 drivers/usb/musb/mpfs.c   | 265 ++++++++++++++++++++++++++++++++++++++
 4 files changed, 279 insertions(+), 1 deletion(-)
 create mode 100644 drivers/usb/musb/mpfs.c
Quoted 4 lines

base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56

Signature · 1 line
2.36.1

Any chance you can get your company to fix up their email settings:

Grabbing thread from lore.kernel.org/all/20220613114642.1615292-1-conor.dooley%40microchip.com/t.mbox.gz Analyzing 4 messages in the thread
Checking attestation on all messages, may take a moment...
---
✗ [PATCH v2 1/2] usb: musb: Add support for PolarFire SoC's musb controller
✗ [PATCH v2 2/2] MAINTAINERS: add musb to PolarFire SoC entry
---
✗ BADSIG: DKIM/microchip.com
---
Total patches: 2

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

If I didn't know better, I would think you were spoofing the address...

Great, thanks. I was honestly hoping you would make this complaint. I brought it up with our IT before & nothing has happened yet.

It's amazing that your company emails are even making it to many systems these days with that broken.

Well DKIM is actually enabled for the domain - just it is simple/simple which I would imagine passes in direct emails?

Quoted 6 lines
Quoted 2 lines

At least now I have the direct complaint to forward :)

Please do, and tell them that in the future, some of us will probably start requiring this to pass as I doubt they want just anyone to spoof patches from your domain :)

I said as much to them already, hopefully the complaint helps.

Thanks again,
Conor.

maintainer
#9 lore raw
Quoted 51 lines · On Tue, Jun 21, 2022 at 03:48:03PM +0000, [email protected] wrote:
Quoted 48 lines · Greg KH
Quoted 47 lines · On Tue, Jun 21, 2022 at 03:16:49PM +0000, [email protected] wrote:
Quoted 43 lines · Greg Kroah-Hartman
Quoted 23 lines · Conor Dooley

Hey Bin, Greg,
Short series here adding support for USB on Microchip PolarFire SoC FPGAs. The kconfig dependency for INVENTRA_DMA has become a bit of a mouthful, is there a better way of dealing with that?
Thanks,
Conor.

Changes since v1:
- Drop unneeded resource copying as per Rob's changes to the other drivers
- Drop the dts patch

Conor Dooley (2):
usb: musb: Add support for PolarFire SoC's musb controller
MAINTAINERS: add musb to PolarFire SoC entry

 MAINTAINERS               |   1 +
 drivers/usb/musb/Kconfig  |  13 +-
 drivers/usb/musb/Makefile |   1 +
 drivers/usb/musb/mpfs.c   | 265 ++++++++++++++++++++++++++++++++++++++
 4 files changed, 279 insertions(+), 1 deletion(-)
 create mode 100644 drivers/usb/musb/mpfs.c
Quoted 4 lines

base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56

Signature · 1 line
2.36.1

Any chance you can get your company to fix up their email settings:

Grabbing thread from lore.kernel.org/all/20220613114642.1615292-1-conor.dooley%40microchip.com/t.mbox.gz Analyzing 4 messages in the thread
Checking attestation on all messages, may take a moment...
---
✗ [PATCH v2 1/2] usb: musb: Add support for PolarFire SoC's musb controller
✗ [PATCH v2 2/2] MAINTAINERS: add musb to PolarFire SoC entry
---
✗ BADSIG: DKIM/microchip.com
---
Total patches: 2

If I didn't know better, I would think you were spoofing the address...

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Great, thanks. I was honestly hoping you would make this complaint. I brought it up with our IT before & nothing has happened yet.

It's amazing that your company emails are even making it to many systems these days with that broken.

Well DKIM is actually enabled for the domain - just it is simple/simple which I would imagine passes in direct emails?

I do not know what is wrong, only that our checking of the email shows something went wrong. I will let the email admins figure out what is going on as that is their domain, not mine.

thanks,

greg k-h