Skip to contentSkip to conversation

arm64: dts: meson-sm1: fix wrong GPIO domain for GPIOE_2

PATCH In review Dongjin Kim 2 participants 4 messages Jan 27, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: meson-sm1: fix wrong GPIO domain for GPIOE_2

GPIOE_2 is in AO domain and "<&gpio GPIOE_2 ...>" changes the state of GPIOZ_14 connected to INTR of 'RTL8211F' on ODROID-HC and TF_PWR_EN of 'FC8731' on BPI-M5

Fixes 1f80a5cf74a6 ("arm64: dts: meson-sm1-odroid: add missing enable gpio and supply for tf_io regulator")
Fixes 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts")
---
 arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +-
 arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts +1 -1
index 212c6aa5a3b8..5751c48620ed 100644
@@ -123,7 +123,7 @@ vddio_c: regulator-vddio_c {
 		regulator-min-microvolt = <1800000>;
 		regulator-max-microvolt = <3300000>;
 
-		enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>;
+		enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 		regulator-always-on;
 
arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi +1 -1
index bf29afac645f..d4349b355e4a 100644
@@ -52,7 +52,7 @@ tf_io: gpio-regulator-tf_io {
 		regulator-max-microvolt = <3300000>;
 		vin-supply = <&vcc_5v>;
 
-		enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>;
+		enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 		regulator-always-on;
 
Signature · 1 line
2.32.0
#1 lore raw

Hi,

Quoted 32 lines · Dongjin Kim

GPIOE_2 is in AO domain and "<&gpio GPIOE_2 ...>" changes the state of GPIOZ_14 connected to INTR of 'RTL8211F' on ODROID-HC and TF_PWR_EN of 'FC8731' on BPI-M5

Fixes 1f80a5cf74a6 ("arm64: dts: meson-sm1-odroid: add missing enable gpio and supply for tf_io regulator")
Fixes 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts")
---
 arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +-
 arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts +1 -1
index 212c6aa5a3b8..5751c48620ed 100644
@@ -123,7 +123,7 @@ vddio_c: regulator-vddio_c {
 		regulator-min-microvolt = <1800000>;
 		regulator-max-microvolt = <3300000>;
 
-		enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>;
+		enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 		regulator-always-on;
 
arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi +0 -0
index bf29afac645f..d4349b355e4a 100644

arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi tf_io: gpio-regulator-tf_io { · line 58

Quoted 8 lines
arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi +1 -1
@@ -52,7 +52,7 @@ tf_io: gpio-regulator-tf_io {
 		regulator-max-microvolt = <3300000>;
 		vin-supply = <&vcc_5v>;
 
-		enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>;
+		enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 		regulator-always-on;
 

Thanks for the fixes,
can you send 2 patches fixing each files instead ?

Thanks,
Neil

#2 lore raw
Quoted 46 lines · Neil Armstrong

Hi,

Quoted 32 lines · Dongjin Kim

GPIOE_2 is in AO domain and "<&gpio GPIOE_2 ...>" changes the state of GPIOZ_14 connected to INTR of 'RTL8211F' on ODROID-HC and TF_PWR_EN of 'FC8731' on BPI-M5

Fixes 1f80a5cf74a6 ("arm64: dts: meson-sm1-odroid: add missing enable gpio and supply for tf_io regulator")
Fixes 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts")
---
 arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +-
 arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts +1 -1
index 212c6aa5a3b8..5751c48620ed 100644
@@ -123,7 +123,7 @@ vddio_c: regulator-vddio_c {
 		regulator-min-microvolt = <1800000>;
 		regulator-max-microvolt = <3300000>;
 
-		enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>;
+		enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 		regulator-always-on;
 
arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi +0 -0
index bf29afac645f..d4349b355e4a 100644

arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi tf_io: gpio-regulator-tf_io { · line 58

Quoted 8 lines
arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi +1 -1
@@ -52,7 +52,7 @@ tf_io: gpio-regulator-tf_io {
 		regulator-max-microvolt = <3300000>;
 		vin-supply = <&vcc_5v>;
 
-		enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>;
+		enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 		regulator-always-on;
 

Thanks for the fixes,
can you send 2 patches fixing each files instead ?

Quoted 2 lines

Thanks,
Neil

Sure.
By the way, I would drop a fix for 'meson-sm1-odroid.dtsi' since I found a patch just now.
https://patchwork.kernel.org/project/linux-amlogic/patch/20220127130537.GA187347@odroid-VirtualBox/

Thanks,
Dongjin.

#3 lore raw

Hi,

Quoted 47 lines · Dongjin Kim
Quoted 46 lines · Neil Armstrong

Hi,

Quoted 32 lines · Dongjin Kim

GPIOE_2 is in AO domain and "<&gpio GPIOE_2 ...>" changes the state of GPIOZ_14 connected to INTR of 'RTL8211F' on ODROID-HC and TF_PWR_EN of 'FC8731' on BPI-M5

Fixes 1f80a5cf74a6 ("arm64: dts: meson-sm1-odroid: add missing enable gpio and supply for tf_io regulator")
Fixes 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts")
---
 arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +-
 arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts +1 -1
index 212c6aa5a3b8..5751c48620ed 100644
@@ -123,7 +123,7 @@ vddio_c: regulator-vddio_c {
 		regulator-min-microvolt = <1800000>;
 		regulator-max-microvolt = <3300000>;
 
-		enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>;
+		enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 		regulator-always-on;
 
arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi +0 -0
index bf29afac645f..d4349b355e4a 100644

arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi tf_io: gpio-regulator-tf_io { · line 58

Quoted 8 lines
arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi +1 -1
@@ -52,7 +52,7 @@ tf_io: gpio-regulator-tf_io {
 		regulator-max-microvolt = <3300000>;
 		vin-supply = <&vcc_5v>;
 
-		enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>;
+		enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 		regulator-always-on;
 

Thanks for the fixes,
can you send 2 patches fixing each files instead ?

Quoted 7 lines
Quoted 2 lines

Thanks,
Neil

Sure.
By the way, I would drop a fix for 'meson-sm1-odroid.dtsi' since I found a patch just now.
https://patchwork.kernel.org/project/linux-amlogic/patch/20220127130537.GA187347@odroid-VirtualBox/

Sure, you sent the v1 at the same time, and he just resend a new version.

Neil

Quoted 4 lines

Thanks,
Dongjin.