package/libxmlsec1: fix Config.in comment dependencies
PATCH 1/1 package/libxmlsec1: fix Config.in comment dependencies
Commit fef9cad1fe84b4366e705adb03470e12199ffd25 ("package/libxmlsec1:
bump version to 1.3.12") has introduced a gcc 7.x and atomic dependency, but the Config.in comment dependencies are not correct:
+comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
+ depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_TOOLCHAIN_HAS_ATOMIC
Indeed, we treat BR2_TOOLCHAIN_HAS_ATOMIC like an architecture dependency in Buildroot, so it should be:
+comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
+ depends on BR2_TOOLCHAIN_HAS_ATOMIC
+ depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
so that the comment does NOT show up when BR2_TOOLCHAIN_HAS_ATOMIC is false.
--- package/libxmlsec1/Config.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/libxmlsec1/Config.in +2 -1
@@ -14,4 +14,5 @@ config BR2_PACKAGE_LIBXMLSEC1 https://github.com/lsh123/xmlsec comment "libxmlsec1 needs a toolchain w/ gcc >= 7" - depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_TOOLCHAIN_HAS_ATOMIC + depends on BR2_TOOLCHAIN_HAS_ATOMIC + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
Signature · 6 lines
2.55.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 15 lines · Thomas Petazzoni via buildroot
Commit
fef9cad1fe84b4366e705adb03470e12199ffd25("package/libxmlsec1:
bump version to 1.3.12") has introduced a gcc 7.x and atomic dependency, but the Config.in comment dependencies are not correct:(quoted diff) +2
-0+comment "libxmlsec1 needs a toolchain w/ gcc >= 7" + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7 ||!BR2_TOOLCHAIN_HAS_ATOMIC
Indeed, we treat
BR2_TOOLCHAIN_HAS_ATOMIClike an architecture dependency in Buildroot, so it should be:package/libxmlsec1/Config.in +3
-0+comment "libxmlsec1 needs a toolchain w/ gcc >= 7" + depends on BR2_TOOLCHAIN_HAS_ATOMIC + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
Quoted 4 lines
so that the comment does NOT show up when
BR2_TOOLCHAIN_HAS_ATOMICis false.Signed-off-by Thomas Petazzoni <[email protected]>
Applied to master, thanks.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot