Skip to contentSkip to conversation

gettext: Disable error_at_line detection for musl

PATCH In review Khem Raj 2 participants 4 messages Sep 20, 2023

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 gettext: Disable error_at_line detection for musl

---
 meta/recipes-core/gettext/gettext_0.22.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/gettext/gettext_0.22.bb +1 -0
index f5290ac0e44..91db6627748 100644
@@ -53,6 +53,7 @@ EXTRA_OECONF:append:class-target = " \
                  gt_cv_locale_de_utf8=de_DE \
                  gt_cv_locale_de=de_DE.ISO-8859-1 \
 "
+EXTRA_OECONF:append:libc-musl = " ac_cv_lib_error_at_line=no"
 
 PACKAGECONFIG ??= "croco glib libxml"
 PACKAGECONFIG:class-native = ""
Signature · 1 line
2.42.0
#1 lore raw
Quoted 10 lines · Khem Raj
---
 meta/recipes-core/gettext/gettext_0.22.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/gettext/gettext_0.22.bb +0 -0
index f5290ac0e44..91db6627748 100644

meta/recipes-core/gettext/gettext_0.22.bb EXTRA_OECONF:append:class-target = " \ · line 59

Quoted 7 lines
meta/recipes-core/gettext/gettext_0.22.bb +1 -0
@@ -53,6 +53,7 @@ EXTRA_OECONF:append:class-target = " \
                  gt_cv_locale_de_utf8=de_DE \
                  gt_cv_locale_de=de_DE.ISO-8859-1 \
 "
+EXTRA_OECONF:append:libc-musl = " ac_cv_lib_error_at_line=no"
 
 PACKAGECONFIG ??= "croco glib libxml"
 PACKAGECONFIG:class-native = ""

Is this something which should be in the musl site file?

Cheers,

Richard

author
#2 lore raw
Quoted 17 lines · Richard Purdie

Review

Quoted 6 lines · Khem Raj
---
 meta/recipes-core/gettext/gettext_0.22.bb | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/meta/recipes-core/gettext/gettext_0.22.bb

Quoted 9 lines

index f5290ac0e44..91db6627748 100644

meta/recipes-core/gettext/gettext_0.22.bb +1 -0
@@ -53,6 +53,7 @@ EXTRA_OECONF:append:class-target = " \
                  gt_cv_locale_de_utf8=de_DE \
                  gt_cv_locale_de=de_DE.ISO-8859-1 \
 "
+EXTRA_OECONF:append:libc-musl = " ac_cv_lib_error_at_line=no"
 
Quoted 4 lines

meta/recipes-core/gettext/gettext_0.22.bb EXTRA_OECONF:append:class-target = " \ · line 59

Quoted 2 lines
meta/recipes-core/gettext/gettext_0.22.bb +0 -0
 PACKAGECONFIG ??= "croco glib libxml"
 PACKAGECONFIG:class-native = ""

Is this something which should be in the musl site file?

I was thinking on same lines but then I wanted to see how many packages would need it. It seems it’s packaged using gnulib that need it but then not all. Adding to site files is a bigger hammer I want to see the length and breadth of its impact

I will refactor the bsd-headers patch to keep the error.h a bit more

Quoted 5 lines

Cheers,

Richard

#3 lore raw
Quoted 28 lines · Khem Raj
Quoted 6 lines · Richard Purdie
Quoted 5 lines · Khem Raj

---
  meta/recipes-core/gettext/gettext_0.22.bb | 1 +

  1 file changed, 1 insertion(+)
Quoted 16 lines
Quoted 8 lines
meta/recipes-core/gettext/gettext_0.22.bb +0 -0
index f5290ac0e44..91db6627748 100644
@@ -53,6 +53,7 @@ EXTRA_OECONF:append:class-target = " \
                    gt_cv_locale_de_utf8=de_DE \
                    gt_cv_locale_de=de_DE.ISO-8859-1 \
Quoted 5 lines

  "
+EXTRA_OECONF:append:libc-musl = " ac_cv_lib_error_at_line=no"
  PACKAGECONFIG ??= "croco glib libxml" PACKAGECONFIG:class-native = ""

Is this something which should be in the musl site file?

Quoted 7 lines

I was thinking on same lines but then I wanted to see how many packages would need it. It seems it’s packaged using gnulib that need it but then not all. Adding to site files is a bigger hammer I want to see the length and breadth of its impact

I will refactor the bsd-headers patch to keep the error.h a bit more

I think the site file does make more sense for this.

Given I know you heard my comments yesterday about stabilising for release, if you're going to send "test" changes like this could you please at least note that in the commit message?

I really could do without debugging things for people at this point in the release cycle.

Cheers,

Richard