Skip to contentSkip to conversation

fpga: xilinx: remove xilinx- prefix on files

PATCH In review [email protected] 2 participants 4 messages Jun 8, 2021 – Jun 9, 2021

Subsystems (2)
lore
Share & tools
lore

[email protected]

author reviewer
#0 lore raw

PATCH 6/7 fpga: xilinx: remove xilinx- prefix on files

From: Tom Rix <[email protected]>

It is not necessary to have a xilinx- prefix on a file when the file is in a xilinx/ subdir.

---
 drivers/fpga/xilinx/Makefile                                  | 4 ++--
 drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0
 drivers/fpga/xilinx/{xilinx-spi.c => spi.c}                   | 0
 3 files changed, 2 insertions(+), 2 deletions(-)
 rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%)
 rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%)
drivers/fpga/xilinx/Makefile +2 -2
index 7bb7543412790..4ac727d03e140 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 
-obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o
-obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o
+obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o
+obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o
 obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o
 obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o
 
drivers/fpga/xilinx/pr-decoupler.c renamed from drivers/fpga/xilinx/xilinx-pr-decoupler.c +0 -0
similarity index 100%
rename from drivers/fpga/xilinx/xilinx-pr-decoupler.c
rename to drivers/fpga/xilinx/pr-decoupler.c
drivers/fpga/xilinx/spi.c renamed from drivers/fpga/xilinx/xilinx-spi.c +0 -0
similarity index 100%
rename from drivers/fpga/xilinx/xilinx-spi.c
rename to drivers/fpga/xilinx/spi.c
Signature · 1 line
2.26.3
#1 lore raw
Quoted 19 lines · On Tue, Jun 08, 2021 at 09:25:51AM -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

It is not necessary to have a xilinx- prefix on a file when the file is in a xilinx/ subdir.

---
 drivers/fpga/xilinx/Makefile                                  | 4 ++--
 drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0
 drivers/fpga/xilinx/{xilinx-spi.c => spi.c}                   | 0
 3 files changed, 2 insertions(+), 2 deletions(-)
 rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%)
 rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%)
drivers/fpga/xilinx/Makefile +0 -0
index 7bb7543412790..4ac727d03e140 100644

drivers/fpga/xilinx/Makefile line 4

Quoted 6 lines
drivers/fpga/xilinx/Makefile +2 -2
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 
-obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o
-obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o
+obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o
+obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o

You just renamed the module to be called "spi.ko"????

Did you test this thing? You can not rename modules without good reasons, and calling a device specific kernel module "spi.ko" is not ok.

greg k-h

author reviewer
#2 lore raw
Quoted 22 lines · Greg KH
Quoted 21 lines · On Tue, Jun 08, 2021 at 09:25:51AM -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

It is not necessary to have a xilinx- prefix on a file when the file is in a xilinx/ subdir.

---
  drivers/fpga/xilinx/Makefile                                  | 4 ++--
  drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0
  drivers/fpga/xilinx/{xilinx-spi.c => spi.c}                   | 0
  3 files changed, 2 insertions(+), 2 deletions(-)

rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%) rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%)

drivers/fpga/xilinx/Makefile +0 -0
index 7bb7543412790..4ac727d03e140 100644
@@ -1,7 +1,7 @@
  # SPDX-License-Identifier: GPL-2.0
 
Quoted 8 lines

drivers/fpga/xilinx/Makefile line 4

Quoted 4 lines
drivers/fpga/xilinx/Makefile +2 -2
-obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o
-obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o
+obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o
+obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o

You just renamed the module to be called "spi.ko"????

Did you test this thing? You can not rename modules without good reasons, and calling a device specific kernel module "spi.ko" is not ok.

yes, this is a problem, I will drop the renaming patches.

Tom

Quoted 2 lines

greg k-h

#3 lore raw
Quoted 29 lines · Tom Rix
Quoted 27 lines · Greg KH
Quoted 19 lines · On Tue, Jun 08, 2021 at 09:25:51AM -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

It is not necessary to have a xilinx- prefix on a file when the file is in a xilinx/ subdir.

---
  drivers/fpga/xilinx/Makefile                                  | 4 ++--
  drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0
  drivers/fpga/xilinx/{xilinx-spi.c => spi.c}                   | 0
  3 files changed, 2 insertions(+), 2 deletions(-)

rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%) rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%)

drivers/fpga/xilinx/Makefile +0 -0
index 7bb7543412790..4ac727d03e140 100644

drivers/fpga/xilinx/Makefile line 3

Quoted 5 lines
drivers/fpga/xilinx/Makefile +2 -2
@@ -1,7 +1,7 @@
  # SPDX-License-Identifier: GPL-2.0
-obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o
-obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o
+obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o
+obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o

You just renamed the module to be called "spi.ko"????

Quoted 4 lines
Quoted 2 lines

Did you test this thing? You can not rename modules without good reasons, and calling a device specific kernel module "spi.ko" is not ok.

yes, this is a problem, I will drop the renaming patches.

So you didn't test these?

Again, why is this file movement necessary?