fpga: xilinx: remove xilinx- prefix on files
Subsystems (2)
[email protected]
reviewerPATCH 6/7 fpga: xilinx: remove xilinx- prefix on files
From: Tom Rix <[email protected]>
It is not necessary to have a xilinx- prefix on a file when the file is in a xilinx/ subdir.
---
drivers/fpga/xilinx/Makefile | 4 ++--
drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0
drivers/fpga/xilinx/{xilinx-spi.c => spi.c} | 0
3 files changed, 2 insertions(+), 2 deletions(-)
rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%)
rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%)drivers/fpga/xilinx/Makefile +2 -2
@@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o +obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o
drivers/fpga/xilinx/pr-decoupler.c renamed from drivers/fpga/xilinx/xilinx-pr-decoupler.c +0 -0
drivers/fpga/xilinx/spi.c renamed from drivers/fpga/xilinx/xilinx-spi.c +0 -0
Signature · 1 line
2.26.3
Quoted 19 lines · On Tue, Jun 08, 2021 at 09:25:51AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
It is not necessary to have a xilinx- prefix on a file when the file is in a xilinx/ subdir.
Signed-off-by Tom Rix <[email protected]>--- drivers/fpga/xilinx/Makefile | 4 ++-- drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0 drivers/fpga/xilinx/{xilinx-spi.c => spi.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%) rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%)drivers/fpga/xilinx/Makefile +0
-0
drivers/fpga/xilinx/Makefile line 4
Quoted 6 lines
drivers/fpga/xilinx/Makefile +2
-2@@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o +obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o
You just renamed the module to be called "spi.ko"????
Did you test this thing? You can not rename modules without good reasons, and calling a device specific kernel module "spi.ko" is not ok.
greg k-h
Tom Rix
reviewerQuoted 22 lines · Greg KH
Quoted 21 lines · On Tue, Jun 08, 2021 at 09:25:51AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
It is not necessary to have a xilinx- prefix on a file when the file is in a xilinx/ subdir.
Signed-off-by Tom Rix <[email protected]>--- drivers/fpga/xilinx/Makefile | 4 ++-- drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0 drivers/fpga/xilinx/{xilinx-spi.c => spi.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-)rename
drivers/fpga/xilinx/{xilinx-pr-decoupler.c=>pr-decoupler.c} (100%) renamedrivers/fpga/xilinx/{xilinx-spi.c=>spi.c} (100%)drivers/fpga/xilinx/Makefile +0
-0@@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0
Quoted 8 lines
drivers/fpga/xilinx/Makefile line 4
Quoted 4 lines
drivers/fpga/xilinx/Makefile +2
-2-obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o +obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.oYou just renamed the module to be called "spi.ko"????
Did you test this thing? You can not rename modules without good reasons, and calling a device specific kernel module "spi.ko" is not ok.
yes, this is a problem, I will drop the renaming patches.
Tom
Quoted 2 lines
greg k-h
Quoted 29 lines · Tom Rix
Quoted 27 lines · Greg KH
Quoted 19 lines · On Tue, Jun 08, 2021 at 09:25:51AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
It is not necessary to have a xilinx- prefix on a file when the file is in a xilinx/ subdir.
Signed-off-by Tom Rix <[email protected]>--- drivers/fpga/xilinx/Makefile | 4 ++-- drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0 drivers/fpga/xilinx/{xilinx-spi.c => spi.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-)rename
drivers/fpga/xilinx/{xilinx-pr-decoupler.c=>pr-decoupler.c} (100%) renamedrivers/fpga/xilinx/{xilinx-spi.c=>spi.c} (100%)drivers/fpga/xilinx/Makefile +0
-0drivers/fpga/xilinx/Makefile line 3
Quoted 5 lines
drivers/fpga/xilinx/Makefile +2
-2@@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o +obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.oYou just renamed the module to be called "spi.ko"????
Quoted 4 lines
Quoted 2 lines
Did you test this thing? You can not rename modules without good reasons, and calling a device specific kernel module "spi.ko" is not ok.
yes, this is a problem, I will drop the renaming patches.
So you didn't test these?
Again, why is this file movement necessary?